Page MenuHomePhabricator
Feed All Stories

Today

bytesofman added inline comments to D17871: [ecash-lib] Add `parseSlp`.
Sat, Mar 29, 04:07
tobias_ruck updated the diff for D17871: [ecash-lib] Add `parseSlp`.

add .js suffix

Sat, Mar 29, 00:33
tobias_ruck updated the diff for D17871: [ecash-lib] Add `parseSlp`.

add consts to address review; also factor out nextMintOutIdx

Sat, Mar 29, 00:28

Yesterday

bytesofman added a comment to D17871: [ecash-lib] Add `parseSlp`.

Is it possible to have a "valid" SLP OP_RETURN string that exceeds the OP_RETURN byte limit?

Fri, Mar 28, 21:43
PiRK added inline comments to D17873: assumeutxo: Get rid of faked nTx and nChainTx values.
Fri, Mar 28, 21:43
teamcity updated the summary of D17874: assumeutxo: Remove BLOCK_ASSUMED_VALID flag.
Fri, Mar 28, 21:39
PiRK requested review of D17874: assumeutxo: Remove BLOCK_ASSUMED_VALID flag.
Fri, Mar 28, 21:39
teamcity updated the summary of D17873: assumeutxo: Get rid of faked nTx and nChainTx values.
Fri, Mar 28, 21:37
PiRK requested review of D17873: assumeutxo: Get rid of faked nTx and nChainTx values.
Fri, Mar 28, 21:37
PiRK added inline comments to D17872: block index: split ResetChainStats from UpdateChainStats.
Fri, Mar 28, 21:34
PiRK requested review of D17872: block index: split ResetChainStats from UpdateChainStats.
Fri, Mar 28, 21:28
tobias_ruck requested review of D17871: [ecash-lib] Add `parseSlp`.
Fri, Mar 28, 20:45
bytesofman requested changes to D17871: [ecash-lib] Add `parseSlp`.

How is this function expected to be used? For the most part, correctly parsing an SLP OP_RETURN is often irrelevant, since we lack the indexer data (e.g. a well-formed SEND OP_RETURN could be a burn; validity in general depends on the indexer).

Fri, Mar 28, 17:29
PiRK accepted D17870: [website] Don't mix permissions when building the documentation.
Fri, Mar 28, 17:25
tobias_ruck published D17871: [ecash-lib] Add `parseSlp` for review.
Fri, Mar 28, 16:47
Fabien requested review of D17870: [website] Don't mix permissions when building the documentation.
Fri, Mar 28, 15:10
Fabien closed D17869: [explorer] Fix address conversion on testnet.
Fri, Mar 28, 14:25
Fabien committed rABC0b6c26f53098: [explorer] Fix address conversion on testnet (authored by Fabien).
[explorer] Fix address conversion on testnet
Fri, Mar 28, 14:25
Fabien closed D17868: [website] Update the upgrade page for May 2025.
Fri, Mar 28, 14:24
Fabien committed rABCWEB13f5cd3f2d9b: [website] Update the upgrade page for May 2025 (authored by Fabien).
[website] Update the upgrade page for May 2025
Fri, Mar 28, 14:24
PiRK accepted D17868: [website] Update the upgrade page for May 2025.
Fri, Mar 28, 12:24
PiRK accepted D17869: [explorer] Fix address conversion on testnet.
Fri, Mar 28, 12:22
Fabien accepted D17867: [avalanche] Add stake contenders to the cache every time a proof is registered.
Fri, Mar 28, 09:42
Fabien requested review of D17869: [explorer] Fix address conversion on testnet.
Fri, Mar 28, 09:17
Fabien requested review of D17868: [website] Update the upgrade page for May 2025.
Fri, Mar 28, 08:49
PiRK closed D17866: doc: Improve comments describing setBlockIndexCandidates checks.
Fri, Mar 28, 07:43
PiRK committed rABCfda261378276: doc: Improve comments describing setBlockIndexCandidates checks (authored by PiRK).
doc: Improve comments describing setBlockIndexCandidates checks
Fri, Mar 28, 07:43
PiRK updated the summary of D17866: doc: Improve comments describing setBlockIndexCandidates checks.
Fri, Mar 28, 07:40
alitayin requested review of D17815: [Cashtab] Introduce CSS variables to make styling easier.
Fri, Mar 28, 06:24
alitayin added inline comments to D17815: [Cashtab] Introduce CSS variables to make styling easier.
Fri, Mar 28, 02:01

Thu, Mar 27

roqqit accepted D17866: doc: Improve comments describing setBlockIndexCandidates checks.
Thu, Mar 27, 21:30
roqqit requested review of D17867: [avalanche] Add stake contenders to the cache every time a proof is registered.
Thu, Mar 27, 21:10
PiRK requested review of D17866: doc: Improve comments describing setBlockIndexCandidates checks.
Thu, Mar 27, 20:58
PiRK committed rABCac987c34e50d: chain: Rename HaveTxsDownloaded to HaveNumChainTxs, add note (authored by James O'Beirne <james.obeirne@pm.me>).
chain: Rename HaveTxsDownloaded to HaveNumChainTxs, add note
Thu, Mar 27, 20:51
PiRK closed D17864: chain: Rename HaveTxsDownloaded to HaveNumChainTxs, add note.
Thu, Mar 27, 20:51
roqqit closed D17861: [avalanche] Make sure to only promote contenders once for each proofid.
Thu, Mar 27, 18:00
roqqit committed rABCaff18f3253ee: [avalanche] Make sure to only promote contenders once for each proofid (authored by roqqit).
[avalanche] Make sure to only promote contenders once for each proofid
Thu, Mar 27, 18:00
roqqit closed D17860: [avalanche] Add some logging when stake contenders are cached or promoted.
Thu, Mar 27, 18:00
roqqit committed rABC6fb44405d40d: [avalanche] Add some logging when stake contenders are cached or promoted (authored by roqqit).
[avalanche] Add some logging when stake contenders are cached or promoted
Thu, Mar 27, 18:00
Fabien accepted D17860: [avalanche] Add some logging when stake contenders are cached or promoted.
Thu, Mar 27, 17:41
Fabien accepted D17861: [avalanche] Make sure to only promote contenders once for each proofid.
Thu, Mar 27, 17:41
Fabien committed rABCd3394f2fd066: [e.cash] Add upgrade info for May 2025 (authored by Fabien).
[e.cash] Add upgrade info for May 2025
Thu, Mar 27, 17:24
roqqit accepted D17864: chain: Rename HaveTxsDownloaded to HaveNumChainTxs, add note.
Thu, Mar 27, 16:58
roqqit updated the diff for D17861: [avalanche] Make sure to only promote contenders once for each proofid.

remove the set because it is not really needed

Thu, Mar 27, 16:50
roqqit updated the diff for D17860: [avalanche] Add some logging when stake contenders are cached or promoted.

feedback

Thu, Mar 27, 16:41
teamcity updated the summary of D17864: chain: Rename HaveTxsDownloaded to HaveNumChainTxs, add note.
Thu, Mar 27, 15:00
PiRK requested review of D17864: chain: Rename HaveTxsDownloaded to HaveNumChainTxs, add note.
Thu, Mar 27, 15:00
Fabien committed rABCWEBaa9386754209: [website] Make the 0.29.x releases obsolete (authored by Fabien).
[website] Make the 0.29.x releases obsolete
Thu, Mar 27, 14:19
Fabien closed D17863: [website] Make the 0.29.x releases obsolete.
Thu, Mar 27, 14:19
PiRK accepted D17863: [website] Make the 0.29.x releases obsolete.
Thu, Mar 27, 13:59
Fabien requested review of D17863: [website] Make the 0.29.x releases obsolete.
Thu, Mar 27, 12:33
Fabien closed D17862: Reword the upgrade notice in the release notes.
Thu, Mar 27, 12:31
Fabien committed rABCb94483b95b2e: Reword the upgrade notice in the release notes (authored by Fabien).
Reword the upgrade notice in the release notes
Thu, Mar 27, 12:31
aimal accepted D17862: Reword the upgrade notice in the release notes.
Thu, Mar 27, 12:30
Fabien requested review of D17862: Reword the upgrade notice in the release notes.
Thu, Mar 27, 12:29
Fabien requested changes to D17861: [avalanche] Make sure to only promote contenders once for each proofid.
Thu, Mar 27, 09:36
Fabien committed rABC7d6b688e816c: Bump version to 0.31.0 (authored by Fabien).
Bump version to 0.31.0
Thu, Mar 27, 08:42
Fabien requested changes to D17860: [avalanche] Add some logging when stake contenders are cached or promoted.

For this kind of log you should use LogPrintLevel(BCLog::AVALANCHE, BCLog::Level::Debug, "foo bar baz\n");

Thu, Mar 27, 08:40
Fabien closed D17856: Bump replay protection to November 2025.
Thu, Mar 27, 08:28
Fabien committed rABCac9fefe118df: Bump replay protection to November 2025 (authored by Fabien).
Bump replay protection to November 2025
Thu, Mar 27, 08:28
johnkuney added inline comments to D17815: [Cashtab] Introduce CSS variables to make styling easier.
Thu, Mar 27, 03:06

Wed, Mar 26

roqqit updated the test plan for D17860: [avalanche] Add some logging when stake contenders are cached or promoted.
Wed, Mar 26, 23:12
roqqit requested review of D17861: [avalanche] Make sure to only promote contenders once for each proofid.
Wed, Mar 26, 23:12
roqqit requested review of D17860: [avalanche] Add some logging when stake contenders are cached or promoted.
Wed, Mar 26, 22:55
PiRK closed D17858: [electrum] bump version to 5.4.2 and add release notes.
Wed, Mar 26, 15:05
PiRK committed rABC2dcd21093b82: [electrum] bump version to 5.4.2 and add release notes (authored by PiRK).
[electrum] bump version to 5.4.2 and add release notes
Wed, Mar 26, 15:05
Fabien accepted D17858: [electrum] bump version to 5.4.2 and add release notes.
Wed, Mar 26, 14:50
PiRK requested review of D17858: [electrum] bump version to 5.4.2 and add release notes.
Wed, Mar 26, 13:14
PiRK accepted D17856: Bump replay protection to November 2025.
Wed, Mar 26, 12:40
Fabien updated the diff for D17856: Bump replay protection to November 2025.

Update the name

Wed, Mar 26, 11:51
Fabien added a comment to D17856: Bump replay protection to November 2025.

Sorry - should be Shibusawa (last name).

Wed, Mar 26, 11:47
hazzarust closed D17847: [Chronik] Add broadcast_txs_and_validate_rawtxs integration test into bitcoinsuite-chronik-client.
Wed, Mar 26, 11:23
hazzarust committed rABC0c1713d91285: [Chronik] Add broadcast_txs_and_validate_rawtxs integration test into… (authored by hazzarust).
[Chronik] Add broadcast_txs_and_validate_rawtxs integration test into…
Wed, Mar 26, 11:23
Klakurka added a comment to D17856: Bump replay protection to November 2025.

Sorry - should be Shibusawa (last name).

Wed, Mar 26, 11:13
PiRK added a comment to D17856: Bump replay protection to November 2025.
$ date -ud @1763208000
sam. 15 nov. 2025 12:00:00 UTC
Wed, Mar 26, 11:07
Fabien requested review of D17856: Bump replay protection to November 2025.
Wed, Mar 26, 09:14
Fabien accepted D17847: [Chronik] Add broadcast_txs_and_validate_rawtxs integration test into bitcoinsuite-chronik-client.
Wed, Mar 26, 08:17

Tue, Mar 25

PiRK closed D17855: script: Enhance validations in utxo_snapshot.sh.
Tue, Mar 25, 22:53
PiRK committed rABCdebc1be254f1: script: Enhance validations in utxo_snapshot.sh (authored by pablomartin4btc <pablomartin4btc@gmail.com>).
script: Enhance validations in utxo_snapshot.sh
Tue, Mar 25, 22:53
hazzarust updated the diff for D17847: [Chronik] Add broadcast_txs_and_validate_rawtxs integration test into bitcoinsuite-chronik-client.

Added comments

Tue, Mar 25, 19:04
hazzarust closed D17853: [chronik] Amend broadcast_tx and broadcast_txs in bitcoinsuite-chronik-client.
Tue, Mar 25, 19:02
hazzarust committed rABC396a501ae4d5: [chronik] Amend broadcast_tx and broadcast_txs in bitcoinsuite-chronik-client (authored by hazzarust).
[chronik] Amend broadcast_tx and broadcast_txs in bitcoinsuite-chronik-client
Tue, Mar 25, 19:02
Fabien accepted D17855: script: Enhance validations in utxo_snapshot.sh.
Tue, Mar 25, 16:04
Fabien accepted D17853: [chronik] Amend broadcast_tx and broadcast_txs in bitcoinsuite-chronik-client.
Tue, Mar 25, 15:58
teamcity updated the summary of D17855: script: Enhance validations in utxo_snapshot.sh.
Tue, Mar 25, 15:03
PiRK requested review of D17855: script: Enhance validations in utxo_snapshot.sh.
Tue, Mar 25, 15:03
hazzarust added inline comments to D17847: [Chronik] Add broadcast_txs_and_validate_rawtxs integration test into bitcoinsuite-chronik-client.
Tue, Mar 25, 13:25
hazzarust updated the diff for D17853: [chronik] Amend broadcast_tx and broadcast_txs in bitcoinsuite-chronik-client.

change ordering

Tue, Mar 25, 13:11
teamcity closed T3775: Build Bitcoin-ABC / Master / Native tests / Test Native OSX is broken. as Resolved.
Tue, Mar 25, 12:31
bytesofman committed rABCceb4df3ac043: [Cashtab] Show the normal list workflow for XECX from the list option (authored by bytesofman).
[Cashtab] Show the normal list workflow for XECX from the list option
Tue, Mar 25, 12:08
bytesofman closed D17854: [Cashtab] Show the normal list workflow for XECX from the list option.
Tue, Mar 25, 12:08
Fabien requested changes to D17847: [Chronik] Add broadcast_txs_and_validate_rawtxs integration test into bitcoinsuite-chronik-client.
Tue, Mar 25, 09:31
PiRK accepted D17854: [Cashtab] Show the normal list workflow for XECX from the list option.
Tue, Mar 25, 07:11
bytesofman updated the test plan for D17854: [Cashtab] Show the normal list workflow for XECX from the list option.
Tue, Mar 25, 04:56
bytesofman updated the diff for D17854: [Cashtab] Show the normal list workflow for XECX from the list option.

patch conditional rendering for test

Tue, Mar 25, 04:53
bytesofman published D17854: [Cashtab] Show the normal list workflow for XECX from the list option for review.
Tue, Mar 25, 04:46

Mon, Mar 24

bytesofman planned changes to D17822: [ecash-wallet] Add fluent API for building and broadcasting txs.

Pushing up this last round of feedback-based changes to support incremental review, but this is not ready to land yet

Mon, Mar 24, 21:26
bytesofman updated the diff for D17822: [ecash-wallet] Add fluent API for building and broadcasting txs.

Update interfaces, add some intermediate steps, take sighash as a param

Mon, Mar 24, 21:23
PiRK closed D17851: blockstorage: add return codes on flush functions, force callers to handle them.
Mon, Mar 24, 19:27
PiRK committed rABCaa67c37d0718: blockstorage: add return codes on flush functions, force callers to handle them (authored by TheCharlatan <seb.kung@gmail.com>).
blockstorage: add return codes on flush functions, force callers to handle them
Mon, Mar 24, 19:27