This does not work yet. When testing on mainnet with a very recent snapshot, the node crashed before finishing background IBD because chronik tried to index a mempool tx that was spending coins not yet indexed.

The CI found more, confirmed locally by nuking the build dir & ccache and restarting the compilation from scratch

the CI keeps finding more when locally the build passes

more

i missed two

ok some specific recommendations

rebase

also a fair point. Rome wasnt built in a day haha

move dummy code to #else branch

In D18066#411944, @emack wrote:

In mobile mode, this new header now takes up 30% of the UI. I know it moves off the screen when scrolling but it reappears with navigating to a new component. I think tooltips like Staking and Savings should be able to be closed or minimized by the user? Or perhaps have an onHover icon?
Also the Learn more link on mobile screens are somewhat harder to click (maybe I just have fat fingers) - perhaps make the whole row a link?

For sure, fair points. I believe its not necessarily much taller than the current UI if you do have an XECX and Firma balance, but that shouldnt be the benchmark.
I can try for a more compact solution, and possibly look at allowing users to dismiss the info text

don't use conditional compilation for lambda definition

fix clang-tidy warning

will likely have to wrap the lambda captures in #if ENABLE_CHRONIK blocks to prevent error: lambda capture 'args' is not used [-Werror,-Wunused-lambda-capture]

Made relevant to eCash, changed tests and comments

fully support chronik (in the long run this is less work than repeatedly explaining that chronik should be enabled with a restart only after background validation is complete)

still missing the tests

In mobile mode, this new header now takes up 30% of the UI. I know it moves off the screen when scrolling but it reappears with navigating to a new component. I think tooltips like Staking and Savings should be able to be closed or minimized by the user?
Also the Learn more link on mobile screens are somewhat harder to click (maybe I just have fat fingers) - perhaps make the whole row a link?

In D18069#411927, @emack wrote:

are these the warnings you're referring to when npm run build? If so I'm still seeing them

are these the warnings you're referring to when npm run build? If so I'm still seeing them

In D18061#411855, @emack wrote:

If you input a large enough number Cashtab crashes with a WSOD and spits out a range error on console. Not a big issue but rather unsightly. The other send amount inputs throughout the app gracefully spits out a Unable to parse sendAmount as a number UI error instead of sharting.

lint

support prefix and suffix for customized input field currency clarification

fix year in header for Receive

If you input a large enough number Cashtab crashes with a WSOD and spits out a range error on console. Not a big issue but rather unsightly. The other send amount inputs throughout the app gracefully spits out a Unable to parse sendAmount as a number UI error instead of sharting.

We should document this behavior somehow

Can we have the unit in the amount input field ? IMO it avoids confusion better than the icon only, and 10 XEC is very different from 10 FIRMA

Build Bitcoin ABC Diffs / Diff Testing (preview-cashtab) passed.
Preview is available at http://51.68.37.192:41715 for the next 60 minutes.

Build Bitcoin ABC Diffs / Diff Testing (preview-cashtab) passed.
Preview is available at http://51.83.66.92:41822 for the next 60 minutes.

@bot preview-cashtab

@bot preview-cashtab

Clearing my queue, my previous comment still holds.

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.83.66.92:41098 for the next 60 minutes.

@bot preview-e.cash

Updated comments