@deadalnix : Can you please get specific about what you mean by 'wild guesses' in the current patch .
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Jul 3 2017
Jul 3 2017
The test framework is using the default value of '.' for SRCDIR .
freetrader added a comment to D292: Addresses hang issue seen in T28 by freetrader -- properly register Config type with Qt so it may be used in signals/slots.
I've tested this using a build with Qt4 and it works on my system.
I'll try building on older Ubuntu to see if its ok there too.
Please update the TEST PLAN , that was the point of my initial request.
freetrader accepted D291: Use raw string comparison instead of std::regex , as it is clearly not mature..
Fixes the test on my system (which is not plain Debian 8).
Jul 2 2017
Jul 2 2017
freetrader committed rABCe0ec90e662e6: Align UAHF spec with upstream Bitcoin-UAHF (authored by freetrader).
Align UAHF spec with upstream Bitcoin-UAHF
If there is no intention to further test on nolnet (expressed by further comments / planning discussion on this ticket), I will withdraw (abandon) this Diff by Tue 4 Jul 12:00AM UTC .
freetrader added a comment to D290: Fixed runtime error on older gcc/g++ (<4.9) where std::reg_ex is non-standards compliant and produced a regex compile fail. This new simpler regex does not trip up even broken libstdc++ std::regex implementations..
I'm ok with the simplification of the regex and nailing it down to use std::regex::basic .
Jul 1 2017
Jul 1 2017
Herald added 1 blocking reviewer(s) for D289: Align UAHF spec with upstream Bitcoin-UAHF: Restricted Project.
Jun 30 2017
Jun 30 2017
freetrader updated the test plan for D282: Better error messages if bitcoind binary cannot be found.
Repurpose this diff to make it into better error handling for misconfiguration.
Jun 29 2017
Jun 29 2017
Changes look good to me.
freetrader added inline comments to D287: Check for user agent string length and trim it if necessary.
freetrader added inline comments to D287: Check for user agent string length and trim it if necessary.
I do not have any issue with this change, but the Test Plan is inadequate since there are no unit tests covering this, hence 'make check' does not test it - it requires running at least the Python tests.
Jun 28 2017
Jun 28 2017
freetrader added inline comments to D287: Check for user agent string length and trim it if necessary.
freetrader added inline comments to D287: Check for user agent string length and trim it if necessary.
freetrader accepted D286: Make sure we have one txdata object per tx we validate. That's required for parallel signature checking..
Accepted - this is a revert of 05fdbe78b and back to existing Core code .
freetrader abandoned D283: Fix test framework buffering issue which disturbed abc-p2p-fullblocktest.py.
Agreed, D284 code change is simpler and appears to be just as stable.
freetrader requested changes to D284: Fix race condition when reading from the network in mininode.py.
Minor things only.
freetrader updated the test plan for D283: Fix test framework buffering issue which disturbed abc-p2p-fullblocktest.py.
freetrader updated the summary of D283: Fix test framework buffering issue which disturbed abc-p2p-fullblocktest.py.
freetrader added inline comments to D283: Fix test framework buffering issue which disturbed abc-p2p-fullblocktest.py.
freetrader added a comment to D283: Fix test framework buffering issue which disturbed abc-p2p-fullblocktest.py.
Travis tests results are green:
Herald added 1 blocking reviewer(s) for D283: Fix test framework buffering issue which disturbed abc-p2p-fullblocktest.py: Restricted Project.
In D282#4611, @deadalnix wrote:No. If the argument passed down is wrong, you want to report it, not do wild guesses that may or may not be what the caller intended.
Herald added 1 blocking reviewer(s) for D282: Better error messages if bitcoind binary cannot be found: Restricted Project.
Jun 25 2017
Jun 25 2017
Jun 23 2017
Jun 23 2017
freetrader committed rABCa737cabe0271: Remove leftover from the schnorr experiment (authored by MattBitprim).
Remove leftover from the schnorr experiment
freetrader closed D247: Remove leftover from the schnorr experiment by committing rABCa737cabe0271: Remove leftover from the schnorr experiment (authored by MattBitprim).
Taking this to close / land as there seems to be no outstanding action required.
If, when we format everything before release, we could solve the problem of single-line if(some_condition) { do_something(); } contraction, that would be great.
I'd much prefer the body to be on a different line.
freetrader committed rABC8609fc611590: Change from overflow to testing integer minimum (eliminate compiler warning) (authored by freetrader).
Change from overflow to testing integer minimum (eliminate compiler warning)
Herald added 1 blocking reviewer(s) for D259: Change from overflow to testing integer minimum (eliminate compiler warning): Restricted Project.
freetrader committed rABC30682a7c4c37: Set memory buffer size to 0 for OutputChecker (authored by freetrader).
Set memory buffer size to 0 for OutputChecker
Jun 23 2017, 08:42 · Restricted Project
Herald added 1 blocking reviewer(s) for D257: Set memory buffer size to 0 for OutputChecker: Restricted Project.
Jun 22 2017
Jun 22 2017
freetrader committed rABCa9fa5c8f475c: Add two simple test framework self-tests (authored by freetrader).
Add two simple test framework self-tests
Updated after the initial stderr checkers are no longer
passed to initialize_chain. It is transformed instead into
a test which calls initialize_chain directly to set up
a test chain.
freetrader created T52: Fix doxygen same line annotations which are pulled to previous line by clang-style.
Jun 22 2017, 19:14 · Restricted Project
Ok, some doxygen comment misery, but that's for fixing later.
Resolved with D243
Jun 22 2017, 19:06 · Restricted Project
freetrader closed T45: Create a RPC to set UAHF start time, a subtask of T46: Get the release in shape, as Resolved.
Ignore previous comment - I checked and there's no linter diff on my tree for transaction.h, so I guess it's good.
No diff against transaction.h ?
freetrader committed rABCcbdaf5b22f61: Implement setting of UAHF start time via RPC (authored by freetrader).
Implement setting of UAHF start time via RPC
Accepted, nothing major noticed.
More cleanups after review
Accepted this on account of argument against semantic change.
If there was such a semantic change it would need separate testing to show it is ok.
Simplify test as suggested by review
freetrader added a comment to D246: Make sure we generate a block bigger than 1MB by stuffing the coinbase when required.
I'm ok with these changes and have convinced myself (by a little math) that the block stuffing works as advertised.
Initial batch of fixes from deadalnix review comments
freetrader added inline comments to D246: Make sure we generate a block bigger than 1MB by stuffing the coinbase when required.
In case of changing compiled files source tree, make check should be added to Test Plan.
Jun 21 2017
Jun 21 2017
freetrader committed rABCc1cb5aad751a: Mark fall-through cases in our code clearly (authored by freetrader).
Mark fall-through cases in our code clearly
I didn't test this yet. But you wrote
"In practice it does not seem to work right despite -Wimplicit-fallthrough=3"
Note that you used "FALLTHROUGH" but on this page you linked, https://developers.redhat.com/blog/2017/03/10/wimplicit-fallthrough-in-gcc-7/:
it says "FALLTHRU".
Might that be the reason explaining this?