Remove commented log statement in high_priority_transaction.py
Avoid passing config to addPriotityTxs as a parameter use the member in the object

Add new nBlockPriorityPercentage globals and 2 new methods to get/set such value.
Set will also assure that the proposed value belongs to [0..100].

Accepted modulo the unsigned int unrelated change (but I'm good in either case) .

Seems ok from here, wonder if we could avoid the repetition of this check

if (VersionBitsState(pindex->pprev, consensusparams,
                     Consensus::DEPLOYMENT_CSV,
                     versionbitscache) == THRESHOLD_ACTIVE) {

seems ok from here

Rebase

Use a int64_t var to evaluate -blockprioritypercentage input value

Fix @deadalnix nits about comments

Fix bip68-sequence.py

Fix typos in the release-notes.md

Fix comments in high high_priority_transaction.py
Add comment in the new added test to explain the definition of the hiprio cut-off
Mention the introduction of blockprioritypercentage parameter in the release notes
Mention the deprecation of blockprioritysize parameter in the release notes
Fix python files indentation

Take out of WIP, added functional test to verify hiprio txns inclusion. Stop execution if -blockptioritypercentage par is out of range

Add blockprioritypercentage parameter and remove blockprioritysize

@deadalnix as I wrote in the note I still have to add the test to verify that hiprio txns will be actually included.

Properly set up -blockprioritysize default

wonder if we could just add the 478559 and then rely on assumevalid to lessen the load due to validation during the sync step.

In D447#7644, @CCulianu wrote:

It would make the review process easier if you will apply format changes in another diff.
Once the formatting diff will be merged, you could rebase this one.

I'm ok with the changes you made, the only thing I would made differently (as I said already) is setting the new constant (UAHF_START_TIME = 2000000000)
in the test_framework/cdefs.py so that in case we need to change it we could change it only in one place. rather than in all the file u modified in this diff.

I'm ok with the changes you made, the only thing I would made differently (as I said already) is setting the new constant (UAHF_START_TIME = 2000000000)
in the test_framework/cdefs.py so that in case we need to change it we could change it only in one place. rather than in all the file u modified in this diff.

Fix a typo and wording

Update comments in contrib/seeds/makeseeds.py

Forgot to regenerate src/chainparamsseeds.h.
Make sure there is @generated in the comment in the header of src/chainparamsseeds.h.

Superseded by 403

Remove extraline in .arclint

@deadalnix need to close this one cause I preapared the diff against @freetrader github repo rather than the phabricator one

ok got what you meant hopefully.
In https://reviews.bitcoinabc.org/D401 I've excluded src/chainparamsseeds.h from being ling and autopep8 contrib/seeds/makeseeds.py
once it's landed I'm going to rebase D399

Format makeseeds.py using autopep8 (like it was in the 1st submission)

what you asked then?

Exclude contrib/seeds/makeseeds.py from the linting process

misunderstood what you meant.
going to exclude contrib/seeds/makeseeds.py from linting

Exclude src/chainparamsseeds.h from linting process

makeseeds.py has already been linted using autopep8.

didn't mean to accept also for the group Bitcoin ABC. is there a way to undo that part of the approval?

proof read, everything seems ok.

Dunno if you care but I would add reference to fanquake's commit fix (af5d48c9a03182fdf121623bd98136b66d0fcb27).
Other than that the change is ok.

New function to add multi parameters
Add regex based test to check how userAgent() trim too long subversion string

fix a typo
expand log aout sanitize uacomment
add a comment for ForceSetArg

Add cpp test case to check max user agent string len
Format a LogPrints in net.cpp

WIP, need to add a unit test to validate userAgent return value

solved by D249