Feed Advanced Search

Advanced Search
Use Results
Edit Query
Hide Query

Aug 26 2018

schancel accepted D1682: Use Txid in CWallet::GetWalletTx.

Aug 26 2018, 01:30

Aug 25 2018

schancel accepted D1681: Use TxId in walletdb.

Aug 25 2018, 17:33

schancel accepted D1676: Update hash.{h|cpp} to use fixed size types..

Aug 25 2018, 17:33

schancel accepted D1675: Refactor bloom.{h|cpp}.

Aug 25 2018, 17:32

schancel accepted D1679: Use TxId in the wallet RPC..

Aug 25 2018, 16:41

schancel accepted D1678: Use TxId in validation.cpp instead of uint256.

Aug 25 2018, 16:40

schancel accepted D1677: Parse the TxId as a TxId in bitcoin-tx.cpp.

Aug 25 2018, 16:40

schancel accepted D1674: Make TxId constructione xplicit.

Aug 25 2018, 16:36

schancel accepted D1680: Add an error message when not using clang-format 4.0.

Aug 25 2018, 16:31

Aug 24 2018

schancel committed rABC87d967d48f27: Move CFeeRate into its own source files (authored by schancel).

Move CFeeRate into its own source files

Aug 24 2018, 22:04

schancel closed D1673: Move CFeeRate into its own source files.

Aug 24 2018, 22:04

schancel added inline comments to D1673: Move CFeeRate into its own source files.

Aug 24 2018, 21:30

schancel retitled D1673: Move CFeeRate into its own source files from Move CFeeRate to it's own files to Move CFeeRate into its own source files.

Aug 24 2018, 21:24

Herald added a reviewer for D1673: Move CFeeRate into its own source files: Restricted Project.

Aug 24 2018, 21:21

schancel committed rABCcd3c01418d9e: Use ceiling division for fees when funding transactions (authored by schancel).

Use ceiling division for fees when funding transactions

Aug 24 2018, 20:33

schancel closed D1662: Use ceiling division for fees when funding transactions.

Aug 24 2018, 20:33

schancel updated the summary of D1662: Use ceiling division for fees when funding transactions.

Aug 24 2018, 19:38

schancel updated the diff for D1662: Use ceiling division for fees when funding transactions.

Rebase on D1670

Aug 24 2018, 19:01

schancel accepted D1672: Remove the Amount::GetSatoshi function.

Aug 24 2018, 18:55

schancel accepted D1669: Do not use GetSatoshi in the qt code..

Aug 24 2018, 18:55

schancel accepted D1671: Remove various calls to GetSatoshi.

Aug 24 2018, 18:55

schancel accepted D1670: Split test for fee rate and amount.

Aug 24 2018, 18:54

schancel updated the diff for D1662: Use ceiling division for fees when funding transactions.

Remove accidental inclusion

Aug 24 2018, 18:26

schancel updated the diff for D1662: Use ceiling division for fees when funding transactions.

Update based on feedback

Aug 24 2018, 18:25

schancel added inline comments to D1662: Use ceiling division for fees when funding transactions.

Aug 24 2018, 18:06

Aug 21 2018

schancel added inline comments to D1662: Use ceiling division for fees when funding transactions.

Aug 21 2018, 19:03

schancel updated the diff for D1662: Use ceiling division for fees when funding transactions.

Add tests like a good programmer

Aug 21 2018, 17:24

schancel requested changes to D1630: Add HTTP callback args wrapper to support multiple args.

Aug 21 2018, 16:58

schancel added inline comments to D1630: Add HTTP callback args wrapper to support multiple args.

Aug 21 2018, 16:58

schancel accepted D1664: Added notes in gitian-signing for optionally generating SHA256SUMS.

Aug 21 2018, 16:57

schancel accepted D1663: Updated release notes to make it clear where the Github release contents come from.

Aug 21 2018, 16:56

Aug 20 2018

schancel renamed T397: Added `trusted` to help of gettransaction RPC from Added `trusted` to help of gettransaction to Added `trusted` to help of gettransaction RPC.

Aug 20 2018, 21:58 · Bootcamp, Restricted Project

schancel triaged T397: Added `trusted` to help of gettransaction RPC as Low priority.

Aug 20 2018, 21:58 · Bootcamp, Restricted Project

Herald added a reviewer for D1662: Use ceiling division for fees when funding transactions: Restricted Project.

Aug 20 2018, 21:17

schancel requested changes to D1650: Update macOS build to use correct versions of dependencies.

Actually, can you verify the OSX cross compilation is using berkeleydb5.3? We don't want official builds using >5.3 due to licensing.

Aug 20 2018, 20:15

schancel accepted D1658: Add note in the docs about gitian building for OSX.

Aug 20 2018, 20:14

schancel abandoned D1652: CHECKDATASIG(VERIFY): Update for single, raw SHA256 message hash.

Aug 20 2018, 20:13

schancel commandeered D1652: CHECKDATASIG(VERIFY): Update for single, raw SHA256 message hash.

Aug 20 2018, 20:13

schancel accepted D1650: Update macOS build to use correct versions of dependencies.

Aug 20 2018, 20:12

Aug 16 2018

schancel accepted D1657: Added a note about preserving binaries for signing after doing a gitian build.

Aug 16 2018, 21:18

Aug 13 2018

schancel added inline comments to D1651: Update getrawtransaction to allow retrieval by including blockid; useful for pruning nodes that cannot use -txindex..

Aug 13 2018, 21:13

schancel accepted D1646: Hash the input of OP_CHECKDATASIG instead of expecting the user to do it..

Aug 13 2018, 20:20

schancel requested changes to D1646: Hash the input of OP_CHECKDATASIG instead of expecting the user to do it..

Aug 13 2018, 20:03

schancel committed rABC3ac42e84f48b: [qa] make create_confirmed_utxos calculate fees (authored by schancel).

[qa] make create_confirmed_utxos calculate fees

Aug 13 2018, 19:16

schancel closed D1633: [qa] make create_confirmed_utxos calculate fees.

Aug 13 2018, 19:15

schancel committed rABC9e2c9735be30: [qa] move and rename mine_large_block from util to blocktools (authored by schancel).

[qa] move and rename mine_large_block from util to blocktools

Aug 13 2018, 18:50

schancel closed D1636: [qa] move and rename mine_large_block from util to blocktools.

Aug 13 2018, 18:50

schancel updated the diff for D1633: [qa] make create_confirmed_utxos calculate fees.

Fix nits

Aug 13 2018, 17:32

schancel updated the diff for D1636: [qa] move and rename mine_large_block from util to blocktools.

Rebase

Aug 13 2018, 17:31

schancel committed rABC1462272d6178: [qa] add cashaddr module, and fix send_big_transactions (authored by schancel).

[qa] add cashaddr module, and fix send_big_transactions

Aug 13 2018, 17:03

schancel closed D1634: [qa] add cashaddr module, and fix send_big_transactions.

Aug 13 2018, 17:03

Aug 12 2018

schancel committed rABC4271fd9c0bf4: [qa] Fix assertions in fundrawtransaction (authored by schancel).

[qa] Fix assertions in fundrawtransaction

Aug 12 2018, 18:23

schancel closed D1645: [qa] Fix assertions in fundrawtransaction.

Aug 12 2018, 18:23

Herald added a reviewer for D1645: [qa] Fix assertions in fundrawtransaction: Restricted Project.

Aug 12 2018, 10:25

Aug 10 2018

schancel abandoned D1637: [qa] move create_confirmed_utxos to blocktools.py from util.py.

Aug 10 2018, 20:10

schancel committed rABCf3949a1489cd: [qa] make fundrawtransaction test calculate fees properly (authored by schancel).

[qa] make fundrawtransaction test calculate fees properly

Aug 10 2018, 19:59

schancel closed D1635: [qa] make fundrawtransaction test calculate fees properly.

Aug 10 2018, 19:59

Aug 9 2018

schancel updated the diff for D1634: [qa] add cashaddr module, and fix send_big_transactions.

Move note about where the cashaddr module was taken from to the correct location

Aug 9 2018, 22:27

schancel accepted D1640: Add blockindexworkcomparator.h to Makefile.am.

Aug 9 2018, 22:26

schancel updated the diff for D1634: [qa] add cashaddr module, and fix send_big_transactions.

Fix more nits

Aug 9 2018, 22:15

schancel updated the diff for D1634: [qa] add cashaddr module, and fix send_big_transactions.

Fix nits

Aug 9 2018, 22:09

schancel added inline comments to D1634: [qa] add cashaddr module, and fix send_big_transactions.

Aug 9 2018, 22:08

schancel updated the diff for D1633: [qa] make create_confirmed_utxos calculate fees.

Rebase

Aug 9 2018, 22:04

schancel committed rABCc99367a12f71: [qa] move create_confirmed_utxos to blocktools.py from util.py (authored by schancel).

[qa] move create_confirmed_utxos to blocktools.py from util.py

Aug 9 2018, 22:00

schancel closed D1632: [qa] move create_confirmed_utxos to blocktools.py from util.py.

Aug 9 2018, 22:00

schancel updated the diff for D1632: [qa] move create_confirmed_utxos to blocktools.py from util.py.

Rebase

Aug 9 2018, 21:58

Herald added a reviewer for D1637: [qa] move create_confirmed_utxos to blocktools.py from util.py: Restricted Project.

Aug 9 2018, 19:24

Herald added a reviewer for D1636: [qa] move and rename mine_large_block from util to blocktools: Restricted Project.

Aug 9 2018, 19:06

Herald added a reviewer for D1635: [qa] make fundrawtransaction test calculate fees properly: Restricted Project.

Aug 9 2018, 18:16

Herald added a reviewer for D1634: [qa] add cashaddr module, and fix send_big_transactions: Restricted Project.

Aug 9 2018, 17:49

Herald added a reviewer for D1633: [qa] make create_confirmed_utxos calculate fees: Restricted Project.

Aug 9 2018, 17:39

Herald added a reviewer for D1632: [qa] move create_confirmed_utxos to blocktools.py from util.py: Restricted Project.

Aug 9 2018, 17:37

schancel requested changes to D1600: Added RPCCommand and associated classes.

Aug 9 2018, 15:12

schancel added a comment to D1606: OP_INVERT implementation.

There should be some additional testing in the magnetic anomaly activation test.

Aug 9 2018, 01:10

schancel added inline comments to D1598: OP_MUL implementation.

Aug 9 2018, 01:07

schancel added a comment to D1593: Expand IsOpcodeDisabled() function to prepare for implementation of re-enabled opcodes in Magnetic update..

@danconnolly You're correct, my bad. This looks good. Let me take a look at the implementations before I sign off on landing this.

Aug 9 2018, 01:06

Aug 8 2018

schancel added a comment to D1600: Added RPCCommand and associated classes.

Regarding the example, weren't we going to move the Help messages into a special method that executes if validation fails? I thought you didn't want them inline with the normal handling?

Aug 8 2018, 22:28

schancel accepted D1625: Add activation code for OP_CHECKDATASIG.

Aug 8 2018, 19:49

Aug 7 2018

schancel accepted D1612: Bump automatic replay protection to May 2019 upgrade.

Aug 7 2018, 19:11

schancel requested changes to D1628: Seperated enum class BlockValidity from chain.h into its own .h file and updated other .h and .cpp dependencies..

Aug 7 2018, 19:11

schancel added a comment to D1628: Seperated enum class BlockValidity from chain.h into its own .h file and updated other .h and .cpp dependencies..

I think this needs to be rebased. There's been a lot of changes to blockvalidity by @deadalnix that don't seem to be here, and there's some autoconf problem.

Aug 7 2018, 19:11

schancel requested changes to D1625: Add activation code for OP_CHECKDATASIG.

Aug 7 2018, 19:07

Aug 6 2018

schancel abandoned D1486: Use a modified size for transaction minimum fee calculation..

Aug 6 2018, 17:49

schancel abandoned D1581: Update CTxMemPoolEntry and BlockAssembler to billing cutoffs.

Aug 6 2018, 17:49

schancel committed rABC4fcdb4c2f859: Make transaction ordering tests easier to debug (authored by schancel).

Make transaction ordering tests easier to debug

Aug 6 2018, 17:45

schancel closed D1615: Make transaction ordering tests easier to debug.

Aug 6 2018, 17:45

schancel added a comment to D1615: Make transaction ordering tests easier to debug.

Those steps don't actually work for being able to debug these tests. Having some kind of annotation makes debugging much simpler since this test is fragile.

Aug 6 2018, 17:18

schancel added a comment to D1626: code formatting for transaction.cpp.

Looks great. Thanks @andychen

Aug 6 2018, 17:14

schancel committed rABCe10cafb55058: Revert "Remove unecessary header in amount.h" (authored by schancel).

Revert "Remove unecessary header in amount.h"

Aug 6 2018, 17:02

schancel added a reverting change for rABCffd121e24b84: Remove unecessary header in amount.h: rABCe10cafb55058: Revert "Remove unecessary header in amount.h".

Aug 6 2018, 17:02

schancel closed D1627: Revert "Remove unecessary header in amount.h".

Aug 6 2018, 17:02

schancel updated the diff for D1627: Revert "Remove unecessary header in amount.h".

Add extra info

Aug 6 2018, 15:14

Herald added a reviewer for D1627: Revert "Remove unecessary header in amount.h": Restricted Project.

Aug 6 2018, 15:08

schancel added a reverting change for rABCffd121e24b84: Remove unecessary header in amount.h: D1627: Revert "Remove unecessary header in amount.h".

Aug 6 2018, 15:08

Aug 3 2018

schancel accepted D1618: Various nits in pubkey.cpp.

Aug 3 2018, 16:57

schancel accepted D1617: Remove unecessary header in amount.h.

Aug 3 2018, 16:57

schancel requested changes to D1612: Bump automatic replay protection to May 2019 upgrade.

Aug 3 2018, 16:36

D1613: [cmake] Fix json test generation is now accepted and ready to land.

Aug 3 2018, 16:35

schancel accepted D1613: [cmake] Fix json test generation.

Aug 3 2018, 16:35

schancel updated the diff for D1581: Update CTxMemPoolEntry and BlockAssembler to billing cutoffs.

Fix comment

Aug 3 2018, 01:55