Page MenuHomePhabricator
Feed All Stories

Jan 17 2020

deadalnix committed rABC4cf7adeee08b: Make use of TAG_PUBKEY constants in secp256k1_eckey_pubkey_parse (authored by Ben Woosley <ben.woosley@gmail.com>).
Make use of TAG_PUBKEY constants in secp256k1_eckey_pubkey_parse
Jan 17 2020, 11:36
deadalnix closed D4983: Make use of TAG_PUBKEY constants in secp256k1_eckey_pubkey_parse.
Jan 17 2020, 11:36
deadalnix committed rABC6e298506c77b: improvements to random seed in src/tests.c (authored by Don Viszneki <don@codebad.com>).
improvements to random seed in src/tests.c
Jan 17 2020, 11:36
deadalnix closed D4984: improvements to random seed in src/tests.c.
Jan 17 2020, 11:36
Fabien accepted D4984: improvements to random seed in src/tests.c.
Jan 17 2020, 10:44
Fabien accepted D4983: Make use of TAG_PUBKEY constants in secp256k1_eckey_pubkey_parse.
Jan 17 2020, 10:42
Fabien accepted D4982: Fix algorithm selection in bench_ecmult.
Jan 17 2020, 10:40
Fabien accepted D4981: Summarize build options in configure script.
Jan 17 2020, 10:39
Fabien accepted D4980: Make randomization of a non-signing context a noop.
Jan 17 2020, 10:38
Fabien accepted D4979: Correct order of libs returned on pkg-config --libs --static libsecp256k1 call..
Jan 17 2020, 10:34
Fabien accepted D4977: Make constants static: static const secp256k1_ge secp256k1_ge_const_g; static const int CURVE_B;.
Jan 17 2020, 10:32
Fabien accepted D4976: secp256k1_fe_sqrt: Verify that the arguments don't alias..

Please consider backporting https://github.com/bitcoin-core/secp256k1/pull/591 to fix the bench issue that this check triggers.

Jan 17 2020, 10:29
Fabien accepted D4975: Assorted minor corrections.
Jan 17 2020, 10:15
Fabien accepted D4974: Optimize secp256k1_fe_normalize_weak calls..
Jan 17 2020, 10:13
Fabien added a comment to D4973: Use __GNUC_PREREQ for detecting __builtin_expect.

I fail to see how this is an improvement, since that would prevent CLang from using __builtin_expect. Is this solving any issue ?

Jan 17 2020, 10:09
Fabien accepted D4972: Eliminate scratch memory used when generating contexts.

I need to investigate the unrelated build failure, it looks like there is a flaky test.

Jan 17 2020, 09:55
Fabien accepted D4971: add static context object which has no capabilities.
Jan 17 2020, 09:34
Fabien accepted D4978: Portability fix for the configure scripts generated.
Jan 17 2020, 07:53
teamcity added a comment to D4961: [CMAKE] Add a check_linker_flag function.

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing passed.

Jan 17 2020, 07:49
teamcity added a comment to D4961: [CMAKE] Add a check_linker_flag function.

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing passed.

Jan 17 2020, 07:47
teamcity added a comment to D4961: [CMAKE] Add a check_linker_flag function.

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing started.

Jan 17 2020, 07:41
teamcity added a comment to D4961: [CMAKE] Add a check_linker_flag function.

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing passed.

Jan 17 2020, 07:41
teamcity added a comment to D4961: [CMAKE] Add a check_linker_flag function.

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing started.

Jan 17 2020, 07:36
teamcity added a comment to D4961: [CMAKE] Add a check_linker_flag function.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 17 2020, 07:28
teamcity added a comment to D4961: [CMAKE] Add a check_linker_flag function.

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing started.

Jan 17 2020, 07:28
Fabien added inline comments to D4961: [CMAKE] Add a check_linker_flag function.
Jan 17 2020, 07:24
teamcity added a comment to D4961: [CMAKE] Add a check_linker_flag function.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 17 2020, 07:24
Fabien updated the diff for D4961: [CMAKE] Add a check_linker_flag function.

Address feedback.

Jan 17 2020, 07:24
teamcity added a comment to D4984: improvements to random seed in src/tests.c.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 17 2020, 03:28
Harbormaster failed remote builds in B9004: Diff 15555 for D4982: Fix algorithm selection in bench_ecmult!
Jan 17 2020, 03:17
teamcity added a comment to D4982: Fix algorithm selection in bench_ecmult.
Jan 17 2020, 03:17
teamcity added a comment to D4983: Make use of TAG_PUBKEY constants in secp256k1_eckey_pubkey_parse.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 17 2020, 03:15
teamcity added a comment to D4981: Summarize build options in configure script.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 17 2020, 03:14
teamcity added a comment to D4984: improvements to random seed in src/tests.c.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 17 2020, 03:14
deadalnix created D4984: improvements to random seed in src/tests.c.
Jan 17 2020, 03:14
teamcity added a comment to D4983: Make use of TAG_PUBKEY constants in secp256k1_eckey_pubkey_parse.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 17 2020, 03:11
deadalnix created D4983: Make use of TAG_PUBKEY constants in secp256k1_eckey_pubkey_parse.
Jan 17 2020, 03:10
teamcity added a comment to D4982: Fix algorithm selection in bench_ecmult.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 17 2020, 03:08
deadalnix created D4982: Fix algorithm selection in bench_ecmult.
Jan 17 2020, 03:07
teamcity added a comment to D4981: Summarize build options in configure script.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 17 2020, 03:04
deadalnix created D4981: Summarize build options in configure script.
Jan 17 2020, 03:04
teamcity added a comment to D4980: Make randomization of a non-signing context a noop.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 17 2020, 03:03
teamcity added a comment to D4980: Make randomization of a non-signing context a noop.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 17 2020, 02:59
deadalnix created D4980: Make randomization of a non-signing context a noop.
Jan 17 2020, 02:59
deadalnix requested changes to D4929: Make last disconnected block BLOCK_FAILED_VALID, even when aborted.

See build failure.

Jan 17 2020, 01:51
deadalnix requested changes to D4943: Add an option to set the functional test suite name.

Looking at the screenshot I understand better. You get 2 runs due to pre and post activation. This is what you want to indicate in the name of the test suite - as well as other parameters if they come to be more in the future.

Jan 17 2020, 01:47
teamcity added a comment to D4979: Correct order of libs returned on pkg-config --libs --static libsecp256k1 call..

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 17 2020, 01:46
teamcity added a comment to D4979: Correct order of libs returned on pkg-config --libs --static libsecp256k1 call..

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 17 2020, 01:42
deadalnix created D4979: Correct order of libs returned on pkg-config --libs --static libsecp256k1 call..
Jan 17 2020, 01:42
teamcity added a comment to D4978: Portability fix for the configure scripts generated.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 17 2020, 01:40
teamcity added a comment to D4977: Make constants static: static const secp256k1_ge secp256k1_ge_const_g; static const int CURVE_B;.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 17 2020, 01:36
teamcity added a comment to D4978: Portability fix for the configure scripts generated.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 17 2020, 01:35
deadalnix created D4978: Portability fix for the configure scripts generated.
Jan 17 2020, 01:35
teamcity added a comment to D4976: secp256k1_fe_sqrt: Verify that the arguments don't alias..
Jan 17 2020, 01:32
Harbormaster failed remote builds in B8998: Diff 15549 for D4976: secp256k1_fe_sqrt: Verify that the arguments don't alias.!
Jan 17 2020, 01:32
teamcity added a comment to D4977: Make constants static: static const secp256k1_ge secp256k1_ge_const_g; static const int CURVE_B;.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 17 2020, 01:32
deadalnix created D4977: Make constants static: static const secp256k1_ge secp256k1_ge_const_g; static const int CURVE_B;.
Jan 17 2020, 01:32
teamcity added a comment to D4975: Assorted minor corrections.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 17 2020, 01:31
teamcity added a comment to D4976: secp256k1_fe_sqrt: Verify that the arguments don't alias..

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 17 2020, 01:30
deadalnix created D4976: secp256k1_fe_sqrt: Verify that the arguments don't alias..
Jan 17 2020, 01:29
teamcity added a comment to D4975: Assorted minor corrections.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 17 2020, 01:27
deadalnix created D4975: Assorted minor corrections.
Jan 17 2020, 01:27
deadalnix requested changes to D4418: Add simple unit tests for parse_name().
Jan 17 2020, 01:20
teamcity added a comment to D4974: Optimize secp256k1_fe_normalize_weak calls..

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 17 2020, 01:18
deadalnix accepted D4970: Update seeds.
Jan 17 2020, 01:10
deadalnix accepted D4966: Merge #12804: [tests] Fix intermittent rpc_net.py failure..
Jan 17 2020, 01:09
deadalnix requested changes to D4968: Update chainparams.

Figure out the test failure.

Jan 17 2020, 01:08
deadalnix accepted D4969: Update manpages for 0.20.11 release.
Jan 17 2020, 01:08
teamcity added a comment to D4968: Update chainparams.
Jan 17 2020, 01:08
teamcity added a comment to D4973: Use __GNUC_PREREQ for detecting __builtin_expect.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 17 2020, 01:06
teamcity added a comment to D4974: Optimize secp256k1_fe_normalize_weak calls..

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 17 2020, 01:05
deadalnix created D4974: Optimize secp256k1_fe_normalize_weak calls..
Jan 17 2020, 01:05
teamcity added a comment to D4968: Update chainparams.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 17 2020, 01:05
teamcity added a comment to D4973: Use __GNUC_PREREQ for detecting __builtin_expect.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 17 2020, 01:02
deadalnix created D4973: Use __GNUC_PREREQ for detecting __builtin_expect.
Jan 17 2020, 01:02
teamcity added a comment to D4972: Eliminate scratch memory used when generating contexts.
Jan 17 2020, 00:58
Harbormaster failed remote builds in B8994: Diff 15545 for D4972: Eliminate scratch memory used when generating contexts!
Jan 17 2020, 00:58
teamcity added a comment to D4972: Eliminate scratch memory used when generating contexts.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 17 2020, 00:56
deadalnix created D4972: Eliminate scratch memory used when generating contexts.
Jan 17 2020, 00:55
teamcity added a comment to D4971: add static context object which has no capabilities.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 17 2020, 00:46
teamcity added a comment to D4970: Update seeds.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 17 2020, 00:35
teamcity added a comment to D4970: Update seeds.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 17 2020, 00:34
teamcity added a comment to D4970: Update seeds.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 17 2020, 00:32
teamcity added a comment to D4971: add static context object which has no capabilities.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 17 2020, 00:32
deadalnix created D4971: add static context object which has no capabilities.
Jan 17 2020, 00:32
teamcity added a comment to D4970: Update seeds.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 17 2020, 00:30
teamcity added a comment to D4970: Update seeds.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 17 2020, 00:30
teamcity added a comment to D4970: Update seeds.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 17 2020, 00:29
jasonbcox created D4970: Update seeds.
Jan 17 2020, 00:29
teamcity added a comment to D4969: Update manpages for 0.20.11 release.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 17 2020, 00:26
teamcity added a comment to D4969: Update manpages for 0.20.11 release.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 17 2020, 00:22
jasonbcox created D4969: Update manpages for 0.20.11 release.
Jan 17 2020, 00:22
Harbormaster failed remote builds in B8990: Diff 15541 for D4968: Update chainparams!
Jan 17 2020, 00:22
teamcity added a comment to D4968: Update chainparams.
Jan 17 2020, 00:21
teamcity added a comment to D4968: Update chainparams.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Jan 17 2020, 00:19
jasonbcox created D4968: Update chainparams.
Jan 17 2020, 00:19

Jan 16 2020

teamcity added a comment to D4965: Merge #13126: util: Add Clang thread safety annotations for variables guarded by cs_args.

Build Bitcoin-ABC / Diffs (Resource Intensive) / Resource Intensive Diff Testing passed.

Jan 16 2020, 23:55
teamcity added a comment to D4967: Merge #14108: tests: Add missing locking annotations and locks (g_cs_orphans).
Jan 16 2020, 23:49
teamcity added a comment to D4967: Merge #14108: tests: Add missing locking annotations and locks (g_cs_orphans).

Build Bitcoin-ABC / Diffs (Resource Intensive) / Resource Intensive Diff Testing passed.

Jan 16 2020, 23:49
teamcity added a comment to D4882: [CMAKE] Add a check-extended target.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Jan 16 2020, 23:47