Page MenuHomePhabricator
Feed Advanced Search

Feb 28 2020

deadalnix accepted D5371: Make CPack email available for all generators.
Feb 28 2020, 23:47
deadalnix requested changes to D5379: [CMake] Introduce DEB generator for making .deb packages.

This is clearly the wrong place for this.

Feb 28 2020, 23:47
deadalnix created D5378: Convert bench.h to fixed-point math.
Feb 28 2020, 23:27
deadalnix committed rABC56f5c2a7d458: [cmake] Add comment on libsecp256k1 benchamrks (authored by deadalnix).
[cmake] Add comment on libsecp256k1 benchamrks
Feb 28 2020, 23:26
deadalnix closed D5375: [cmake] Add comment on libsecp256k1 benchamrks.
Feb 28 2020, 23:25
deadalnix accepted D5376: Fix make dist by finishing RPM cleanup.
Feb 28 2020, 23:24
deadalnix created D5377: Add SECURITY.md.
Feb 28 2020, 23:22
deadalnix created D5375: [cmake] Add comment on libsecp256k1 benchamrks.
Feb 28 2020, 23:18
deadalnix updated the summary of D5374: Preventing compiler optimizations in benchmarks without a memory fence.
Feb 28 2020, 23:10
deadalnix updated the test plan for D5374: Preventing compiler optimizations in benchmarks without a memory fence.
Feb 28 2020, 23:08
deadalnix created D5374: Preventing compiler optimizations in benchmarks without a memory fence.
Feb 28 2020, 23:08
deadalnix committed rABC477f66718a83: Don't park blocks when there is no actual reorg (authored by deadalnix).
Don't park blocks when there is no actual reorg
Feb 28 2020, 22:37
deadalnix closed D5370: Don't park blocks when there is no actual reorg.
Feb 28 2020, 22:37
deadalnix created D5370: Don't park blocks when there is no actual reorg.
Feb 28 2020, 16:36
deadalnix updated the diff for D5362: variable signing precompute table.

Proper error message

Feb 28 2020, 15:59
deadalnix committed rABCe3c138cdadcd: Increase robustness against UB in secp256k1_scalar_cadd_bit (authored by roconnor-blockstream <roconnor@blockstream.com>).
Increase robustness against UB in secp256k1_scalar_cadd_bit
Feb 28 2020, 15:49
deadalnix closed D5365: Increase robustness against UB in secp256k1_scalar_cadd_bit.
Feb 28 2020, 15:49
deadalnix committed rABC476508e45a04: Remove mention of ec_privkey_export because it doesn't exist (authored by Jonas Nick <jonasd.nick@gmail.com>).
Remove mention of ec_privkey_export because it doesn't exist
Feb 28 2020, 15:46
deadalnix closed D5364: Remove mention of ec_privkey_export because it doesn't exist.
Feb 28 2020, 15:46
deadalnix committed rABCeaa823883f72: Remove note about heap allocation in secp256k1_ecmult_odd_multiples_table_stora… (authored by Jonas Nick <jonasd.nick@gmail.com>).
Remove note about heap allocation in secp256k1_ecmult_odd_multiples_table_stora…
Feb 28 2020, 15:43
deadalnix closed D5366: Remove note about heap allocation in secp256k1_ecmult_odd_multiples_table_storage_var.
Feb 28 2020, 15:43
deadalnix committed rABC91e49ef1b67d: Make no-float policy explicit (authored by Tim Ruffing <crypto@timruffing.de>).
Make no-float policy explicit
Feb 28 2020, 15:40
deadalnix closed D5367: Make no-float policy explicit.
Feb 28 2020, 15:40
deadalnix retitled D5366: Remove note about heap allocation in secp256k1_ecmult_odd_multiples_table_storage_var from Remove note about heap allocation in secp256k1_ecmult_odd_multiples_table_storage_var which was removed in 47045270fa90f81205d989f7107769bce1e71c4d to Remove note about heap allocation in secp256k1_ecmult_odd_multiples_table_storage_var.
Feb 28 2020, 15:39
deadalnix committed rABC7c4cbf413ca8: Fix ASM setting in travis (authored by Jonas Nick <jonasd.nick@gmail.com>).
Fix ASM setting in travis
Feb 28 2020, 15:08
deadalnix closed D5368: Fix ASM setting in travis.
Feb 28 2020, 15:08
deadalnix created D5368: Fix ASM setting in travis.
Feb 28 2020, 14:09
deadalnix created D5367: Make no-float policy explicit.
Feb 28 2020, 13:49
deadalnix created D5366: Remove note about heap allocation in secp256k1_ecmult_odd_multiples_table_storage_var.
Feb 28 2020, 13:47
deadalnix created D5365: Increase robustness against UB in secp256k1_scalar_cadd_bit.
Feb 28 2020, 13:39
deadalnix created D5364: Remove mention of ec_privkey_export because it doesn't exist.
Feb 28 2020, 13:35
deadalnix committed rABC0fc988519347: JNI: fix use sig array (authored by lyjstudy).
JNI: fix use sig array
Feb 28 2020, 13:30
deadalnix closed D5353: JNI: fix use sig array.
Feb 28 2020, 13:30
deadalnix accepted D5363: Fix the benchmark build when wallet is disabled.
Feb 28 2020, 13:23
deadalnix accepted D5319: Move lcov-filter.py to cmake/utils.
Feb 28 2020, 13:13
deadalnix retitled D5319: Move lcov-filter.py to cmake/utils from Move lcov-filter.py to test/coverage to Move lcov-filter.py to cmake/utils.
Feb 28 2020, 13:13
deadalnix accepted D5333: [CMAKE] Fix build with make as a generator.
Feb 28 2020, 13:12
deadalnix requested changes to D5339: [CMAKE] Improve FindBerkeleyDB.
Feb 28 2020, 13:12
deadalnix committed rABC0b4455444dd7: [cmake] Build bench by default (authored by deadalnix).
[cmake] Build bench by default
Feb 28 2020, 13:07
deadalnix closed D5346: [cmake] Build bench by default.
Feb 28 2020, 13:07
deadalnix updated the diff for D5362: variable signing precompute table.

Fix readme

Feb 28 2020, 02:37
deadalnix created D5362: variable signing precompute table.
Feb 28 2020, 02:36
deadalnix updated the diff for D5353: JNI: fix use sig array.

rebase

Feb 28 2020, 01:46
deadalnix accepted D5337: [automated-commits] Add update-timings.

Pulling this from teamcity would be better, but we can live with this.

Feb 28 2020, 01:45
deadalnix updated the diff for D5346: [cmake] Build bench by default.

rebase

Feb 28 2020, 01:43
deadalnix accepted D5360: Make gen-manpages.sh return non-zero if the script fails at any point.
Feb 28 2020, 01:40
deadalnix committed rABC30ed56545064: Avoid calling secp256k1_*_is_zero when secp256k1_*_set_b32 fails. (authored by Gregory Maxwell <greg@xiph.org>).
Avoid calling secp256k1_*_is_zero when secp256k1_*_set_b32 fails.
Feb 28 2020, 01:39
deadalnix closed D5347: Avoid calling secp256k1_*_is_zero when secp256k1_*_set_b32 fails..
Feb 28 2020, 01:39
deadalnix committed rABCf6b2ace37ed7: Add a descriptive comment for secp256k1_ecmult_const. (authored by Gregory Maxwell <greg@xiph.org>).
Add a descriptive comment for secp256k1_ecmult_const.
Feb 28 2020, 01:38
deadalnix closed D5349: Add a descriptive comment for secp256k1_ecmult_const..
Feb 28 2020, 01:37
deadalnix committed rABC7116a8096f6b: secp256k1/src/tests.c: Properly handle sscanf return value (authored by Mustapha Abiola <mustapha@trilemma.net>).
secp256k1/src/tests.c: Properly handle sscanf return value
Feb 28 2020, 01:36
deadalnix closed D5356: secp256k1/src/tests.c: Properly handle sscanf return value.
Feb 28 2020, 01:36
deadalnix committed rABC30b847e3177a: Fix typo (authored by practicalswift <practicalswift@users.noreply.github.com>).
Fix typo
Feb 28 2020, 01:34
deadalnix closed D5355: Fix typo.
Feb 28 2020, 01:34
deadalnix committed rABC571f87cc42be: Fix typo in secp256k1_preallocated.h (authored by Jan Xie <jan.h.xie@gmail.com>).
Fix typo in secp256k1_preallocated.h
Feb 28 2020, 01:33
deadalnix closed D5351: Fix typo in secp256k1_preallocated.h.
Feb 28 2020, 01:32
deadalnix committed rABCa326d61f584e: Make ./configure string consistent (authored by Tim Ruffing <crypto@timruffing.de>).
Make ./configure string consistent
Feb 28 2020, 01:30
deadalnix closed D5358: Make ./configure string consistent.
Feb 28 2020, 01:30
deadalnix committed rABC84df61acffad: [seeder] Various nits in the cmake build (authored by deadalnix).
[seeder] Various nits in the cmake build
Feb 28 2020, 01:28
deadalnix closed D5345: [seeder] Various nits in the cmake build.
Feb 28 2020, 01:28
deadalnix accepted D5359: Fix missing update to bitcoin-qt manpages.
Feb 28 2020, 01:26
deadalnix committed rABC7119d300be05: Fix a nit in the recovery tests (authored by Elichai Turkel <elichai.turkel@gmail.com>).
Fix a nit in the recovery tests
Feb 28 2020, 01:23
deadalnix closed D5357: Fix a nit in the recovery tests.
Feb 28 2020, 01:23
deadalnix committed rABC63a363d822d2: typo in comment for secp256k1_ec_pubkey_tweak_mul () (authored by philsmd <921533+philsmd@users.noreply.github.com>).
typo in comment for secp256k1_ec_pubkey_tweak_mul ()
Feb 28 2020, 01:17
deadalnix closed D5348: typo in comment for secp256k1_ec_pubkey_tweak_mul ().
Feb 28 2020, 01:17
deadalnix committed rABCbf4703e70a3a: scalar_impl.h: fix includes (authored by Marko Bencun <mbencun+pgp@gmail.com>).
scalar_impl.h: fix includes
Feb 28 2020, 01:15
deadalnix closed D5350: scalar_impl.h: fix includes.
Feb 28 2020, 01:14
deadalnix committed rABCf4a6d50e4e12: Moved a dereference so the null check will be before the dereferencing (authored by Elichai Turkel <elichai.turkel@gmail.com>).
Moved a dereference so the null check will be before the dereferencing
Feb 28 2020, 01:12
deadalnix closed D5352: Moved a dereference so the null check will be before the dereferencing.
Feb 28 2020, 01:12
deadalnix committed rABC181d54fa7045: Fix typo in docs for _context_set_illegal_callback (authored by Tim Ruffing <crypto@timruffing.de>).
Fix typo in docs for _context_set_illegal_callback
Feb 28 2020, 01:10
deadalnix closed D5354: Fix typo in docs for _context_set_illegal_callback.
Feb 28 2020, 01:10
deadalnix created D5358: Make ./configure string consistent.
Feb 28 2020, 01:06
deadalnix created D5357: Fix a nit in the recovery tests.
Feb 28 2020, 01:03
deadalnix created D5356: secp256k1/src/tests.c: Properly handle sscanf return value.
Feb 28 2020, 01:01
deadalnix created D5355: Fix typo.
Feb 28 2020, 00:59
deadalnix created D5354: Fix typo in docs for _context_set_illegal_callback.
Feb 28 2020, 00:55
deadalnix created D5353: JNI: fix use sig array.
Feb 28 2020, 00:45
deadalnix created D5352: Moved a dereference so the null check will be before the dereferencing.
Feb 28 2020, 00:42
deadalnix created D5351: Fix typo in secp256k1_preallocated.h.
Feb 28 2020, 00:39
deadalnix created D5350: scalar_impl.h: fix includes.
Feb 28 2020, 00:37
deadalnix created D5349: Add a descriptive comment for secp256k1_ecmult_const..
Feb 28 2020, 00:33
deadalnix created D5348: typo in comment for secp256k1_ec_pubkey_tweak_mul ().
Feb 28 2020, 00:28
deadalnix created D5347: Avoid calling secp256k1_*_is_zero when secp256k1_*_set_b32 fails..
Feb 28 2020, 00:23
deadalnix created D5346: [cmake] Build bench by default.
Feb 28 2020, 00:11
deadalnix created D5345: [seeder] Various nits in the cmake build.
Feb 28 2020, 00:04

Feb 27 2020

deadalnix requested changes to D5339: [CMAKE] Improve FindBerkeleyDB.
Feb 27 2020, 23:41
deadalnix requested changes to D5333: [CMAKE] Fix build with make as a generator.
Feb 27 2020, 23:30
deadalnix added inline comments to D5333: [CMAKE] Fix build with make as a generator.
Feb 27 2020, 23:30
deadalnix added a comment to D5319: Move lcov-filter.py to cmake/utils.

It is test related, but this is not a test. IMO, you can move it somewhere down cmake/util or something like that, so that it gets exported to libsecp256k1.

Feb 27 2020, 23:27
deadalnix accepted D5341: [backport] Qt: Replace remaining 0 with nullptr #15114.
Feb 27 2020, 23:22

Feb 26 2020

deadalnix accepted D5334: [CI] Run the cmake build with make as a generator.
Feb 26 2020, 18:02
deadalnix added inline comments to D5334: [CI] Run the cmake build with make as a generator.
Feb 26 2020, 18:02
deadalnix added a comment to D5333: [CMAKE] Fix build with make as a generator.

You need to fix you test plan, it's not displaying right.

Feb 26 2020, 16:54
deadalnix requested changes to D5333: [CMAKE] Fix build with make as a generator.
Feb 26 2020, 16:51

Feb 24 2020

deadalnix accepted D5318: Don't use std::quick_exit() as it is poorly supported.
Feb 24 2020, 13:05
deadalnix added a comment to D4418: Add simple unit tests for parse_name().

The fact that you had an off by one error and that the test was passing anyways is a sure sign test test is not design in a robust manner.

Feb 24 2020, 01:09
deadalnix requested changes to D4418: Add simple unit tests for parse_name().
Feb 24 2020, 01:09

Feb 23 2020

deadalnix committed rABC80dd145c4985: [secp256k1] Allow to use external default callbacks (authored by Tim Ruffing <crypto@timruffing.de>).
[secp256k1] Allow to use external default callbacks
Feb 23 2020, 23:46
deadalnix closed D5308: [secp256k1] Allow to use external default callbacks.
Feb 23 2020, 23:46
deadalnix committed rABCb27bc243bc48: [secp256k1] Remove a warning in multiset test (authored by deadalnix).
[secp256k1] Remove a warning in multiset test
Feb 23 2020, 23:37