Page MenuHomePhabricator
Feed Advanced Search

Sep 2 2020

jasonbcox accepted D7314: [CMAKE] Add an install target for the secp256k1 benchmarks.
Sep 2 2020, 22:29
jasonbcox requested review of D7328: Port the abcbot code into this repository.
Sep 2 2020, 21:36
jasonbcox requested review of D7326: Fix detection of binary open() calls in the Python encoding linter.
Sep 2 2020, 21:14
jasonbcox accepted D7315: [backport#14890] rpc: Avoid creating non-standard raw transactions.
Sep 2 2020, 18:13
jasonbcox accepted D7312: [backport#14478] Show error to user when corrupt wallet unlock fails.
Sep 2 2020, 18:00
jasonbcox accepted D7311: [CI] Move some more path definitions to the Configuration object.
Sep 2 2020, 17:57
jasonbcox accepted D7310: [CI] Move the project root directory to the Configuration object.
Sep 2 2020, 17:52
jasonbcox accepted D7300: [backport#13966] Hide spendable label if private key is disabled.
Sep 2 2020, 16:09
jasonbcox requested review of D7313: Remove legacy announcements feed.
Sep 2 2020, 16:08
jasonbcox accepted D7308: [CI] Prevent artifacts from the same diretory to fail the build.
Sep 2 2020, 15:28
jasonbcox accepted D7309: [CI] Clear the artifacts directory before the build.
Sep 2 2020, 15:27

Sep 1 2020

jasonbcox accepted D7301: [backport#13966] gui: Show watch-only eye instead of HD disabled.
Sep 1 2020, 20:31
jasonbcox requested changes to D7300: [backport#13966] Hide spendable label if private key is disabled.

Summary points to wrong commit

Sep 1 2020, 20:30
jasonbcox committed rABCWEB9f1a4d5020ba: Fix blog feed ordering (authored by jasonbcox).
Fix blog feed ordering
Sep 1 2020, 18:40
jasonbcox closed D7298: Fix blog feed ordering.
Sep 1 2020, 18:40
jasonbcox requested review of D7298: Fix blog feed ordering.
Sep 1 2020, 18:37

Aug 31 2020

jasonbcox accepted D7285: [backport#17593][test] move wallet helper functions into test library.
Aug 31 2020, 22:38
jasonbcox accepted D7284: [backport#17593][test] move mining helper functions into test library.
Aug 31 2020, 22:37
jasonbcox accepted D7283: [backport#17593][test] move string helper functions into test library.
Aug 31 2020, 22:34
jasonbcox accepted D7274: [backport#17342][tests] Don't use nScriptCheckThreads in the checkqueue_tests.
Aug 31 2020, 22:08
jasonbcox requested changes to D7274: [backport#17342][tests] Don't use nScriptCheckThreads in the checkqueue_tests.

It's not clear from the Github history whether this commit was outdated from the start or what, but the commit message does not match the patch. There is some indication that the refactor took a turn for a better design though. Please fix this otherwise it's just confusing in our own git history.

Aug 31 2020, 21:20
jasonbcox accepted D7276: [backport#13551] tests: Fix incorrect documentation for test case cuckoocache_hit_rate_ok.
Aug 31 2020, 21:15
jasonbcox accepted D7277: Update the link to the cashaddr spec.

Thanks for the patch. Tested on my local machine and it looks good. Please be sure to setup your dev environment for next time. :)

Aug 31 2020, 20:48
jasonbcox committed rABC4937f6a2b32c: Add miner fund address list to getblocktemplate output (authored by jasonbcox).
Add miner fund address list to getblocktemplate output
Aug 31 2020, 18:59
jasonbcox closed D7235: Add miner fund address list to getblocktemplate output.
Aug 31 2020, 18:58
jasonbcox committed rABCWEB18bf62da639a: Add a feed from blog.bitcoinabc.org (authored by jasonbcox).
Add a feed from blog.bitcoinabc.org
Aug 31 2020, 18:55
jasonbcox closed D7253: Add a feed from blog.bitcoinabc.org.
Aug 31 2020, 18:54
jasonbcox updated the diff for D7253: Add a feed from blog.bitcoinabc.org.

Prettier format + fix tag

Aug 31 2020, 18:47
jasonbcox updated the diff for D7235: Add miner fund address list to getblocktemplate output.

Rebase

Aug 31 2020, 18:33
jasonbcox accepted D7273: [WEBSITE] Bump ruby and jelyll version.
Aug 31 2020, 15:47

Aug 28 2020

jasonbcox committed rABC728b49749065: Add wrapper function for miner fund amount (authored by jasonbcox).
Add wrapper function for miner fund amount
Aug 28 2020, 23:37
jasonbcox closed D7272: Add wrapper function for miner fund amount.
Aug 28 2020, 23:37
jasonbcox committed rABC412606949534: Bump version to 0.22.2 (authored by jasonbcox).
Bump version to 0.22.2
Aug 28 2020, 22:45
jasonbcox closed D7271: Bump version to 0.22.2.
Aug 28 2020, 22:45
jasonbcox updated the summary of D7235: Add miner fund address list to getblocktemplate output.
Aug 28 2020, 19:50
jasonbcox updated the diff for D7235: Add miner fund address list to getblocktemplate output.

Rebase on D7272 to address feedback

Aug 28 2020, 19:49
jasonbcox requested review of D7272: Add wrapper function for miner fund amount.
Aug 28 2020, 19:45
jasonbcox updated the diff for D7271: Bump version to 0.22.2.

Fix version number in the release notes

Aug 28 2020, 19:35
jasonbcox added inline comments to D7253: Add a feed from blog.bitcoinabc.org.
Aug 28 2020, 19:33
jasonbcox updated the diff for D7253: Add a feed from blog.bitcoinabc.org.
  • Use jQuery objects instead of plain strings -> HTML
  • Encode all strings from the blog feed
Aug 28 2020, 19:33
jasonbcox requested review of D7271: Bump version to 0.22.2.
Aug 28 2020, 18:32
jasonbcox accepted D7267: Add more flexibility to the update-aur.sh script.
Aug 28 2020, 16:52
jasonbcox accepted D7270: [CI] Run automated commit builds in separate directories.
Aug 28 2020, 16:48
jasonbcox accepted D7269: [CI] Continuously update the man pages.

I talked with Fabien about this. Originally I did not take this route because I worried there would be too much noise. But as Fabien pointed out to me, only version numbers, chainparams, and newly added args should trigger an update to the manpages. We'll see how this goes in practice.

Aug 28 2020, 16:47

Aug 27 2020

jasonbcox accepted D7261: Add a script to update the AUR packages.
Aug 27 2020, 21:57
jasonbcox requested changes to D7261: Add a script to update the AUR packages.
Aug 27 2020, 21:50
jasonbcox accepted D7260: Add the files from AUR repository to contrib/aur.

I'm aware there are many improvements to make here (notably the commented out ninja check) and Fabien has informed me that he has patches in flight for these. I think committing them as-is is best so we can start tracking changes from the current state.

Aug 27 2020, 21:37
jasonbcox committed rABCWEB4cb3174a8b19: Fixup build tagging (authored by jasonbcox).
Fixup build tagging
Aug 27 2020, 21:30
jasonbcox closed D7258: Fixup build tagging.
Aug 27 2020, 21:30
jasonbcox accepted D7257: [CI] Prevent stdout buffer overflow.
Aug 27 2020, 20:35
jasonbcox added inline comments to D7258: Fixup build tagging.
Aug 27 2020, 15:31
jasonbcox updated the diff for D7258: Fixup build tagging.

fix typo

Aug 27 2020, 15:30

Aug 26 2020

jasonbcox requested review of D7258: Fixup build tagging.
Aug 26 2020, 23:56
jasonbcox updated the diff for D7253: Add a feed from blog.bitcoinabc.org.

Ensure there is a way to provide static blog feed content to improve SEO.
CI will run this script on every deployment to ensure the content is up-to-date.

Aug 26 2020, 23:49
jasonbcox updated the diff for D7235: Add miner fund address list to getblocktemplate output.
  • Added miner fund value
  • Made the fund information a JSON object, containing addresses and minimumvalue
  • Added missing help text
Aug 26 2020, 22:38

Aug 25 2020

jasonbcox requested review of D7253: Add a feed from blog.bitcoinabc.org.
Aug 25 2020, 22:33

Aug 24 2020

jasonbcox accepted D7245: Cleanup autotools workaround in apptest.cpp.
Aug 24 2020, 16:58
jasonbcox accepted D7244: Kill autotools.

Macro likestamp:

Aug 24 2020, 16:57
jasonbcox committed rABC3d12fe01ab32: Add test coverage for getblocktemplate's sigoplimit (authored by jasonbcox).
Add test coverage for getblocktemplate's sigoplimit
Aug 24 2020, 16:11
jasonbcox closed D7234: Add test coverage for getblocktemplate's sigoplimit.
Aug 24 2020, 16:11
jasonbcox committed rABCa341679b4c13: Add test coverage for getblocktemplate's mintime (authored by jasonbcox).
Add test coverage for getblocktemplate's mintime
Aug 24 2020, 15:43
jasonbcox closed D7233: Add test coverage for getblocktemplate's mintime.
Aug 24 2020, 15:43
jasonbcox committed rABCf02132a0d60b: Add a test for ABC-specific getblocktemplate behavior (authored by jasonbcox).
Add a test for ABC-specific getblocktemplate behavior
Aug 24 2020, 15:24
jasonbcox closed D7230: Add a test for ABC-specific getblocktemplate behavior.
Aug 24 2020, 15:24

Aug 22 2020

jasonbcox updated the test plan for D7235: Add miner fund address list to getblocktemplate output.
Aug 22 2020, 04:49
jasonbcox updated the diff for D7235: Add miner fund address list to getblocktemplate output.

Fixed tests

Aug 22 2020, 04:48
jasonbcox updated the diff for D7234: Add test coverage for getblocktemplate's sigoplimit.

Use available constants

Aug 22 2020, 04:38
jasonbcox updated the diff for D7230: Add a test for ABC-specific getblocktemplate behavior.

Improve test robustness according to feedback

Aug 22 2020, 04:34
jasonbcox added inline comments to D7230: Add a test for ABC-specific getblocktemplate behavior.
Aug 22 2020, 04:33
jasonbcox abandoned D7237: TEST PATCH PLEASE IGNORE.
Aug 22 2020, 04:24
jasonbcox accepted D7238: build: pass -fcommon when building genisoimage.
Aug 22 2020, 04:23

Aug 21 2020

jasonbcox added a comment to D7237: TEST PATCH PLEASE IGNORE.

@bot gitian-osx

Aug 21 2020, 17:26
jasonbcox added a comment to D7237: TEST PATCH PLEASE IGNORE.

@bot gitian-osx

Aug 21 2020, 17:20
jasonbcox added a comment to D7237: TEST PATCH PLEASE IGNORE.

@bot gitian-osx

Aug 21 2020, 17:16
jasonbcox planned changes to D7237: TEST PATCH PLEASE IGNORE.
Aug 21 2020, 16:55
jasonbcox requested review of D7237: TEST PATCH PLEASE IGNORE.
Aug 21 2020, 16:55

Aug 20 2020

jasonbcox accepted D7213: [backport#15402] Prevent callback overruns in InvalidateBlock and RewindBlockIndex.
Aug 20 2020, 23:57
jasonbcox requested review of D7235: Add miner fund address list to getblocktemplate output.
Aug 20 2020, 23:17
jasonbcox updated the summary of D7235: Add miner fund address list to getblocktemplate output.
Aug 20 2020, 23:16
jasonbcox planned changes to D7235: Add miner fund address list to getblocktemplate output.
Aug 20 2020, 23:13
jasonbcox requested review of D7235: Add miner fund address list to getblocktemplate output.
Aug 20 2020, 23:13
jasonbcox updated the summary of D7234: Add test coverage for getblocktemplate's sigoplimit.
Aug 20 2020, 22:40
jasonbcox updated the summary of D7233: Add test coverage for getblocktemplate's mintime.
Aug 20 2020, 22:40
jasonbcox updated the summary of D7234: Add test coverage for getblocktemplate's sigoplimit.
Aug 20 2020, 22:39
jasonbcox requested review of D7234: Add test coverage for getblocktemplate's sigoplimit.
Aug 20 2020, 22:39
jasonbcox updated the summary of D7233: Add test coverage for getblocktemplate's mintime.
Aug 20 2020, 22:37
jasonbcox requested review of D7233: Add test coverage for getblocktemplate's mintime.
Aug 20 2020, 22:28
jasonbcox updated the diff for D7230: Add a test for ABC-specific getblocktemplate behavior.

Make the test more friendly to future additions

Aug 20 2020, 22:25
jasonbcox planned changes to D7230: Add a test for ABC-specific getblocktemplate behavior.
Aug 20 2020, 22:15
jasonbcox accepted D7229: build: Skip i686 build by default in gitian.
Aug 20 2020, 21:59
jasonbcox accepted D7231: [CI] Only build the required static dependencies.
Aug 20 2020, 21:29
jasonbcox committed rABCbbdd88c01f03: Fix comment referencing incorrect activation (authored by jasonbcox).
Fix comment referencing incorrect activation
Aug 20 2020, 20:43
jasonbcox closed D7228: Fix comment referencing incorrect activation.
Aug 20 2020, 20:42
jasonbcox requested review of D7230: Add a test for ABC-specific getblocktemplate behavior.
Aug 20 2020, 20:41
jasonbcox added a comment to T1014: Improve test coverage for ABC-specific behaviors in getblocktemplate.

It may be necessary to sanity test tx ordering as well.

Aug 20 2020, 20:40
jasonbcox requested changes to D7229: build: Skip i686 build by default in gitian.

Also remove i686 from contrib/release/github-release.sh

Aug 20 2020, 20:27
jasonbcox requested review of D7228: Fix comment referencing incorrect activation.
Aug 20 2020, 18:37
jasonbcox accepted D7226: test: remove rapidcheck integration and tests.
Aug 20 2020, 17:44
jasonbcox accepted D7227: [CI] Cross build and run the tests for Linux 32 bits.
Aug 20 2020, 17:42

Aug 19 2020

jasonbcox accepted D7222: [CMAKE] Move the test log files to test/log.
Aug 19 2020, 18:44