handle the case of avaproof message before avahello: discourage the peer and ignore the proof
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Mar 25 2021
Mar 24 2021
address the easy items of the review*, and also remove node from queue when it sends a duplicate proof (we ban it anyway)
don't register the nodes while IBD is ongoing. Queue them for later.
@bot build-linux-arm build-linux-aarch64
Node registration must be postponed after end of IBD.
rebase
rebase
This needs rebase
Mar 23 2021
Less ambiguous send/receive icons
There are still quite a few unit tests to be changed. We can no longer just take a random uint32 to create a valid proof, it must be in the correct range.
Maybe I'm nit-picking but the arrow down icon is confusing. By clicking on it I expect the item to expand with details, but it opens the explorer in a new window. Can this icon be chosen to not look like an expand/collapse button ?
Mar 22 2021
Wordings looks fine to me.
Better active pane underline css (previously did not line up in Firefox)
Based on D9342, we can potentially register the proof earlier depending on the proofs ValidationState at init.
rebase on master after landing D9342
drop the if
I suspect that the if (!g_avalanche) test will never be true. In init.cpp, g_avalanche is set in step 7 before the node actually starts connecting to peers (step 12).
move & add comments