Page MenuHomePhabricator
Feed All Stories

Mar 25 2021

PiRK updated the diff for D9327: [avalanche] implement an avalanche handshake.

handle the case of avaproof message before avahello: discourage the peer and ignore the proof

Mar 25 2021, 09:49
abc-bot committed rABCe7392519bdcc: [Automated] Update timing.json (authored by abc-bot).
[Automated] Update timing.json
Mar 25 2021, 03:19
bytesofman accepted D9349: [website] Fix image alt tag for STEX exchange.
Mar 25 2021, 02:36
abc-bot committed rABC70f61e11bda8: [Automated] Update seeds (authored by abc-bot).
[Automated] Update seeds
Mar 25 2021, 02:16
abc-bot committed rABC34cf505a795f: [Automated] Update chainparams (authored by abc-bot).
[Automated] Update chainparams
Mar 25 2021, 02:07

Mar 24 2021

Mengerian requested review of D9349: [website] Fix image alt tag for STEX exchange.
Mar 24 2021, 22:25
teamcity closed T1590: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Linux ARM is broken. as Resolved.
Mar 24 2021, 21:26
teamcity closed T1589: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Linux AArch64 is broken. as Resolved.
Mar 24 2021, 21:20
Fabien closed D9347: Fix the abc_p2p_avalanche functional tests for ARM.
Mar 24 2021, 21:02
Fabien committed rABC9da10b1b09e7: Fix the abc_p2p_avalanche functional tests for ARM (authored by Fabien).
Fix the abc_p2p_avalanche functional tests for ARM
Mar 24 2021, 21:02
bytesofman requested review of D9348: [Cashtab] Parse token txs in tx history.
Mar 24 2021, 19:12
PiRK planned changes to D9327: [avalanche] implement an avalanche handshake.
Mar 24 2021, 17:31
PiRK updated the diff for D9327: [avalanche] implement an avalanche handshake.

address the easy items of the review*, and also remove node from queue when it sends a duplicate proof (we ban it anyway)

Mar 24 2021, 17:30
PiRK planned changes to D9327: [avalanche] implement an avalanche handshake.
Mar 24 2021, 17:13
PiRK updated the diff for D9327: [avalanche] implement an avalanche handshake.

don't register the nodes while IBD is ongoing. Queue them for later.

Mar 24 2021, 17:13
PiRK accepted D9347: Fix the abc_p2p_avalanche functional tests for ARM.
Mar 24 2021, 16:31
teamcity awarded D9347: Fix the abc_p2p_avalanche functional tests for ARM a Piece of Eight token.
Mar 24 2021, 15:35
teamcity awarded D9347: Fix the abc_p2p_avalanche functional tests for ARM a Haypence token.
Mar 24 2021, 15:30
Fabien added a comment to D9347: Fix the abc_p2p_avalanche functional tests for ARM.

@bot build-linux-arm build-linux-aarch64

Mar 24 2021, 15:30
Fabien requested review of D9347: Fix the abc_p2p_avalanche functional tests for ARM.
Mar 24 2021, 15:29
Christopherhale updated Christopherhale.
Mar 24 2021, 14:57
Mengerian closed D9346: [website] Add Huobi to list of BCHA-supporting exchanges.
Mar 24 2021, 14:39
Mengerian committed rABCWEB9ec3c987c919: [website] Add Huobi to list of BCHA-supporting exchanges (authored by Mengerian).
[website] Add Huobi to list of BCHA-supporting exchanges
Mar 24 2021, 14:39
samet updated samet.
Mar 24 2021, 13:23
Joey King <joseph.roy.king@gmail.com> closed D9344: [Cashtab] toggle display between tx history and tokens.
Mar 24 2021, 13:07
Joey King <joseph.roy.king@gmail.com> committed rABC0b2f82a91efb: [Cashtab] toggle display between tx history and tokens (authored by Joey King <joseph.roy.king@gmail.com>).
[Cashtab] toggle display between tx history and tokens
Mar 24 2021, 13:07
Fabien requested changes to D9327: [avalanche] implement an avalanche handshake.
Mar 24 2021, 12:51
teamcity triaged T1590: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Linux ARM is broken. as Unbreak Now! priority.
Mar 24 2021, 12:39
teamcity triaged T1589: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Linux AArch64 is broken. as Unbreak Now! priority.
Mar 24 2021, 12:36
PiRK planned changes to D9327: [avalanche] implement an avalanche handshake.

Node registration must be postponed after end of IBD.

Mar 24 2021, 12:33
PiRK updated the diff for D9338: [avalanche] refactor conditional processing in ProcessMessage.

rebase

Mar 24 2021, 12:15
PiRK updated the diff for D9327: [avalanche] implement an avalanche handshake.

rebase

Mar 24 2021, 12:13
PiRK closed D9323: [avalanche] register our proof after IBD.
Mar 24 2021, 12:08
PiRK committed rABCa3903ab998e7: [avalanche] register our proof after IBD (authored by PiRK).
[avalanche] register our proof after IBD
Mar 24 2021, 12:08
Fabien accepted D9341: [avalanche] improve the test for the avahello handshake.
Mar 24 2021, 09:44
Fabien accepted D9338: [avalanche] refactor conditional processing in ProcessMessage.
Mar 24 2021, 09:40
Fabien requested changes to D9327: [avalanche] implement an avalanche handshake.

This needs rebase

Mar 24 2021, 09:39
Fabien accepted D9344: [Cashtab] toggle display between tx history and tokens.
Mar 24 2021, 07:32
bytesofman accepted D9346: [website] Add Huobi to list of BCHA-supporting exchanges.
Mar 24 2021, 03:29
Mengerian requested review of D9346: [website] Add Huobi to list of BCHA-supporting exchanges.
Mar 24 2021, 03:00

Mar 23 2021

teamcity added a comment to D9345: [avalanche] set a minimum amount for a proof.
Mar 23 2021, 18:29
bytesofman updated the diff for D9344: [Cashtab] toggle display between tx history and tokens.

Less ambiguous send/receive icons

Mar 23 2021, 18:27
teamcity added a comment to D9345: [avalanche] set a minimum amount for a proof.
Mar 23 2021, 18:27
teamcity added a comment to D9345: [avalanche] set a minimum amount for a proof.
Mar 23 2021, 18:25
teamcity added a comment to D9345: [avalanche] set a minimum amount for a proof.
Mar 23 2021, 18:24
teamcity added a comment to D9345: [avalanche] set a minimum amount for a proof.
Mar 23 2021, 18:19
PiRK added a comment to D9345: [avalanche] set a minimum amount for a proof.

There are still quite a few unit tests to be changed. We can no longer just take a random uint32 to create a valid proof, it must be in the correct range.

Mar 23 2021, 18:11
PiRK planned changes to D9345: [avalanche] set a minimum amount for a proof.
Mar 23 2021, 18:11
PiRK requested review of D9345: [avalanche] set a minimum amount for a proof.
Mar 23 2021, 18:11
Fabien requested changes to D9344: [Cashtab] toggle display between tx history and tokens.

arrow_tx_history.png (233×465 px, 15 KB)

Maybe I'm nit-picking but the arrow down icon is confusing. By clicking on it I expect the item to expand with details, but it opens the explorer in a new window. Can this icon be chosen to not look like an expand/collapse button ?

Mar 23 2021, 18:11
Fabien accepted D9323: [avalanche] register our proof after IBD.
Mar 23 2021, 18:11
teamcity closed T1588: Build Bitcoin-ABC / Nightly Builds / Initial Block Download Tests / Initial Block Download w/o Checkpoints is broken. as Resolved.
Mar 23 2021, 09:58
PiRK requested review of D9323: [avalanche] register our proof after IBD.
Mar 23 2021, 09:54
Unknown Object (User) added a comment to rABCWEB7ad44b03b62d: [WEBSITE] Fetch the documentation content from the abc repo.
Mar 23 2021, 07:55

Mar 22 2021

Fabien closed D9336: [WEBSITE] Add an upgrade notice banner to the release page.
Mar 22 2021, 22:01
Fabien committed rABCWEB925dd0122ba0: [WEBSITE] Add an upgrade notice banner to the release page (authored by Fabien).
[WEBSITE] Add an upgrade notice banner to the release page
Mar 22 2021, 22:01
Mengerian accepted D9336: [WEBSITE] Add an upgrade notice banner to the release page.

Wordings looks fine to me.

Mar 22 2021, 22:00
bytesofman updated the diff for D9344: [Cashtab] toggle display between tx history and tokens.

Better active pane underline css (previously did not line up in Firefox)

Mar 22 2021, 21:44
bytesofman requested review of D9344: [Cashtab] toggle display between tx history and tokens.
Mar 22 2021, 21:33
PiRK planned changes to D9323: [avalanche] register our proof after IBD.

Based on D9342, we can potentially register the proof earlier depending on the proofs ValidationState at init.

Mar 22 2021, 20:17
PiRK updated the diff for D9323: [avalanche] register our proof after IBD.

rebase on master after landing D9342

Mar 22 2021, 20:03
Fabien closed D9342: Verify avalanche proof at init.
Mar 22 2021, 19:30
Fabien committed rABCa04ba649ce0a: Verify avalanche proof at init (authored by Fabien).
Verify avalanche proof at init
Mar 22 2021, 19:30
PiRK accepted D9342: Verify avalanche proof at init.
Mar 22 2021, 19:26
Fabien requested review of D9342: Verify avalanche proof at init.
Mar 22 2021, 19:14
PiRK updated the summary of D9341: [avalanche] improve the test for the avahello handshake.
Mar 22 2021, 17:17
PiRK requested review of D9341: [avalanche] improve the test for the avahello handshake.
Mar 22 2021, 17:17
teamcity triaged T1588: Build Bitcoin-ABC / Nightly Builds / Initial Block Download Tests / Initial Block Download w/o Checkpoints is broken. as Unbreak Now! priority.
Mar 22 2021, 14:21
PiRK updated the diff for D9338: [avalanche] refactor conditional processing in ProcessMessage.

drop the if

Mar 22 2021, 13:47
Fabien requested changes to D9338: [avalanche] refactor conditional processing in ProcessMessage.
Mar 22 2021, 13:32
Fabien closed D9339: Drop duplicated chainparamsconstants.cpp.
Mar 22 2021, 11:00
Fabien committed rABCf4afb35e81e3: Drop duplicated chainparamsconstants.cpp (authored by Fabien).
Drop duplicated chainparamsconstants.cpp
Mar 22 2021, 11:00
PiRK accepted D9339: Drop duplicated chainparamsconstants.cpp.
Mar 22 2021, 10:54
Fabien closed D9340: Drop bch network.
Mar 22 2021, 10:52
Fabien committed rABC592ab3edd0b8: Drop bch network (authored by Fabien).
Drop bch network
Mar 22 2021, 10:52
PiRK accepted D9340: Drop bch network.
Mar 22 2021, 10:32
Fabien requested review of D9340: Drop bch network.
Mar 22 2021, 10:05
Fabien requested review of D9339: Drop duplicated chainparamsconstants.cpp.
Mar 22 2021, 10:00
PiRK added a comment to D9338: [avalanche] refactor conditional processing in ProcessMessage.

I suspect that the if (!g_avalanche) test will never be true. In init.cpp, g_avalanche is set in step 7 before the node actually starts connecting to peers (step 12).

Mar 22 2021, 09:31
PiRK updated the summary of D9338: [avalanche] refactor conditional processing in ProcessMessage.
Mar 22 2021, 09:21
PiRK updated the diff for D9338: [avalanche] refactor conditional processing in ProcessMessage.

move & add comments

Mar 22 2021, 09:20
PiRK requested review of D9338: [avalanche] refactor conditional processing in ProcessMessage.
Mar 22 2021, 09:14
Fabien closed D9334: Add -netinfo peer connections dashboard.
Mar 22 2021, 09:13
Fabien committed rABC02e6486e5d6d: Add -netinfo peer connections dashboard (authored by Jon Atack <jon@atack.com>).
Add -netinfo peer connections dashboard
Mar 22 2021, 09:13
Fabien closed D9333: Bump version to 0.23.0.
Mar 22 2021, 09:12
Fabien committed rABCc0abbe448a86: Bump version to 0.23.0 (authored by Fabien).
Bump version to 0.23.0
Mar 22 2021, 09:12
Fabien closed D9225: Move replay protection activation to Nov. 15, 2021.
Mar 22 2021, 09:11
Fabien committed rABCb3f978c96962: Move replay protection activation to Nov. 15, 2021 (authored by Fabien).
Move replay protection activation to Nov. 15, 2021
Mar 22 2021, 09:11
Fabien closed D9332: net: improve nLastBlockTime and nLastTXTime documentation.
Mar 22 2021, 09:08
Fabien committed rABC610fc886e8e5: net: improve nLastBlockTime and nLastTXTime documentation (authored by Jon Atack <jon@atack.com>).
net: improve nLastBlockTime and nLastTXTime documentation
Mar 22 2021, 09:08
Fabien closed D9331: net, rpc: expose nLastBlockTime/nLastTXTime as last block/last_transaction in getpeerinfo.
Mar 22 2021, 09:07
Fabien committed rABCd923449b165b: net, rpc: expose nLastBlockTime/nLastTXTime as last block/last_transaction in… (authored by Jon Atack <jon@atack.com>).
net, rpc: expose nLastBlockTime/nLastTXTime as last block/last_transaction in…
Mar 22 2021, 09:07
Fabien closed D9330: p2p: Reduce inv traffic during IBD.
Mar 22 2021, 09:05
Fabien committed rABC53281306280f: p2p: Reduce inv traffic during IBD (authored by MarcoFalke <falke.marco@gmail.com>).
p2p: Reduce inv traffic during IBD
Mar 22 2021, 09:05
Fabien closed D9326: net: Extract download permission from noban.
Mar 22 2021, 09:04
Fabien committed rABC56f61132d708: net: Extract download permission from noban (authored by MarcoFalke <falke.marco@gmail.com>).
net: Extract download permission from noban
Mar 22 2021, 09:04
Fabien closed D9325: doc: Extract net permissions doc.
Mar 22 2021, 09:03
Fabien committed rABC630e4f7fd5f1: doc: Extract net permissions doc (authored by MarcoFalke <falke.marco@gmail.com>).
doc: Extract net permissions doc
Mar 22 2021, 09:03
Fabien closed D9324: Prepare docs for the next minor version bump.
Mar 22 2021, 09:02
Fabien committed rABC37fd3f1027cf: Prepare docs for the next minor version bump (authored by Fabien).
Prepare docs for the next minor version bump
Mar 22 2021, 09:01