Page MenuHomePhabricator
Feed Advanced Search

Oct 21 2022

sdulfari added a comment to D12325: [avalanche] Record peers that have avalanche enabled.

Failure appears unrelated to changes. Restarting builds...

Oct 21 2022, 17:56
sdulfari abandoned D12345: [avalanche] Fix a data race where updating availability scores can coincide with initialization of the state container.

Redid this patch per feedback. New one is here: D12355

Oct 21 2022, 17:55
sdulfari updated the summary of D12355: [avalanche] Fix a data race where updating availability scores can coincide with initialization of state.
Oct 21 2022, 17:54
sdulfari requested review of D12355: [avalanche] Fix a data race where updating availability scores can coincide with initialization of state.
Oct 21 2022, 17:53
sdulfari updated the diff for D12325: [avalanche] Record peers that have avalanche enabled.

Use compare_exchange_strong per feedback. This also fixes the race between AVAHELLO and addavalanchenode,
but the race between UpdateAvalancheStatistics and AVAHELLO/addavalanchenode still exists.

Oct 21 2022, 17:09

Oct 20 2022

sdulfari updated the summary of D12345: [avalanche] Fix a data race where updating availability scores can coincide with initialization of the state container.
Oct 20 2022, 20:04
sdulfari requested review of D12345: [avalanche] Fix a data race where updating availability scores can coincide with initialization of the state container.
Oct 20 2022, 20:04
sdulfari updated the diff for D12325: [avalanche] Record peers that have avalanche enabled.
  • Fix the score comparator to meet Comparator requirements when at least one of the CNodes has no m_avalanche_state
  • Set m_avalanche_enabled to true in addavalanchenode so AVAHELLO is appropriately ignored like past behavior
Oct 20 2022, 18:28
sdulfari planned changes to D12325: [avalanche] Record peers that have avalanche enabled.
Oct 20 2022, 18:10
sdulfari accepted D12340: Make CAddrman::Select_ select buckets, not positions, first.
Oct 20 2022, 17:02
sdulfari accepted D12343: net: don't bind on 0.0.0.0 if binds are restricted to Tor.
Oct 20 2022, 16:53
sdulfari updated the diff for D12325: [avalanche] Record peers that have avalanche enabled.

feedback

Oct 20 2022, 16:34
sdulfari closed D12324: [avalanche] Cleanup old usage of legacyavaproof in functional test framework.
Oct 20 2022, 16:24
sdulfari committed rABCfcccee0cf4f4: [avalanche] Cleanup old usage of legacyavaproof in functional test framework (authored by sdulfari).
[avalanche] Cleanup old usage of legacyavaproof in functional test framework
Oct 20 2022, 16:24
sdulfari requested review of D12325: [avalanche] Record peers that have avalanche enabled.
Oct 20 2022, 02:46

Oct 19 2022

sdulfari accepted D12313: test: add addpeeraddress "tried", test addrman checks on restart with asmap.
Oct 19 2022, 23:25
sdulfari accepted D12312: rpc, test: addpeeraddress test coverage, code simplify/constness.
Oct 19 2022, 23:18
sdulfari published D12324: [avalanche] Cleanup old usage of legacyavaproof in functional test framework for review.
Oct 19 2022, 22:52
sdulfari accepted D12309: test: Remove option to make TestChain100Setup non-deterministic.
Oct 19 2022, 15:48

Oct 18 2022

sdulfari accepted D12287: refactor: move update_* structs from txmempool.h to .cpp file.
Oct 18 2022, 17:08
sdulfari accepted D12294: [addrman] Make m_asmap private.
Oct 18 2022, 17:08
sdulfari accepted D12295: addrman: Fix format string in deserialize error.
Oct 18 2022, 16:59
sdulfari closed D12290: [avalanche] Separate pubkey from AvalancheState.
Oct 18 2022, 15:59
sdulfari committed rABC080be4129500: [avalanche] Separate pubkey from AvalancheState (authored by sdulfari).
[avalanche] Separate pubkey from AvalancheState
Oct 18 2022, 15:59
sdulfari closed D12289: simplify ValidDeployment check to avoid gcc warning.
Oct 18 2022, 15:55
sdulfari committed rABC214c0d52faa8: simplify ValidDeployment check to avoid gcc warning (authored by MarcoFalke <falke.marco@gmail.com>).
simplify ValidDeployment check to avoid gcc warning
Oct 18 2022, 15:55

Oct 17 2022

sdulfari requested review of D12290: [avalanche] Separate pubkey from AvalancheState.
Oct 17 2022, 21:40
sdulfari requested changes to D12287: refactor: move update_* structs from txmempool.h to .cpp file.
Oct 17 2022, 20:39
sdulfari requested review of D12289: simplify ValidDeployment check to avoid gcc warning.
Oct 17 2022, 20:36

Oct 14 2022

sdulfari accepted D12257: refactor: Make CAddrMan::cs non-recursive.
Oct 14 2022, 17:17

Oct 12 2022

sdulfari accepted D12229: validation: make CChainState::m_mempool optional.
Oct 12 2022, 20:39

Oct 10 2022

sdulfari closed D12167: Fix localhost typo in addresses directed at addnode rpc.
Oct 10 2022, 17:13
sdulfari committed rABCa71b37139b49: Fix localhost typo in addresses directed at addnode rpc (authored by sdulfari).
Fix localhost typo in addresses directed at addnode rpc
Oct 10 2022, 17:13
sdulfari accepted D12186: [linter] Fix css code style issues.
Oct 10 2022, 17:07
sdulfari accepted D12177: [avalanche] Avoid connecting via addavalanchenode in tests.
Oct 10 2022, 17:06

Oct 7 2022

sdulfari requested changes to D12177: [avalanche] Avoid connecting via addavalanchenode in tests.
Oct 7 2022, 23:53
sdulfari accepted D12176: [avalanche] Cleanup the proof voting test.
Oct 7 2022, 23:37

Oct 6 2022

sdulfari requested review of D12167: Fix localhost typo in addresses directed at addnode rpc.
Oct 6 2022, 17:37

Oct 5 2022

sdulfari closed D12157: Increase max ipv4 seeds per ASN.
Oct 5 2022, 16:58
sdulfari committed rABCc50d61b74744: Increase max ipv4 seeds per ASN (authored by sdulfari).
Increase max ipv4 seeds per ASN
Oct 5 2022, 16:58
sdulfari closed D12141: Improve clarity of makeseeds and increase max ipv6 ASNs.
Oct 5 2022, 16:50
sdulfari committed rABCb0a0bdf184ff: Improve clarity of makeseeds and increase max ipv6 ASNs (authored by Baas <matthew.baas@gmail.com>).
Improve clarity of makeseeds and increase max ipv6 ASNs
Oct 5 2022, 16:50
sdulfari updated the summary of D12157: Increase max ipv4 seeds per ASN.
Oct 5 2022, 16:50
sdulfari requested review of D12157: Increase max ipv4 seeds per ASN.
Oct 5 2022, 16:49
sdulfari updated the diff for D12141: Improve clarity of makeseeds and increase max ipv6 ASNs.

Rebase and bump MIN_BLOCKS to 760000

Oct 5 2022, 16:14
sdulfari closed D12143: Remove suspicious hosts list from makeseeds.
Oct 5 2022, 16:10
sdulfari committed rABC555fc65e8973: Remove suspicious hosts list from makeseeds (authored by laanwj <126646+laanwj@users.noreply.github.com>).
Remove suspicious hosts list from makeseeds
Oct 5 2022, 16:10
sdulfari closed D12142: Add .gitignore for dns seeds.
Oct 5 2022, 16:09
sdulfari committed rABC4eedb4cd02dd: Add .gitignore for dns seeds (authored by sdulfari).
Add .gitignore for dns seeds
Oct 5 2022, 16:09

Oct 4 2022

sdulfari requested review of D12143: Remove suspicious hosts list from makeseeds.
Oct 4 2022, 22:42
sdulfari requested review of D12142: Add .gitignore for dns seeds.
Oct 4 2022, 22:22
sdulfari updated the summary of D12141: Improve clarity of makeseeds and increase max ipv6 ASNs.
Oct 4 2022, 22:06
sdulfari updated the summary of D12141: Improve clarity of makeseeds and increase max ipv6 ASNs.
Oct 4 2022, 22:06
sdulfari requested review of D12141: Improve clarity of makeseeds and increase max ipv6 ASNs.
Oct 4 2022, 22:05
sdulfari closed D12138: Refactor & improve makeseeds.
Oct 4 2022, 18:26
sdulfari committed rABC93df28c6574f: Refactor & improve makeseeds (authored by Wladimir J. van der Laan <laanwj@protonmail.com>).
Refactor & improve makeseeds
Oct 4 2022, 18:26
sdulfari added inline comments to D12138: Refactor & improve makeseeds.
Oct 4 2022, 18:25
sdulfari added inline comments to D12138: Refactor & improve makeseeds.
Oct 4 2022, 18:24
sdulfari updated the diff for D12138: Refactor & improve makeseeds.

Fix typo

Oct 4 2022, 18:24
sdulfari requested review of D12138: Refactor & improve makeseeds.
Oct 4 2022, 17:48
sdulfari accepted D12132: [website] Update the link in the release page to the avalanche blog post.
Oct 4 2022, 15:35

Oct 3 2022

sdulfari accepted D12119: test: Remove spurious double lock tsan suppressions by bumping to clang-12.
Oct 3 2022, 16:20
sdulfari accepted D12118: Close minor startup race between main and scheduler threads.
Oct 3 2022, 16:19

Sep 30 2022

sdulfari accepted D12104: Prepare for using debian 11 for the regular builds.
Sep 30 2022, 18:39
sdulfari requested changes to D12104: Prepare for using debian 11 for the regular builds.
Sep 30 2022, 16:53
sdulfari accepted D12103: Migrate gitian builds to Debian Bullseye.

Looks like a networking issue when building gitian-win. I trust it builds correctly.

Sep 30 2022, 16:46

Sep 28 2022

sdulfari closed D12087: [avalanche] Add immature_stake_amount to getavalancheinfo.
Sep 28 2022, 19:07
sdulfari committed rABC30885098376a: [avalanche] Add immature_stake_amount to getavalancheinfo (authored by sdulfari).
[avalanche] Add immature_stake_amount to getavalancheinfo
Sep 28 2022, 19:07
sdulfari closed D12086: [avalanche] Make ProofPool's for each proof logic public.
Sep 28 2022, 19:07
sdulfari committed rABC5f75c2e74f53: [avalanche] Make ProofPool's for each proof logic public (authored by sdulfari).
[avalanche] Make ProofPool's for each proof logic public
Sep 28 2022, 19:07
sdulfari requested review of D12087: [avalanche] Add immature_stake_amount to getavalancheinfo.
Sep 28 2022, 18:38
sdulfari requested review of D12086: [avalanche] Make ProofPool's for each proof logic public.
Sep 28 2022, 18:01
sdulfari closed D12064: [avalanche] Cleanup redundant proof count getters in PeerManager API.
Sep 28 2022, 15:45
sdulfari committed rABCdf44771070c0: [avalanche] Cleanup redundant proof count getters in PeerManager API (authored by sdulfari).
[avalanche] Cleanup redundant proof count getters in PeerManager API
Sep 28 2022, 15:45
sdulfari closed D12077: [avalanche] Cleanup redundant argument in getavalancheinfo test.
Sep 28 2022, 15:38
sdulfari committed rABCe7a9f5e7ca31: [avalanche] Cleanup redundant argument in getavalancheinfo test (authored by sdulfari).
[avalanche] Cleanup redundant argument in getavalancheinfo test
Sep 28 2022, 15:38
sdulfari closed D12062: [avalanche] Add getavalancheproofs RPC to retrieve tracked proof ids.
Sep 28 2022, 15:38
sdulfari committed rABC069441490afd: [avalanche] Add getavalancheproofs RPC to retrieve tracked proof ids (authored by sdulfari).
[avalanche] Add getavalancheproofs RPC to retrieve tracked proof ids
Sep 28 2022, 15:38

Sep 27 2022

sdulfari requested review of D12077: [avalanche] Cleanup redundant argument in getavalancheinfo test.
Sep 27 2022, 17:43
sdulfari updated the diff for D12062: [avalanche] Add getavalancheproofs RPC to retrieve tracked proof ids.

Address feedback and make new ProofPool getters const

Sep 27 2022, 17:40
sdulfari accepted D12049: log, sync: add LOCK logging category, apply it to lock contention.
Sep 27 2022, 17:38
sdulfari added a comment to D12062: [avalanche] Add getavalancheproofs RPC to retrieve tracked proof ids.

Will work on the remaining feedback.

Sep 27 2022, 17:11

Sep 26 2022

sdulfari accepted D12058: rpc: Return total fee in mempool.

Please add a release note. Can be in this diff or separate.

Sep 26 2022, 18:50
sdulfari updated the diff for D12062: [avalanche] Add getavalancheproofs RPC to retrieve tracked proof ids.

Fix a race condition in the test

Sep 26 2022, 18:35
sdulfari requested review of D12064: [avalanche] Cleanup redundant proof count getters in PeerManager API.
Sep 26 2022, 18:32
sdulfari abandoned D12013: [avalanche] Add a way to retrieve proof ids from each pool.
Sep 26 2022, 18:22
sdulfari requested review of D12062: [avalanche] Add getavalancheproofs RPC to retrieve tracked proof ids.
Sep 26 2022, 18:18
sdulfari added a comment to D12049: log, sync: add LOCK logging category, apply it to lock contention.

Thanks for fixing the last backport link. I've reviewed the remainder and they look ok.

Sep 26 2022, 17:03
sdulfari closed D12050: [avalanche] Improve const correctness of ProofPool::countProofs().
Sep 26 2022, 17:00
sdulfari committed rABC8d208e1ea83e: [avalanche] Improve const correctness of ProofPool::countProofs() (authored by sdulfari).
[avalanche] Improve const correctness of ProofPool::countProofs()
Sep 26 2022, 17:00

Sep 23 2022

sdulfari requested changes to D12049: log, sync: add LOCK logging category, apply it to lock contention.

Which change was from https://github.com/bitcoin/bitcoin/pull/24470 ? I could not find it.

Sep 23 2022, 21:35
sdulfari requested review of D12050: [avalanche] Improve const correctness of ProofPool::countProofs().
Sep 23 2022, 18:14
sdulfari accepted D12031: Replace Gluon activation time with the actual block height.
Sep 23 2022, 17:20
sdulfari accepted D12037: Run with wellington activated in the tests.
Sep 23 2022, 17:20
sdulfari requested changes to D12031: Replace Gluon activation time with the actual block height.
Sep 23 2022, 15:49

Sep 22 2022

sdulfari closed D12014: [avalanche] Create a type alias for proof id sets.
Sep 22 2022, 17:18
sdulfari committed rABC2c4dd9196603: [avalanche] Create a type alias for proof id sets (authored by sdulfari).
[avalanche] Create a type alias for proof id sets
Sep 22 2022, 17:18
sdulfari accepted D12034: move-only: Move constants and functions to blockstorage.
Sep 22 2022, 17:17
sdulfari accepted D12033: refactor: Move block storage globals to blockstorage.
Sep 22 2022, 17:07
sdulfari accepted D12032: refactor: Move pruning/reindex/importing globals to blockstorage.
Sep 22 2022, 17:03