Responding to review feedback. I decided to make the switch a separate component. The switch in the top right of the banner looked off, so I am trying it on the same line as the wallet name and wallet rename button. The balance header has now been added to the receive.js page.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Oct 28 2022
Oct 27 2022
Responding to review feedback.
Oct 26 2022
Responding to review feedback, bannedFiatCurrencies array has been removed, isProbablyNotScamTokenname & isProbablyNotScamTokenTicker functions now reference the settingsValidation.fiatCurrency array.
Responding to review feedback + rebase.
Oct 25 2022
Fixed overly complicated conditional rendering per review feedback.
Responding to review feedback, added top 500 coins by name, ticker and ID from coin gecko. Regarding the error messaging, it is already set up to tell the user whether the ticker or the name is banned. The newTokenTicker and newTokenName can be added to the error message for more specificity, but the message becomes fairly verbose then.
Oct 24 2022
Oct 21 2022
Responding to review feedback
Responding to review feedback.
Responding to review feedback, created 2 new functions to handle checking against token ticker and token name blacklists. Since the functions are essentially identical, this could probably be handled by a single function. Let me know what you think. Logic around error notification under the inputs has changed to allow for more specific messaging (ie validation error vs blacklist error). Check has been added for newTokenNameIsProbablyNotAScam & newTokenTickerIsProbablyNotAScam before the Create eToken button unlocks.
Oct 18 2022
Removed test comment
Responding to review feedback, rebased & added test comment.
Oct 10 2022
fixed typo in comment
Responding to review feedback
Oct 7 2022
Removed test comment
Rebased and added test comment
Oct 6 2022
Responded to review feedback, added try/catch and new TypeError to catch if invalid params were provided to the function.
Responding to review feedback
Changed logic so that if hideMessagesFromUnkownSenders is on, the reply button will only appear on messages from non-contacts that have been expanded, and messages from contacts will display the reply button.
Oct 4 2022
Oct 3 2022
Sep 30 2022
To address clipping in web app and extension, navmenu width has been reduced, 1px margin right has been added for web view & extension. Media query removes margin right on mobile view.
Sep 29 2022
Sep 28 2022
Sep 27 2022
Responding to review feedback- made relevant changes, commented out broken tests per discussion with Joey to help with next steps.
responding to review feedback
Responding to review feedback. Found a solution to the new error on SO: https://stackoverflow.com/questions/60414352/next-js-ant-design-dragger-file-upload-fails-on-deployed-instance. Further info about the custom request can be found here: https://github.com/react-component/upload#customrequest. According to the user who posted the solution, "by default, the ANTD upload component makes a POST request to upload the file. So, to avoid this, add a customRequest props on Upload as below."
Sep 26 2022
Responding to review feedback.
Sep 23 2022
Cleaned up timing issue on close. When transitioning max-height, even though the element does not grow to that height, the transition still happens from that height. For this reason, the closing transitions have been shortened considerably and cubic-bezier is used to smooth the transition effect on close.
Per review feedback: widened NavMenu, added border to NavMenu & removed borders from NavItems. Also, added additional transition effects to handle the new border.
Sep 22 2022
Responding to review feedback, removed GA event from ScanQrCode, removed imports for currency obj & GA. Removed tokenprefixes key/value pair from currency obj.
responding to review feedback
Sep 21 2022
Responding to review feedback: removed previous version of components library, initialized a neutrinojs react components project.
Rebased to master, removed unused currency.prefixes key/value from currency obj, changed currency.tokenPrefixes to a string.