Page MenuHomePhabricator
Feed Advanced Search

Oct 28 2022

kieran709 updated the diff for D12374: [Cashtab] Added toggle hide balance switch.

Responding to review feedback. I decided to make the switch a separate component. The switch in the top right of the banner looked off, so I am trying it on the same line as the wallet name and wallet rename button. The balance header has now been added to the receive.js page.

Oct 28 2022, 16:48

Oct 27 2022

kieran709 added inline comments to D12374: [Cashtab] Added toggle hide balance switch.
Oct 27 2022, 18:00
kieran709 closed D12194: [Cashtab] Add blacklist for token name and token ticker fields.
Oct 27 2022, 16:56
kieran709 committed rABC1eea7a1143e3: [Cashtab] Add blacklist for token name and token ticker fields (authored by kieran709).
[Cashtab] Add blacklist for token name and token ticker fields
Oct 27 2022, 16:56
kieran709 updated the summary of D12383: [Cashtab] Lessen spacing between from and contactName in Tx.js.
Oct 27 2022, 16:13
kieran709 requested review of D12383: [Cashtab] Lessen spacing between from and contactName in Tx.js.
Oct 27 2022, 16:06
kieran709 updated the diff for D12194: [Cashtab] Add blacklist for token name and token ticker fields.

Responding to review feedback.

Oct 27 2022, 15:48

Oct 26 2022

kieran709 updated the diff for D12194: [Cashtab] Add blacklist for token name and token ticker fields.

Responding to review feedback, bannedFiatCurrencies array has been removed, isProbablyNotScamTokenname & isProbablyNotScamTokenTicker functions now reference the settingsValidation.fiatCurrency array.

Oct 26 2022, 20:46
kieran709 updated the summary of D12374: [Cashtab] Added toggle hide balance switch.
Oct 26 2022, 20:06
kieran709 requested review of D12374: [Cashtab] Added toggle hide balance switch.
Oct 26 2022, 20:06
kieran709 closed D12196: [Cashtab][Pt 2/2] Parse Airdrops in TxHistory - using cashtabCache to get airdrop token name.
Oct 26 2022, 16:24
kieran709 committed rABC9327aeab5132: [Cashtab][Pt 2/2] Parse Airdrops in TxHistory - using cashtabCache to get… (authored by kieran709).
[Cashtab][Pt 2/2] Parse Airdrops in TxHistory - using cashtabCache to get…
Oct 26 2022, 16:24
kieran709 closed D12195: [Cashtab][Pt1/2] Parse Airdrops in TxHistory.
Oct 26 2022, 16:24
kieran709 committed rABC63e90422e90b: [Cashtab][Pt1/2] Parse Airdrops in TxHistory (authored by kieran709).
[Cashtab][Pt1/2] Parse Airdrops in TxHistory
Oct 26 2022, 16:24
kieran709 updated the diff for D12194: [Cashtab] Add blacklist for token name and token ticker fields.

Responding to review feedback + rebase.

Oct 26 2022, 15:01

Oct 25 2022

kieran709 closed D12369: [Cashtab] Rename WalletInfo Component in Receive.js.
Oct 25 2022, 20:00
kieran709 committed rABC23af147f7dfe: [Cashtab] Rename WalletInfo Component in Receive.js (authored by kieran709).
[Cashtab] Rename WalletInfo Component in Receive.js
Oct 25 2022, 20:00
kieran709 requested review of D12369: [Cashtab] Rename WalletInfo Component in Receive.js.
Oct 25 2022, 17:42
kieran709 updated the diff for D12196: [Cashtab][Pt 2/2] Parse Airdrops in TxHistory - using cashtabCache to get airdrop token name.

Fixed overly complicated conditional rendering per review feedback.

Oct 25 2022, 17:08
kieran709 closed D12364: [Cashtab] Fix formatting issue for Cashtab msgs containing long strings.
Oct 25 2022, 16:49
kieran709 committed rABCc2a65a075c0d: [Cashtab] Fix formatting issue for Cashtab msgs containing long strings (authored by kieran709).
[Cashtab] Fix formatting issue for Cashtab msgs containing long strings
Oct 25 2022, 16:49
kieran709 updated the diff for D12194: [Cashtab] Add blacklist for token name and token ticker fields.

Responding to review feedback, added top 500 coins by name, ticker and ID from coin gecko. Regarding the error messaging, it is already set up to tell the user whether the ticker or the name is banned. The newTokenTicker and newTokenName can be added to the error message for more specificity, but the message becomes fairly verbose then.

Oct 25 2022, 16:32
kieran709 accepted D12323: [Cashtab] [extension address passing p9] Display the received address in the GetAddress.tsx component.
Oct 25 2022, 15:27

Oct 24 2022

kieran709 closed D12354: [Cashtab Extension] fixed roaming nav menu when extension popped out.
Oct 24 2022, 18:46
kieran709 committed rABCce74285270d4: [Cashtab Extension] fixed roaming nav menu when extension popped out (authored by kieran709).
[Cashtab Extension] fixed roaming nav menu when extension popped out
Oct 24 2022, 18:46
kieran709 requested review of D12364: [Cashtab] Fix formatting issue for Cashtab msgs containing long strings.
Oct 24 2022, 16:24

Oct 21 2022

kieran709 updated the diff for D12196: [Cashtab][Pt 2/2] Parse Airdrops in TxHistory - using cashtabCache to get airdrop token name.

Responding to review feedback

Oct 21 2022, 18:34
kieran709 requested review of D12354: [Cashtab Extension] fixed roaming nav menu when extension popped out.
Oct 21 2022, 17:14
kieran709 updated the diff for D12195: [Cashtab][Pt1/2] Parse Airdrops in TxHistory.

Responding to review feedback.

Oct 21 2022, 15:59
kieran709 closed D12188: [Cashtab] Remove unused imports useBCH.test.js.
Oct 21 2022, 15:25
kieran709 committed rABC5fa5f1098e02: [Cashtab] Remove unused imports useBCH.test.js (authored by kieran709).
[Cashtab] Remove unused imports useBCH.test.js
Oct 21 2022, 15:25
kieran709 updated the diff for D12194: [Cashtab] Add blacklist for token name and token ticker fields.

Responding to review feedback, created 2 new functions to handle checking against token ticker and token name blacklists. Since the functions are essentially identical, this could probably be handled by a single function. Let me know what you think. Logic around error notification under the inputs has changed to allow for more specific messaging (ie validation error vs blacklist error). Check has been added for newTokenNameIsProbablyNotAScam & newTokenTickerIsProbablyNotAScam before the Create eToken button unlocks.

Oct 21 2022, 14:58

Oct 18 2022

kieran709 updated the summary of D12196: [Cashtab][Pt 2/2] Parse Airdrops in TxHistory - using cashtabCache to get airdrop token name.
Oct 18 2022, 14:39
kieran709 updated the diff for D12188: [Cashtab] Remove unused imports useBCH.test.js.

Removed test comment

Oct 18 2022, 14:23
kieran709 updated the diff for D12188: [Cashtab] Remove unused imports useBCH.test.js.

Responding to review feedback, rebased & added test comment.

Oct 18 2022, 14:23
kieran709 abandoned D12187: [Cashtab] Create adjustTokenQtyForDecimals function.
Oct 18 2022, 14:18
kieran709 closed D12179: [Cashtab] Tx History should immediately update to include newly added contacts.
Oct 18 2022, 14:17
kieran709 committed rABC47626f928b9e: [Cashtab] Tx History should immediately update to include newly added contacts (authored by kieran709).
[Cashtab] Tx History should immediately update to include newly added contacts
Oct 18 2022, 14:17

Oct 10 2022

kieran709 requested review of D12196: [Cashtab][Pt 2/2] Parse Airdrops in TxHistory - using cashtabCache to get airdrop token name.
Oct 10 2022, 20:26
kieran709 requested review of D12195: [Cashtab][Pt1/2] Parse Airdrops in TxHistory.
Oct 10 2022, 18:40
kieran709 updated the diff for D12194: [Cashtab] Add blacklist for token name and token ticker fields.

fixed typo in comment

Oct 10 2022, 16:34
kieran709 updated the summary of D12194: [Cashtab] Add blacklist for token name and token ticker fields.
Oct 10 2022, 16:33
kieran709 requested review of D12194: [Cashtab] Add blacklist for token name and token ticker fields.
Oct 10 2022, 16:32
kieran709 requested review of D12188: [Cashtab] Remove unused imports useBCH.test.js.
Oct 10 2022, 13:40
kieran709 requested review of D12187: [Cashtab] Create adjustTokenQtyForDecimals function.
Oct 10 2022, 13:28
kieran709 abandoned D12136: [Cashtab] create adjustTokenQtyForDecimals function.
Oct 10 2022, 13:20
kieran709 updated the summary of D12179: [Cashtab] Tx History should immediately update to include newly added contacts.
Oct 10 2022, 13:19
kieran709 updated the diff for D12179: [Cashtab] Tx History should immediately update to include newly added contacts.

Responding to review feedback

Oct 10 2022, 13:18

Oct 7 2022

kieran709 updated the diff for D12136: [Cashtab] create adjustTokenQtyForDecimals function.

Removed test comment

Oct 7 2022, 20:23
kieran709 updated the diff for D12136: [Cashtab] create adjustTokenQtyForDecimals function.

Rebased and added test comment

Oct 7 2022, 20:22
kieran709 requested review of D12179: [Cashtab] Tx History should immediately update to include newly added contacts.
Oct 7 2022, 20:19

Oct 6 2022

kieran709 updated the diff for D12136: [Cashtab] create adjustTokenQtyForDecimals function.

Responded to review feedback, added try/catch and new TypeError to catch if invalid params were provided to the function.

Oct 6 2022, 20:14
kieran709 closed D12166: [Cashtab] Fix reply button not showing.
Oct 6 2022, 16:41
kieran709 committed rABCdc95242fb70b: [Cashtab] Fix reply button not showing (authored by kieran709).
[Cashtab] Fix reply button not showing
Oct 6 2022, 16:41
kieran709 updated the diff for D12166: [Cashtab] Fix reply button not showing.

Responding to review feedback

Oct 6 2022, 16:17
kieran709 requested review of D12166: [Cashtab] Fix reply button not showing.
Oct 6 2022, 15:38
kieran709 abandoned D12165: [Cashtab] Fix Reply button not showing.
Oct 6 2022, 15:16
kieran709 updated the diff for D12165: [Cashtab] Fix Reply button not showing.

Changed logic so that if hideMessagesFromUnkownSenders is on, the reply button will only appear on messages from non-contacts that have been expanded, and messages from contacts will display the reply button.

Oct 6 2022, 14:37
kieran709 requested review of D12165: [Cashtab] Fix Reply button not showing.
Oct 6 2022, 14:33

Oct 4 2022

kieran709 requested review of D12136: [Cashtab] create adjustTokenQtyForDecimals function.
Oct 4 2022, 13:58

Oct 3 2022

kieran709 closed D12100: [Cashtab] Patched nav menu being cut off on some mobile views.
Oct 3 2022, 14:57
kieran709 committed rABC3a90c9864d57: [Cashtab] Patched nav menu being cut off on some mobile views (authored by kieran709).
[Cashtab] Patched nav menu being cut off on some mobile views
Oct 3 2022, 14:57

Sep 30 2022

kieran709 updated the diff for D12100: [Cashtab] Patched nav menu being cut off on some mobile views.

To address clipping in web app and extension, navmenu width has been reduced, 1px margin right has been added for web view & extension. Media query removes margin right on mobile view.

Sep 30 2022, 15:27
kieran709 requested review of D12100: [Cashtab] Patched nav menu being cut off on some mobile views.
Sep 30 2022, 02:29

Sep 29 2022

kieran709 planned changes to D11941: [xec-web-components] Create XEC components library with an address converter.
Sep 29 2022, 14:38

Sep 28 2022

kieran709 closed D12079: [Cashtab] Patch font color for One To Many Airdrop Payment Outputs input.
Sep 28 2022, 18:47
kieran709 committed rABCf78e8db284cb: [Cashtab] Patch font color for One To Many Airdrop Payment Outputs input (authored by kieran709).
[Cashtab] Patch font color for One To Many Airdrop Payment Outputs input
Sep 28 2022, 18:46
kieran709 closed D12080: [Cashtab] Match hover effect for all icons on settings page.
Sep 28 2022, 15:10
kieran709 committed rABCc19935877176: [Cashtab] Match hover effect for all icons on settings page (authored by kieran709).
[Cashtab] Match hover effect for all icons on settings page
Sep 28 2022, 15:10
kieran709 closed D11997: [Cashtab] Add hamburger menu to taskbar.
Sep 28 2022, 14:00
kieran709 committed rABCeb90042170f6: [Cashtab] Add hamburger menu to taskbar (authored by kieran709).
[Cashtab] Add hamburger menu to taskbar
Sep 28 2022, 14:00

Sep 27 2022

kieran709 requested review of D12080: [Cashtab] Match hover effect for all icons on settings page.
Sep 27 2022, 20:49
kieran709 requested review of D12079: [Cashtab] Patch font color for One To Many Airdrop Payment Outputs input.
Sep 27 2022, 20:34
kieran709 planned changes to D11062: [Cashtab] fix fee calculation.
Sep 27 2022, 18:48
kieran709 updated the diff for D11062: [Cashtab] fix fee calculation.

Responding to review feedback- made relevant changes, commented out broken tests per discussion with Joey to help with next steps.

Sep 27 2022, 18:48
kieran709 closed D12065: [Cashtab] fix antd error in console when user clicks Create eToken.
Sep 27 2022, 17:55
kieran709 committed rABCbc8729c3ab4a: [Cashtab] fix antd error in console when user clicks Create eToken (authored by kieran709).
[Cashtab] fix antd error in console when user clicks Create eToken
Sep 27 2022, 17:55
kieran709 updated the diff for D11997: [Cashtab] Add hamburger menu to taskbar.

responding to review feedback

Sep 27 2022, 17:52
kieran709 closed D12060: [Cashtab] fix antd syntax issue.
Sep 27 2022, 16:19
kieran709 committed rABC79a6ad1bf2da: [Cashtab] fix antd syntax issue (authored by kieran709).
[Cashtab] fix antd syntax issue
Sep 27 2022, 16:19
kieran709 updated the diff for D12065: [Cashtab] fix antd error in console when user clicks Create eToken.

Responding to review feedback. Found a solution to the new error on SO: https://stackoverflow.com/questions/60414352/next-js-ant-design-dragger-file-upload-fails-on-deployed-instance. Further info about the custom request can be found here: https://github.com/react-component/upload#customrequest. According to the user who posted the solution, "by default, the ANTD upload component makes a POST request to upload the file. So, to avoid this, add a customRequest props on Upload as below."

Sep 27 2022, 15:54
kieran709 closed D12061: [Cashtab] Comments in loadContactList should refer to contactList, not settings.
Sep 27 2022, 14:05
kieran709 committed rABC0fd427ad9498: [Cashtab] Comments in loadContactList should refer to contactList, not settings (authored by kieran709).
[Cashtab] Comments in loadContactList should refer to contactList, not settings
Sep 27 2022, 14:05

Sep 26 2022

kieran709 closed D11741: [Cashtab] currency.prefixes & currency.tokenPrefixes converted to strings.
Sep 26 2022, 18:41
kieran709 committed rABC1b9a4de8a9b5: [Cashtab] currency.prefixes & currency.tokenPrefixes converted to strings (authored by kieran709).
[Cashtab] currency.prefixes & currency.tokenPrefixes converted to strings
Sep 26 2022, 18:41
kieran709 requested review of D12065: [Cashtab] fix antd error in console when user clicks Create eToken.
Sep 26 2022, 18:40
kieran709 abandoned D12063: [Cashtab] fix error in console when user clicks Create eToken.
Sep 26 2022, 18:35
kieran709 requested review of D12063: [Cashtab] fix error in console when user clicks Create eToken.
Sep 26 2022, 18:22
kieran709 requested review of D12061: [Cashtab] Comments in loadContactList should refer to contactList, not settings.
Sep 26 2022, 17:59
kieran709 requested review of D12060: [Cashtab] fix antd syntax issue.
Sep 26 2022, 17:51
kieran709 updated the diff for D11997: [Cashtab] Add hamburger menu to taskbar.

Responding to review feedback.

Sep 26 2022, 14:46

Sep 23 2022

kieran709 abandoned D12012: [Cashtab] Patch token info amounts improperly rounding.
Sep 23 2022, 20:04
kieran709 updated the diff for D11997: [Cashtab] Add hamburger menu to taskbar.

Cleaned up timing issue on close. When transitioning max-height, even though the element does not grow to that height, the transition still happens from that height. For this reason, the closing transitions have been shortened considerably and cubic-bezier is used to smooth the transition effect on close.

Sep 23 2022, 20:04
kieran709 planned changes to D11997: [Cashtab] Add hamburger menu to taskbar.
Sep 23 2022, 17:55
kieran709 updated the diff for D11997: [Cashtab] Add hamburger menu to taskbar.

Per review feedback: widened NavMenu, added border to NavMenu & removed borders from NavItems. Also, added additional transition effects to handle the new border.

Sep 23 2022, 17:41

Sep 22 2022

kieran709 updated the diff for D11741: [Cashtab] currency.prefixes & currency.tokenPrefixes converted to strings.

Responding to review feedback, removed GA event from ScanQrCode, removed imports for currency obj & GA. Removed tokenprefixes key/value pair from currency obj.

Sep 22 2022, 19:36
kieran709 updated the diff for D11997: [Cashtab] Add hamburger menu to taskbar.

responding to review feedback

Sep 22 2022, 16:30

Sep 21 2022

kieran709 updated the diff for D11941: [xec-web-components] Create XEC components library with an address converter.

Responding to review feedback: removed previous version of components library, initialized a neutrinojs react components project.

Sep 21 2022, 14:29
kieran709 updated the diff for D11741: [Cashtab] currency.prefixes & currency.tokenPrefixes converted to strings.

Rebased to master, removed unused currency.prefixes key/value from currency obj, changed currency.tokenPrefixes to a string.

Sep 21 2022, 13:35
kieran709 abandoned D11689: [Cashtab] Parse airdrops in TxHistory.
Sep 21 2022, 13:22