Updated README, comments and removed redundant typecast.

Added two standard one to one send XEC tests, one with change and one without.

Superseded by D14607

Responding to feedback

Responding to feedback

Responding to feedback

Remove newline

Removed the xecAmount override as it was only needed for the original mock data that was not aligned with the latest alias spec, hence previously returning change. This is no longer the case with the latest mocks. This also removes the previous comment around updating the spec.

Following further testing, moving the alias server error logic to the first useEffect that uses balances.totalBalance as a dependency is the right approach. Have verified this useEffect block is triggered upon app load, Alias.js component load and post-registration broadcast. Additional verification can be done by malforming the alias-server endpoint used in useWallet's refreshAliases and in Alias.js' preparePreviewModal.

Upon further testing, both useEffects are being triggered upon Alias.js load. Going to have a think about the most efficient approach to this.

Responding to feedback

For discussion in tg

In D14578#327436, @Fabien wrote:

Chronik does not yet support its full feature set

What features are missing ?

Responding to feedback

Updated comments

Updated the post-registration syntax that appends the new alias to the pending array. This can be validated by adding a console log to the top of useWallet's useEffect() function so it displays the aliases state variable value upon startup but not yet triggering the API refresh calls.

Awaiting alias-server to come back up before final integration tests on this diff

Responding to feedback

Accepted with minor nit

Minor commenting nit

• Added warning about not tracking pending aliases for other wallets as part of the registration confirmation modal if the user is specifying a separate address for the alias
• Cleared inputs upon registration broadcast
• Fixed a silent bug where refreshAliases() was being constantly triggered in a loop - have moved it into its own useEffect() now with just hasPendingAliases as a dependency
• Responding to other feedback as below:

• New refreshAliases() function added to useWallet that calls the /address endpoint to retrieve both registered and pending aliases for the active wallet
• Latest aliases are stored in useWallet's state variable latestAliases, which are then used by Alias.js to populate the registered and pending alias dropdowns
• Interval created in useWallet that calls refreshAliases() to refresh registered and pending aliases
• useEffect() dependencies adjusted in Alias.js so that a refresh is triggered upon alias registration (balance change) and new aliases detected
• No longer using localStorage to keep track of pending aliases
• Per earlier feedback, no longer using websocket listener on 'BlockConnected' events as that may not be a one to one correlation to a successful registration

How did you build your tests, and especially how did you compute the expected txFee?

Responding to feedback

I've been looking at this from a customer (wallet dev) POV. To show the latest alias list attached to the wallet I would have to call /address to get the list of confirmed aliases and then quickly followed by /pending to get the pending list.

👍

Updated error message

Added ecashaddrjs as a dependency

• Added p2pkh script type validation on outputArray
• Reversed the change output logic

Not sure if this is the diff for it but here are some dev resource suggestions:

1. 17.7 XEC total is being rounded down to 17, should be displayed as is up to the 2 decimal points.
2. Minor nit, can use a newline before displaying the addresses.

Responding to feedback

think the API first before you start coding this

@tobias_ruck

Updated unit test descriptions

Removed duplicate unit test grouping

• Corrected setting of `this._workingIndex
• Moved this modulo index derivation logic into a separate deriveEndpointIndex function to enable unit tests, including a new setWorkingIndex function to override the index for unit tests.
• Added unit tests for a four element array, validating index derivation order for cases with a default and custom working index.

Responding to feedback

Responding to feedback

Rebased to D14423 and used the mock chronik from there to add new unit tests which mock the script().utxos() API calls from within getInputUtxos.