Dimensions now look all ok across mobile and extension, however it has scanning issues as per video below specific to the version on https://cashtab-local-dev.netlify.app.

rebase + version bump

Following tg discussions, will be replacing each component notification callsites with pure calls to the antd component, as there is little value in retaining a dedicated Notifications.js component. This will be done in a series of diffs, one for each component.

version bump

In D15281#343784, @bytesofman wrote:

please update the test plan to confirm the websocket is not re-initializing every 60s. If this is happening, need a diff to fix.

It's not autosizing on extension, resulting in extra swipes from the user to move the QR code into view. There's also not a great deal of room either with the header now fixed so the QR code should auto size on extension to render everything in the component.

Icons and hover looks good - just needs vertical alignment between X and the fb/gh icons.

Rebased to D15296 and version bump

Version bump

version bump

Version bump and head/footer bg css merge

• icon param is now required, and the callsite can supply a 'default' value if they want to use the default antd icons, otherwise can provide one from CustomIcons.js.
• data-testid now removed as a param and hardcoded as 'cashtab-notification'
• updated conditional rendering of hyperlink in the notification description via the new <NotificationLink> styled component. Can use false to indicate a non-hyperlinked notification.

The callsite is per below for a hyperlinked :

displayNotification(
	'success',
	title,
	msg,
	<NotificationLink link={'http://test.com'}/>,
	'default',
);

which generates the following

Removed interval setting in activateWallet per feedback

Removed redundant css props

Refactored displayNotification for efficiency and flexibility, including unit tests reflecting the existing 12 notifications.

Removed unused declarations

Accepted with minor nit

For consistency, remove the settings label (via app.js) since none of the other components use it. It will also ensure it's always positioned the same vertically.

Would it be handy for you to share the wallet (via tg) that contained this non-render so I can test against master vs this patch?

I'm getting a cherry picking error - can you try rebasing?

Refresh page in PWA, see udpate modal. On update, the form label has changed.

run npm ci if you are patching it

yup that was the issue

npm test failing with:

Tested all ok - amount input customizable via pow and disabled via ecash land

The simple hyperlink text seems a bit out of place with the rest of the UI. I believe the web app convention is to hyperlink an image for social links.

On a semi related note, not entering any address input, with a valid send amount, clicking send spits out this error msg that sounds like it's passed directly from a library, which could use a bit of a non-technical tailoring via a separate diff.

Isn't it better to just render this on the default tx history element state? Are there any advantages to making the user click into it to see the time? There's plenty of space for it.

Now that D15084 is landed, removing the now-redundant prefix conversions

Rebased to legacy address mitigation in D15084, token component rejig in D15122 and myriad of other diffs landed this week

Rebase to master

Tested fine, but probably should have an alias specific validation in a separate diff to note aliases are not supported for signature verification

Updated check condition for 'ecash:..' prefix

Accepted with minor nit - from a BAU perspective, it would be useful to log "Connected to blah.chronik.cash" in the console logs. Just in case there are performance issues or anything unexpected with the instance even though it is responsive.

Updated checks to isLegacyMigrationRequired

Ok for now but need to keep a note somewhere to revert this when/if we implement memo cash for XEC, at which point users should be able to mention BCH and have it show up on the herald.

When you malform all 3 chronik urls, it gives you a rather ungraceful uncaught exception per below, traced back to the update() function in useWallet.js

In D15108#339171, @bytesofman wrote:

Have there been complaints about this?

Tested all ok. Gonna be a hellish rebase for D15079 though.

Moved address conversion logic to migrateLegacyWallet per feedback

Updated isLegacyMigrationRequired to check 1899, 145 and 245 derivation path cashAddresses for non-eCash prefixes, along with unit test coverage.
I didn't do this for migrateLegacyWallet as per feedback because each path in that method already uses deriveAccount() which explictly encodes all addresses to the ecash prefix as below, so didn't see a need to double handle this once isLegacyMigrationRequired flags it for conversion:

const deriveAccount = async ({ masterHDNode, path }) => {
...
	const cashAddress = cashaddr.encode('ecash', 'P2PKH', node.identifier);

Pending D15084