Page MenuHomePhabricator
Feed All Stories

Aug 22 2024

tobias_ruck updated the summary of D16544: [ecash-agora] Add `agora.py` plugin to index ONESHOT offers.
Aug 22 2024, 12:30
teamcity added a comment to D16674: [Chronik] Rename `group` in `PluginOutput` to `groups`.
Aug 22 2024, 12:29
tobias_ruck closed D16673: [ecash-lib] Fix fee estimation for signatories that depend on tx outputs.
Aug 22 2024, 12:27
tobias_ruck committed rABC4c13a54223ae: [ecash-lib] Fix fee estimation for signatories that depend on tx outputs (authored by tobias_ruck).
[ecash-lib] Fix fee estimation for signatories that depend on tx outputs
Aug 22 2024, 12:27
tobias_ruck updated the diff for D16544: [ecash-agora] Add `agora.py` plugin to index ONESHOT offers.

minor fixes/cleanup, rebase on D16674

Aug 22 2024, 12:25
tobias_ruck requested review of D16674: [Chronik] Rename `group` in `PluginOutput` to `groups`.
Aug 22 2024, 12:22
PiRK accepted D16673: [ecash-lib] Fix fee estimation for signatories that depend on tx outputs.
Aug 22 2024, 12:05
PiRK updated the diff for D16571: [chronik] Add a struct to compute a block merkle tree.

use a verb in the function name, as per suggestion

Aug 22 2024, 10:36
tobias_ruck updated the summary of D16544: [ecash-agora] Add `agora.py` plugin to index ONESHOT offers.
Aug 22 2024, 03:03
tobias_ruck updated the diff for D16544: [ecash-agora] Add `agora.py` plugin to index ONESHOT offers.

remove unrelated chronik-db change

Aug 22 2024, 02:59
tobias_ruck updated the diff for D16544: [ecash-agora] Add `agora.py` plugin to index ONESHOT offers.

rebase, update using a dataclass, add sats calculation as requested

Aug 22 2024, 02:59
tobias_ruck updated the diff for D16673: [ecash-lib] Fix fee estimation for signatories that depend on tx outputs.

fix comments

Aug 22 2024, 02:53
tobias_ruck updated the summary of D16673: [ecash-lib] Fix fee estimation for signatories that depend on tx outputs.
Aug 22 2024, 02:52
tobias_ruck requested review of D16673: [ecash-lib] Fix fee estimation for signatories that depend on tx outputs.
Aug 22 2024, 02:51

Aug 21 2024

johnkuney closed D16672: [explorer] Remove extra pagination.
Aug 21 2024, 22:19
johnkuney committed rABC9e12b2825253: [explorer] Remove extra pagination (authored by johnkuney).
[explorer] Remove extra pagination
Aug 21 2024, 22:19
tobias_ruck accepted D16672: [explorer] Remove extra pagination.
Aug 21 2024, 22:00
johnkuney added a comment to D16672: [explorer] Remove extra pagination.

so when I saved it did all that formatting...removed it though and just saved without autoformat on...

Aug 21 2024, 20:52
johnkuney updated the diff for D16672: [explorer] Remove extra pagination.

update js file hash

Aug 21 2024, 20:50
johnkuney updated the diff for D16672: [explorer] Remove extra pagination.

remove format change

Aug 21 2024, 20:48
tobias_ruck requested changes to D16672: [explorer] Remove extra pagination.
Aug 21 2024, 20:35
johnkuney updated the diff for D16672: [explorer] Remove extra pagination.

update hash for js files

Aug 21 2024, 19:38
johnkuney requested review of D16672: [explorer] Remove extra pagination.
Aug 21 2024, 19:21
johnkuney closed D16671: [explorer] Add replace rule for token data.
Aug 21 2024, 19:20
johnkuney committed rABC838bf8d1b4dc: [explorer] Add replace rule for token data (authored by johnkuney).
[explorer] Add replace rule for token data
Aug 21 2024, 19:20
roqqit updated the diff for D16668: [avalanche] Add stake contender inv type.

use named arg per feedback

Aug 21 2024, 19:03
tobias_ruck accepted D16671: [explorer] Add replace rule for token data.
Aug 21 2024, 18:56
johnkuney updated the diff for D16671: [explorer] Add replace rule for token data.

rebase

Aug 21 2024, 18:44
tobias_ruck closed D16666: [explorer] Support multi-token transactions.
Aug 21 2024, 18:36
tobias_ruck committed rABC3dfcb1da12d6: [explorer] Support multi-token transactions (authored by tobias_ruck).
[explorer] Support multi-token transactions
Aug 21 2024, 18:36
johnkuney requested review of D16671: [explorer] Add replace rule for token data.
Aug 21 2024, 18:36
johnkuney closed D16670: [explorer] Remove trailing commma in linter file.
Aug 21 2024, 18:35
johnkuney committed rABC16c48c9a5aae: [explorer] Remove trailing commma in linter file (authored by johnkuney).
[explorer] Remove trailing commma in linter file
Aug 21 2024, 18:35
tobias_ruck accepted D16571: [chronik] Add a struct to compute a block merkle tree.
Aug 21 2024, 18:32
PiRK accepted D16670: [explorer] Remove trailing commma in linter file.
Aug 21 2024, 18:27
PiRK added inline comments to D16571: [chronik] Add a struct to compute a block merkle tree.
Aug 21 2024, 18:12
PiRK updated the diff for D16571: [chronik] Add a struct to compute a block merkle tree.

I missed one

Aug 21 2024, 18:11
PiRK updated the diff for D16571: [chronik] Add a struct to compute a block merkle tree.

review items

Aug 21 2024, 18:08
johnkuney requested review of D16670: [explorer] Remove trailing commma in linter file.
Aug 21 2024, 18:01
PiRK accepted D16666: [explorer] Support multi-token transactions.

We figured out my issue for running the explorer, I wasn't running cargo run in the right folder.
The result looks good, each UTXO shows the correct token now.

Aug 21 2024, 14:40
PiRK added a comment to D16666: [explorer] Support multi-token transactions.

The code looks good as far as I can tell, but I'm having trouble running the test plan to check the result.

Aug 21 2024, 13:02
PiRK accepted D16668: [avalanche] Add stake contender inv type.

with a nit in the test

Aug 21 2024, 12:53
PiRK updated the test plan for D16669: [electrum] fix the btchip-python dependency for pip > 24.1.
Aug 21 2024, 08:46
PiRK updated the summary of D16669: [electrum] fix the btchip-python dependency for pip > 24.1.
Aug 21 2024, 08:45
PiRK added inline comments to D16665: [electrum] use python's standard library `secrets` for randrange.
Aug 21 2024, 08:36
PiRK updated the summary of D16664: [electrum] bump mnemonic dependency to >=0.21.
Aug 21 2024, 08:34
PiRK requested review of D16669: [electrum] fix the btchip-python dependency for pip > 24.1.
Aug 21 2024, 08:33

Aug 20 2024

tobias_ruck published D16666: [explorer] Support multi-token transactions for review.
Aug 20 2024, 19:26
tobias_ruck closed D16662: [explorer] Format askama HTML templates using djlint instead of prettier.
Aug 20 2024, 19:16
tobias_ruck committed rABC1243bd9ebf29: [explorer] Format askama HTML templates using djlint instead of prettier (authored by tobias_ruck).
[explorer] Format askama HTML templates using djlint instead of prettier
Aug 20 2024, 19:16
tobias_ruck updated the diff for D16662: [explorer] Format askama HTML templates using djlint instead of prettier.

fix missing =

Aug 20 2024, 19:13
roqqit requested review of D16668: [avalanche] Add stake contender inv type.
Aug 20 2024, 16:41
PiRK published D16665: [electrum] use python's standard library `secrets` for randrange for review.
Aug 20 2024, 16:34
PiRK published D16664: [electrum] bump mnemonic dependency to >=0.21 for review.
Aug 20 2024, 16:32
PiRK requested review of D16667: [electrum] update dockerfiles to unbreak the release build.
Aug 20 2024, 16:16
PiRK accepted D16662: [explorer] Format askama HTML templates using djlint instead of prettier.

OK. It requires python >= 3.8, which is fine. I added a suggestion about an alternative way to pass the input data to stdin, your pick.

Aug 20 2024, 14:35
tobias_ruck updated the test plan for D16662: [explorer] Format askama HTML templates using djlint instead of prettier.
Aug 20 2024, 12:07
tobias_ruck retitled D16662: [explorer] Format askama HTML templates using djlint instead of prettier from [explorer] Fix formatting of askama HTML templates to [explorer] Format askama HTML templates using djlint instead of prettier.
Aug 20 2024, 12:07
tobias_ruck updated the diff for D16662: [explorer] Format askama HTML templates using djlint instead of prettier.

fix lint length

Aug 20 2024, 12:00
tobias_ruck updated the diff for D16662: [explorer] Format askama HTML templates using djlint instead of prettier.

use djlint to lint explorer templates

Aug 20 2024, 11:58
PiRK updated the test plan for D16663: [electrum] fix fiat price cache not being created if it does not already exist.
Aug 20 2024, 09:44
PiRK added inline comments to D16663: [electrum] fix fiat price cache not being created if it does not already exist.
Aug 20 2024, 09:42
teamcity updated the summary of D16663: [electrum] fix fiat price cache not being created if it does not already exist.
Aug 20 2024, 09:40
PiRK requested review of D16663: [electrum] fix fiat price cache not being created if it does not already exist.
Aug 20 2024, 09:40
PiRK added a comment to D16662: [explorer] Format askama HTML templates using djlint instead of prettier.

I tried adding a .prettierignore file to web/explorer with a explorer-server/templates line, but it does not seem to have any effect, prettier still messes up the html files in this directory. So not sure how to what I suggested.

Aug 20 2024, 08:12
PiRK added a comment to D16662: [explorer] Format askama HTML templates using djlint instead of prettier.

I agree that it looks a lot more readable like this, and everything looks good to me. I'm just wondering whether applying markdown formatting to html files makes sense in the first place. Does it add anything useful vs just disabling prettier altogether for this project?

Aug 20 2024, 07:58

Aug 19 2024

tobias_ruck requested review of D16662: [explorer] Format askama HTML templates using djlint instead of prettier.
Aug 19 2024, 23:11
tobias_ruck requested changes to D16571: [chronik] Add a struct to compute a block merkle tree.
Aug 19 2024, 21:34
PiRK added inline comments to D16571: [chronik] Add a struct to compute a block merkle tree.
Aug 19 2024, 11:19
PiRK updated the diff for D16571: [chronik] Add a struct to compute a block merkle tree.

rebase on latest master

Aug 19 2024, 11:13
teamcity added a comment to D16571: [chronik] Add a struct to compute a block merkle tree.
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
Aug 19 2024, 10:59
teamcity added a comment to D16571: [chronik] Add a struct to compute a block merkle tree.
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
Aug 19 2024, 10:59
teamcity added a comment to D16571: [chronik] Add a struct to compute a block merkle tree.
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
Aug 19 2024, 10:59
teamcity added a comment to D16571: [chronik] Add a struct to compute a block merkle tree.
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
Aug 19 2024, 10:59
teamcity added a comment to D16571: [chronik] Add a struct to compute a block merkle tree.
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
Aug 19 2024, 10:56
PiRK updated the diff for D16571: [chronik] Add a struct to compute a block merkle tree.

use Sha256d instead of [u8; 32] everywhere and use integer arithmetic in branch_length

Aug 19 2024, 10:52
PiRK accepted D16650: [avalanche] Reject transactions that conflict with a finalized one.

Looks good.
As discussed above, there is some ambiguity about TX_AVALANCHE_RECONSIDERABLE currently only being used for non-finalized conflicting txs (tx added to the TxConflicting pool). The pool will need to be renamed if/when we start adding other type of transactions to it, but that can be done if/when needed.

Aug 19 2024, 07:33

Aug 18 2024

abc-bot committed rABC465d676f8e34: [Automated] Update chainparams (authored by abc-bot).
[Automated] Update chainparams
Aug 18 2024, 21:09
abc-bot committed rABC9c4442d195a0: [Automated] Update timing.json (authored by abc-bot).
[Automated] Update timing.json
Aug 18 2024, 20:38
bytesofman closed D16655: [Cashtab] ChronikClientNode to ChronikClient.
Aug 18 2024, 15:53
bytesofman committed rABC58e0e5a9c61d: [Cashtab] ChronikClientNode to ChronikClient (authored by bytesofman).
[Cashtab] ChronikClientNode to ChronikClient
Aug 18 2024, 15:53
bytesofman closed D16657: [ecash-agora] Replace legacy ChronikClientNode with ChronikClient.
Aug 18 2024, 15:52
bytesofman committed rABC347d5998d0cc: [ecash-agora] Replace legacy ChronikClientNode with ChronikClient (authored by bytesofman).
[ecash-agora] Replace legacy ChronikClientNode with ChronikClient
Aug 18 2024, 15:52
bytesofman closed D16656: [ecash-lib] Replace legacy ChronikClientNode references with ChronikClient.
Aug 18 2024, 15:51
bytesofman committed rABC656d823277b2: [ecash-lib] Replace legacy ChronikClientNode references with ChronikClient (authored by bytesofman).
[ecash-lib] Replace legacy ChronikClientNode references with ChronikClient
Aug 18 2024, 15:51

Aug 17 2024

bytesofman closed D16661: [Cashtab] Display some ideas for how to use a new amount of XEC.
Aug 17 2024, 23:03
bytesofman committed rABC1c0c7c93b2d8: [Cashtab] Display some ideas for how to use a new amount of XEC (authored by bytesofman).
[Cashtab] Display some ideas for how to use a new amount of XEC
Aug 17 2024, 23:03
bytesofman closed D16660: [dependencies] Patch checksum for nodesetup.h.
Aug 17 2024, 23:01
bytesofman committed rABC78c654a50448: [dependencies] Patch checksum for nodesetup.h (authored by bytesofman).
[dependencies] Patch checksum for nodesetup.h
Aug 17 2024, 23:00
Fabien accepted D16660: [dependencies] Patch checksum for nodesetup.h.
Aug 17 2024, 20:32
teamcity awarded D16660: [dependencies] Patch checksum for nodesetup.h a Doubloon token.
Aug 17 2024, 05:12
emack added a comment to D16660: [dependencies] Patch checksum for nodesetup.h.

@bot ecash-herald-tests

Aug 17 2024, 05:11
emack accepted D16661: [Cashtab] Display some ideas for how to use a new amount of XEC.

Minor nit

Aug 17 2024, 05:10
emack accepted D16656: [ecash-lib] Replace legacy ChronikClientNode references with ChronikClient.
Aug 17 2024, 05:07

Aug 16 2024

bytesofman published D16661: [Cashtab] Display some ideas for how to use a new amount of XEC for review.
Aug 16 2024, 21:43
bytesofman published D16660: [dependencies] Patch checksum for nodesetup.h for review.
Aug 16 2024, 21:16
teamcity awarded D16660: [dependencies] Patch checksum for nodesetup.h a Piece of Eight token.
Aug 16 2024, 21:09
teamcity awarded D16660: [dependencies] Patch checksum for nodesetup.h a Haypence token.
Aug 16 2024, 21:00
johnkuney closed D16659: [e.cash] Add airdrop flag to create wallet button.
Aug 16 2024, 20:32
johnkuney committed rABC1de0cf49d8ec: [e.cash] Add airdrop flag to create wallet button (authored by johnkuney).
[e.cash] Add airdrop flag to create wallet button
Aug 16 2024, 20:32