Page MenuHomePhabricator
Feed All Stories

Nov 29 2024

Fabien added a comment to D17247: build: switch to using LLVM 17.x for macOS builds.

@bot guix-osx

Nov 29 2024, 19:20
Fabien updated the summary of D17247: build: switch to using LLVM 17.x for macOS builds.
Nov 29 2024, 19:20
Fabien updated the diff for D17247: build: switch to using LLVM 17.x for macOS builds.

Rebase

Nov 29 2024, 19:20
tobias_ruck requested review of D17255: [ecash-lib] Add support for LEGACY sighash.
Nov 29 2024, 19:19
Fabien requested review of D17254: Fix missing endef in native_cctools.mk.
Nov 29 2024, 19:13
Fabien closed D17253: build: fix mutex detection when building bdb on macOS.
Nov 29 2024, 19:10
Fabien committed rABC8fc7a3d8a370: build: fix mutex detection when building bdb on macOS (authored by fanquake <fanquake@gmail.com>).
build: fix mutex detection when building bdb on macOS
Nov 29 2024, 19:10
PiRK accepted D17253: build: fix mutex detection when building bdb on macOS.
Nov 29 2024, 19:04
tobias_ruck planned changes to D17193: [ecash-lib] Add support for LEGACY sighash.

wait for the avalanche fix

Nov 29 2024, 18:57
teamcity added a comment to D17193: [ecash-lib] Add support for LEGACY sighash.
Nov 29 2024, 18:52
teamcity triaged T3686: Build Bitcoin-ABC / Master / Cross Builds / Cross Build OSX is broken. as Unbreak Now! priority.
Nov 29 2024, 18:51
tobias_ruck updated the diff for D17193: [ecash-lib] Add support for LEGACY sighash.

forward process env

Nov 29 2024, 18:35
teamcity added a comment to D17193: [ecash-lib] Add support for LEGACY sighash.
Nov 29 2024, 18:27
teamcity closed T3684: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Windows 64-bit is broken. as Resolved.
Nov 29 2024, 18:22
Fabien closed D17251: contrib: add macOS test for fixup_chains usage.
Nov 29 2024, 18:06
Fabien committed rABC57b456de2118: contrib: add macOS test for fixup_chains usage (authored by Fabien).
contrib: add macOS test for fixup_chains usage
Nov 29 2024, 18:06
Fabien updated the summary of D17251: contrib: add macOS test for fixup_chains usage.
Nov 29 2024, 18:05
tobias_ruck updated the diff for D17193: [ecash-lib] Add support for LEGACY sighash.

fix shasum calc

Nov 29 2024, 17:51
Fabien closed D17245: build: Produce a .zip for macOS distribution.
Nov 29 2024, 17:44
Fabien closed D17246: guix: remove input labels.
Nov 29 2024, 17:44
Fabien committed rABC1a5cfe548714: guix: remove input labels (authored by fanquake <fanquake@gmail.com>).
guix: remove input labels
Nov 29 2024, 17:44
Fabien committed rABCbdd3a95ea024: build: Produce a .zip for macOS distribution (authored by fanquake <fanquake@gmail.com>).
build: Produce a .zip for macOS distribution
Nov 29 2024, 17:44
Fabien closed D17248: Fix a linkage error when cross building for windows with the hardening flags.
Nov 29 2024, 17:44
Fabien committed rABC669ebc5fb537: Fix a linkage error when cross building for windows with the hardening flags (authored by Fabien).
Fix a linkage error when cross building for windows with the hardening flags
Nov 29 2024, 17:44
teamcity updated the summary of D17253: build: fix mutex detection when building bdb on macOS.
Nov 29 2024, 17:41
Fabien requested review of D17253: build: fix mutex detection when building bdb on macOS.
Nov 29 2024, 17:41
teamcity added a comment to D17193: [ecash-lib] Add support for LEGACY sighash.
Nov 29 2024, 17:40
bytesofman added inline comments to D17193: [ecash-lib] Add support for LEGACY sighash.
Nov 29 2024, 17:25
tobias_ruck accepted D17242: [CHRONIK] Updated pyo3 version.
Nov 29 2024, 17:06
teamcity closed T3685: Build Bitcoin-ABC / CashTab / CashTab Unit Tests is broken. as Resolved.
Nov 29 2024, 17:02
tobias_ruck updated the diff for D17193: [ecash-lib] Add support for LEGACY sighash.

move doged download into the functional test

Nov 29 2024, 17:00
PiRK accepted D17251: contrib: add macOS test for fixup_chains usage.
Nov 29 2024, 16:58
PiRK accepted D17248: Fix a linkage error when cross building for windows with the hardening flags.
Nov 29 2024, 16:55
PiRK accepted D17246: guix: remove input labels.
Nov 29 2024, 16:54
PiRK accepted D17245: build: Produce a .zip for macOS distribution.
Nov 29 2024, 16:51
teamcity added a comment to D17250: build: depends move macOS C(XX) FLAGS out of C & CXX.
Nov 29 2024, 16:44
teamcity added a comment to D17249: depends: qt 5.15.13.
Nov 29 2024, 16:43
PiRK closed D17252: add missing unordered_map include.
Nov 29 2024, 16:40
PiRK committed rABC4cb2cf5a2548: add missing unordered_map include (authored by PiRK).
add missing unordered_map include
Nov 29 2024, 16:40
Fabien accepted D17252: add missing unordered_map include.
Nov 29 2024, 16:36
PiRK requested review of D17252: add missing unordered_map include.
Nov 29 2024, 16:32
teamcity added a comment to D17193: [ecash-lib] Add support for LEGACY sighash.
Nov 29 2024, 16:30
teamcity updated the summary of D17251: contrib: add macOS test for fixup_chains usage.
Nov 29 2024, 16:17
Fabien requested review of D17251: contrib: add macOS test for fixup_chains usage.
Nov 29 2024, 16:17
tobias_ruck updated the summary of D17193: [ecash-lib] Add support for LEGACY sighash.
Nov 29 2024, 15:59
teamcity added a comment to D17247: build: switch to using LLVM 17.x for macOS builds.
Nov 29 2024, 15:59
hazzarust updated the diff for D17242: [CHRONIK] Updated pyo3 version.

Reformatted the use statement to make it one line
use std::{collections::BTreeMap, ffi::CString};
Also changed thiserror back to original version (1.0), and will change in a seperate diff

Nov 29 2024, 15:57
teamcity awarded D17250: build: depends move macOS C(XX) FLAGS out of C & CXX a Haypence token.
Nov 29 2024, 15:45
Fabien planned changes to D17250: build: depends move macOS C(XX) FLAGS out of C & CXX.

@bot guix-osx

Nov 29 2024, 15:45
teamcity updated the summary of D17250: build: depends move macOS C(XX) FLAGS out of C & CXX.
Nov 29 2024, 15:45
Fabien requested review of D17250: build: depends move macOS C(XX) FLAGS out of C & CXX.
Nov 29 2024, 15:45
tobias_ruck requested changes to D17242: [CHRONIK] Updated pyo3 version.
Nov 29 2024, 15:39
teamcity awarded D17249: depends: qt 5.15.13 a Haypence token.
Nov 29 2024, 15:35
Fabien planned changes to D17249: depends: qt 5.15.13.

@bot guix-linux guix-osx guix-win

Nov 29 2024, 15:35
teamcity updated the summary of D17249: depends: qt 5.15.13.
Nov 29 2024, 15:34
Fabien requested review of D17249: depends: qt 5.15.13.
Nov 29 2024, 15:34
tobias_ruck updated the diff for D17193: [ecash-lib] Add support for LEGACY sighash.

fix "Oi, you got a loicense fo that, mate?" spelling, fix build

Nov 29 2024, 15:33
teamcity triaged T3685: Build Bitcoin-ABC / CashTab / CashTab Unit Tests is broken. as Unbreak Now! priority.
Nov 29 2024, 15:31
Fabien requested review of D17248: Fix a linkage error when cross building for windows with the hardening flags.
Nov 29 2024, 15:31
teamcity awarded D17247: build: switch to using LLVM 17.x for macOS builds a Haypence token.
Nov 29 2024, 15:30
Fabien planned changes to D17247: build: switch to using LLVM 17.x for macOS builds.

@bot guix-osx

Nov 29 2024, 15:29
teamcity updated the summary of D17247: build: switch to using LLVM 17.x for macOS builds.
Nov 29 2024, 15:29
Fabien requested review of D17247: build: switch to using LLVM 17.x for macOS builds.
Nov 29 2024, 15:29
Fabien closed D17244: [chronik] Fix a race in chronik_resync.py.
Nov 29 2024, 15:23
Fabien committed rABC2a99990e10c0: [chronik] Fix a race in chronik_resync.py (authored by Fabien).
[chronik] Fix a race in chronik_resync.py
Nov 29 2024, 15:23
teamcity awarded D17246: guix: remove input labels a Haypence token.
Nov 29 2024, 15:22
Fabien added a comment to D17246: guix: remove input labels.

@bot guix-linux guix-osx guix-win

Nov 29 2024, 15:22
teamcity updated the summary of D17246: guix: remove input labels.
Nov 29 2024, 14:56
Fabien requested review of D17246: guix: remove input labels.
Nov 29 2024, 14:56
teamcity updated the summary of D17245: build: Produce a .zip for macOS distribution.
Nov 29 2024, 14:55
Fabien requested review of D17245: build: Produce a .zip for macOS distribution.
Nov 29 2024, 14:55
bytesofman requested review of D17219: [Cashtab] Support send token txs with bip21 query strings.
Nov 29 2024, 13:57
bytesofman requested review of D17240: [Cashtab] Do not show ALP and SLP options for NFT mints.

In these situations I feel it may be more intuitive if you leave the toggle there but simply disable it (maybe greyed out to indicate lock status?) so that it's clear to the user this is SLP only. Otherwise they might be looking for the toggle they saw previously with no on screen hint as to why it's not there.

Nov 29 2024, 13:48
bytesofman closed D17243: [ecash-agora] Add a Dockerfile for CI publishing.
Nov 29 2024, 13:42
bytesofman committed rABC95ec22dbb633: [ecash-agora] Add a Dockerfile for CI publishing (authored by bytesofman).
[ecash-agora] Add a Dockerfile for CI publishing
Nov 29 2024, 13:42
PiRK added a comment to D17185: [chronik] Create a new optional JSON RPC interface.

This is a bit clumsy but seems to work;

diff --git a/electrum/electrumabc/interface.py b/electrum/electrumabc/interface.py
index b1198bb889..42e6e23193 100644
--- a/electrum/electrumabc/interface.py
+++ b/electrum/electrumabc/interface.py
@@ -341,17 +341,40 @@ class TcpConnection(threading.Thread, PrintError):
Nov 29 2024, 13:29
bytesofman closed D17228: [ecash-herald] Link to token landing pages instead of token explorer page.
Nov 29 2024, 13:28
bytesofman committed rABCe403691ca4da: [ecash-herald] Link to token landing pages instead of token explorer page (authored by bytesofman).
[ecash-herald] Link to token landing pages instead of token explorer page
Nov 29 2024, 13:28
bytesofman closed D17227: [mock-chronik-client] Use npm published version of ecashaddrjs as dependency for published version.
Nov 29 2024, 13:22
bytesofman committed rABC6476efcc3d6b: [mock-chronik-client] Use npm published version of ecashaddrjs as dependency… (authored by bytesofman).
[mock-chronik-client] Use npm published version of ecashaddrjs as dependency…
Nov 29 2024, 13:22
bytesofman closed D17225: [ecash-herald] Parse ALP token actions.
Nov 29 2024, 13:20
bytesofman committed rABCec514b7aef75: [ecash-herald] Parse ALP token actions (authored by bytesofman).
[ecash-herald] Parse ALP token actions
Nov 29 2024, 13:20
hazzarust updated the summary of D17242: [CHRONIK] Updated pyo3 version.
Nov 29 2024, 13:01
hazzarust updated the diff for D17242: [CHRONIK] Updated pyo3 version.

Reverted back to just calling CString instead of using the new str_to_cstr function

Nov 29 2024, 12:44
PiRK accepted D17244: [chronik] Fix a race in chronik_resync.py.
Nov 29 2024, 12:21
teamcity added a comment to D17193: [ecash-lib] Add support for LEGACY sighash.
Nov 29 2024, 12:07
tobias_ruck updated the summary of D17193: [ecash-lib] Add support for LEGACY sighash.
Nov 29 2024, 11:57
tobias_ruck updated the test plan for D17193: [ecash-lib] Add support for LEGACY sighash.
Nov 29 2024, 11:57
tobias_ruck updated the test plan for D17193: [ecash-lib] Add support for LEGACY sighash.
Nov 29 2024, 11:57
tobias_ruck updated the summary of D17193: [ecash-lib] Add support for LEGACY sighash.
Nov 29 2024, 11:49
tobias_ruck updated the test plan for D17193: [ecash-lib] Add support for LEGACY sighash.
Nov 29 2024, 11:47
tobias_ruck planned changes to D17193: [ecash-lib] Add support for LEGACY sighash.
Nov 29 2024, 11:42
tobias_ruck updated the diff for D17193: [ecash-lib] Add support for LEGACY sighash.

use doged to test legacy signatures

Nov 29 2024, 11:41
tobias_ruck requested changes to D17242: [CHRONIK] Updated pyo3 version.
Nov 29 2024, 11:08
hazzarust updated the diff for D17242: [CHRONIK] Updated pyo3 version.

rerun ci

Nov 29 2024, 10:35
emack requested changes to D17240: [Cashtab] Do not show ALP and SLP options for NFT mints.

In these situations I feel it may be more intuitive if you leave the toggle there but simply disable it (maybe greyed out to indicate lock status?) so that it's clear to the user this is SLP only. Otherwise they might be looking for the toggle they saw previously with no on screen hint as to why it's not there.

Nov 29 2024, 10:30
emack accepted D17241: [Cashtab] Update style element to match redesign.
Nov 29 2024, 10:25
emack requested changes to D17219: [Cashtab] Support send token txs with bip21 query strings.
Nov 29 2024, 10:24
Fabien requested review of D17244: [chronik] Fix a race in chronik_resync.py.
Nov 29 2024, 10:07
teamcity closed T3683: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Linux 64 is broken. as Resolved.
Nov 29 2024, 09:42