Page MenuHomePhabricator
Feed Advanced Search

Feb 27 2025

roqqit committed rABCb0cae7ddadea: [avalanche] Return proofids in addition to payout scripts in getWinners (authored by roqqit).
[avalanche] Return proofids in addition to payout scripts in getWinners
Feb 27 2025, 16:47

Feb 26 2025

roqqit requested review of D17711: [avalanche] Return proofids in addition to payout scripts in getWinners.
Feb 26 2025, 22:51
roqqit requested review of D17710: [avalanche] Simplify contenders by treating rejection and invalidation the same.
Feb 26 2025, 22:34
roqqit accepted D17704: index: Move last_locator_write_time and logging to end of threadsync loop.
Feb 26 2025, 16:43
roqqit accepted D17703: doc: BaseIndex sync behavior with empty datadir.
Feb 26 2025, 16:40
roqqit accepted D17702: index: Don't commit a best block before indexing it during sync.
Feb 26 2025, 16:39
teamcity awarded D17700: [avalanche] Process responses to stake contender polls a Haypence token.
Feb 26 2025, 09:08

Feb 25 2025

roqqit updated the diff for D17700: [avalanche] Process responses to stake contender polls.

bump -avastalevotethreshold a bit because some rounds get voted while finalizing the first block

Feb 25 2025, 23:49
roqqit updated the diff for D17700: [avalanche] Process responses to stake contender polls.

add test cases for all invalidated and all stalled contenders

Feb 25 2025, 22:04
roqqit planned changes to D17700: [avalanche] Process responses to stake contender polls.
Feb 25 2025, 21:30
roqqit updated the diff for D17700: [avalanche] Process responses to stake contender polls.

fixing locking issues

Feb 25 2025, 21:30
roqqit planned changes to D17700: [avalanche] Process responses to stake contender polls.

Early feedback indicates some stuff is missing:

  1. Comment on the outcomes of a stale vote.
  2. Test case if all contenders are rejected.
  3. Test case if all contenders are stalled.
Feb 25 2025, 20:30
roqqit closed D17699: [avalanche] Clarify and simplify checking polled contenders.
Feb 25 2025, 20:23
roqqit committed rABC251c3b16b672: [avalanche] Clarify and simplify checking polled contenders (authored by roqqit).
[avalanche] Clarify and simplify checking polled contenders
Feb 25 2025, 20:23
roqqit requested review of D17700: [avalanche] Process responses to stake contender polls.
Feb 25 2025, 20:20
roqqit requested review of D17699: [avalanche] Clarify and simplify checking polled contenders.
Feb 25 2025, 20:09
roqqit accepted D17698: Avoid inflight polls in getavaaddr_interval_test.
Feb 25 2025, 16:31
roqqit closed D17696: [avalanche] Make contender test more comprehensive.
Feb 25 2025, 16:29
roqqit committed rABCdc86c1e90e2a: [avalanche] Make contender test more comprehensive (authored by roqqit).
[avalanche] Make contender test more comprehensive
Feb 25 2025, 16:29
roqqit closed D17695: [avalanche] Make payout scripts unique in contenders test.
Feb 25 2025, 16:28
roqqit committed rABC80581e12b70b: [avalanche] Make payout scripts unique in contenders test (authored by roqqit).
[avalanche] Make payout scripts unique in contenders test
Feb 25 2025, 16:28
roqqit closed D17693: [avalanche] Cleanup payout address optionality.
Feb 25 2025, 16:24
roqqit committed rABCba6cbc602b92: [avalanche] Cleanup payout address optionality (authored by roqqit).
[avalanche] Cleanup payout address optionality
Feb 25 2025, 16:24
roqqit closed D17694: test: Ignore UTF-8 errors in assert_debug_log.
Feb 25 2025, 16:22
roqqit committed rABC052eab4970d3: test: Ignore UTF-8 errors in assert_debug_log (authored by fanquake <fanquake@gmail.com>).
test: Ignore UTF-8 errors in assert_debug_log
Feb 25 2025, 16:22
roqqit updated the diff for D17696: [avalanche] Make contender test more comprehensive.

rebase

Feb 25 2025, 04:23
roqqit updated the diff for D17695: [avalanche] Make payout scripts unique in contenders test.

skip if wallet isn't available

Feb 25 2025, 04:21
roqqit requested review of D17696: [avalanche] Make contender test more comprehensive.
Feb 25 2025, 04:16
roqqit requested review of D17695: [avalanche] Make payout scripts unique in contenders test.
Feb 25 2025, 04:06
roqqit requested review of D17694: test: Ignore UTF-8 errors in assert_debug_log.
Feb 25 2025, 00:02

Feb 24 2025

roqqit requested review of D17693: [avalanche] Cleanup payout address optionality.
Feb 24 2025, 22:00
roqqit closed D17692: [avalanche] Fix missing wait_until in contender test.
Feb 24 2025, 19:39
roqqit committed rABC103c143b2bea: [avalanche] Fix missing wait_until in contender test (authored by roqqit).
[avalanche] Fix missing wait_until in contender test
Feb 24 2025, 19:39
roqqit requested review of D17692: [avalanche] Fix missing wait_until in contender test.
Feb 24 2025, 18:00
roqqit accepted D17691: test: refactor: use `create_block` parameters.
Feb 24 2025, 17:37
roqqit accepted D17690: test: remove unnecessary block rehashing prior to solving.
Feb 24 2025, 16:42

Feb 23 2025

roqqit accepted D17688: doc: Improve ZMQ documentation.
Feb 23 2025, 17:03

Feb 21 2025

roqqit committed rABC0ab1dbf3adcc: [avalanche] Poll for stake contenders (authored by roqqit).
[avalanche] Poll for stake contenders
Feb 21 2025, 22:07
roqqit closed D17607: [avalanche] Poll for stake contenders.
Feb 21 2025, 22:07

Feb 19 2025

roqqit updated the diff for D17607: [avalanche] Poll for stake contenders.

Rebase on D17660 to address the feedback about splitting up setContenderStatusForLocalWinners(). It should be more clear now that addToReconcile() is only called once per block.

Feb 19 2025, 22:04
roqqit accepted D17679: Remove extra mockscheduler call in abc_p2p_getavaaddr.
Feb 19 2025, 20:59

Feb 14 2025

roqqit closed D17660: [avalanche] Improve API for setContenderStatusForLocalWinners.
Feb 14 2025, 17:52
roqqit committed rABC2c29ef6261c7: [avalanche] Improve API for setContenderStatusForLocalWinners (authored by roqqit).
[avalanche] Improve API for setContenderStatusForLocalWinners
Feb 14 2025, 17:52

Feb 13 2025

roqqit updated the diff for D17660: [avalanche] Improve API for setContenderStatusForLocalWinners.

Avoid unused pollableContenders at call sites for now

Feb 13 2025, 16:59
roqqit added inline comments to D17660: [avalanche] Improve API for setContenderStatusForLocalWinners.
Feb 13 2025, 16:53

Feb 12 2025

roqqit accepted D17661: Better port collision management for the functional tests.
Feb 12 2025, 23:01
roqqit requested review of D17660: [avalanche] Improve API for setContenderStatusForLocalWinners.
Feb 12 2025, 19:03
roqqit accepted D17658: Add a simplifygbt option to simplify parsing the block template for miners.
Feb 12 2025, 17:27

Feb 11 2025

roqqit accepted D17658: Add a simplifygbt option to simplify parsing the block template for miners.
Feb 11 2025, 21:56
roqqit requested changes to D17658: Add a simplifygbt option to simplify parsing the block template for miners.

Is there a reason -simplifygbt is a command line arg and not a parameter to getblocktemplate?

Feb 11 2025, 16:32

Feb 10 2025

roqqit closed D17615: [avalanche] Add stake contender to AnyVoteItem.
Feb 10 2025, 17:09
roqqit committed rABC95622f64aac3: [avalanche] Add stake contender to AnyVoteItem (authored by roqqit).
[avalanche] Add stake contender to AnyVoteItem
Feb 10 2025, 17:09

Feb 7 2025

roqqit accepted D17645: wallet: make chain optional for CWallet::Create.
Feb 7 2025, 19:09
roqqit accepted D17644: CWallet::Create move chain init message up into calling code.
Feb 7 2025, 18:48
roqqit accepted D17643: refactor: Add CWallet:::AttachChain method.
Feb 7 2025, 18:47
roqqit accepted D17642: refactor: move first run detection to client code.

nvm. compared the wrong lines side-by-side

Feb 7 2025, 16:44
roqqit requested changes to D17642: refactor: move first run detection to client code.
Feb 7 2025, 00:59

Feb 5 2025

roqqit accepted D17634: chainparams: add blockhash to AssumeutxoData.
Feb 5 2025, 19:03
roqqit accepted D17633: assumeutxo: remove snapshot during -reindex{-chainstate}.
Feb 5 2025, 18:18
roqqit accepted D17632: net_processing: Request assumeutxo background chain blocks.
Feb 5 2025, 18:06
roqqit accepted D17631: [net processing] pass a Peer to FindNextBlocksToDownload.
Feb 5 2025, 16:45

Feb 3 2025

roqqit accepted D17629: bugfix: correct is_snapshot_cs in VerifyDB.
Feb 3 2025, 17:02

Jan 31 2025

roqqit updated the diff for D17615: [avalanche] Add stake contender to AnyVoteItem.

Make local acceptance match what this node would eventually vote

Jan 31 2025, 22:07

Jan 30 2025

roqqit closed D17616: [avalanche] Eliminate taking unnecessary locks on cs_stakingRewards when getting stake contender status.
Jan 30 2025, 19:38
roqqit committed rABCfd85bce1ebe4: [avalanche] Eliminate taking unnecessary locks on cs_stakingRewards when… (authored by roqqit).
[avalanche] Eliminate taking unnecessary locks on cs_stakingRewards when…
Jan 30 2025, 19:38
roqqit requested review of D17616: [avalanche] Eliminate taking unnecessary locks on cs_stakingRewards when getting stake contender status.
Jan 30 2025, 17:11
roqqit published D17607: [avalanche] Poll for stake contenders for review.
Jan 30 2025, 17:04
roqqit requested review of D17615: [avalanche] Add stake contender to AnyVoteItem.
Jan 30 2025, 16:59

Jan 29 2025

roqqit closed D17590: [avalanche] Check that avalanche invalidated items no longer poll in the dont_poll_invalid_item test case.
Jan 29 2025, 20:38
roqqit committed rABC1d9e9cd37db2: [avalanche] Check that avalanche invalidated items no longer poll in the… (authored by roqqit).
[avalanche] Check that avalanche invalidated items no longer poll in the…
Jan 29 2025, 20:38
roqqit updated the diff for D17590: [avalanche] Check that avalanche invalidated items no longer poll in the dont_poll_invalid_item test case.

Add comments to make it more clear that the test is checking the item is not being polled for

Jan 29 2025, 17:26
roqqit committed rABCfe50cfef5517: [doc] Cleanup trailing whitespaces (authored by roqqit).
[doc] Cleanup trailing whitespaces
Jan 29 2025, 17:18
roqqit closed D17602: [doc] Cleanup trailing whitespaces.
Jan 29 2025, 17:18

Jan 27 2025

roqqit updated the diff for D17602: [doc] Cleanup trailing whitespaces.

Remove erroneous image file change

Jan 27 2025, 22:11
roqqit requested review of D17602: [doc] Cleanup trailing whitespaces.
Jan 27 2025, 22:09
roqqit closed D17589: [avalanche] Clear updates on each call to registerVotes.
Jan 27 2025, 21:50
roqqit committed rABC221da91fe481: [avalanche] Clear updates on each call to registerVotes (authored by roqqit).
[avalanche] Clear updates on each call to registerVotes
Jan 27 2025, 21:50
roqqit updated the diff for D17589: [avalanche] Clear updates on each call to registerVotes.

feedback

Jan 27 2025, 19:41

Jan 24 2025

roqqit accepted D17585: Bump the timeout for the feature_cltv test.
Jan 24 2025, 20:09
roqqit accepted D17586: Bump the timeout in p2p_ibd_stalling.
Jan 24 2025, 20:09
roqqit requested review of D17590: [avalanche] Check that avalanche invalidated items no longer poll in the dont_poll_invalid_item test case.
Jan 24 2025, 20:07
roqqit requested review of D17589: [avalanche] Clear updates on each call to registerVotes.
Jan 24 2025, 19:53

Jan 23 2025

roqqit accepted D17581: [electrum] bump version to 5.4.0 and add release notes.
Jan 23 2025, 17:54
roqqit requested review of D17582: [avalanche] Add an invalidation latch to contender cache.
Jan 23 2025, 17:51
roqqit closed D17574: [avalanche] Fixup incorrect comment about contender cache vote status.
Jan 23 2025, 17:46
roqqit committed rABC8a22e311702c: [avalanche] Fixup incorrect comment about contender cache vote status (authored by roqqit).
[avalanche] Fixup incorrect comment about contender cache vote status
Jan 23 2025, 17:46

Jan 21 2025

roqqit requested review of D17574: [avalanche] Fixup incorrect comment about contender cache vote status.
Jan 21 2025, 19:36

Jan 16 2025

roqqit closed D17538: [test] Make test_getpeerinfo more robust by using mocktime.
Jan 16 2025, 21:07
roqqit committed rABCd2683db55d84: [test] Make test_getpeerinfo more robust by using mocktime (authored by roqqit).
[test] Make test_getpeerinfo more robust by using mocktime
Jan 16 2025, 21:07
roqqit updated the diff for D17538: [test] Make test_getpeerinfo more robust by using mocktime.

Remove errant newline

Jan 16 2025, 18:02
roqqit updated the diff for D17538: [test] Make test_getpeerinfo more robust by using mocktime.

Use assert_equal

Jan 16 2025, 18:00

Jan 15 2025

roqqit closed D17531: [test] Fix intermittent timeouts in various functional tests.
Jan 15 2025, 22:25
roqqit committed rABC18aa9533dcc9: [test] Fix intermittent timeouts in various functional tests (authored by MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>).
[test] Fix intermittent timeouts in various functional tests
Jan 15 2025, 22:25
roqqit committed rABC4b8c65801635: test: Fail if connect_nodes fails (authored by laanwj <126646+laanwj@users.noreply.github.com>).
test: Fail if connect_nodes fails
Jan 15 2025, 22:25
roqqit closed D17530: test: Fail if connect_nodes fails.
Jan 15 2025, 22:25
roqqit closed D17539: [test] Cleanup unnecessary sync_all in rpc_net.py.
Jan 15 2025, 22:24
roqqit committed rABCc801d8fc621a: [test] Cleanup unnecessary sync_all in rpc_net.py (authored by roqqit).
[test] Cleanup unnecessary sync_all in rpc_net.py
Jan 15 2025, 22:24
roqqit closed D17529: [test] clarify rpc_net & p2p_disconnect_ban functional tests.
Jan 15 2025, 22:24
roqqit committed rABC7878d95a0db2: [test] clarify rpc_net & p2p_disconnect_ban functional tests (authored by Wladimir J. van der Laan <laanwj@protonmail.com>).
[test] clarify rpc_net & p2p_disconnect_ban functional tests
Jan 15 2025, 22:24
roqqit requested review of D17539: [test] Cleanup unnecessary sync_all in rpc_net.py.
Jan 15 2025, 18:23