Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.83.66.92:41483 for the next 60 minutes.

@bot preview-e.cash

typo fix: Added hyphen to eCash-native

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.83.66.92:41999 for the next 60 minutes.

@bot preview-e.cash

preserve attribution headers in ecashaddrjs, keep ignores in the top-level .gitignore

remove a print

support opcode 0x01, write more tests, find out that the op == OpCodes.OP_PUSHDATA4 branch is wrong, fix it

In D17755#404635, @teamcity wrote:

Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.

Failed tests logs:

====== CashTab Unit Tests: <Token /> available actions rendered We can redeem XECX for XEC 1:1 using a workflow unique to XECX ======
Error: expect(element).toBeDisabled()

Received element is not disabled:
  <button class="sc-caSCKo sc-kjoXOD DHATx" style="margin-top: 12px;" />
    at Object.toBeDisabled (/work/cashtab/src/components/Etokens/__tests__/TokenActions.test.js:1985:30)

Each failure log is accessible here:
CashTab Unit Tests: <Token /> available actions rendered We can redeem XECX for XEC 1:1 using a workflow unique to XECX

A flynt false positive

actually back out the changes in net.cpp

newline net.cpp to back out unrelated autofix

newlines to back out unrelated autofixes

backing out unrelated autofixes from arc lint everything

running arc lint --everything and taking some autofixes

patch py lint issue (handled in separate diff), exclude src/ which has .ts files that are not typescript

and arc diff the next update without the linting bypass pls

Regarding the mypy issue, what are your mypy and python versions ?

add tests for incorrect data length in otherwise valid succession of push ops

make this a move only commit

let's add the headers in a separate diff, so it is clear that no code was changed

In D17755#404513, @emack wrote:

/modules/chronik-client/.prettierignore and /.prettierignore be removed as it's similar to .eslintignore

On another note, I'm getting the following from arc lint --everything

However, arc lint on the cashtab folder runs fine, which doesn't seem to be a local issue?

Squashed commits as requested and removed unnecessary useEffec

In D17756#404523, @alitayin wrote:

In D17756#404509, @emack wrote:

Implemented a click-outside closing mechanism for the settings window

where is this implemented? I'm not seeing event bubbling above, only the removal of the redundant useEffect.

This is a update.
Perhaps my update method wasn't quite right? It created a new sub-diff, this is the initial submission https://reviews.bitcoinabc.org/D17756?id=52941

In D17756#404509, @emack wrote:

Implemented a click-outside closing mechanism for the settings window

where is this implemented? I'm not seeing event bubbling above, only the removal of the redundant useEffect.

Please prefix your title with [cashtab] so we now in the review queue what part of the code is changed

In D17755#404513, @emack wrote:

/modules/chronik-client/.prettierignore and /.prettierignore be removed as it's similar to .eslintignore

On another note, I'm getting the following from arc lint --everything

However, arc lint on the cashtab folder runs fine, which doesn't seem to be a local issue?

/modules/chronik-client/.prettierignore and /.prettierignore be removed as it's similar to .eslintignore

Implemented a click-outside closing mechanism for the settings window

where is this implemented? I'm not seeing event bubbling above, only the removal of the redundant useEffect.

Remove useEffect

superseded by D17755

Linter

fixed error

Downcast the Report into ChronikClientError, so that we can now match on status code being returned (thanks Fabien!). Updated variable names from load to get, updated panic messages