Page MenuHomePhabricator
Feed Advanced Search

Tue, Mar 18

PiRK closed D17785: [electrum] install a custom version of trezorlib.
Tue, Mar 18, 14:49
PiRK committed rABCcd9dcc148d47: [electrum] install a custom version of trezorlib (authored by PiRK).
[electrum] install a custom version of trezorlib
Tue, Mar 18, 14:48
PiRK updated the diff for D17785: [electrum] install a custom version of trezorlib.

use slip10 1.0.1 to better satisfy the trezorlib >= 1.0.1 requirements (the AppImage build works with 1.0.0, but with more recent versions of pip the conflict becomes an error)

Tue, Mar 18, 12:07
PiRK planned changes to D17785: [electrum] install a custom version of trezorlib.
Tue, Mar 18, 11:35
PiRK updated the diff for D17785: [electrum] install a custom version of trezorlib.

update the repo and commit hash to ecash/2.8.9 tag from the Bitcoin ABC repo

Tue, Mar 18, 08:23

Mon, Mar 17

PiRK committed rABCceb2d83868fc: [electrum] make it possible to spend tokens by manually selecting the coins to… (authored by PiRK).
[electrum] make it possible to spend tokens by manually selecting the coins to…
Mon, Mar 17, 14:08
PiRK closed D17809: [electrum] make it possible to spend tokens by manually selecting the coins to spend.
Mon, Mar 17, 14:08
PiRK closed D17808: [electrum] properly exclude ALP tokens when sending XEC.
Mon, Mar 17, 14:08
PiRK committed rABC0e9f232bbe91: [electrum] properly exclude ALP tokens when sending XEC (authored by PiRK).
[electrum] properly exclude ALP tokens when sending XEC
Mon, Mar 17, 14:08
PiRK added inline comments to D17808: [electrum] properly exclude ALP tokens when sending XEC.
Mon, Mar 17, 09:23
PiRK updated the diff for D17808: [electrum] properly exclude ALP tokens when sending XEC.

factor the token detection into a wallet.has_tokens(coin) method and fix one more thing that could cause accidental spending of ALP tokens (for users who enabled "Spend only fused coins", if a token is sent to the same address as a fused coin)

Mon, Mar 17, 09:19
PiRK closed D17806: [electrum] Make the coin consolidator not burn alp tokens.
Mon, Mar 17, 08:57
PiRK committed rABCf9a8f5d46c53: [electrum] Make the coin consolidator not burn alp tokens (authored by PiRK).
[electrum] Make the coin consolidator not burn alp tokens
Mon, Mar 17, 08:57

Sat, Mar 15

PiRK added a comment to D17806: [electrum] Make the coin consolidator not burn alp tokens.

TIL coin consolidator is a thing in electrum

how is this used in the GUI? is this just called in normal tx building?

Sat, Mar 15, 07:08

Fri, Mar 14

PiRK accepted D17807: [token-server] Soften recaptcha check.
Fri, Mar 14, 14:32
PiRK added a comment to D17808: [electrum] properly exclude ALP tokens when sending XEC.

As an additional test I'm also going to try to be in a few CashFusion rounds to confirm no tokens are burned. But I cannot guarantee the tests will be conclusive in a timely manner.

Fri, Mar 14, 14:30
PiRK requested review of D17809: [electrum] make it possible to spend tokens by manually selecting the coins to spend.
Fri, Mar 14, 14:29
PiRK updated the summary of D17808: [electrum] properly exclude ALP tokens when sending XEC.
Fri, Mar 14, 14:21
PiRK requested review of D17808: [electrum] properly exclude ALP tokens when sending XEC.
Fri, Mar 14, 14:20
PiRK requested review of D17806: [electrum] Make the coin consolidator not burn alp tokens.
Fri, Mar 14, 12:39

Thu, Mar 13

PiRK accepted D17798: [electrum] Update trezor firmware.

tested with python3.11 (via AppImage)

Thu, Mar 13, 15:22
PiRK accepted D17800: [fuzzer] Fix the validation_load_mempool build.
Thu, Mar 13, 15:12
PiRK requested changes to D17798: [electrum] Update trezor firmware.
Thu, Mar 13, 15:04
PiRK closed D17797: [electrum] also use patched btchip-python in non-deterministic requirements-hw.txt.
Thu, Mar 13, 14:47
PiRK closed D17796: [electrum] bump hidapi and remove --only-binary workaround.
Thu, Mar 13, 14:47
PiRK committed rABC3a3f70a15b77: [electrum] bump hidapi and remove --only-binary workaround (authored by PiRK).
[electrum] bump hidapi and remove --only-binary workaround
Thu, Mar 13, 14:47
PiRK committed rABCdab327942d2a: [electrum] also use patched btchip-python in non-deterministic requirements-hw. (authored by PiRK).
[electrum] also use patched btchip-python in non-deterministic requirements-hw.
Thu, Mar 13, 14:47
PiRK closed D17777: [electrum] freeze UTXOs that may contain ALP tokens.
Thu, Mar 13, 10:00
PiRK committed rABC5d218549c5d2: [electrum] freeze UTXOs that may contain ALP tokens (authored by PiRK).
[electrum] freeze UTXOs that may contain ALP tokens
Thu, Mar 13, 10:00
PiRK planned changes to D17785: [electrum] install a custom version of trezorlib.
Thu, Mar 13, 09:57
PiRK updated the diff for D17785: [electrum] install a custom version of trezorlib.

rebase on D17797 (extracted some changes not directly related to trezor)

Thu, Mar 13, 09:56
PiRK requested review of D17797: [electrum] also use patched btchip-python in non-deterministic requirements-hw.txt.
Thu, Mar 13, 09:52
PiRK requested review of D17796: [electrum] bump hidapi and remove --only-binary workaround.
Thu, Mar 13, 09:46
PiRK closed D17790: [electrum] build: use pyca/cryptography release version.
Thu, Mar 13, 09:41
PiRK committed rABCe5f570af9696: [electrum] build: use pyca/cryptography release version (authored by EchterAgo).
[electrum] build: use pyca/cryptography release version
Thu, Mar 13, 09:41
PiRK added a comment to D17795: [avalanche] Use the block fitter to track the finalized txs statistics.

my review collided with an update that fixed the issue

Thu, Mar 13, 08:17
PiRK accepted D17795: [avalanche] Use the block fitter to track the finalized txs statistics.
Thu, Mar 13, 08:16
PiRK requested changes to D17795: [avalanche] Use the block fitter to track the finalized txs statistics.

This diff somehow pulls blockfitter.cpp into bitcoin-chainstate's dependencies, so you need to add it a second time in CMakeList.txt

Thu, Mar 13, 08:15
PiRK accepted D17793: Extract the block fitting logic from the block assembler logic.
Thu, Mar 13, 08:10
PiRK accepted D17792: Reset the block template in the constructor.
Thu, Mar 13, 07:55
PiRK accepted D17791: Use constants for the coinbase reserved size in the block assembler.
Thu, Mar 13, 07:52
PiRK closed D17787: [electrum] enable the Build Avalanche Proof context menu action when possible for Trezor wallets.
Thu, Mar 13, 07:46
PiRK committed rABC41118e547b70: [electrum] enable the Build Avalanche Proof context menu action when possible… (authored by PiRK).
[electrum] enable the Build Avalanche Proof context menu action when possible…
Thu, Mar 13, 07:46
PiRK updated the summary of D17787: [electrum] enable the Build Avalanche Proof context menu action when possible for Trezor wallets.
Thu, Mar 13, 07:45

Wed, Mar 12

PiRK requested review of D17790: [electrum] build: use pyca/cryptography release version.
Wed, Mar 12, 19:49
PiRK accepted D17786: [Cashtab] Patch header links to token page in extension.
Wed, Mar 12, 18:55
PiRK updated the diff for D17777: [electrum] freeze UTXOs that may contain ALP tokens.

feedback + handle case of same transaction added twice without clearing first (don't duplicate outpoints, don't even bother rescanning the transaction)

Wed, Mar 12, 18:54
PiRK requested review of D17787: [electrum] enable the Build Avalanche Proof context menu action when possible for Trezor wallets.
Wed, Mar 12, 18:40
PiRK published D17785: [electrum] install a custom version of trezorlib for review.
Wed, Mar 12, 18:23
PiRK added inline comments to D17777: [electrum] freeze UTXOs that may contain ALP tokens.
Wed, Mar 12, 16:09

Tue, Mar 11

PiRK updated the diff for D17777: [electrum] freeze UTXOs that may contain ALP tokens.

minor UI improvement (change the greyed out spend action text to tell why the coin is unspendable)

Tue, Mar 11, 20:59
PiRK updated the summary of D17777: [electrum] freeze UTXOs that may contain ALP tokens.
Tue, Mar 11, 20:50
PiRK published D17777: [electrum] freeze UTXOs that may contain ALP tokens for review.
Tue, Mar 11, 19:56

Mon, Mar 10

PiRK accepted D17771: [avalanche] Remove useless timeout in the tx finalization test.
Mon, Mar 10, 16:04
PiRK accepted D17770: [electrum] Add native eCash support for compatible Trezor One firmware.
Mon, Mar 10, 13:29

Fri, Mar 7

PiRK committed rABC3e0722f77bc2: [electrum] implement eMPP parsing (authored by PiRK).
[electrum] implement eMPP parsing
Fri, Mar 7, 15:46
PiRK closed D17760: [electrum] implement eMPP parsing.
Fri, Mar 7, 15:46
PiRK updated the diff for D17760: [electrum] implement eMPP parsing.

remove a print

Fri, Mar 7, 13:10
PiRK added inline comments to D17760: [electrum] implement eMPP parsing.
Fri, Mar 7, 13:09
PiRK updated the diff for D17760: [electrum] implement eMPP parsing.

support opcode 0x01, write more tests, find out that the op == OpCodes.OP_PUSHDATA4 branch is wrong, fix it

Fri, Mar 7, 13:08
PiRK closed D17758: [electrum] rename package slp -> tokens.
Fri, Mar 7, 12:48
PiRK closed D17759: [electrum] add copyright header to slp.py.
Fri, Mar 7, 12:48
PiRK committed rABCfd987ce15b52: [electrum] add copyright header to slp.py (authored by PiRK).
[electrum] add copyright header to slp.py
Fri, Mar 7, 12:48
PiRK committed rABC91072984102b: [electrum] rename package slp -> tokens (authored by PiRK).
[electrum] rename package slp -> tokens
Fri, Mar 7, 12:48
PiRK closed D17757: [electrum] import the slp module directly.
Fri, Mar 7, 12:48
PiRK committed rABC5d0411c26b96: [electrum] import the slp module directly (authored by PiRK).
[electrum] import the slp module directly
Fri, Mar 7, 12:48
PiRK accepted D17762: [lint patch] resolve arc lint issue.

A flynt false positive

Fri, Mar 7, 08:47

Thu, Mar 6

PiRK added inline comments to D17760: [electrum] implement eMPP parsing.
Thu, Mar 6, 17:34
PiRK added inline comments to D17760: [electrum] implement eMPP parsing.
Thu, Mar 6, 17:32
PiRK updated the diff for D17760: [electrum] implement eMPP parsing.

add tests for incorrect data length in otherwise valid succession of push ops

Thu, Mar 6, 17:28
PiRK requested review of D17760: [electrum] implement eMPP parsing.
Thu, Mar 6, 16:41
PiRK updated the diff for D17758: [electrum] rename package slp -> tokens.

make this a move only commit

Thu, Mar 6, 16:40
PiRK updated the summary of D17759: [electrum] add copyright header to slp.py.
Thu, Mar 6, 16:39
PiRK requested review of D17759: [electrum] add copyright header to slp.py.
Thu, Mar 6, 16:35
PiRK planned changes to D17758: [electrum] rename package slp -> tokens.

let's add the headers in a separate diff, so it is clear that no code was changed

Thu, Mar 6, 16:32
PiRK requested review of D17758: [electrum] rename package slp -> tokens.
Thu, Mar 6, 16:31
PiRK requested review of D17757: [electrum] import the slp module directly.
Thu, Mar 6, 16:30
PiRK closed D17753: test: adjust chainstate tests to use recognized snapshot base.
Thu, Mar 6, 09:35
PiRK committed rABC43c4d6926372: test: adjust chainstate tests to use recognized snapshot base (authored by James O'Beirne <james.obeirne@pm.me>).
test: adjust chainstate tests to use recognized snapshot base
Thu, Mar 6, 09:35

Wed, Mar 5

PiRK requested review of D17753: test: adjust chainstate tests to use recognized snapshot base.
Wed, Mar 5, 14:43

Mar 4 2025

PiRK closed D17750: index: verify blocks data existence only once.
Mar 4 2025, 14:37
PiRK closed D17749: init: don't start indexes sync thread prematurely.
Mar 4 2025, 14:37
PiRK committed rABCc7c0f9d22238: index: verify blocks data existence only once (authored by furszy <matiasfurszyfer@protonmail.com>).
index: verify blocks data existence only once
Mar 4 2025, 14:37
PiRK committed rABC4708298172e0: init: don't start indexes sync thread prematurely (authored by furszy <matiasfurszyfer@protonmail.com>).
init: don't start indexes sync thread prematurely
Mar 4 2025, 14:37
PiRK committed rABC8ec06eaff80b: make GetFirstStoredBlock assert that 'start_block' always has data (authored by furszy <matiasfurszyfer@protonmail.com>).
make GetFirstStoredBlock assert that 'start_block' always has data
Mar 4 2025, 14:37
PiRK closed D17748: refactor: simplify pruning violation check.
Mar 4 2025, 14:37
PiRK closed D17747: make GetFirstStoredBlock assert that 'start_block' always has data.
Mar 4 2025, 14:37
PiRK committed rABC8b333e573585: refactor: simplify pruning violation check (authored by furszy <matiasfurszyfer@protonmail.com>).
refactor: simplify pruning violation check
Mar 4 2025, 14:37
PiRK closed D17746: refactor: init indexes, decouple 'Start()' from the creation step.
Mar 4 2025, 14:37
PiRK closed D17745: rename 'loadblk' thread name to 'initload'.
Mar 4 2025, 14:37
PiRK committed rABCf31a5561bd77: refactor: init indexes, decouple 'Start()' from the creation step (authored by furszy <matiasfurszyfer@protonmail.com>).
refactor: init indexes, decouple 'Start()' from the creation step
Mar 4 2025, 14:37
PiRK committed rABC648994976d40: rename 'loadblk' thread name to 'initload' (authored by PiRK).
rename 'loadblk' thread name to 'initload'
Mar 4 2025, 14:37
PiRK closed D17744: init: start indexes sync earlier.
Mar 4 2025, 14:37
PiRK committed rABCd5b31e212b22: init: start indexes sync earlier (authored by furszy <matiasfurszyfer@protonmail.com>).
init: start indexes sync earlier
Mar 4 2025, 14:37
PiRK accepted D17751: [avalanche] Add the finalized transactions ancestors to the list of recently finalized items.
Mar 4 2025, 14:30
PiRK added inline comments to D17751: [avalanche] Add the finalized transactions ancestors to the list of recently finalized items.
Mar 4 2025, 13:21
PiRK updated the summary of D17750: index: verify blocks data existence only once.
Mar 4 2025, 10:32
PiRK requested review of D17750: index: verify blocks data existence only once.
Mar 4 2025, 10:22
PiRK updated the summary of D17749: init: don't start indexes sync thread prematurely.
Mar 4 2025, 10:18
PiRK requested review of D17749: init: don't start indexes sync thread prematurely.
Mar 4 2025, 10:18