Page MenuHomePhabricator
Feed All Stories

Mon, May 5

teamcity added a comment to D18050: test: Add coverage for failing dumptxoutset behavior.
Mon, May 5, 11:36
teamcity added a comment to D18050: test: Add coverage for failing dumptxoutset behavior.
Mon, May 5, 11:36
teamcity added a comment to D18050: test: Add coverage for failing dumptxoutset behavior.
Mon, May 5, 11:35
teamcity added a comment to D18050: test: Add coverage for failing dumptxoutset behavior.
Mon, May 5, 11:35
teamcity added a comment to D18050: test: Add coverage for failing dumptxoutset behavior.
Mon, May 5, 11:35
teamcity added a comment to D18049: rpc: Manage dumptxoutset rollback with RAII class.
Mon, May 5, 11:33
teamcity added a comment to D18049: rpc: Manage dumptxoutset rollback with RAII class.
Mon, May 5, 11:33
teamcity added a comment to D18049: rpc: Manage dumptxoutset rollback with RAII class.
Mon, May 5, 11:33
teamcity added a comment to D18049: rpc: Manage dumptxoutset rollback with RAII class.
Mon, May 5, 11:33
teamcity added a comment to D18049: rpc: Manage dumptxoutset rollback with RAII class.
Mon, May 5, 11:32
teamcity updated the summary of D18050: test: Add coverage for failing dumptxoutset behavior.
Mon, May 5, 11:29
PiRK requested review of D18050: test: Add coverage for failing dumptxoutset behavior.
Mon, May 5, 11:29
teamcity updated the summary of D18049: rpc: Manage dumptxoutset rollback with RAII class.
Mon, May 5, 11:27
PiRK requested review of D18049: rpc: Manage dumptxoutset rollback with RAII class.
Mon, May 5, 11:27
teamcity updated the summary of D18048: rpc, refactor: Prevent potential race conditions in dumptxoutset.
Mon, May 5, 11:25
PiRK requested review of D18048: rpc, refactor: Prevent potential race conditions in dumptxoutset.
Mon, May 5, 11:25
teamcity updated the summary of D18047: RPC: Add type parameter to dumptxoutset.
Mon, May 5, 11:23
PiRK requested review of D18047: RPC: Add type parameter to dumptxoutset.
Mon, May 5, 11:23
Fabien requested review of D18046: [avalanche] Don't poll for txs below -blockmintxfee.
Mon, May 5, 09:50
alitayin requested review of D18041: [Cashtab] Set ConnectionStrategy.ClosestFirst for initialization.

I tried shortening the timeout to 500ms and performed some tests. I found that the selection strategy doesn't slow down the user's startup experience; instead, it might make it faster. The user's actual complete loading occurs when the "loading" state disappears, which is loadCashtabState in useWallet.ts. Through adding a timer for simple testing, taking my Hong Kong IP as an example, useWallet.ts:969 shows Cashtab startup duration: 2583ms. This is the time actually perceived by users. However, when using the "selection strategy" and changing the timeout from 1000ms to 500ms, the test result is 620ms for Cashtab startup duration. Therefore, finding a faster node within 500ms and establishing a connection is often faster than choosing a default one. Furthermore, this 500ms could potentially be adjusted to 400ms or 300ms, meaning "if we can't find a faster node within 300-400ms, it doesn't matter anymore." WebSocket connection establishment speed is 2-3 times that of ping, and it's easy to prove through testing that lower WebSocket latency means lower query latency.

Mon, May 5, 04:37

Sun, May 4

abc-bot committed rABC6be43a111ee5: [Automated] Update seeds (authored by abc-bot).
[Automated] Update seeds
Sun, May 4, 21:16
abc-bot committed rABC22ef0239fcd1: [Automated] Update chainparams (authored by abc-bot).
[Automated] Update chainparams
Sun, May 4, 21:09
abc-bot committed rABCdebbcf40d542: [Automated] Update timing.json (authored by abc-bot).
[Automated] Update timing.json
Sun, May 4, 20:38
bytesofman closed D18045: [Cashtab] Improve performance of flaky test by waiting for async text to appear.
Sun, May 4, 18:15
bytesofman committed rABC48746aa130e5: [Cashtab] Improve performance of flaky test by waiting for async text to appear (authored by bytesofman).
[Cashtab] Improve performance of flaky test by waiting for async text to appear
Sun, May 4, 18:15
Fabien accepted D18045: [Cashtab] Improve performance of flaky test by waiting for async text to appear.
Sun, May 4, 18:05
bytesofman published D18045: [Cashtab] Improve performance of flaky test by waiting for async text to appear for review.
Sun, May 4, 18:02
bytesofman committed rABC88d6844da3f2: [Cashtab] Load FIRMA agora page with price in fiat instead of XEC (authored by bytesofman).
[Cashtab] Load FIRMA agora page with price in fiat instead of XEC
Sun, May 4, 03:22
bytesofman closed D18044: [Cashtab] Load FIRMA agora page with price in fiat instead of XEC.
Sun, May 4, 03:22
alitayin added a comment to D18041: [Cashtab] Set ConnectionStrategy.ClosestFirst for initialization.

My view is that this approach is worthwhile.

Sun, May 4, 02:16
emack accepted D18044: [Cashtab] Load FIRMA agora page with price in fiat instead of XEC.
Sun, May 4, 02:14
teamcity added a comment to D18044: [Cashtab] Load FIRMA agora page with price in fiat instead of XEC.

Build Bitcoin ABC Diffs / Diff Testing (preview-cashtab) passed.
Preview is available at http://51.68.37.192:41160 for the next 60 minutes.

Sun, May 4, 02:06
teamcity awarded D18044: [Cashtab] Load FIRMA agora page with price in fiat instead of XEC a Haypence token.
Sun, May 4, 02:03
emack added a comment to D18044: [Cashtab] Load FIRMA agora page with price in fiat instead of XEC.

@bot preview-cashtab

Sun, May 4, 02:03

Sat, May 3

bytesofman requested changes to D18041: [Cashtab] Set ConnectionStrategy.ClosestFirst for initialization.

at the moment this is not worth implementing in cashtab

Sat, May 3, 22:59
bytesofman published D18044: [Cashtab] Load FIRMA agora page with price in fiat instead of XEC for review.
Sat, May 3, 22:55
teamcity closed T3815: Build Bitcoin-ABC / Master / Native tests / Test Native OSX is broken. as Resolved.
Sat, May 3, 22:36
PiRK closed D18043: test: fix flaky p2p_leak.
Sat, May 3, 22:27
PiRK committed rABC248a9df83c67: test: fix flaky p2p_leak (authored by PiRK).
test: fix flaky p2p_leak
Sat, May 3, 22:27
Fabien accepted D18043: test: fix flaky p2p_leak.
Sat, May 3, 20:23
PiRK updated the summary of D18043: test: fix flaky p2p_leak.
Sat, May 3, 19:55
PiRK requested review of D18043: test: fix flaky p2p_leak.
Sat, May 3, 19:54

Fri, May 2

teamcity added a comment to D17822: [ecash-wallet] Add fluent API for building and broadcasting txs.
Fri, May 2, 23:55
bytesofman planned changes to D17822: [ecash-wallet] Add fluent API for building and broadcasting txs.

regtest handles basic cases for SLP and ALP now. Next up is cleaning up debug logs, function names, adding unit tests for untested functions.

Fri, May 2, 23:54
bytesofman updated the diff for D17822: [ecash-wallet] Add fluent API for building and broadcasting txs.

rebase, get regtest working with SLP and ALP. NB we still have lots of cleaning up and other tests to add.

Fri, May 2, 23:53
teamcity triaged T3815: Build Bitcoin-ABC / Master / Native tests / Test Native OSX is broken. as Unbreak Now! priority.
Fri, May 2, 22:03
PiRK closed D18002: validation: mark blocks building on an invalid block as having failed parents.
Fri, May 2, 21:49
PiRK committed rABC93fea30e948f: validation: mark blocks building on an invalid block as having failed parents (authored by Martin Zumsande <mzumsande@gmail.com>).
validation: mark blocks building on an invalid block as having failed parents
Fri, May 2, 21:49
PiRK closed D18042: bugfix: the end of a reorged chain is invalid when connect fails.
Fri, May 2, 21:49
PiRK committed rABC44bc22686223: bugfix: the end of a reorged chain is invalid when connect fails (authored by Pieter Wuille <pieter.wuille@gmail.com>).
bugfix: the end of a reorged chain is invalid when connect fails
Fri, May 2, 21:49
Fabien accepted D18002: validation: mark blocks building on an invalid block as having failed parents.
Fri, May 2, 21:18
Fabien accepted D18042: bugfix: the end of a reorged chain is invalid when connect fails.
Fri, May 2, 20:54
PiRK updated the diff for D18002: validation: mark blocks building on an invalid block as having failed parents.

rebase on bugfix

Fri, May 2, 16:24
PiRK updated the diff for D18042: bugfix: the end of a reorged chain is invalid when connect fails.

rebase

Fri, May 2, 16:23
PiRK closed D18000: validation: call RecalculateBestHeader in InvalidChainFound.
Fri, May 2, 16:21
PiRK committed rABCacc1b2899fa6: validation: call RecalculateBestHeader in InvalidChainFound (authored by Martin Zumsande <mzumsande@gmail.com>).
validation: call RecalculateBestHeader in InvalidChainFound
Fri, May 2, 16:21
PiRK closed D17999: rpc: call RecalculateBestHeader as part of reconsiderblock.
Fri, May 2, 16:21
PiRK committed rABC0b7dc1ed016e: rpc: call RecalculateBestHeader as part of reconsiderblock (authored by Martin Zumsande <mzumsande@gmail.com>).
rpc: call RecalculateBestHeader as part of reconsiderblock
Fri, May 2, 16:21
PiRK closed D17998: RPC: Extract InvalidateBlock and ReconsiderBlock helpers.
Fri, May 2, 16:21
PiRK committed rABC913404a4fb9c: RPC: Extract InvalidateBlock and ReconsiderBlock helpers (authored by Fabian Jahr <fjahr@protonmail.com>).
RPC: Extract InvalidateBlock and ReconsiderBlock helpers
Fri, May 2, 16:21
teamcity updated the summary of D18042: bugfix: the end of a reorged chain is invalid when connect fails.
Fri, May 2, 16:18
PiRK requested review of D18042: bugfix: the end of a reorged chain is invalid when connect fails.
Fri, May 2, 16:18
alitayin added inline comments to D18041: [Cashtab] Set ConnectionStrategy.ClosestFirst for initialization.
Fri, May 2, 00:28
emack added inline comments to D18041: [Cashtab] Set ConnectionStrategy.ClosestFirst for initialization.
Fri, May 2, 00:12

Thu, May 1

teamcity added a comment to D18041: [Cashtab] Set ConnectionStrategy.ClosestFirst for initialization.

Build Bitcoin ABC Diffs / Diff Testing (preview-cashtab) passed.
Preview is available at http://51.89.41.69:41339 for the next 60 minutes.

Thu, May 1, 20:20
teamcity awarded D18041: [Cashtab] Set ConnectionStrategy.ClosestFirst for initialization a Haypence token.
Thu, May 1, 20:08
Fabien added a comment to D18041: [Cashtab] Set ConnectionStrategy.ClosestFirst for initialization.

@bot preview-cashtab

Thu, May 1, 20:08
Fabien closed D18004: [avalanche] Delay polling the conflicting transactions.
Thu, May 1, 20:03
Fabien committed rABCfa8168048c22: [avalanche] Delay polling the conflicting transactions (authored by Fabien).
[avalanche] Delay polling the conflicting transactions
Thu, May 1, 20:03
alitayin requested review of D18041: [Cashtab] Set ConnectionStrategy.ClosestFirst for initialization.
Thu, May 1, 20:02
roqqit abandoned D18003: [avalanche] Fix incomplete testing of contenders when staking rewards are active.

see D18036

Thu, May 1, 19:37
roqqit accepted D18004: [avalanche] Delay polling the conflicting transactions.

I see

Thu, May 1, 19:36
teamcity closed T3811: Build Bitcoin-ABC / Master / Default Extended Tests is broken. as Resolved.
Thu, May 1, 19:15
teamcity closed T3810: Build Bitcoin-ABC / Master / Coverage is broken. as Resolved.
Thu, May 1, 19:07
roqqit closed D18036: [avalanche] Fix incomplete testing of contenders when staking rewards are active.
Thu, May 1, 18:22
roqqit committed rABC029da727864b: [avalanche] Fix incomplete testing of contenders when staking rewards are active (authored by Fabien).
[avalanche] Fix incomplete testing of contenders when staking rewards are active
Thu, May 1, 18:22
Fabien accepted D18036: [avalanche] Fix incomplete testing of contenders when staking rewards are active.
Thu, May 1, 18:04
teamcity awarded D18036: [avalanche] Fix incomplete testing of contenders when staking rewards are active a Doubloon token.
Thu, May 1, 17:30
Fabien added a comment to D18036: [avalanche] Fix incomplete testing of contenders when staking rewards are active.

@bot build-master

Thu, May 1, 17:30
roqqit updated the diff for D18036: [avalanche] Fix incomplete testing of contenders when staking rewards are active.

cleanup remaining issues from old draft

Thu, May 1, 17:25
roqqit commandeered D18036: [avalanche] Fix incomplete testing of contenders when staking rewards are active.
Thu, May 1, 17:24
Fabien planned changes to D18036: [avalanche] Fix incomplete testing of contenders when staking rewards are active.
Thu, May 1, 16:39
Fabien updated the diff for D18036: [avalanche] Fix incomplete testing of contenders when staking rewards are active.

Rebase

Thu, May 1, 16:38
Fabien committed rABC19fd8b8c6ea2: [test] Assert the exact list of contenders to be polled in… (authored by Fabien).
[test] Assert the exact list of contenders to be polled in…
Thu, May 1, 16:38
Fabien closed D18033: [test] Assert the exact list of contenders to be polled in abc_p2p_avalanche_contender_voting.
Thu, May 1, 16:38
Fabien closed D18040: [test] Only activate the quorum after all the peers are connected.
Thu, May 1, 16:38
Fabien closed D18039: [test] Finalize the tip when possible in abc_p2p_avalanche_contender_voting.
Thu, May 1, 16:38
Fabien committed rABC895953381351: [test] Finalize the tip when possible in abc_p2p_avalanche_contender_voting (authored by Fabien).
[test] Finalize the tip when possible in abc_p2p_avalanche_contender_voting
Thu, May 1, 16:38
Fabien committed rABCf12eb8ee2200: [test] Only activate the quorum after all the peers are connected (authored by Fabien).
[test] Only activate the quorum after all the peers are connected
Thu, May 1, 16:38
Fabien closed D18038: [test] Vote unknown for the elements we don't care in abc_p2p_avalanche_contender_voting.
Thu, May 1, 16:38
Fabien committed rABC126377f4b3a5: [test] Vote unknown for the elements we don't care in… (authored by Fabien).
[test] Vote unknown for the elements we don't care in…
Thu, May 1, 16:38
Fabien closed D18037: [test] Don't assume the proof score in abc_p2p_avalanche_contender_voting.
Thu, May 1, 16:38
Fabien committed rABCb8ea7cea73de: [test] Don't assume the proof score in abc_p2p_avalanche_contender_voting (authored by Fabien).
[test] Don't assume the proof score in abc_p2p_avalanche_contender_voting
Thu, May 1, 16:38
roqqit requested changes to D18036: [avalanche] Fix incomplete testing of contenders when staking rewards are active.
Thu, May 1, 16:11
roqqit accepted D18033: [test] Assert the exact list of contenders to be polled in abc_p2p_avalanche_contender_voting.
Thu, May 1, 16:04
roqqit accepted D18040: [test] Only activate the quorum after all the peers are connected.
Thu, May 1, 15:58
roqqit accepted D18039: [test] Finalize the tip when possible in abc_p2p_avalanche_contender_voting.
Thu, May 1, 15:57
roqqit accepted D18038: [test] Vote unknown for the elements we don't care in abc_p2p_avalanche_contender_voting.
Thu, May 1, 15:53
roqqit accepted D18037: [test] Don't assume the proof score in abc_p2p_avalanche_contender_voting.
Thu, May 1, 15:52
Fabien updated the diff for D18004: [avalanche] Delay polling the conflicting transactions.

Rebase

Thu, May 1, 15:29