Page MenuHomePhabricator
Feed All Stories

All Stories
Use Results
Edit Query

Wed, May 7

Fabien committed rABCc5564148fabb: Add missing cstdint header (authored by Fabien).
Add missing cstdint header
Wed, May 7, 16:57
PiRK accepted D18062: Add missing cstdint header.
Wed, May 7, 16:57
Fabien accepted D18060: assumeutxo: Drop block height from metadata.
Wed, May 7, 16:43
Fabien accepted D18059: validation: Don't load a snapshot if it's not in the best header chain..
Wed, May 7, 16:40
Fabien updated the diff for D18062: Add missing cstdint header.

More missing cstdint

Wed, May 7, 15:58
Fabien planned changes to D18062: Add missing cstdint header.
Wed, May 7, 15:35
Fabien retitled D18062: Add missing cstdint header from Add missing header in chainparamsbase.h to Add missing cstdint header.
Wed, May 7, 15:31
Fabien requested review of D18062: Add missing cstdint header.
Wed, May 7, 14:55
PiRK updated the summary of D18060: assumeutxo: Drop block height from metadata.
Wed, May 7, 13:55
PiRK added inline comments to D18060: assumeutxo: Drop block height from metadata.
Wed, May 7, 13:49
teamcity updated the summary of D18060: assumeutxo: Drop block height from metadata.
Wed, May 7, 13:45
PiRK requested review of D18060: assumeutxo: Drop block height from metadata.
Wed, May 7, 13:44
teamcity updated the summary of D18059: validation: Don't load a snapshot if it's not in the best header chain..
Wed, May 7, 13:43
PiRK requested review of D18059: validation: Don't load a snapshot if it's not in the best header chain..
Wed, May 7, 13:43
PiRK closed D18056: assumeutxo: Check snapshot base block is not marked invalid.
Wed, May 7, 13:04
PiRK committed rABC864d8bb7714c: assumeutxo: Check snapshot base block is not marked invalid (authored by Fabian Jahr <fjahr@protonmail.com>).
assumeutxo: Check snapshot base block is not marked invalid
Wed, May 7, 13:04
PiRK closed D18055: refactor: Move early loadtxoutset checks into ActiveSnapshot.
Wed, May 7, 13:04
PiRK committed rABCef4fb8890310: refactor: Move early loadtxoutset checks into ActiveSnapshot (authored by MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>).
refactor: Move early loadtxoutset checks into ActiveSnapshot
Wed, May 7, 13:04
Fabien closed D18058: Bump version to 0.31.3.
Wed, May 7, 12:53
Fabien committed rABC25f6ba3d50dd: Bump version to 0.31.3 (authored by Fabien).
Bump version to 0.31.3
Wed, May 7, 12:53
PiRK accepted D18058: Bump version to 0.31.3.
Wed, May 7, 12:53
tobias_ruck requested changes to D17928: [chronik] Add address.rs from givelotus/bitcoinsuite into bitcoinsuite-chronik-client.
Wed, May 7, 12:18
hazzarust updated the diff for D17928: [chronik] Add address.rs from givelotus/bitcoinsuite into bitcoinsuite-chronik-client.

lint

Wed, May 7, 12:16
hazzarust updated the diff for D17928: [chronik] Add address.rs from givelotus/bitcoinsuite into bitcoinsuite-chronik-client.

Updated documentation, changed to_cash_addr to take AddressType

Wed, May 7, 12:11
bytesofman closed D18057: [ecash-lib] Add parseEmppScript method.
Wed, May 7, 11:23
bytesofman committed rABCab3fcc0da679: [ecash-lib] Add parseEmppScript method (authored by bytesofman).
[ecash-lib] Add parseEmppScript method
Wed, May 7, 11:23
Fabien requested review of D18058: Bump version to 0.31.3.
Wed, May 7, 09:43
Fabien accepted D18056: assumeutxo: Check snapshot base block is not marked invalid.
Wed, May 7, 09:39
Fabien accepted D18055: refactor: Move early loadtxoutset checks into ActiveSnapshot.
Wed, May 7, 09:39
tobias_ruck accepted D18057: [ecash-lib] Add parseEmppScript method.
Wed, May 7, 09:18

Tue, May 6

bytesofman updated the diff for D18057: [ecash-lib] Add parseEmppScript method.

function doc

Tue, May 6, 22:06
tobias_ruck requested changes to D18057: [ecash-lib] Add parseEmppScript method.
Tue, May 6, 21:51
bytesofman published D18057: [ecash-lib] Add parseEmppScript method for review.
Tue, May 6, 21:49
PiRK updated the summary of D18056: assumeutxo: Check snapshot base block is not marked invalid.
Tue, May 6, 20:30
teamcity updated the summary of D18056: assumeutxo: Check snapshot base block is not marked invalid.
Tue, May 6, 20:29
PiRK requested review of D18056: assumeutxo: Check snapshot base block is not marked invalid.
Tue, May 6, 20:29
teamcity updated the summary of D18055: refactor: Move early loadtxoutset checks into ActiveSnapshot.
Tue, May 6, 20:29
PiRK requested review of D18055: refactor: Move early loadtxoutset checks into ActiveSnapshot.
Tue, May 6, 20:29
PiRK closed D18053: rpc: Avoid getchaintxstats invalid results.
Tue, May 6, 16:19
PiRK committed rABCb78399611ae6: rpc: Avoid getchaintxstats invalid results (authored by MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>).
rpc: Avoid getchaintxstats invalid results
Tue, May 6, 16:19
Fabien accepted D18053: rpc: Avoid getchaintxstats invalid results.
Tue, May 6, 15:29
PiRK closed D18054: test: add a --repeat argument to test_runner.py.
Tue, May 6, 14:58
PiRK committed rABC5c43c94353ca: test: add a --repeat argument to test_runner.py (authored by PiRK).
test: add a --repeat argument to test_runner.py
Tue, May 6, 14:58
PiRK updated the diff for D18053: rpc: Avoid getchaintxstats invalid results.

give up on using std::optional

Tue, May 6, 14:53
Fabien accepted D18054: test: add a --repeat argument to test_runner.py.
Tue, May 6, 14:51
teamcity added a comment to D18053: rpc: Avoid getchaintxstats invalid results.
Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.
Tue, May 6, 14:31
teamcity added a comment to D18053: rpc: Avoid getchaintxstats invalid results.
Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.
Tue, May 6, 14:30
PiRK updated the diff for D18053: rpc: Avoid getchaintxstats invalid results.

try a copy

Tue, May 6, 14:27
teamcity added a comment to D18053: rpc: Avoid getchaintxstats invalid results.
Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.
Tue, May 6, 14:22
teamcity added a comment to D18053: rpc: Avoid getchaintxstats invalid results.
Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.
Tue, May 6, 14:21
PiRK updated the diff for D18053: rpc: Avoid getchaintxstats invalid results.

try another workaround

Tue, May 6, 14:19
PiRK added a comment to D18054: test: add a --repeat argument to test_runner.py.
In D18054#411619, @Fabien wrote:

Nice ! Should --repeat also imply --failfast ? What do you think ?

Tue, May 6, 13:54
Fabien added a comment to D18054: test: add a --repeat argument to test_runner.py.

Nice ! Should --repeat also imply --failfast ? What do you think ?

Tue, May 6, 12:52
Fabien requested changes to D18053: rpc: Avoid getchaintxstats invalid results.

clearing my queue

Tue, May 6, 12:49
teamcity added a comment to D18053: rpc: Avoid getchaintxstats invalid results.
Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.
Tue, May 6, 11:19
teamcity added a comment to D18053: rpc: Avoid getchaintxstats invalid results.
Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.
Tue, May 6, 11:18
PiRK updated the diff for D18053: rpc: Avoid getchaintxstats invalid results.

workaround for false-positive -Werror=maybe-uninitialized: try opt.value() instead of *opt

Tue, May 6, 11:17
PiRK planned changes to D18053: rpc: Avoid getchaintxstats invalid results.
Tue, May 6, 11:00
PiRK requested review of D18054: test: add a --repeat argument to test_runner.py.
Tue, May 6, 10:58
teamcity added a comment to D18053: rpc: Avoid getchaintxstats invalid results.
Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.
Tue, May 6, 10:31
teamcity added a comment to D18053: rpc: Avoid getchaintxstats invalid results.
Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.
Tue, May 6, 10:30
teamcity updated the summary of D18053: rpc: Avoid getchaintxstats invalid results.
Tue, May 6, 10:29
PiRK requested review of D18053: rpc: Avoid getchaintxstats invalid results.
Tue, May 6, 10:28
PiRK closed D18052: [electrum] wrap the error message when exchange rate API fails.
Tue, May 6, 09:01
PiRK committed rABCc362a890c708: [electrum] wrap the error message when exchange rate API fails (authored by PiRK).
[electrum] wrap the error message when exchange rate API fails
Tue, May 6, 09:01
Fabien accepted D18052: [electrum] wrap the error message when exchange rate API fails.
Tue, May 6, 08:00
PiRK requested review of D18052: [electrum] wrap the error message when exchange rate API fails.
Tue, May 6, 06:56
aidenbrooks00 updated aidenbrooks00.
Tue, May 6, 02:41
aidenbrooks00 updated aidenbrooks00.
Tue, May 6, 02:41
aidenbrooks00 updated aidenbrooks00.
Tue, May 6, 02:39
alitayin closed D18041: [Cashtab] Set ConnectionStrategy.ClosestFirst for initialization.
Tue, May 6, 02:08
alitayin committed rABC973fbe8030ca: [Cashtab] Set ConnectionStrategy.ClosestFirst for initialization (authored by alitayin).
[Cashtab] Set ConnectionStrategy.ClosestFirst for initialization
Tue, May 6, 02:08

Mon, May 5

bytesofman updated the summary of D17822: [ecash-wallet] Add fluent API for building and broadcasting txs.
Mon, May 5, 22:17
bytesofman updated the diff for D17822: [ecash-wallet] Add fluent API for building and broadcasting txs.

lint

Mon, May 5, 22:13
bytesofman updated the diff for D17822: [ecash-wallet] Add fluent API for building and broadcasting txs.

cleaned up, mvp

Mon, May 5, 22:12
PiRK closed D18050: test: Add coverage for failing dumptxoutset behavior.
Mon, May 5, 14:55
PiRK committed rABC0ed1bd0f3755: test: Add coverage for failing dumptxoutset behavior (authored by Fabian Jahr <fjahr@protonmail.com>).
test: Add coverage for failing dumptxoutset behavior
Mon, May 5, 14:55
PiRK closed D18049: rpc: Manage dumptxoutset rollback with RAII class.
Mon, May 5, 14:54
PiRK committed rABC7acba5eca425: rpc: Manage dumptxoutset rollback with RAII class (authored by Fabian Jahr <fjahr@protonmail.com>).
rpc: Manage dumptxoutset rollback with RAII class
Mon, May 5, 14:54
PiRK closed D18048: rpc, refactor: Prevent potential race conditions in dumptxoutset.
Mon, May 5, 14:54
PiRK committed rABC8451d333629f: rpc, refactor: Prevent potential race conditions in dumptxoutset (authored by Fabian Jahr <fjahr@protonmail.com>).
rpc, refactor: Prevent potential race conditions in dumptxoutset
Mon, May 5, 14:54
PiRK closed D18047: RPC: Add type parameter to dumptxoutset.
Mon, May 5, 14:54
PiRK committed rABCd2078ef2efd2: RPC: Add type parameter to dumptxoutset (authored by Fabian Jahr <fjahr@protonmail.com>).
RPC: Add type parameter to dumptxoutset
Mon, May 5, 14:54
PiRK updated the diff for D18050: test: Add coverage for failing dumptxoutset behavior.

check that the blockchain is restored after the temporary rollback

Mon, May 5, 14:38
PiRK closed D18051: test: fix another intermittent fault in p2p_leak.
Mon, May 5, 14:15
PiRK committed rABC7c5b0ee93f30: test: fix another intermittent fault in p2p_leak (authored by PiRK).
test: fix another intermittent fault in p2p_leak
Mon, May 5, 14:15
Fabien accepted D18051: test: fix another intermittent fault in p2p_leak.
Mon, May 5, 14:03
PiRK requested review of D18051: test: fix another intermittent fault in p2p_leak.
Mon, May 5, 13:53
Fabien accepted D18050: test: Add coverage for failing dumptxoutset behavior.
Mon, May 5, 13:47
Fabien added inline comments to D18050: test: Add coverage for failing dumptxoutset behavior.
Mon, May 5, 13:43
Fabien accepted D18049: rpc: Manage dumptxoutset rollback with RAII class.
Mon, May 5, 13:41
Fabien accepted D18048: rpc, refactor: Prevent potential race conditions in dumptxoutset.
Mon, May 5, 13:39
Fabien accepted D18047: RPC: Add type parameter to dumptxoutset.
Mon, May 5, 13:36
bytesofman accepted D18041: [Cashtab] Set ConnectionStrategy.ClosestFirst for initialization.

My main objection here

Mon, May 5, 12:58
Fabien closed D18046: [avalanche] Don't poll for txs below -blockmintxfee.
Mon, May 5, 12:28
Fabien committed rABCcb73d05ae251: [avalanche] Don't poll for txs below -blockmintxfee (authored by Fabien).
[avalanche] Don't poll for txs below -blockmintxfee
Mon, May 5, 12:28
PiRK updated the diff for D18050: test: Add coverage for failing dumptxoutset behavior.

rebase

Mon, May 5, 12:15
PiRK updated the diff for D18049: rpc: Manage dumptxoutset rollback with RAII class.

fix -Werror=reorder warning

Mon, May 5, 12:13
PiRK planned changes to D18049: rpc: Manage dumptxoutset rollback with RAII class.
Mon, May 5, 12:11
PiRK accepted D18046: [avalanche] Don't poll for txs below -blockmintxfee.
Mon, May 5, 12:10
First
Prev
Next