Rebase and address comments
Feed Advanced Search
Jun 25 2019
Jun 25 2019
deadalnix added a comment to D3394: wallet: Switch to using output groups instead of coins in coin selection.
deadalnix added inline comments to D3394: wallet: Switch to using output groups instead of coins in coin selection.
deadalnix added a comment to D3393: wallet: Add output grouping.
Backport bugfix from PR13805
deadalnix updated the summary of D3393: wallet: Add output grouping.
D3371: fix BIP37 processing for non-topologically ordered blocks is now accepted and ready to land.
deadalnix added a comment to D2980: Merge #12287: Optimise lock behaviour for GuessVerificationProgress().
This is when I point out that CI dosn't run debug, or maybe it does, who knows. So I don't know if this is a giant regression or if the comment mention a fix that don't need fixing or what.
D3408: Merge #10789: Punctuation/grammer fixes in rpcwallet.cpp is now accepted and ready to land.
D3406: Merge #9750: Bloomfilter: parameter variables made constant is now accepted and ready to land.
D3407: Merge #10432: [Trivial] Add BITCOIN_FS_H endif footer in fs.h is now accepted and ready to land.
Jun 24 2019
Jun 24 2019
deadalnix committed rABC0cb6aa009058: Speedup coinselector_tests by using a dummy WalletDBWrapper when apropriate (authored by deadalnix).
Speedup coinselector_tests by using a dummy WalletDBWrapper when apropriate
deadalnix committed rABC740a33e83f89: Actually disable BnB when there are preset inputs (authored by Andrew Chow <achow101-github@achow101.com>).
Actually disable BnB when there are preset inputs
deadalnix committed rABCe45beabef48d: Fix Clang Static Analyzer warnings (authored by practicalswift <practicalswift@users.noreply.github.com>).
Fix Clang Static Analyzer warnings
deadalnix committed rABCafc4447ef4ef: wallet: Make fee settings non-static members (authored by MarcoFalke <falke.marco@gmail.com>).
wallet: Make fee settings non-static members
deadalnix added a comment to D3364: wallet: Make fee settings non-static members.
Remove comment
D3399: unsigned int -> size_t in merkleblock-related code is now accepted and ready to land.
deadalnix committed rABCac9f7d12da63: wallet: Add input bytes to CInputCoin (authored by Karl-Johan Alm <karljohan-alm@garage.co.jp>).
wallet: Add input bytes to CInputCoin
deadalnix committed rABC19826e3b8f8b: moveonly: CoinElegibilityFilter into coinselection.h (authored by Karl-Johan Alm <karljohan-alm@garage.co.jp>).
moveonly: CoinElegibilityFilter into coinselection.h
deadalnix committed rABCb16cdc104c73: utils: Add insert() convenience templates (authored by Karl-Johan Alm <karljohan-alm@garage.co.jp>).
utils: Add insert() convenience templates
Jun 23 2019
Jun 23 2019
D3363: [CMAKE] Build checkblock benchmark now requires changes to proceed.
Jun 22 2019
Jun 22 2019
D3371: fix BIP37 processing for non-topologically ordered blocks now requires changes to proceed.
deadalnix updated the summary of D3394: wallet: Switch to using output groups instead of coins in coin selection.
deadalnix added inline comments to D3378: Actually disable BnB when there are preset inputs.
deadalnix added a comment to D3253: Remove Schnorr activation.
Wait, does that pass IBD? There may be some problem with the sigops count. Please double check before landing.
D3380: Merge #12250: Make CKey::Load references const is now accepted and ready to land.
D3318: [LINTER] Prevent including a source file is now accepted and ready to land.
D3365: Merge #8498: Near-Bugfix: Optimization: Minimize the number of times it is checked that no money... is now accepted and ready to land.
D3384: Merge #10228: build: regenerate bitcoin-config.h as necessary is now accepted and ready to land.
D3386: Merge #10196: Bugfix: PrioritiseTransaction updates the mempool tx counter is now accepted and ready to land.
Jun 21 2019
Jun 21 2019
deadalnix committed rABC278e8f83d10d: Remove unecessary include of boost/version (authored by deadalnix).
Remove unecessary include of boost/version
D3376: Merge #11237: qt: Fixing division by zero in time remaining is now accepted and ready to land.
D3365: Merge #8498: Near-Bugfix: Optimization: Minimize the number of times it is checked that no money... now requires changes to proceed.
deadalnix added a comment to D3364: wallet: Make fee settings non-static members.
Rebase and remove redundant forward declaration
Jun 20 2019
Jun 20 2019
D3114: De-witnessing some comments is now accepted and ready to land.
D3365: Merge #8498: Near-Bugfix: Optimization: Minimize the number of times it is checked that no money... now requires changes to proceed.
A small change, but otherwise, LGTM.
Jun 19 2019
Jun 19 2019
deadalnix added a comment to D3364: wallet: Make fee settings non-static members.
Rebase
deadalnix committed rABC04dacad3085c: [refactor] Make TransactionWithinChainLimit more flexible (authored by Karl-Johan Alm <karljohan-alm@garage.co.jp>).
[refactor] Make TransactionWithinChainLimit more flexible
Jun 18 2019
Jun 18 2019
deadalnix added a comment to D3343: [refactor] Make TransactionWithinChainLimit more flexible.
GetHash => GetId
deadalnix added a comment to D3283: Merge #10408, #13291, and partial #13163.
There are no explanation as to why the squash is necessary in the link you provided nor in your comment.
D3354: Clarify include guard naming convention is now accepted and ready to land.
Restore CWallet::minTxFee
deadalnix committed rABCe389a8cb3527: bench: Simplify CoinSelection (authored by João Barbosa <joao.paulo.barbosa@gmail.com>).
bench: Simplify CoinSelection
deadalnix retitled D3353: Restore CWallet::minTxFee from Restor CWallet::minTxFee to Restore CWallet::minTxFee.
deadalnix committed rABC25eb9b97fd71: Add a test to make sure that negative effective values are filtered (authored by Andrew Chow <achow101-github@achow101.com>).
Add a test to make sure that negative effective values are filtered
deadalnix committed rABC167773c1432d: Have SelectCoinsMinConf and SelectCoins use BnB or Knapsack and use it (authored by Andrew Chow <achow101-github@achow101.com>).
Have SelectCoinsMinConf and SelectCoins use BnB or Knapsack and use it
deadalnix committed rABC0d8923573d99: tests: Avoid copies of CTransaction (authored by MarcoFalke <falke.marco@gmail.com>).
tests: Avoid copies of CTransaction
Jun 17 2019
Jun 17 2019
deadalnix committed rABC80d081077dc0: Use mempool's descendent count in the wallet code (authored by Karl-Johan Alm <karljohan-alm@garage.co.jp>).
Use mempool's descendent count in the wallet code
Restore minRelayTxFee
deadalnix committed rABC1f83114372e2: Implement getRequiredFee in the node interface and use it (authored by deadalnix).
Implement getRequiredFee in the node interface and use it
deadalnix added a comment to D3336: tests: Avoid copies of CTransaction.
Fix mempool_tests.cpp , Fix comment saying +2 when +3 is relevent.
deadalnix added inline comments to D3336: tests: Avoid copies of CTransaction.
deadalnix added a comment to D3301: Have SelectCoinsMinConf and SelectCoins use BnB or Knapsack and use it.
Remove witness overhead
deadalnix requested review of D3342: Use mempool's descendent count in the wallet code.
deadalnix committed rABC79d37414f1ac: Dead code removal (authored by Thomas Snider <tjps636@gmail.com>).
Dead code removal
D3253: Remove Schnorr activation now requires changes to proceed.
Jun 16 2019
Jun 16 2019
D3351: Fix lock reference in miner.h is now accepted and ready to land.
D3335: [LINTER] Make the check-doc linter run only once now requires changes to proceed.
I'll need more time to actually review this, but it's clear that the API is not what you'd expect.