Page MenuHomePhabricator
Feed All Stories

Sep 20 2024

Fabien planned changes to D16791: Store the last 20 headers reception time to a file.

The option should not be hidden

Sep 20 2024, 20:22
teamcity closed T3632: Build Bitcoin-ABC / Master / Default Extended Tests is broken. as Resolved.
Sep 20 2024, 17:45
roqqit closed D16793: [avalanche] Use block index instead of blockhash for adding contenders to the cache.
Sep 20 2024, 16:57
roqqit committed rABCb5fe46c6e31d: [avalanche] Use block index instead of blockhash for adding contenders to the… (authored by roqqit).
[avalanche] Use block index instead of blockhash for adding contenders to the…
Sep 20 2024, 16:57
roqqit closed D16792: [avalanche] Cleanup unneeded variable in contender cache test.
Sep 20 2024, 16:57
roqqit committed rABCe686b296e89b: [avalanche] Cleanup unneeded variable in contender cache test (authored by roqqit).
[avalanche] Cleanup unneeded variable in contender cache test
Sep 20 2024, 16:56
teamcity triaged T3632: Build Bitcoin-ABC / Master / Default Extended Tests is broken. as Unbreak Now! priority.
Sep 20 2024, 16:26
teamcity updated the summary of D16798: p2p: Ensure transaction announcements are only queued for fully connected peers.
Sep 20 2024, 15:54
PiRK requested review of D16798: p2p: Ensure transaction announcements are only queued for fully connected peers.
Sep 20 2024, 15:53
johnkuney closed D16724: [explorer] add testnet toggle in menu bar.
Sep 20 2024, 15:35
johnkuney committed rABCd89ea22e29c3: [explorer] add testnet toggle in menu bar (authored by johnkuney).
[explorer] add testnet toggle in menu bar
Sep 20 2024, 15:35
teamcity updated the summary of D16797: net: Avoid SetTxRelay for feeler connections.
Sep 20 2024, 15:03
PiRK requested review of D16797: net: Avoid SetTxRelay for feeler connections.
Sep 20 2024, 15:03
teamcity updated the summary of D16796: net: Set relay in version msg to peers with relay permission.
Sep 20 2024, 14:58
PiRK requested review of D16796: net: Set relay in version msg to peers with relay permission.
Sep 20 2024, 14:58
teamcity updated the summary of D16795: refactor: Introduce PeerManagerImpl::RejectIncomingTxs.
Sep 20 2024, 14:57
PiRK requested review of D16795: refactor: Introduce PeerManagerImpl::RejectIncomingTxs.
Sep 20 2024, 14:57
teamcity awarded D16791: Store the last 20 headers reception time to a file a Piece of Eight token.
Sep 20 2024, 14:46
Fabien added a comment to D16791: Store the last 20 headers reception time to a file.

@bot build-diff

Sep 20 2024, 14:46
Fabien closed D16794: Interleave the debug.log with the unit test log when run via ninja.
Sep 20 2024, 11:36
Fabien committed rABCa7ca07264935: Interleave the debug.log with the unit test log when run via ninja (authored by Fabien).
Interleave the debug.log with the unit test log when run via ninja
Sep 20 2024, 11:36
teamcity awarded D16791: Store the last 20 headers reception time to a file a Haypence token.
Sep 20 2024, 11:34
Fabien added a comment to D16791: Store the last 20 headers reception time to a file.

@bot build-diff

Sep 20 2024, 11:34
PiRK accepted D16794: Interleave the debug.log with the unit test log when run via ninja.
Sep 20 2024, 10:13
Fabien requested changes to D16782: [avalanche] Implement cleanup for stake contender cache.

I see your test doesn't check for contiguous heights, you should add that

Sep 20 2024, 09:52
Fabien accepted D16793: [avalanche] Use block index instead of blockhash for adding contenders to the cache.
Sep 20 2024, 09:47
Fabien accepted D16792: [avalanche] Cleanup unneeded variable in contender cache test.
Sep 20 2024, 09:45
Fabien updated the diff for D16791: Store the last 20 headers reception time to a file.

Rebase on top of D16794, hopefully to test will fail

Sep 20 2024, 09:44
Fabien requested review of D16794: Interleave the debug.log with the unit test log when run via ninja.
Sep 20 2024, 09:23
Fabien added inline comments to D16791: Store the last 20 headers reception time to a file.
Sep 20 2024, 08:22
Fabien updated the diff for D16791: Store the last 20 headers reception time to a file.

Improve logging + feedback

Sep 20 2024, 08:09
roqqit requested changes to D16791: Store the last 20 headers reception time to a file.

The patch looks ok but there is a test failure

Sep 20 2024, 00:38
roqqit accepted D16791: Store the last 20 headers reception time to a file.
Sep 20 2024, 00:37
roqqit updated the diff for D16782: [avalanche] Implement cleanup for stake contender cache.

changes per feedback to remove the cs_main lock. now depends on D16793

Sep 20 2024, 00:18
roqqit requested review of D16793: [avalanche] Use block index instead of blockhash for adding contenders to the cache.
Sep 20 2024, 00:14
roqqit requested review of D16792: [avalanche] Cleanup unneeded variable in contender cache test.
Sep 20 2024, 00:10
teamcity added a comment to D16791: Store the last 20 headers reception time to a file.
Sep 20 2024, 00:02

Sep 19 2024

Fabien requested review of D16791: Store the last 20 headers reception time to a file.
Sep 19 2024, 23:41
Fabien accepted D16724: [explorer] add testnet toggle in menu bar.
Sep 19 2024, 23:33
johnkuney updated the diff for D16724: [explorer] add testnet toggle in menu bar.

url edit

Sep 19 2024, 21:49
Fabien requested changes to D16724: [explorer] add testnet toggle in menu bar.
Sep 19 2024, 19:33
bytesofman closed D16786: [chronik-client] Support history, confirmedTxs, unconfirmedTxs for plugins endpoints.
Sep 19 2024, 16:29
bytesofman committed rABCaaff0e599d1b: [chronik-client] Support history, confirmedTxs, unconfirmedTxs for plugins… (authored by bytesofman).
[chronik-client] Support history, confirmedTxs, unconfirmedTxs for plugins…
Sep 19 2024, 16:29
tobias_ruck accepted D16786: [chronik-client] Support history, confirmedTxs, unconfirmedTxs for plugins endpoints.
Sep 19 2024, 16:28
bytesofman updated the diff for D16786: [chronik-client] Support history, confirmedTxs, unconfirmedTxs for plugins endpoints.

remove py script comments from plugins.ts, improve comments

Sep 19 2024, 16:24
johnkuney added a comment to D16724: [explorer] add testnet toggle in menu bar.

Yeah good call

Sep 19 2024, 16:05
johnkuney updated the diff for D16724: [explorer] add testnet toggle in menu bar.

avoid showing wrong selector in preview mode

Sep 19 2024, 16:05
johnkuney closed D16780: [e.cash] Prevent core tech section height jumping.
Sep 19 2024, 15:58
johnkuney committed rABCb9da1ee0a31e: [e.cash] Prevent core tech section height jumping (authored by johnkuney).
[e.cash] Prevent core tech section height jumping
Sep 19 2024, 15:58
johnkuney closed D16781: [e.cash] Increase avalanche animation frame rate.
Sep 19 2024, 15:57
johnkuney committed rABC0c25d59766cb: [e.cash] Increase avalanche animation frame rate (authored by johnkuney).
[e.cash] Increase avalanche animation frame rate
Sep 19 2024, 15:57
bytesofman accepted D16780: [e.cash] Prevent core tech section height jumping.
Sep 19 2024, 13:55
bytesofman accepted D16781: [e.cash] Increase avalanche animation frame rate.
Sep 19 2024, 13:53
teamcity added a comment to D16780: [e.cash] Prevent core tech section height jumping.

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.89.41.69:41549 for the next 60 minutes.

Sep 19 2024, 13:38
teamcity added a comment to D16781: [e.cash] Increase avalanche animation frame rate.

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.83.220.60:41248 for the next 60 minutes.

Sep 19 2024, 13:37
bytesofman added inline comments to D16745: [ecash-agora] Partial Agora offers: Add SLP support to plugin, `Agora` and `AgoraOffer`.
Sep 19 2024, 13:21
teamcity awarded D16780: [e.cash] Prevent core tech section height jumping a Haypence token.
Sep 19 2024, 13:11
bytesofman added a comment to D16780: [e.cash] Prevent core tech section height jumping.

@bot preview-e.cash

Sep 19 2024, 13:11
teamcity awarded D16781: [e.cash] Increase avalanche animation frame rate a Haypence token.
Sep 19 2024, 13:11
bytesofman added a comment to D16781: [e.cash] Increase avalanche animation frame rate.

@bot preview-e.cash

Sep 19 2024, 13:11
bytesofman updated the diff for D16786: [chronik-client] Support history, confirmedTxs, unconfirmedTxs for plugins endpoints.

rebase

Sep 19 2024, 12:59
bytesofman closed D16783: [chronik-client] Support websocket subscriptions to plugins.
Sep 19 2024, 12:51
bytesofman committed rABC87174b963d77: [chronik-client] Support websocket subscriptions to plugins (authored by bytesofman).
[chronik-client] Support websocket subscriptions to plugins
Sep 19 2024, 12:51
bytesofman added inline comments to D16783: [chronik-client] Support websocket subscriptions to plugins.
Sep 19 2024, 12:47
bytesofman updated the diff for D16786: [chronik-client] Support history, confirmedTxs, unconfirmedTxs for plugins endpoints.

explain sorting, remove global tx objects from plugins tests

Sep 19 2024, 12:45
bytesofman added a comment to D16786: [chronik-client] Support history, confirmedTxs, unconfirmedTxs for plugins endpoints.

ok updated sorting with comment, removed globals

Sep 19 2024, 12:45
PiRK closed D16569: [chronik] add an optional checkpoint_height query parameters to the block-header endpoint.
Sep 19 2024, 12:28
PiRK committed rABC0a75b25cc085: [chronik] add an optional checkpoint_height query parameters to the block… (authored by PiRK).
[chronik] add an optional checkpoint_height query parameters to the block…
Sep 19 2024, 12:28
Fabien closed D16785: [chronik-doc] Use the local node for the examples.
Sep 19 2024, 12:27
Fabien committed rABC346a6701a008: [chronik-doc] Use the local node for the examples (authored by Fabien).
[chronik-doc] Use the local node for the examples
Sep 19 2024, 12:27
bytesofman accepted D16785: [chronik-doc] Use the local node for the examples.
Sep 19 2024, 12:26
Fabien requested review of D16785: [chronik-doc] Use the local node for the examples.

The dir goes into baseUrl

Sep 19 2024, 12:25
bytesofman added a comment to D16785: [chronik-doc] Use the local node for the examples.

Actually I think the update goes in the next key of this settings page. So, will be like this:

Sep 19 2024, 12:22
bytesofman requested changes to D16785: [chronik-doc] Use the local node for the examples.

If we are updating the URL, also need to update

Sep 19 2024, 12:20
Fabien requested changes to D16724: [explorer] add testnet toggle in menu bar.
Sep 19 2024, 12:00
Fabien accepted D16569: [chronik] add an optional checkpoint_height query parameters to the block-header endpoint.
Sep 19 2024, 11:44
Fabien updated the diff for D16785: [chronik-doc] Use the local node for the examples.

Update the URLs scheme

Sep 19 2024, 11:38
Fabien updated the summary of D16785: [chronik-doc] Use the local node for the examples.
Sep 19 2024, 11:37
PiRK closed D16787: [net processing] Handle IsContinuationOfLowWorkHeadersSync return value correctly when new headers sync is started.
Sep 19 2024, 10:25
PiRK committed rABCdd52be11d685: [net processing] Handle IsContinuationOfLowWorkHeadersSync return value… (authored by dergoegge <n.goeggi@gmail.com>).
[net processing] Handle IsContinuationOfLowWorkHeadersSync return value…
Sep 19 2024, 10:25
PiRK updated the diff for D16569: [chronik] add an optional checkpoint_height query parameters to the block-header endpoint.

feedback

Sep 19 2024, 09:53
tobias_ruck added inline comments to D16745: [ecash-agora] Partial Agora offers: Add SLP support to plugin, `Agora` and `AgoraOffer`.
Sep 19 2024, 09:43
Fabien accepted D16787: [net processing] Handle IsContinuationOfLowWorkHeadersSync return value correctly when new headers sync is started.
Sep 19 2024, 09:42
tobias_ruck requested changes to D16786: [chronik-client] Support history, confirmedTxs, unconfirmedTxs for plugins endpoints.
Sep 19 2024, 09:14
tobias_ruck accepted D16783: [chronik-client] Support websocket subscriptions to plugins.

otherwise lgtm

Sep 19 2024, 09:05
teamcity updated the summary of D16787: [net processing] Handle IsContinuationOfLowWorkHeadersSync return value correctly when new headers sync is started.
Sep 19 2024, 09:02
PiRK requested review of D16787: [net processing] Handle IsContinuationOfLowWorkHeadersSync return value correctly when new headers sync is started.
Sep 19 2024, 09:02
bytesofman added inline comments to D16786: [chronik-client] Support history, confirmedTxs, unconfirmedTxs for plugins endpoints.
Sep 19 2024, 03:26
johnkuney added a comment to D16724: [explorer] add testnet toggle in menu bar.

Ah okay cool, yeah sorry think I misunderstood you the first time.
I thought we were not going to have it on explorer.e.cash. But I'm with you now

Sep 19 2024, 03:26
emack added inline comments to D16786: [chronik-client] Support history, confirmedTxs, unconfirmedTxs for plugins endpoints.
Sep 19 2024, 03:19
bytesofman published D16786: [chronik-client] Support history, confirmedTxs, unconfirmedTxs for plugins endpoints for review.
Sep 19 2024, 02:51

Sep 18 2024

bytesofman published D16783: [chronik-client] Support websocket subscriptions to plugins for review.
Sep 18 2024, 21:53
bytesofman requested changes to D16755: [ecash-agora] Partial Agora offers: Add ALP support to plugin, `Agora` and `AgoraOffer`.
Sep 18 2024, 21:34
roqqit closed D16779: [avalanche] Add missing const to getWinners.
Sep 18 2024, 21:33
roqqit committed rABCa18387188c0d: [avalanche] Add missing const to getWinners (authored by roqqit).
[avalanche] Add missing const to getWinners
Sep 18 2024, 21:33
bytesofman accepted D16753: [ecash-agora] Add ALP support to `AgoraPartial.script`.
Sep 18 2024, 21:29
bytesofman requested changes to D16745: [ecash-agora] Partial Agora offers: Add SLP support to plugin, `Agora` and `AgoraOffer`.

re this comment

image.png (136×604 px, 12 KB)

Sep 18 2024, 21:28
bytesofman accepted D16743: [ecash-agora] Add `AgoraPartial.script` to build the Script for partial SLP offers.
Sep 18 2024, 21:27
Fabien added a comment to D16724: [explorer] add testnet toggle in menu bar.

Regarding the config this looks good at first glance

Sep 18 2024, 21:24
Fabien added a comment to D16724: [explorer] add testnet toggle in menu bar.

Would it be possible to actually switch between testnet and mainnet instead of just urls?
Like what makes it run testnet? you need to change the chain parameter and the chronik instance in the config? But I guess it would require a recompile so maybe not doable?

Also how useful will this actually be, if we are not going to have it on explorer.e.cash? The scenario would be you are on texplorer.fabien.cash and then hit the switch and go to explorer.e.cash with no switcher....what is it solving?

Sep 18 2024, 21:22