- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Sep 24 2024
Typo in the ipc message key
Fix the integration test
Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.68.37.192:41647 for the next 60 minutes.
should also update the chronik-client test in this diff
@bot preview-e.cash
@bot check-iguana
Fix test, feedback
improve tests, rebase
one small nit
rebase onto D16753.
rebase on D16745.
address review + based memes
Not for this diff but tickers sound like something we should be mandating during token creation. It's an easy alternative to token id to separate identical tokens. But if we do mandate it then it's worth tracking whether a ticker already exist.
I also checked etoken creation and it's not mandated there either.
Sep 23 2024
In D16803#381211, @bytesofman wrote:Diff looks good but my understanding is behind on how chronik "knows" a block has been invalidated by avalanche. Having trouble following the logic in this diff.
Is chronik already handling this case but just not sending a msg? Where is the case recognized?
Applied light changes to the copy as suggested.
Diff looks good but my understanding is behind on how chronik "knows" a block has been invalidated by avalanche. Having trouble following the logic in this diff.
light copy suggestions, see inline
In D16782#381036, @Fabien wrote:I see your test doesn't check for contiguous heights, you should add that
Use lower_bound instead since it is more technically correct and robust to future changes. There is no change in behavior.
diff --git a/chronik/chronik-indexer/src/query/blocks.rs b/chronik/chronik-indexer/src/query/blocks.rs index 01e658e2fd..f130f2e7f3 100644 --- a/chronik/chronik-indexer/src/query/blocks.rs +++ b/chronik/chronik-indexer/src/query/blocks.rs @@ -33,6 +33,7 @@ use crate::{ OutputsSpent, TxTokenData, }, }; +use std::time::{Duration, Instant};
Rebase and fix typo
changed back to original "Subnets" copy, with small addition.
pushing out of review
Sep 22 2024
Sep 21 2024
Document -persistrecentheaderstime