Page MenuHomePhabricator
Feed All Stories

Oct 10 2024

teamcity closed T3653: Build Bitcoin-ABC / Master / Sanitizers / Thread Sanitizer (TSAN) is broken. as Resolved.
Oct 10 2024, 07:27
Fabien committed rABC5a3dd8183dfc: p2p: Avoid prematurely clearing download state for other peers (authored by Suhas Daftuar <sdaftuar@chaincode.com>).
p2p: Avoid prematurely clearing download state for other peers
Oct 10 2024, 07:09
Fabien committed rABC2701a514b014: Avoid headers assertions in the compact block workflow (authored by Fabien).
Avoid headers assertions in the compact block workflow
Oct 10 2024, 06:51
Fabien closed D16877: [faucet] Help typescript to infer the type of an empty array.
Oct 10 2024, 06:51
Fabien committed rABC0edc15f825e9: [faucet] Help typescript to infer the type of an empty array (authored by Fabien).
[faucet] Help typescript to infer the type of an empty array
Oct 10 2024, 06:51

Oct 9 2024

teamcity triaged T3653: Build Bitcoin-ABC / Master / Sanitizers / Thread Sanitizer (TSAN) is broken. as Unbreak Now! priority.
Oct 9 2024, 20:54
roqqit closed D16876: [avalanche] Add test case of vote status for manually added stake winner.
Oct 9 2024, 20:38
roqqit committed rABC36b7920c9271: [avalanche] Add test case of vote status for manually added stake winner (authored by roqqit).
[avalanche] Add test case of vote status for manually added stake winner
Oct 9 2024, 20:38
bytesofman accepted D16877: [faucet] Help typescript to infer the type of an empty array.

possibly overkill for this app, but you can see how config.ts defines an interface in token-server to handle this

Oct 9 2024, 19:49
Fabien requested review of D16877: [faucet] Help typescript to infer the type of an empty array.
Oct 9 2024, 19:02
Fabien accepted D16876: [avalanche] Add test case of vote status for manually added stake winner.
Oct 9 2024, 18:39
roqqit requested review of D16876: [avalanche] Add test case of vote status for manually added stake winner.
Oct 9 2024, 16:12
roqqit closed D16874: test: simplify uint256 (de)serialization routines.
Oct 9 2024, 15:41
roqqit committed rABCca4d4be53648: test: simplify uint256 (de)serialization routines (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>).
test: simplify uint256 (de)serialization routines
Oct 9 2024, 15:41
PiRK added a comment to D16875: [electrum] update block explorers.

not a blocker, but mb worth noting

if you

  • set explorer to bitcoinabc
  • close electrum
  • arc patch this diff
  • ./electrum-abc

then check out preferences

image.png (531×453 px, 39 KB)

looks like "no" explorer is selected. However, if you click to see txs in the explorer, it does use explorer.e.cash

if you do the same but with "ViaWallet", it works and also appears as selected in preferences

image.png (531×453 px, 41 KB)

Oct 9 2024, 13:03
bytesofman accepted D16875: [electrum] update block explorers.

not a blocker, but mb worth noting

Oct 9 2024, 12:55
teamcity triaged T3652: Build Bitcoin-ABC / Nightly Builds / GUIX Builds / GUIX Windows is broken. as Unbreak Now! priority.
Oct 9 2024, 12:01
teamcity triaged T3651: Build Bitcoin-ABC / Nightly Builds / GUIX Builds / GUIX MacOS is broken. as Unbreak Now! priority.
Oct 9 2024, 12:00
PiRK accepted D16874: test: simplify uint256 (de)serialization routines.
Oct 9 2024, 07:47
PiRK requested review of D16875: [electrum] update block explorers.
Oct 9 2024, 07:32
Mengerian closed D16873: [e.cash] Add link for Chronik docs to build page.
Oct 9 2024, 00:28
Mengerian committed rABC1741428f73b6: [e.cash] Add link for Chronik docs to build page (authored by Mengerian).
[e.cash] Add link for Chronik docs to build page
Oct 9 2024, 00:27
johnkuney accepted D16873: [e.cash] Add link for Chronik docs to build page.

Looks good

Oct 9 2024, 00:00

Oct 8 2024

teamcity added a comment to D16873: [e.cash] Add link for Chronik docs to build page.
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
Oct 8 2024, 23:58
teamcity added a comment to D16873: [e.cash] Add link for Chronik docs to build page.
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
Oct 8 2024, 23:58
teamcity awarded D16873: [e.cash] Add link for Chronik docs to build page a Haypence token.
Oct 8 2024, 23:57
johnkuney added a comment to D16873: [e.cash] Add link for Chronik docs to build page.

@bot preview e.cash

Oct 8 2024, 23:57
roqqit updated the summary of D16874: test: simplify uint256 (de)serialization routines.
Oct 8 2024, 23:48
roqqit updated the summary of D16874: test: simplify uint256 (de)serialization routines.
Oct 8 2024, 23:48
roqqit requested review of D16874: test: simplify uint256 (de)serialization routines.
Oct 8 2024, 23:46
Mengerian updated the diff for D16873: [e.cash] Add link for Chronik docs to build page.

Typo in description

Oct 8 2024, 23:45
Mengerian requested review of D16873: [e.cash] Add link for Chronik docs to build page.
Oct 8 2024, 23:44
bytesofman closed D16868: [token-server + cashtab] Implement recaptcha for token rewards.
Oct 8 2024, 20:38
bytesofman committed rABC1dac4ce0fafe: [token-server + cashtab] Implement recaptcha for token rewards (authored by bytesofman).
[token-server + cashtab] Implement recaptcha for token rewards
Oct 8 2024, 20:38
Fabien accepted D16868: [token-server + cashtab] Implement recaptcha for token rewards.
Oct 8 2024, 20:10
bytesofman updated the diff for D16868: [token-server + cashtab] Implement recaptcha for token rewards.

rebase

Oct 8 2024, 20:03
bytesofman closed D16869: [token-server] Remove duplicated test.
Oct 8 2024, 20:03
bytesofman committed rABCb65ae27ba9d1: [token-server] Remove duplicated test (authored by bytesofman).
[token-server] Remove duplicated test
Oct 8 2024, 20:03
Fabien closed D16872: [explorer] Switch the testnet explorer to the final URL.
Oct 8 2024, 19:59
Fabien committed rABCc51c04a3267c: [explorer] Switch the testnet explorer to the final URL (authored by Fabien).
[explorer] Switch the testnet explorer to the final URL
Oct 8 2024, 19:59
bytesofman accepted D16872: [explorer] Switch the testnet explorer to the final URL.
Oct 8 2024, 19:59
Fabien accepted D16869: [token-server] Remove duplicated test.
Oct 8 2024, 19:59
Fabien requested review of D16872: [explorer] Switch the testnet explorer to the final URL.
Oct 8 2024, 19:57
Fabien closed D16870: [chronik-doc] Update the to final URL.
Oct 8 2024, 19:51
Fabien committed rABC2df0a8a49605: [chronik-doc] Update the to final URL (authored by Fabien).
[chronik-doc] Update the to final URL
Oct 8 2024, 19:51
bytesofman accepted D16870: [chronik-doc] Update the to final URL.
Oct 8 2024, 19:50
Fabien requested review of D16870: [chronik-doc] Update the to final URL.
Oct 8 2024, 19:45
bytesofman published D16868: [token-server + cashtab] Implement recaptcha for token rewards for review.
Oct 8 2024, 19:38
bytesofman published D16869: [token-server] Remove duplicated test for review.
Oct 8 2024, 19:05
Fabien closed D16867: Build a package for Ubuntu 24.04 "Noble Numbat".
Oct 8 2024, 18:38
Fabien committed rABC05ae3ef39bef: Build a package for Ubuntu 24.04 "Noble Numbat" (authored by Fabien).
Build a package for Ubuntu 24.04 "Noble Numbat"
Oct 8 2024, 18:38
Fabien closed D16865: [faucet] Add a faucet application.
Oct 8 2024, 18:37
Fabien committed rABC3d313ee39669: [faucet] Add a faucet application (authored by Fabien).
[faucet] Add a faucet application
Oct 8 2024, 18:37
Fabien added inline comments to D16865: [faucet] Add a faucet application.
Oct 8 2024, 18:37
bytesofman accepted D16865: [faucet] Add a faucet application.
Oct 8 2024, 18:35
PiRK closed D16866: [chronik] remove outdated comment for enable_lokad_id_index.
Oct 8 2024, 18:34
PiRK committed rABC2fdbd11f292d: [chronik] remove outdated comment for enable_lokad_id_index (authored by PiRK).
[chronik] remove outdated comment for enable_lokad_id_index
Oct 8 2024, 18:33
PiRK accepted D16867: Build a package for Ubuntu 24.04 "Noble Numbat".
Oct 8 2024, 18:33
Fabien updated the diff for D16865: [faucet] Add a faucet application.

Feedback

Oct 8 2024, 18:21
Fabien requested review of D16867: Build a package for Ubuntu 24.04 "Noble Numbat".
Oct 8 2024, 18:11
Fabien added inline comments to D16865: [faucet] Add a faucet application.
Oct 8 2024, 17:58
bytesofman added inline comments to D16865: [faucet] Add a faucet application.
Oct 8 2024, 17:22
bytesofman requested changes to D16865: [faucet] Add a faucet application.

I don't think unit tests would make sense for this kind of application.

Oct 8 2024, 17:12
bytesofman added a comment to D16865: [faucet] Add a faucet application.

$ ts-node index.ts fails with

Oct 8 2024, 17:06
Fabien accepted D16866: [chronik] remove outdated comment for enable_lokad_id_index.
Oct 8 2024, 16:38
PiRK requested review of D16866: [chronik] remove outdated comment for enable_lokad_id_index.
Oct 8 2024, 15:46
Fabien updated the test plan for D16865: [faucet] Add a faucet application.
Oct 8 2024, 14:26
Fabien updated the diff for D16865: [faucet] Add a faucet application.

Fix the rate limit applying to the balance endpoint due to route conflict, and fix the npm start script

Oct 8 2024, 14:26
Fabien planned changes to D16865: [faucet] Add a faucet application.
Oct 8 2024, 14:20
Fabien updated the test plan for D16865: [faucet] Add a faucet application.
Oct 8 2024, 14:19
Fabien requested review of D16865: [faucet] Add a faucet application.
Oct 8 2024, 14:18
bytesofman closed D16864: [Cashtab] Minimize fees for NFT listing txs.
Oct 8 2024, 13:39
bytesofman committed rABCc19651314fac: [Cashtab] Minimize fees for NFT listing txs (authored by bytesofman).
[Cashtab] Minimize fees for NFT listing txs
Oct 8 2024, 13:39
teamcity closed T3650: Build Bitcoin-ABC / Nightly Builds / GUIX Builds / GUIX Linux is broken. as Resolved.
Oct 8 2024, 12:50
emack accepted D16864: [Cashtab] Minimize fees for NFT listing txs.
Oct 8 2024, 11:01
bytesofman published D16864: [Cashtab] Minimize fees for NFT listing txs for review.
Oct 8 2024, 00:32

Oct 7 2024

Fabien closed D16826: [herald] Show invalidated blocks.
Oct 7 2024, 19:56
Fabien committed rABC43f19a37b28f: [herald] Show invalidated blocks (authored by Fabien).
[herald] Show invalidated blocks
Oct 7 2024, 19:56
Fabien added inline comments to D16826: [herald] Show invalidated blocks.
Oct 7 2024, 19:56
bytesofman accepted D16826: [herald] Show invalidated blocks.
Oct 7 2024, 19:55
Fabien closed D16863: [herald] Generate a block mock file that passes the linter.
Oct 7 2024, 19:55
Fabien committed rABC2343eaf87839: [herald] Generate a block mock file that passes the linter (authored by Fabien).
[herald] Generate a block mock file that passes the linter
Oct 7 2024, 19:55
bytesofman accepted D16863: [herald] Generate a block mock file that passes the linter.
Oct 7 2024, 19:51
Fabien requested review of D16863: [herald] Generate a block mock file that passes the linter.
Oct 7 2024, 19:50
Fabien updated the diff for D16826: [herald] Show invalidated blocks.

Feedback

Oct 7 2024, 19:49
Fabien added inline comments to D16826: [herald] Show invalidated blocks.
Oct 7 2024, 18:20
bytesofman requested changes to D16826: [herald] Show invalidated blocks.
Oct 7 2024, 18:14
Fabien published D16826: [herald] Show invalidated blocks for review.
Oct 7 2024, 15:08
Fabien closed D16861: [herald] Fix parsing of the staking reward winner.
Oct 7 2024, 15:06
Fabien committed rABC4a1e75ee7025: [herald] Fix parsing of the staking reward winner (authored by Fabien).
[herald] Fix parsing of the staking reward winner
Oct 7 2024, 15:06
Fabien closed D16862: [herald] Fix the headers, lint the package.
Oct 7 2024, 15:06
Fabien committed rABCe36e63a307a6: [herald] Fix the headers, lint the package (authored by Fabien).
[herald] Fix the headers, lint the package
Oct 7 2024, 15:06
PiRK accepted D16861: [herald] Fix parsing of the staking reward winner.
Oct 7 2024, 13:26
Fabien updated the diff for D16862: [herald] Fix the headers, lint the package.

Simplify the regex

Oct 7 2024, 13:24
Fabien added inline comments to D16862: [herald] Fix the headers, lint the package.
Oct 7 2024, 13:22
PiRK accepted D16862: [herald] Fix the headers, lint the package.
Oct 7 2024, 13:15
teamcity triaged T3650: Build Bitcoin-ABC / Nightly Builds / GUIX Builds / GUIX Linux is broken. as Unbreak Now! priority.
Oct 7 2024, 12:02
teamcity closed T3649: Build Bitcoin-ABC / Nightly Builds / Initial Block Download Tests / Initial Block Download w/o Checkpoints is broken. as Resolved.
Oct 7 2024, 09:55
Fabien requested review of D16862: [herald] Fix the headers, lint the package.
Oct 7 2024, 08:56
Fabien requested review of D16861: [herald] Fix parsing of the staking reward winner.
Oct 7 2024, 08:39