Page MenuHomePhabricator
Feed Advanced Search

Today

PiRK accepted D17171: [avalanche] Cleanup redundant check for avalanche processor.
Thu, Nov 21, 07:36

Yesterday

PiRK accepted D17166: [chronik-docs] Fix a wrong link in the websocket documentation.
Wed, Nov 20, 11:51

Tue, Nov 19

PiRK closed D17159: util: optimize HexStr.
Tue, Nov 19, 21:04
PiRK committed rABCa91e6a41e27b: util: optimize HexStr (authored by Martin Leitner-Ankerl <martin.ankerl@gmail.com>).
util: optimize HexStr
Tue, Nov 19, 21:04
PiRK closed D17138: Rework receive buffer pushback.
Tue, Nov 19, 21:04
PiRK committed rABC94d6cf737131: Rework receive buffer pushback (authored by Pieter Wuille <pieter@wuille.net>).
Rework receive buffer pushback
Tue, Nov 19, 21:04

Mon, Nov 18

Sintayew4 awarded D17159: util: optimize HexStr a Mountain of Wealth token.
Mon, Nov 18, 23:18
PiRK updated the summary of D17159: util: optimize HexStr.
Mon, Nov 18, 20:02
PiRK abandoned D17139: rpc, test: add sendmsgtopeer rpc and a test for net-level deadlock situation.

squashed with D17138

Mon, Nov 18, 20:01
PiRK updated the diff for D17138: Rework receive buffer pushback.

squash with tests

Mon, Nov 18, 20:01
PiRK closed D17158: Handle invalid hex encoding in ParseHex.
Mon, Nov 18, 19:57
PiRK committed rABC17760e91d644: Handle invalid hex encoding in ParseHex (authored by MarcoFalke <6399679+MarcoFalke@users.noreply.github.com>).
Handle invalid hex encoding in ParseHex
Mon, Nov 18, 19:57
PiRK closed D17157: util: Add ParseHex<std::byte>() helper.
Mon, Nov 18, 19:57
PiRK committed rABC000b0266e7e8: util: Add ParseHex<std::byte>() helper (authored by MarcoFalke <falke.marco@gmail.com>).
util: Add ParseHex<std::byte>() helper
Mon, Nov 18, 19:57
PiRK closed D17156: refactor: Take Span in SetSeed.
Mon, Nov 18, 19:57
PiRK committed rABCabfd248f0a4b: refactor: Take Span in SetSeed (authored by MarcoFalke <falke.marco@gmail.com>).
refactor: Take Span in SetSeed
Mon, Nov 18, 19:56
PiRK requested review of D17159: util: optimize HexStr.
Mon, Nov 18, 15:47
PiRK updated the diff for D17139: rpc, test: add sendmsgtopeer rpc and a test for net-level deadlock situation.

remove fixme comment (now fixed)

Mon, Nov 18, 11:26
PiRK published D17139: rpc, test: add sendmsgtopeer rpc and a test for net-level deadlock situation for review.
Mon, Nov 18, 11:23
PiRK published D17138: Rework receive buffer pushback for review.
Mon, Nov 18, 11:16
PiRK updated the summary of D17158: Handle invalid hex encoding in ParseHex.
Mon, Nov 18, 11:10
PiRK requested review of D17158: Handle invalid hex encoding in ParseHex.
Mon, Nov 18, 11:10
PiRK updated the summary of D17157: util: Add ParseHex<std::byte>() helper.
Mon, Nov 18, 10:28
PiRK requested review of D17157: util: Add ParseHex<std::byte>() helper.
Mon, Nov 18, 10:25
PiRK requested review of D17156: refactor: Take Span in SetSeed.
Mon, Nov 18, 10:24
PiRK closed D17152: scripted-diff: Rename ValidAsCString to ContainsNoNUL.
Mon, Nov 18, 10:23
PiRK closed D17151: Use std::string_view throughout util strencodings/string.
Mon, Nov 18, 10:23
PiRK committed rABC56db8a817f1c: Use std::string_view throughout util strencodings/string (authored by Pieter Wuille <pieter@wuille.net>).
Use std::string_view throughout util strencodings/string
Mon, Nov 18, 10:23
PiRK committed rABC2ce28a323c56: scripted-diff: Rename ValidAsCString to ContainsNoNUL (authored by PiRK).
scripted-diff: Rename ValidAsCString to ContainsNoNUL
Mon, Nov 18, 10:23
PiRK closed D17150: Make DecodeBase{32,64} take string_view arguments.
Mon, Nov 18, 10:23
PiRK closed D17149: modernize DecodeBase{32,64}, reject incorrect base64 in HTTP auth.
Mon, Nov 18, 10:23
PiRK committed rABC6d85d6304400: Make DecodeBase{32,64} take string_view arguments (authored by Pieter Wuille <pieter@wuille.net>).
Make DecodeBase{32,64} take string_view arguments
Mon, Nov 18, 10:23
PiRK committed rABC5dc47a349314: modernize DecodeBase{32,64}, reject incorrect base64 in HTTP auth (authored by Pieter Wuille <pieter@wuille.net>).
modernize DecodeBase{32,64}, reject incorrect base64 in HTTP auth
Mon, Nov 18, 10:23
PiRK closed D17148: Make strencodings functions use string_view.
Mon, Nov 18, 10:23
PiRK committed rABCdad4fd9df468: Make strencodings functions use string_view (authored by Pieter Wuille <pieter@wuille.net>).
Make strencodings functions use string_view
Mon, Nov 18, 10:23
PiRK closed D17147: util: Introduce ToIntegral<T>(const std::string&) for locale independent parsing using std::from_chars(…) (C++17).
Mon, Nov 18, 10:22
PiRK committed rABC10326d3320e1: util: Introduce ToIntegral<T>(const std::string&) for locale independent… (authored by practicalswift <practicalswift@users.noreply.github.com>).
util: Introduce ToIntegral<T>(const std::string&) for locale independent…
Mon, Nov 18, 10:22
PiRK updated the diff for D17149: modernize DecodeBase{32,64}, reject incorrect base64 in HTTP auth.

fix var shadowing and move comment to the related line of code

Mon, Nov 18, 10:03
PiRK updated the diff for D17149: modernize DecodeBase{32,64}, reject incorrect base64 in HTTP auth.

rebase

Mon, Nov 18, 09:31
PiRK updated the diff for D17147: util: Introduce ToIntegral<T>(const std::string&) for locale independent parsing using std::from_chars(…) (C++17).

comment nits

Mon, Nov 18, 09:29
PiRK closed D17133: net: introduce Sock::WaitMany().
Mon, Nov 18, 06:42
PiRK closed D17132: net: also wait for exceptional events in Sock::Wait().
Mon, Nov 18, 06:42
PiRK closed D17134: net: use Sock::WaitMany() instead of CConnman::SocketEvents().
Mon, Nov 18, 06:42
PiRK committed rABCadc9c8e45a53: net: use Sock::WaitMany() instead of CConnman::SocketEvents() (authored by Vasil Dimov <vd@FreeBSD.org>).
net: use Sock::WaitMany() instead of CConnman::SocketEvents()
Mon, Nov 18, 06:42
PiRK committed rABCf0f41147f028: net: also wait for exceptional events in Sock::Wait() (authored by Vasil Dimov <vd@FreeBSD.org>).
net: also wait for exceptional events in Sock::Wait()
Mon, Nov 18, 06:42
PiRK committed rABC9f4a3fa6a70c: net: introduce Sock::WaitMany() (authored by Vasil Dimov <vd@FreeBSD.org>).
net: introduce Sock::WaitMany()
Mon, Nov 18, 06:42
PiRK closed D17131: net: use Sock in CNode.
Mon, Nov 18, 06:42
PiRK committed rABC48e3344f9f94: net: use Sock in CNode (authored by Vasil Dimov <vd@FreeBSD.org>).
net: use Sock in CNode
Mon, Nov 18, 06:42
PiRK closed D17130: refactor: wrap accept() and extend usage of Sock.
Mon, Nov 18, 06:42
PiRK committed rABC7e5ca9440c2f: refactor: wrap accept() and extend usage of Sock (authored by Vasil Dimov <vd@FreeBSD.org>).
refactor: wrap accept() and extend usage of Sock
Mon, Nov 18, 06:42
PiRK closed D17137: fuzz: Add fuzzing harness for Socks5(...).
Mon, Nov 18, 06:42
PiRK committed rABC5bea016076f0: fuzz: Add fuzzing harness for Socks5(...) (authored by practicalswift <practicalswift@users.noreply.github.com>).
fuzz: Add fuzzing harness for Socks5(...)
Mon, Nov 18, 06:42

Sat, Nov 16

PiRK added a comment to D17149: modernize DecodeBase{32,64}, reject incorrect base64 in HTTP auth.

Tail of the build log:

tests/test_iguana.py::test_invalid_inputindex ##teamcity[testStarted timestamp='2024-11-16T11:34:10.910' captureStandardOutput='false' flowId='tests.test_iguana.test_invalid_inputindex' metainfo='test_invalid_inputindex' name='tests.test_iguana.test_invalid_inputindex']
PASSED                     [ 25%]##teamcity[testFinished timestamp='2024-11-16T11:34:10.925' duration='14' flowId='tests.test_iguana.test_invalid_inputindex' name='tests.test_iguana.test_invalid_inputindex']

tests/test_iguana.py::test_sig_push_only ##teamcity[testStarted timestamp='2024-11-16T11:34:10.926' captureStandardOutput='false' flowId='tests.test_iguana.test_sig_push_only' metainfo='test_sig_push_only' name='tests.test_iguana.test_sig_push_only']
PASSED                          [ 30%]##teamcity[testFinished timestamp='2024-11-16T11:34:11.018' duration='92' flowId='tests.test_iguana.test_sig_push_only' name='tests.test_iguana.test_sig_push_only']

tests/test_iguana.py::test_script_sig_success ##teamcity[testStarted timestamp='2024-11-16T11:34:11.019' captureStandardOutput='false' flowId='tests.test_iguana.test_script_sig_success' metainfo='test_script_sig_success' name='tests.test_iguana.test_script_sig_success']
PASSED                     [ 35%]##teamcity[testFinished timestamp='2024-11-16T11:34:11.103' duration='83' flowId='tests.test_iguana.test_script_sig_success' name='tests.test_iguana.test_script_sig_success']

tests/test_iguana.py::test_script_sig_invalid_opcode_encoding ##teamcity[testStarted timestamp='2024-11-16T11:34:11.103' captureStandardOutput='false' flowId='tests.test_iguana.test_script_sig_invalid_opcode_encoding' metainfo='test_script_sig_invalid_opcode_encoding' name='tests.test_iguana.test_script_sig_invalid_opcode_encoding']
PASSED     [ 40%]##teamcity[testFinished timestamp='2024-11-16T11:34:11.158' duration='54' flowId='tests.test_iguana.test_script_sig_invalid_opcode_encoding' name='tests.test_iguana.test_script_sig_invalid_opcode_encoding']

tests/test_iguana.py::test_script_pub_key_success ##teamcity[testStarted timestamp='2024-11-16T11:34:11.159' captureStandardOutput='false' flowId='tests.test_iguana.test_script_pub_key_success' metainfo='test_script_pub_key_success' name='tests.test_iguana.test_script_pub_key_success']
PASSED                 [ 45%]##teamcity[testFinished timestamp='2024-11-16T11:34:11.227' duration='67' flowId='tests.test_iguana.test_script_pub_key_success' name='tests.test_iguana.test_script_pub_key_success']

tests/test_iguana.py::test_script_pub_key_failure ##teamcity[testStarted timestamp='2024-11-16T11:34:11.228' captureStandardOutput='false' flowId='tests.test_iguana.test_script_pub_key_failure' metainfo='test_script_pub_key_failure' name='tests.test_iguana.test_script_pub_key_failure']
PASSED                 [ 50%]##teamcity[testFinished timestamp='2024-11-16T11:34:11.250' duration='21' flowId='tests.test_iguana.test_script_pub_key_failure' name='tests.test_iguana.test_script_pub_key_failure']

tests/test_iguana.py::test_script_pub_key_empty_stack ##teamcity[testStarted timestamp='2024-11-16T11:34:11.251' captureStandardOutput='false' flowId='tests.test_iguana.test_script_pub_key_empty_stack' metainfo='test_script_pub_key_empty_stack' name='tests.test_iguana.test_script_pub_key_empty_stack']
PASSED             [ 55%]##teamcity[testFinished timestamp='2024-11-16T11:34:11.287' duration='36' flowId='tests.test_iguana.test_script_pub_key_empty_stack' name='tests.test_iguana.test_script_pub_key_empty_stack']

tests/test_iguana.py::test_script_pub_key_false_stack ##teamcity[testStarted timestamp='2024-11-16T11:34:11.288' captureStandardOutput='false' flowId='tests.test_iguana.test_script_pub_key_false_stack' metainfo='test_script_pub_key_false_stack' name='tests.test_iguana.test_script_pub_key_false_stack']
PASSED             [ 60%]##teamcity[testFinished timestamp='2024-11-16T11:34:11.310' duration='21' flowId='tests.test_iguana.test_script_pub_key_false_stack' name='tests.test_iguana.test_script_pub_key_false_stack']

tests/test_iguana.py::test_script_pub_key_cleanstack ##teamcity[testStarted timestamp='2024-11-16T11:34:11.311' captureStandardOutput='false' flowId='tests.test_iguana.test_script_pub_key_cleanstack' metainfo='test_script_pub_key_cleanstack' name='tests.test_iguana.test_script_pub_key_cleanstack']
PASSED              [ 65%]##teamcity[testFinished timestamp='2024-11-16T11:34:11.325' duration='12' flowId='tests.test_iguana.test_script_pub_key_cleanstack' name='tests.test_iguana.test_script_pub_key_cleanstack']

tests/test_iguana.py::test_redeem_script_success ##teamcity[testStarted timestamp='2024-11-16T11:34:11.325' captureStandardOutput='false' flowId='tests.test_iguana.test_redeem_script_success' metainfo='test_redeem_script_success' name='tests.test_iguana.test_redeem_script_success']
PASSED                  [ 70%]##teamcity[testFinished timestamp='2024-11-16T11:34:11.355' duration='29' flowId='tests.test_iguana.test_redeem_script_success' name='tests.test_iguana.test_redeem_script_success']

tests/test_iguana.py::test_redeem_script_error ##teamcity[testStarted timestamp='2024-11-16T11:34:11.356' captureStandardOutput='false' flowId='tests.test_iguana.test_redeem_script_error' metainfo='test_redeem_script_error' name='tests.test_iguana.test_redeem_script_error']
PASSED                    [ 75%]##teamcity[testFinished timestamp='2024-11-16T11:34:11.371' duration='14' flowId='tests.test_iguana.test_redeem_script_error' name='tests.test_iguana.test_redeem_script_error']

tests/test_iguana.py::test_redeem_script_exception ##teamcity[testStarted timestamp='2024-11-16T11:34:11.371' captureStandardOutput='false' flowId='tests.test_iguana.test_redeem_script_exception' metainfo='test_redeem_script_exception' name='tests.test_iguana.test_redeem_script_exception']
PASSED                [ 80%]##teamcity[testFinished timestamp='2024-11-16T11:34:11.386' duration='13' flowId='tests.test_iguana.test_redeem_script_exception' name='tests.test_iguana.test_redeem_script_exception']

tests/test_iguana.py::test_redeem_script_empty_stack ##teamcity[testStarted timestamp='2024-11-16T11:34:11.386' captureStandardOutput='false' flowId='tests.test_iguana.test_redeem_script_empty_stack' metainfo='test_redeem_script_empty_stack' name='tests.test_iguana.test_redeem_script_empty_stack']
PASSED              [ 85%]##teamcity[testFinished timestamp='2024-11-16T11:34:11.401' duration='14' flowId='tests.test_iguana.test_redeem_script_empty_stack' name='tests.test_iguana.test_redeem_script_empty_stack']

tests/test_iguana.py::test_redeem_script_false ##teamcity[testStarted timestamp='2024-11-16T11:34:11.402' captureStandardOutput='false' flowId='tests.test_iguana.test_redeem_script_false' metainfo='test_redeem_script_false' name='tests.test_iguana.test_redeem_script_false']
PASSED                    [ 90%]##teamcity[testFinished timestamp='2024-11-16T11:34:11.418' duration='15' flowId='tests.test_iguana.test_redeem_script_false' name='tests.test_iguana.test_redeem_script_false']

tests/test_iguana.py::test_redeem_script_cleanstack ##teamcity[testStarted timestamp='2024-11-16T11:34:11.418' captureStandardOutput='false' flowId='tests.test_iguana.test_redeem_script_cleanstack' metainfo='test_redeem_script_cleanstack' name='tests.test_iguana.test_redeem_script_cleanstack']
PASSED               [ 95%]##teamcity[testFinished timestamp='2024-11-16T11:34:11.433' duration='13' flowId='tests.test_iguana.test_redeem_script_cleanstack' name='tests.test_iguana.test_redeem_script_cleanstack']

tests/test_iguana.py::test_redeem_script_input_sigchecks ##teamcity[testStarted timestamp='2024-11-16T11:34:11.434' captureStandardOutput='false' flowId='tests.test_iguana.test_redeem_script_input_sigchecks' metainfo='test_redeem_script_input_sigchecks' name='tests.test_iguana.test_redeem_script_input_sigchecks']
PASSED          [100%]##teamcity[testFinished timestamp='2024-11-16T11:34:11.489' duration='54' flowId='tests.test_iguana.test_redeem_script_input_sigchecks' name='tests.test_iguana.test_redeem_script_input_sigchecks']


============================== 20 passed in 0.76s ==============================
[212/489] Running pow test suite
PASSED: pow test suite
[227/489] Running seeder test suite
PASSED: seeder test suite
[231/489] Running bitcoin-qt test suite
PASSED: bitcoin-qt test suite
[486/489] Running bitcoin test suite
PASSED: bitcoin test suite
ninja: build stopped: cannot make progress due to previous errors.
Build build-without-wallet failed with exit code 1
Sat, Nov 16, 14:49
PiRK updated the diff for D17152: scripted-diff: Rename ValidAsCString to ContainsNoNUL.

rebase

Sat, Nov 16, 11:19
PiRK updated the diff for D17151: Use std::string_view throughout util strencodings/string.

rebase

Sat, Nov 16, 11:18
PiRK updated the diff for D17150: Make DecodeBase{32,64} take string_view arguments.

rebase

Sat, Nov 16, 11:01
PiRK updated the diff for D17149: modernize DecodeBase{32,64}, reject incorrect base64 in HTTP auth.

rebase

Sat, Nov 16, 11:00
PiRK updated the diff for D17148: Make strencodings functions use string_view.

fix clang-tidy

Sat, Nov 16, 10:46
PiRK added inline comments to D17151: Use std::string_view throughout util strencodings/string.
Sat, Nov 16, 10:44
PiRK requested review of D17152: scripted-diff: Rename ValidAsCString to ContainsNoNUL.
Sat, Nov 16, 10:42
PiRK requested review of D17151: Use std::string_view throughout util strencodings/string.
Sat, Nov 16, 10:39
PiRK requested review of D17150: Make DecodeBase{32,64} take string_view arguments.
Sat, Nov 16, 10:37
PiRK added a comment to D17149: modernize DecodeBase{32,64}, reject incorrect base64 in HTTP auth.

Note that I squashed these 3 commits because they kept touching the same lines. The intermediate states in-between commits was not very interesting to have in the git history.

Sat, Nov 16, 10:36
PiRK requested review of D17149: modernize DecodeBase{32,64}, reject incorrect base64 in HTTP auth.
Sat, Nov 16, 10:34
PiRK requested review of D17148: Make strencodings functions use string_view.
Sat, Nov 16, 10:32
PiRK updated the diff for D17147: util: Introduce ToIntegral<T>(const std::string&) for locale independent parsing using std::from_chars(…) (C++17).

it didn't complain but fix it anyway

Sat, Nov 16, 10:31
PiRK planned changes to D17147: util: Introduce ToIntegral<T>(const std::string&) for locale independent parsing using std::from_chars(…) (C++17).
Sat, Nov 16, 09:34
PiRK requested review of D17147: util: Introduce ToIntegral<T>(const std::string&) for locale independent parsing using std::from_chars(…) (C++17).
Sat, Nov 16, 09:20

Fri, Nov 15

PiRK accepted D17142: Add checkpoints after the November 2024 upgrade.

block heights and hashes match what I saw

Fri, Nov 15, 14:51
PiRK accepted D17135: [ecash-herald] Show volume by token.
Fri, Nov 15, 09:43

Thu, Nov 14

PiRK added inline comments to D17137: fuzz: Add fuzzing harness for Socks5(...).
Thu, Nov 14, 13:55
PiRK added a comment to D17131: net: use Sock in CNode.
In D17131#388836, @PiRK wrote:

rebase onto D17137 which fixes the fuzzer

Please add the dependency in phab then

Thu, Nov 14, 13:36
PiRK requested review of D17137: fuzz: Add fuzzing harness for Socks5(...).
Thu, Nov 14, 13:34
PiRK added a comment to D17137: fuzz: Add fuzzing harness for Socks5(...).

I missed the main one: core#19203
I added it to the summary

Thu, Nov 14, 13:32
PiRK updated the summary of D17137: fuzz: Add fuzzing harness for Socks5(...).
Thu, Nov 14, 13:31
PiRK updated the diff for D17134: net: use Sock::WaitMany() instead of CConnman::SocketEvents().

rebase

Thu, Nov 14, 11:42
PiRK updated the diff for D17133: net: introduce Sock::WaitMany().

rebase

Thu, Nov 14, 11:38
PiRK updated the diff for D17132: net: also wait for exceptional events in Sock::Wait().

rebase

Thu, Nov 14, 11:38
PiRK updated the diff for D17131: net: use Sock in CNode.

rebase onto D17137 which fixes the fuzzer

Thu, Nov 14, 11:36
PiRK updated the diff for D17130: refactor: wrap accept() and extend usage of Sock.

rebase onto D17137, include relevant fuzzer changes

Thu, Nov 14, 11:33
PiRK requested review of D17137: fuzz: Add fuzzing harness for Socks5(...).
Thu, Nov 14, 11:31

Wed, Nov 13

PiRK added inline comments to D17132: net: also wait for exceptional events in Sock::Wait().
Wed, Nov 13, 21:32
PiRK planned changes to D17131: net: use Sock in CNode.

needs a fuzzer fix and test plan

Wed, Nov 13, 21:30
PiRK updated the summary of D17130: refactor: wrap accept() and extend usage of Sock.
Wed, Nov 13, 21:28
PiRK requested review of D17134: net: use Sock::WaitMany() instead of CConnman::SocketEvents().
Wed, Nov 13, 17:52
PiRK requested review of D17133: net: introduce Sock::WaitMany().
Wed, Nov 13, 17:50
PiRK requested review of D17132: net: also wait for exceptional events in Sock::Wait().
Wed, Nov 13, 17:49
PiRK requested review of D17131: net: use Sock in CNode.
Wed, Nov 13, 17:40
PiRK requested review of D17130: refactor: wrap accept() and extend usage of Sock.
Wed, Nov 13, 17:37
PiRK committed rABCd8719d90bb5c: net: split CConnman::SocketHandler() (authored by Vasil Dimov <vd@FreeBSD.org>).
net: split CConnman::SocketHandler()
Wed, Nov 13, 17:33
PiRK closed D17107: net: keep reference to each node during socket wait.
Wed, Nov 13, 17:33
PiRK closed D17108: net: split CConnman::SocketHandler().
Wed, Nov 13, 17:33
PiRK committed rABC32e377f69f42: net: keep reference to each node during socket wait (authored by Vasil Dimov <vd@FreeBSD.org>).
net: keep reference to each node during socket wait
Wed, Nov 13, 17:33
PiRK closed D17106: net: dedup and RAII-fy the creation of a copy of CConnman::vNodes.
Wed, Nov 13, 17:33
PiRK committed rABCcffdcc3eba2f: net: dedup and RAII-fy the creation of a copy of CConnman::vNodes (authored by Vasil Dimov <vd@FreeBSD.org>).
net: dedup and RAII-fy the creation of a copy of CConnman::vNodes
Wed, Nov 13, 17:33
PiRK updated the diff for D17108: net: split CConnman::SocketHandler().

remove old comment

Wed, Nov 13, 12:07

Tue, Nov 12

PiRK updated the diff for D17108: net: split CConnman::SocketHandler().

add missing lock annotation

Tue, Nov 12, 17:27
PiRK updated the diff for D17107: net: keep reference to each node during socket wait.

rebase

Tue, Nov 12, 17:25
PiRK updated the diff for D17106: net: dedup and RAII-fy the creation of a copy of CConnman::vNodes.

rebase

Tue, Nov 12, 17:24
PiRK closed D17115: test: add option to speed up tx relay/mempool sync.
Tue, Nov 12, 16:53