Page MenuHomePhabricator
Feed Advanced Search

Jun 26 2019

deadalnix created D3428: bench: Make CoinSelection output groups pass eligibility filter.
Jun 26 2019, 19:04
deadalnix committed rABC27b6f17553c0: wallet: shuffle coins before grouping, where warranted (authored by Karl-Johan Alm <kalle.alm@gmail.com>).
wallet: shuffle coins before grouping, where warranted
Jun 26 2019, 12:59
deadalnix closed D3414: wallet: shuffle coins before grouping, where warranted.
Jun 26 2019, 12:59
deadalnix committed rABC903806fc9f40: Make FastRandomContext support standard C++11 RNG interface (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Make FastRandomContext support standard C++11 RNG interface
Jun 26 2019, 12:56
deadalnix closed D3413: Make FastRandomContext support standard C++11 RNG interface.
Jun 26 2019, 12:56
deadalnix committed rABC2f24287f7e02: wallet: sum ancestors rather than taking max in output groups (authored by Karl-Johan Alm <kalle.alm@gmail.com>).
wallet: sum ancestors rather than taking max in output groups
Jun 26 2019, 12:50
deadalnix closed D3412: wallet: sum ancestors rather than taking max in output groups.
Jun 26 2019, 12:50
D3295: Added a script to automate collecting and updating seeds now requires changes to proceed.

The whole thing doesn't actually test what we are interested in: that the node effectively have a good list of node to bootstrap from.

Jun 26 2019, 00:57
deadalnix created D3414: wallet: shuffle coins before grouping, where warranted.
Jun 26 2019, 00:24
deadalnix created D3413: Make FastRandomContext support standard C++11 RNG interface.
Jun 26 2019, 00:20

Jun 25 2019

deadalnix created D3412: wallet: sum ancestors rather than taking max in output groups.
Jun 25 2019, 23:56
D3335: [LINTER] Make the check-doc linter run only once now requires changes to proceed.
Jun 25 2019, 23:26
D3363: [CMAKE] Build checkblock benchmark is now accepted and ready to land.
Jun 25 2019, 23:19
D2645: Reject headers building on invalid chains by tracking invalidity is now accepted and ready to land.
Jun 25 2019, 23:17
D3332: remove SCRIPT_ENABLE_SCHNORR flag and clean up tests now requires changes to proceed.

Don't use 0 for flags.

Jun 25 2019, 23:05
D3264: sigencoding_tests: improve test coverage is now accepted and ready to land.
Jun 25 2019, 20:26
D3347: [script_tests] improve coverage of minimal number encoding is now accepted and ready to land.
Jun 25 2019, 20:25
D3283: Merge #10408, #13291, and partial #13163 is now accepted and ready to land.

OK I got back to it. I don't get the way things are split up. Why do this, which introduce a memory leak, and then do PR10587 to fix it? If the goal was to merge things so that we don't land bugs then what is it about? On the other hand, PR13291 was merged here, but clearly it is not bugfix. The logic of the decoupage do not seems to follow any principle.

Jun 25 2019, 20:24
D2980: Merge #12287: Optimise lock behaviour for GuessVerificationProgress() is now accepted and ready to land.
Jun 25 2019, 20:13
D3331: remove effect of SCRIPT_ENABLE_SCHNORR flag is now accepted and ready to land.
Jun 25 2019, 20:07
D3388: Backport last relevant bit of #11389 is now accepted and ready to land.
Jun 25 2019, 16:36
D3410: Improve signmessages functional test is now accepted and ready to land.
Jun 25 2019, 15:43
D3409: Add getmininginfo functional test is now accepted and ready to land.
Jun 25 2019, 15:43
D3411: Update importprivkey named args documentation is now accepted and ready to land.
Jun 25 2019, 15:34
D3363: [CMAKE] Build checkblock benchmark now requires changes to proceed.
Jun 25 2019, 15:33
deadalnix committed rABC57a774c7dc30: doc: Add release notes for -avoidpartialspends (authored by Karl-Johan Alm <karljohan-alm@garage.co.jp>).
doc: Add release notes for -avoidpartialspends
Jun 25 2019, 15:11
deadalnix closed D3398: doc: Add release notes for -avoidpartialspends.
Jun 25 2019, 15:10
deadalnix committed rABC4ba29712a331: test: Add basic testing for wallet groups (authored by Karl-Johan Alm <karljohan-alm@garage.co.jp>).
test: Add basic testing for wallet groups
Jun 25 2019, 15:07
deadalnix closed D3395: test: Add basic testing for wallet groups.
Jun 25 2019, 15:06
deadalnix committed rABC909f0eeba114: wallet: Remove deprecated OutputEligibleForSpending (authored by Karl-Johan Alm <karljohan-alm@garage.co.jp>).
wallet: Remove deprecated OutputEligibleForSpending
Jun 25 2019, 15:05
deadalnix closed D3396: wallet: Remove deprecated OutputEligibleForSpending.
Jun 25 2019, 15:04
deadalnix committed rABC8dcaeabfcaff: clean-up: Remove no longer used ivars from CInputCoin (authored by Karl-Johan Alm <karljohan-alm@garage.co.jp>).
clean-up: Remove no longer used ivars from CInputCoin
Jun 25 2019, 15:02
deadalnix closed D3397: clean-up: Remove no longer used ivars from CInputCoin.
Jun 25 2019, 15:01
deadalnix committed rABCafa4430b94b9: wallet: Switch to using output groups instead of coins in coin selection (authored by Karl-Johan Alm <karljohan-alm@garage.co.jp>).
wallet: Switch to using output groups instead of coins in coin selection
Jun 25 2019, 14:58
deadalnix closed D3394: wallet: Switch to using output groups instead of coins in coin selection.
Jun 25 2019, 14:58
deadalnix committed rABC6e53ab546d81: Add -avoidpartialspends and m_avoid_partial_spends (authored by Karl-Johan Alm <karljohan-alm@garage.co.jp>).
Add -avoidpartialspends and m_avoid_partial_spends
Jun 25 2019, 14:54
deadalnix closed D3392: Add -avoidpartialspends and m_avoid_partial_spends.
Jun 25 2019, 14:54
deadalnix committed rABC7bc2342c29d0: wallet: Add output grouping (authored by Karl-Johan Alm <karljohan-alm@garage.co.jp>).
wallet: Add output grouping
Jun 25 2019, 14:51
deadalnix closed D3393: wallet: Add output grouping.
Jun 25 2019, 14:51
deadalnix added a comment to D3395: test: Add basic testing for wallet groups.

Add test case from PR13805 and addres various comments

Jun 25 2019, 14:44
deadalnix updated the summary of D3395: test: Add basic testing for wallet groups.
Jun 25 2019, 14:39
deadalnix added a comment to D3394: wallet: Switch to using output groups instead of coins in coin selection.

Rebase and address comments

Jun 25 2019, 14:30
deadalnix added inline comments to D3394: wallet: Switch to using output groups instead of coins in coin selection.
Jun 25 2019, 14:27
deadalnix added a comment to D3393: wallet: Add output grouping.

Backport bugfix from PR13805

Jun 25 2019, 14:22
deadalnix updated the summary of D3393: wallet: Add output grouping.
Jun 25 2019, 14:18
D3371: fix BIP37 processing for non-topologically ordered blocks is now accepted and ready to land.
Jun 25 2019, 02:42
deadalnix added a comment to D2980: Merge #12287: Optimise lock behaviour for GuessVerificationProgress().

This is when I point out that CI dosn't run debug, or maybe it does, who knows. So I don't know if this is a giant regression or if the comment mention a fix that don't need fixing or what.

Jun 25 2019, 02:35
D3408: Merge #10789: Punctuation/grammer fixes in rpcwallet.cpp is now accepted and ready to land.
Jun 25 2019, 02:27
D3406: Merge #9750: Bloomfilter: parameter variables made constant is now accepted and ready to land.
Jun 25 2019, 02:20
D3407: Merge #10432: [Trivial] Add BITCOIN_FS_H endif footer in fs.h is now accepted and ready to land.
Jun 25 2019, 01:55

Jun 24 2019

deadalnix committed rABC0cb6aa009058: Speedup coinselector_tests by using a dummy WalletDBWrapper when apropriate (authored by deadalnix).
Speedup coinselector_tests by using a dummy WalletDBWrapper when apropriate
Jun 24 2019, 16:02
deadalnix closed D3387: Speedup coinselector_tests by using a dummy WalletDBWrapper when apropriate.
Jun 24 2019, 16:02
deadalnix committed rABC740a33e83f89: Actually disable BnB when there are preset inputs (authored by Andrew Chow <achow101-github@achow101.com>).
Actually disable BnB when there are preset inputs
Jun 24 2019, 15:59
deadalnix closed D3378: Actually disable BnB when there are preset inputs.
Jun 24 2019, 15:59
deadalnix committed rABCe45beabef48d: Fix Clang Static Analyzer warnings (authored by practicalswift <practicalswift@users.noreply.github.com>).
Fix Clang Static Analyzer warnings
Jun 24 2019, 15:50
deadalnix closed D3377: Fix Clang Static Analyzer warnings.
Jun 24 2019, 15:50
deadalnix committed rABCafc4447ef4ef: wallet: Make fee settings non-static members (authored by MarcoFalke <falke.marco@gmail.com>).
wallet: Make fee settings non-static members
Jun 24 2019, 15:48
deadalnix closed D3364: wallet: Make fee settings non-static members.
Jun 24 2019, 15:48
deadalnix added a comment to D3364: wallet: Make fee settings non-static members.

Remove comment

Jun 24 2019, 15:35
D3399: unsigned int -> size_t in merkleblock-related code is now accepted and ready to land.
Jun 24 2019, 15:33
deadalnix committed rABCac9f7d12da63: wallet: Add input bytes to CInputCoin (authored by Karl-Johan Alm <karljohan-alm@garage.co.jp>).
wallet: Add input bytes to CInputCoin
Jun 24 2019, 15:24
deadalnix closed D3391: wallet: Add input bytes to CInputCoin.
Jun 24 2019, 15:23
deadalnix committed rABC19826e3b8f8b: moveonly: CoinElegibilityFilter into coinselection.h (authored by Karl-Johan Alm <karljohan-alm@garage.co.jp>).
moveonly: CoinElegibilityFilter into coinselection.h
Jun 24 2019, 15:21
deadalnix closed D3390: moveonly: CoinElegibilityFilter into coinselection.h.
Jun 24 2019, 15:21
deadalnix committed rABCb16cdc104c73: utils: Add insert() convenience templates (authored by Karl-Johan Alm <karljohan-alm@garage.co.jp>).
utils: Add insert() convenience templates
Jun 24 2019, 15:18
deadalnix closed D3389: utils: Add insert() convenience templates.
Jun 24 2019, 15:18

Jun 23 2019

D3363: [CMAKE] Build checkblock benchmark now requires changes to proceed.
Jun 23 2019, 00:08

Jun 22 2019

D3371: fix BIP37 processing for non-topologically ordered blocks now requires changes to proceed.
Jun 22 2019, 23:26
deadalnix created D3398: doc: Add release notes for -avoidpartialspends.
Jun 22 2019, 22:03
deadalnix created D3397: clean-up: Remove no longer used ivars from CInputCoin.
Jun 22 2019, 22:00
deadalnix created D3396: wallet: Remove deprecated OutputEligibleForSpending.
Jun 22 2019, 21:56
deadalnix created D3395: test: Add basic testing for wallet groups.
Jun 22 2019, 21:53
deadalnix updated the summary of D3394: wallet: Switch to using output groups instead of coins in coin selection.
Jun 22 2019, 21:48
deadalnix created D3394: wallet: Switch to using output groups instead of coins in coin selection.
Jun 22 2019, 21:47
deadalnix created D3393: wallet: Add output grouping.
Jun 22 2019, 21:31
deadalnix created D3392: Add -avoidpartialspends and m_avoid_partial_spends.
Jun 22 2019, 21:16
deadalnix added inline comments to D3378: Actually disable BnB when there are preset inputs.
Jun 22 2019, 21:03
deadalnix added a comment to D3253: Remove Schnorr activation.

Wait, does that pass IBD? There may be some problem with the sigops count. Please double check before landing.

Jun 22 2019, 20:47
deadalnix accepted D3253: Remove Schnorr activation.
Jun 22 2019, 20:46
deadalnix created D3391: wallet: Add input bytes to CInputCoin.
Jun 22 2019, 20:37
deadalnix created D3390: moveonly: CoinElegibilityFilter into coinselection.h.
Jun 22 2019, 20:32
deadalnix created D3389: utils: Add insert() convenience templates.
Jun 22 2019, 20:27
D3380: Merge #12250: Make CKey::Load references const is now accepted and ready to land.
Jun 22 2019, 02:12
D3318: [LINTER] Prevent including a source file is now accepted and ready to land.
Jun 22 2019, 02:11
D3365: Merge #8498: Near-Bugfix: Optimization: Minimize the number of times it is checked that no money... is now accepted and ready to land.
Jun 22 2019, 02:10
deadalnix added inline comments to D3365: Merge #8498: Near-Bugfix: Optimization: Minimize the number of times it is checked that no money....
Jun 22 2019, 02:09
deadalnix accepted D3381: Merge #13726: Utils and libraries: Removes the boost/algorithm/string/join dependency.
Jun 22 2019, 02:07
D3384: Merge #10228: build: regenerate bitcoin-config.h as necessary is now accepted and ready to land.
Jun 22 2019, 02:06
deadalnix accepted D3385: Merge #10380: [doc] Removing comments about dirty entries on txmempool.
Jun 22 2019, 02:05
D3386: Merge #10196: Bugfix: PrioritiseTransaction updates the mempool tx counter is now accepted and ready to land.
Jun 22 2019, 02:04
deadalnix created D3387: Speedup coinselector_tests by using a dummy WalletDBWrapper when apropriate.
Jun 22 2019, 01:23

Jun 21 2019

deadalnix committed rABC278e8f83d10d: Remove unecessary include of boost/version (authored by deadalnix).
Remove unecessary include of boost/version
Jun 21 2019, 23:34
deadalnix closed D3379: Remove unecessary include of boost/version.
Jun 21 2019, 23:34
deadalnix created D3379: Remove unecessary include of boost/version.
Jun 21 2019, 14:03
D3376: Merge #11237: qt: Fixing division by zero in time remaining is now accepted and ready to land.
Jun 21 2019, 02:54
deadalnix added inline comments to D3365: Merge #8498: Near-Bugfix: Optimization: Minimize the number of times it is checked that no money....
Jun 21 2019, 02:48
D3365: Merge #8498: Near-Bugfix: Optimization: Minimize the number of times it is checked that no money... now requires changes to proceed.
Jun 21 2019, 02:47
deadalnix created D3378: Actually disable BnB when there are preset inputs.
Jun 21 2019, 02:03
deadalnix created D3377: Fix Clang Static Analyzer warnings.
Jun 21 2019, 01:28
deadalnix added a comment to D3364: wallet: Make fee settings non-static members.

Rebase and remove redundant forward declaration

Jun 21 2019, 00:12