As the author of the previous differential D1652, this looks good to me. Test vectors seem to be the same (I just did a diff of the diffs, it is empty regarding the test vectors) and the code as far as I can see is equivalent.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Aug 14 2018
Aug 14 2018
awemany updated the diff for D1652: CHECKDATASIG(VERIFY): Update for single, raw SHA256 message hash.
Update formatting of comment after clang-format
awemany updated the diff for D1652: CHECKDATASIG(VERIFY): Update for single, raw SHA256 message hash.
Forgot to squash commits - didn't use phabricator for a long time.
Jul 27 2017
Jul 27 2017
awemany accepted D385: Do not increase the banscore of node forwarding transactions that are not valid yet..
make check runs successfully
awemany committed rABCd60dfef8c93b: Factor out getId() from Misbehaving(..) calls (authored by awemany).
Factor out getId() from Misbehaving(..) calls
Fix static
Formatting with clang-format-3.8 again.
Add ref to D380.
Herald added a reviewer for D384: Factor out getId() from Misbehaving(..) calls: Restricted Project.
make check works, log message testing is too much as per dev slack.
Maybe I am at Nazi complaint level here, but any new feature should be tested, no?
awemany committed rABC3fc5f7c2f7e2: Replace boost::unordered_map and boost::unordered_set with std:: variant (authored by awemany).
Replace boost::unordered_map and boost::unordered_set with std:: variant
Herald added a reviewer for D382: Replace boost::unordered_map and boost::unordered_set with std:: variant: Restricted Project.
Jun 22 2017
Jun 22 2017
See comments, make check passes.
See message, looks good and make check passes.
Jun 20 2017
Jun 20 2017
I didn't test this yet. But you wrote
Jun 14 2017
Jun 14 2017
Built and passed in 6s. But see also comments.
Herald added a reviewer for D199: Fix temporary file creation for validation_tests: Restricted Project.
Jun 13 2017
Jun 13 2017
Fix for rebase/merge failure
awemany closed D192: Fix for rebase/merge failure by committing rABC1d1ce9ab25e0: Fix for rebase/merge failure.
awemany committed rABC39fe309bab18: Test LoadExternalBlockFile explictly for blocks larger than 2*MAX_TX_SIZE (authored by awemany).
Test LoadExternalBlockFile explictly for blocks larger than 2*MAX_TX_SIZE
awemany updated the diff for D189: Test LoadExternalBlockFile explictly for blocks larger than 2*MAX_TX_SIZE.
Address review issues raised by deadalnix.
Herald added a reviewer for D189: Test LoadExternalBlockFile explictly for blocks larger than 2*MAX_TX_SIZE: Restricted Project.
awemany committed rABCf3d61491456d: Remove leftover short-circuit evaluation condition from bdb377d68ea8 (authored by awemany).
Remove leftover short-circuit evaluation condition from bdb377d68ea8
awemany updated the test plan for D185: Remove leftover short-circuit evaluation condition from bdb377d68ea8.
Herald added a reviewer for D185: Remove leftover short-circuit evaluation condition from bdb377d68ea8: Restricted Project.
Hi deadalnix,