Page MenuHomePhabricator
Feed All Stories

Today

PiRK accepted D18084: [chronik-client] Properly handle txs ordering in the test.

optional suggestions. The bytes flipping + explicit byteorder specification hurts my brain.

Tue, May 13, 06:04
PiRK added inline comments to D18084: [chronik-client] Properly handle txs ordering in the test.
Tue, May 13, 06:03
johnkuney updated the diff for D18066: [cashtab] Header UI overhaul.

rebase

Tue, May 13, 04:18
johnkuney updated the diff for D18066: [cashtab] Header UI overhaul.

fix tests and lint error

Tue, May 13, 04:16
johnkuney updated the diff for D18066: [cashtab] Header UI overhaul.
  • Remove zero balance messaging and just show 0.00 balance
  • Add links to XECX and Firma token pages
  • Remove color border
  • add horizontal scroll on mobile to reduce height
  • simplify style props
Tue, May 13, 03:52
arty000 accepted rABCWEBa53bf98c756d: [website] Update the upgrade page.
Tue, May 13, 00:25

Yesterday

Fabien closed D18080: [chronik] Electrum: add the blockchain.headers.subscribe endpoint.
Mon, May 12, 22:24
Fabien committed rABCd9be9a3dbe35: [chronik] Electrum: add the blockchain.headers.subscribe endpoint (authored by Fabien).
[chronik] Electrum: add the blockchain.headers.subscribe endpoint
Mon, May 12, 22:24
Fabien closed D18083: More clang-tidy fixes.
Mon, May 12, 22:24
Fabien committed rABC0b231a78864e: More clang-tidy fixes (authored by Fabien).
More clang-tidy fixes
Mon, May 12, 22:24
Fabien requested review of D18084: [chronik-client] Properly handle txs ordering in the test.
Mon, May 12, 22:17
PiRK accepted D18083: More clang-tidy fixes.
Mon, May 12, 22:04
Fabien closed D18081: Remove c++20 header.
Mon, May 12, 21:50
Fabien committed rABCd9414bd7cdc0: Remove c++20 header (authored by Fabien).
Remove c++20 header
Mon, May 12, 21:50
roqqit accepted D18081: Remove c++20 header.

builds on Debian 10 (buster) with gcc 8.3

Mon, May 12, 20:55
teamcity closed T3817: Build Bitcoin-ABC / Master / Sanitizers / Undefined Behavior Sanitizer (UBSAN) is broken. as Resolved.
Mon, May 12, 20:49
teamcity closed T3819: Build Bitcoin-ABC / Master / Sanitizers / Address Sanitizer (ASAN) is broken. as Resolved.
Mon, May 12, 20:48
teamcity closed T3818: Build Bitcoin-ABC / Master / Sanitizers / Thread Sanitizer (TSAN) is broken. as Resolved.
Mon, May 12, 20:44
Fabien requested review of D18083: More clang-tidy fixes.
Mon, May 12, 20:29
Fabien closed D18082: Fix a use after free error.
Mon, May 12, 20:26
Fabien committed rABCd0c31e0913ed: Fix a use after free error (authored by Fabien).
Fix a use after free error
Mon, May 12, 20:26
PiRK accepted D18081: Remove c++20 header.
Mon, May 12, 20:11
teamcity awarded D18082: Fix a use after free error a Haypence token.
Mon, May 12, 20:04
Fabien added a comment to D18082: Fix a use after free error.

@bot build-asan

Mon, May 12, 20:04
teamcity added a comment to D18073: refactor: Make const refs vars where applicable and enable related clang-tidy checks.
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
Mon, May 12, 19:57
PiRK accepted D18082: Fix a use after free error.
Mon, May 12, 19:53
Fabien requested review of D18082: Fix a use after free error.
Mon, May 12, 19:51
teamcity awarded D18073: refactor: Make const refs vars where applicable and enable related clang-tidy checks a Piece of Eight token.
Mon, May 12, 19:47
PiRK added a comment to D18073: refactor: Make const refs vars where applicable and enable related clang-tidy checks.

@bot build-tsan

Mon, May 12, 19:47
Fabien requested review of D18081: Remove c++20 header.
Mon, May 12, 19:34
teamcity added a comment to D18076: clang-tidy: Add more performance checks.
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
Mon, May 12, 19:15
teamcity added a comment to D18071: clang-tidy: Add `performance-no-automatic-move` check.
Mon, May 12, 19:10
teamcity awarded D18076: clang-tidy: Add more performance checks a Haypence token.
Mon, May 12, 19:04
PiRK added a comment to D18076: clang-tidy: Add more performance checks.

@bot build-tsan

Mon, May 12, 19:04
teamcity awarded D18071: clang-tidy: Add `performance-no-automatic-move` check a Haypence token.
Mon, May 12, 19:04
PiRK added a comment to D18071: clang-tidy: Add `performance-no-automatic-move` check.

@bot build-tsan

Mon, May 12, 19:04
teamcity triaged T3819: Build Bitcoin-ABC / Master / Sanitizers / Address Sanitizer (ASAN) is broken. as Unbreak Now! priority.
Mon, May 12, 18:53
teamcity triaged T3818: Build Bitcoin-ABC / Master / Sanitizers / Thread Sanitizer (TSAN) is broken. as Unbreak Now! priority.
Mon, May 12, 18:52
teamcity triaged T3817: Build Bitcoin-ABC / Master / Sanitizers / Undefined Behavior Sanitizer (UBSAN) is broken. as Unbreak Now! priority.
Mon, May 12, 18:51
PiRK accepted D18080: [chronik] Electrum: add the blockchain.headers.subscribe endpoint.

looks good. Tested on mainnet, results are identical to electrum.bitcoinabc.org

Mon, May 12, 18:42
PiRK closed D18076: clang-tidy: Add more performance checks.
Mon, May 12, 18:39
PiRK planned changes to D18079: [assumeutxo] document and enforce incompatability with -chronik.
Mon, May 12, 18:39
PiRK committed rABCc76a8db83fc4: clang-tidy: Add more performance checks (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).
clang-tidy: Add more performance checks
Mon, May 12, 18:39
PiRK closed D18075: clang-tidy: Add `performance-inefficient-vector-operation` check.
Mon, May 12, 18:39
PiRK committed rABC4faf6bb42918: clang-tidy: Add `performance-inefficient-vector-operation` check (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).
clang-tidy: Add `performance-inefficient-vector-operation` check
Mon, May 12, 18:39
PiRK closed D18074: Fix clang-tidy readability-const-return-type violations.
Mon, May 12, 18:39
PiRK closed D18073: refactor: Make const refs vars where applicable and enable related clang-tidy checks.
Mon, May 12, 18:39
PiRK committed rABCfe1b2b8724d7: Fix clang-tidy readability-const-return-type violations (authored by MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>).
Fix clang-tidy readability-const-return-type violations
Mon, May 12, 18:39
PiRK committed rABC83dd42f64f19: tidy: add readability-redundant-declaration (authored by fanquake <fanquake@gmail.com>).
tidy: add readability-redundant-declaration
Mon, May 12, 18:39
PiRK closed D18072: tidy: add readability-redundant-declaration.
Mon, May 12, 18:39
PiRK committed rABC656fea8be36d: refactor: Make const refs vars where applicable and enable related clang-tidy… (authored by Aurèle Oulès <aurele@oules.com>).
refactor: Make const refs vars where applicable and enable related clang-tidy…
Mon, May 12, 18:39
PiRK closed D18071: clang-tidy: Add `performance-no-automatic-move` check.
Mon, May 12, 18:39
PiRK committed rABCcdb730172f4f: clang-tidy: Add `performance-no-automatic-move` check (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).
clang-tidy: Add `performance-no-automatic-move` check
Mon, May 12, 18:39
Kronkmeister closed D18078: [e.cash] Add Trezor to e.cash/wallets list.
Mon, May 12, 17:07
Kronkmeister committed rABC32700bf2f40f: [e.cash] Add Trezor to e.cash/wallets list (authored by Kronkmeister).
[e.cash] Add Trezor to e.cash/wallets list
Mon, May 12, 17:07
bytesofman accepted D18078: [e.cash] Add Trezor to e.cash/wallets list.
Mon, May 12, 16:41
teamcity added a comment to D18078: [e.cash] Add Trezor to e.cash/wallets list.

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.178.130.230:41475 for the next 60 minutes.

Mon, May 12, 16:37
teamcity awarded D18078: [e.cash] Add Trezor to e.cash/wallets list a Haypence token.
Mon, May 12, 16:35
bytesofman added a comment to D18078: [e.cash] Add Trezor to e.cash/wallets list.

@bot preview-e.cash

Mon, May 12, 16:35
teamcity added a comment to D18080: [chronik] Electrum: add the blockchain.headers.subscribe endpoint.
Mon, May 12, 15:51
Fabien requested review of D18080: [chronik] Electrum: add the blockchain.headers.subscribe endpoint.
Mon, May 12, 15:40
teamcity added a comment to D18079: [assumeutxo] document and enforce incompatability with -chronik.
Mon, May 12, 15:16
teamcity added a comment to D18079: [assumeutxo] document and enforce incompatability with -chronik.
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
Mon, May 12, 15:16
teamcity added a comment to D18079: [assumeutxo] document and enforce incompatability with -chronik.
Mon, May 12, 15:13
PiRK requested review of D18079: [assumeutxo] document and enforce incompatability with -chronik.
Mon, May 12, 15:09
tobias_ruck accepted D17928: [chronik] Add address.rs from givelotus/bitcoinsuite into bitcoinsuite-chronik-client.
Mon, May 12, 14:56
Fabien accepted D18071: clang-tidy: Add `performance-no-automatic-move` check.
Mon, May 12, 14:40
Fabien closed D18077: Revert "[chronik] Electrum: add the blockchain.headers.subscribe endpoint".
Mon, May 12, 14:40
Fabien added a reverting change for D18068: [chronik] Electrum: add the blockchain.headers.subscribe endpoint: rABCcdb17840db55: Revert "[chronik] Electrum: add the blockchain.headers.subscribe endpoint".
Mon, May 12, 14:40
Fabien committed rABCcdb17840db55: Revert "[chronik] Electrum: add the blockchain.headers.subscribe endpoint" (authored by Fabien).
Revert "[chronik] Electrum: add the blockchain.headers.subscribe endpoint"
Mon, May 12, 14:40
Fabien added a reverting change for rABC9b02451660e2: [chronik] Electrum: add the blockchain.headers.subscribe endpoint: rABCcdb17840db55: Revert "[chronik] Electrum: add the blockchain.headers.subscribe endpoint".
Mon, May 12, 14:40
PiRK accepted D18077: Revert "[chronik] Electrum: add the blockchain.headers.subscribe endpoint".
Mon, May 12, 14:30
Fabien updated the summary of D18077: Revert "[chronik] Electrum: add the blockchain.headers.subscribe endpoint".
Mon, May 12, 14:30
Fabien requested review of D18077: Revert "[chronik] Electrum: add the blockchain.headers.subscribe endpoint".
Mon, May 12, 14:30
Kronkmeister published D18078: [e.cash] Add Trezor to e.cash/wallets list for review.
Mon, May 12, 13:37
Fabien planned changes to D18077: Revert "[chronik] Electrum: add the blockchain.headers.subscribe endpoint".
Mon, May 12, 13:12
Fabien requested review of D18077: Revert "[chronik] Electrum: add the blockchain.headers.subscribe endpoint".
Mon, May 12, 13:11
Fabien added a reverting change for rABC9b02451660e2: [chronik] Electrum: add the blockchain.headers.subscribe endpoint: D18077: Revert "[chronik] Electrum: add the blockchain.headers.subscribe endpoint".
Mon, May 12, 13:11
Fabien added a reverting change for D18068: [chronik] Electrum: add the blockchain.headers.subscribe endpoint: D18077: Revert "[chronik] Electrum: add the blockchain.headers.subscribe endpoint".
Mon, May 12, 13:11
Fabien closed D18068: [chronik] Electrum: add the blockchain.headers.subscribe endpoint.
Mon, May 12, 12:57
Fabien committed rABC9b02451660e2: [chronik] Electrum: add the blockchain.headers.subscribe endpoint (authored by Fabien).
[chronik] Electrum: add the blockchain.headers.subscribe endpoint
Mon, May 12, 12:57
PiRK added inline comments to D18071: clang-tidy: Add `performance-no-automatic-move` check.
Mon, May 12, 12:55
PiRK updated the diff for D18071: clang-tidy: Add `performance-no-automatic-move` check.

add back const qualifier for colorText (never moved)

Mon, May 12, 12:53
Fabien accepted D18076: clang-tidy: Add more performance checks.
Mon, May 12, 12:47
Fabien accepted D18075: clang-tidy: Add `performance-inefficient-vector-operation` check.
Mon, May 12, 12:42
Fabien updated the test plan for D18068: [chronik] Electrum: add the blockchain.headers.subscribe endpoint.
Mon, May 12, 12:38
Fabien accepted D18074: Fix clang-tidy readability-const-return-type violations.
Mon, May 12, 12:37
Fabien accepted D18073: refactor: Make const refs vars where applicable and enable related clang-tidy checks.
Mon, May 12, 12:30
PiRK accepted D18068: [chronik] Electrum: add the blockchain.headers.subscribe endpoint.
Mon, May 12, 12:30
teamcity awarded D18073: refactor: Make const refs vars where applicable and enable related clang-tidy checks a Haypence token.
Mon, May 12, 12:28
Fabien added a comment to D18073: refactor: Make const refs vars where applicable and enable related clang-tidy checks.

@bot build-fuzzer

Mon, May 12, 12:28
Fabien accepted D18072: tidy: add readability-redundant-declaration.
Mon, May 12, 12:17
Fabien added inline comments to D18071: clang-tidy: Add `performance-no-automatic-move` check.
Mon, May 12, 12:14
alitayin added a comment to D18066: [cashtab] Header UI overhaul.

It is better to remove the color bars on the left side of these small cards, as they may mislead people into thinking they are dismissible notifications, alerts, or clickable items.

Mon, May 12, 12:04
Fabien accepted D17928: [chronik] Add address.rs from givelotus/bitcoinsuite into bitcoinsuite-chronik-client.
Mon, May 12, 12:03
PiRK added a comment to D18068: [chronik] Electrum: add the blockchain.headers.subscribe endpoint.

In the test plan it should probably be createwallet instead of create (that worked for me)

Mon, May 12, 12:02
Fabien updated the diff for D18068: [chronik] Electrum: add the blockchain.headers.subscribe endpoint.

Add integration test

Mon, May 12, 09:30
Fabien updated the test plan for D18068: [chronik] Electrum: add the blockchain.headers.subscribe endpoint.
Mon, May 12, 09:30
abc-bot committed rABCa09ee2d491cc: [Automated] Update seeds (authored by abc-bot).
[Automated] Update seeds
Mon, May 12, 07:25
PiRK updated the diff for D18076: clang-tidy: Add more performance checks.

fix remaining warning

Mon, May 12, 06:55