Page MenuHomePhabricator
Feed All Stories

All Stories
Use Results
Edit Query

Yesterday

bytesofman planned changes to D17822: [ecash-wallet] Add fluent API for building and broadcasting txs.

this is not a great stopping point but I have done so many rewrites and changes now that wanted to get some kind of anchor in for reference

Tue, Apr 22, 23:35
bytesofman updated the diff for D17822: [ecash-wallet] Add fluent API for building and broadcasting txs.

coming up for air, taking a look at what has happened

Tue, Apr 22, 23:30
roqqit requested review of D17972: [doc] Add productivity note about utilizing the ramdisk for faster testing.
Tue, Apr 22, 22:54
roqqit accepted D17969: [CI] Add a --ramdisk option to CI to store the regtest blockchain.
Tue, Apr 22, 22:41
teamcity closed T3787: Build Bitcoin-ABC / Master / Sanitizers / Thread Sanitizer (TSAN) is broken. as Resolved.
Tue, Apr 22, 21:58
teamcity awarded D17971: [avalanche] Fix a lock order inversion a Haypence token.
Tue, Apr 22, 21:56
Fabien added a comment to D17971: [avalanche] Fix a lock order inversion.

@bot build-tsan

Tue, Apr 22, 21:56
Fabien requested review of D17971: [avalanche] Fix a lock order inversion.
Tue, Apr 22, 21:56
teamcity updated the summary of D17970: Disable util::Result copying and assignment.
Tue, Apr 22, 21:46
Fabien requested review of D17970: Disable util::Result copying and assignment.
Tue, Apr 22, 21:46
PiRK closed D17966: assumeutxo,p2p: Start downloading historical blocks from common ancestor.
Tue, Apr 22, 21:43
PiRK committed rABC9b32c3476a3e: assumeutxo,p2p: Start downloading historical blocks from common ancestor (authored by Martin Zumsande <mzumsande@gmail.com>).
assumeutxo,p2p: Start downloading historical blocks from common ancestor
Tue, Apr 22, 21:43
teamcity triaged T3787: Build Bitcoin-ABC / Master / Sanitizers / Thread Sanitizer (TSAN) is broken. as Unbreak Now! priority.
Tue, Apr 22, 21:15
Gautam awarded T476: Write a script to automate the collection of gitian outputs a Like token.
Tue, Apr 22, 21:15 · Restricted Project
Gautam accepted D17969: [CI] Add a --ramdisk option to CI to store the regtest blockchain.

None

Tue, Apr 22, 21:14
Fabien requested changes to D17936: [chronik] Add block subscription functionality to websocket.rs within bitcoinsuite-chronik-client.

Can be simplified even more

Tue, Apr 22, 21:13
Fabien requested review of D17969: [CI] Add a --ramdisk option to CI to store the regtest blockchain.
Tue, Apr 22, 21:06
Fabien accepted D17966: assumeutxo,p2p: Start downloading historical blocks from common ancestor.
Tue, Apr 22, 21:02
Fabien closed D17832: [avalanche] Poll for the transactions that didn't make it into the last block.
Tue, Apr 22, 21:01
Fabien committed rABCa2de9f32d7c5: [avalanche] Poll for the transactions that didn't make it into the last block (authored by Fabien).
[avalanche] Poll for the transactions that didn't make it into the last block
Tue, Apr 22, 21:01
Fabien closed D17958: wallet: Move restorewallet() logic to the wallet section.
Tue, Apr 22, 21:00
Fabien committed rABCf27a78c214ed: wallet: Move restorewallet() logic to the wallet section (authored by w0xlt <94266259+w0xlt@users.noreply.github.com>).
wallet: Move restorewallet() logic to the wallet section
Tue, Apr 22, 21:00
alitayin closed D17949: [chronik-client] Add handling for WebSocket closure .
Tue, Apr 22, 20:26
alitayin committed rABCd27e5156c299: [chronik-client] Add handling for WebSocket closure (authored by alitayin).
[chronik-client] Add handling for WebSocket closure
Tue, Apr 22, 20:26
bytesofman accepted D17949: [chronik-client] Add handling for WebSocket closure .
Tue, Apr 22, 20:25
alitayin added a comment to D17949: [chronik-client] Add handling for WebSocket closure .

This diff will only address the issue of _websocketUrlConnects not closing the WebSocket under timeout conditions.

Tue, Apr 22, 20:15
alitayin updated the summary of D17949: [chronik-client] Add handling for WebSocket closure .
Tue, Apr 22, 20:13
PiRK committed rABC56115c774db2: init: avoid unsetting service bits from `nLocalServices` (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>).
init: avoid unsetting service bits from `nLocalServices`
Tue, Apr 22, 18:44
PiRK closed D17962: init: avoid unsetting service bits from `nLocalServices`.
Tue, Apr 22, 18:44
bytesofman closed D17967: [Cashtab] Improve flaky token test.
Tue, Apr 22, 18:42
bytesofman committed rABC15059d6b6f6a: [Cashtab] Improve flaky token test (authored by bytesofman).
[Cashtab] Improve flaky token test
Tue, Apr 22, 18:42
roqqit accepted D17832: [avalanche] Poll for the transactions that didn't make it into the last block.
Tue, Apr 22, 16:26
PiRK planned changes to D17968: assumeUTXO: fix peers disconnection during sync.
Tue, Apr 22, 15:30
teamcity added a comment to D17968: assumeUTXO: fix peers disconnection during sync.
Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.
Tue, Apr 22, 14:43
PiRK updated the diff for D17968: assumeUTXO: fix peers disconnection during sync.

rebase

Tue, Apr 22, 14:20
PiRK updated the diff for D17966: assumeutxo,p2p: Start downloading historical blocks from common ancestor.

rebase

Tue, Apr 22, 14:20
PiRK updated the diff for D17962: init: avoid unsetting service bits from `nLocalServices`.

rebase

Tue, Apr 22, 14:19
Fabien updated the diff for D17958: wallet: Move restorewallet() logic to the wallet section.

Rebase

Tue, Apr 22, 14:03
Fabien closed D17964: Safegcd-based modular inverses in MuHash3072.
Tue, Apr 22, 14:01
Fabien committed rABC24fbfa016454: Safegcd-based modular inverses in MuHash3072 (authored by Pieter Wuille <pieter@wuille.net>).
Safegcd-based modular inverses in MuHash3072
Tue, Apr 22, 14:01
Fabien accepted D17967: [Cashtab] Improve flaky token test.
Tue, Apr 22, 14:00
bytesofman published D17967: [Cashtab] Improve flaky token test for review.
Tue, Apr 22, 13:58
teamcity added a comment to D17968: assumeUTXO: fix peers disconnection during sync.
Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.
Tue, Apr 22, 13:45
PiRK updated the diff for D17968: assumeUTXO: fix peers disconnection during sync.

--blank line

Tue, Apr 22, 13:38
teamcity updated the summary of D17968: assumeUTXO: fix peers disconnection during sync.
Tue, Apr 22, 13:33
PiRK requested review of D17968: assumeUTXO: fix peers disconnection during sync.
Tue, Apr 22, 13:33
PiRK accepted D17958: wallet: Move restorewallet() logic to the wallet section.

lgtm, just check that the build-debug passes on CI after rebasing on D17964

Tue, Apr 22, 13:29
teamcity updated the summary of D17966: assumeutxo,p2p: Start downloading historical blocks from common ancestor.
Tue, Apr 22, 13:28
PiRK requested review of D17966: assumeutxo,p2p: Start downloading historical blocks from common ancestor.
Tue, Apr 22, 13:28
PiRK accepted D17964: Safegcd-based modular inverses in MuHash3072.
Tue, Apr 22, 13:15
teamcity closed T3786: Build Bitcoin-ABC / CashTab / CashTab Unit Tests is broken. as Resolved.
Tue, Apr 22, 13:10
Fabien closed D17965: [cmake] Add an override option for tmpdirprefix when running functional tests.
Tue, Apr 22, 13:02
Fabien committed rABC64e0fa66e7ee: [cmake] Add an override option for tmpdirprefix when running functional tests (authored by Fabien).
[cmake] Add an override option for tmpdirprefix when running functional tests
Tue, Apr 22, 13:02
Fabien updated the diff for D17964: Safegcd-based modular inverses in MuHash3072.

Fix dyslexia

Tue, Apr 22, 13:01
hazzarust updated the diff for D17936: [chronik] Add block subscription functionality to websocket.rs within bitcoinsuite-chronik-client.

Removed macro and created Mutex around data, so that we don't need to constantly lock().await

Tue, Apr 22, 12:16
PiRK accepted D17965: [cmake] Add an override option for tmpdirprefix when running functional tests.
Tue, Apr 22, 10:53
PiRK added inline comments to D17964: Safegcd-based modular inverses in MuHash3072.
Tue, Apr 22, 10:45
Fabien requested review of D17965: [cmake] Add an override option for tmpdirprefix when running functional tests.
Tue, Apr 22, 10:16
Fabien accepted D17962: init: avoid unsetting service bits from `nLocalServices`.
Tue, Apr 22, 10:04
teamcity triaged T3786: Build Bitcoin-ABC / CashTab / CashTab Unit Tests is broken. as Unbreak Now! priority.
Tue, Apr 22, 09:43
teamcity updated the summary of D17964: Safegcd-based modular inverses in MuHash3072.
Tue, Apr 22, 09:31
Fabien requested review of D17964: Safegcd-based modular inverses in MuHash3072.
Tue, Apr 22, 09:31
Fabien committed rABC648527259e11: fuzz: Update FuzzedDataProvider.h from upstream (LLVM) (authored by practicalswift <practicalswift@users.noreply.github.com>).
fuzz: Update FuzzedDataProvider.h from upstream (LLVM)
Tue, Apr 22, 09:31
Fabien closed D17963: fuzz: Update FuzzedDataProvider.h from upstream (LLVM).
Tue, Apr 22, 09:31
PiRK accepted D17963: fuzz: Update FuzzedDataProvider.h from upstream (LLVM).
Tue, Apr 22, 09:13
teamcity updated the summary of D17963: fuzz: Update FuzzedDataProvider.h from upstream (LLVM).
Tue, Apr 22, 09:04
Fabien requested review of D17963: fuzz: Update FuzzedDataProvider.h from upstream (LLVM).
Tue, Apr 22, 09:04
teamcity awarded D17962: init: avoid unsetting service bits from `nLocalServices` a Haypence token.
Tue, Apr 22, 07:24
Fabien added a comment to D17962: init: avoid unsetting service bits from `nLocalServices`.

@bot build-ibd

Tue, Apr 22, 07:24
teamcity added a comment to D17962: init: avoid unsetting service bits from `nLocalServices`.
Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.
Tue, Apr 22, 06:57
teamcity updated the summary of D17962: init: avoid unsetting service bits from `nLocalServices`.
Tue, Apr 22, 06:47
PiRK requested review of D17962: init: avoid unsetting service bits from `nLocalServices`.
Tue, Apr 22, 06:47
emack accepted D17949: [chronik-client] Add handling for WebSocket closure .
Tue, Apr 22, 01:15

Mon, Apr 21

PiRK closed D17952: refactor: remove ::vpwallets and related global variables.
Mon, Apr 21, 21:07
PiRK committed rABCb59ed33b3ac1: refactor: remove ::vpwallets and related global variables (authored by Russell Yanofsky <russ@yanofsky.org>).
refactor: remove ::vpwallets and related global variables
Mon, Apr 21, 21:07
teamcity added a comment to D17958: wallet: Move restorewallet() logic to the wallet section.
Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.
Mon, Apr 21, 20:19
Fabien added a comment to D17958: wallet: Move restorewallet() logic to the wallet section.
In D17958#409374, @teamcity wrote:
Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.

Failed tests logs:

====== Bitcoin ABC functional tests: feature_assumeutxo.py ======

------- Stdout: -------
2025-04-21T18:48:22.545000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_🏃_20250421_184717/feature_assumeutxo_24
2025-04-21T18:48:25.488000Z TestFramework (INFO): -- Testing assumeutxo + some indexes + pruning
2025-04-21T18:48:25.489000Z TestFramework (INFO): Creating a UTXO snapshot at height 299
2025-04-21T18:48:25.534000Z TestFramework (INFO): Test loading snapshot when headers are not synced
2025-04-21T18:48:29.236000Z TestFramework (INFO): Test bitcoind should fail when mempool not empty.
2025-04-21T18:48:31.530000Z TestFramework (INFO): Test different scenarios of loading invalid snapshot files
2025-04-21T18:48:31.530000Z TestFramework (INFO):   - snapshot file refering to a block that is not in the assumeutxo parameters
2025-04-21T18:48:31.534000Z TestFramework (INFO):   - snapshot file with wrong number of coins
2025-04-21T18:48:31.862000Z TestFramework (INFO):   - snapshot file with alternated UTXO data
2025-04-21T18:48:33.133000Z TestFramework (INFO): Test bitcoind should fail when file path is invalid.
2025-04-21T18:48:33.137000Z TestFramework (INFO): Loading snapshot into second node from /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_🏃_20250421_184717/feature_assumeutxo_24/node0/regtest/utxos.dat
2025-04-21T18:48:33.629000Z TestFramework (INFO): Submit a stale block that forked off the chain before the snapshot
2025-04-21T18:48:33.644000Z TestFramework (INFO): Submit a spending transaction for a snapshot chainstate coin to the mempool
2025-04-21T18:48:33.664000Z TestFramework (INFO): Restarting node to stop at height 359
2025-04-21T18:48:40.169000Z TestFramework (INFO): Checking that blocks are segmented on disk
2025-04-21T18:48:40.170000Z TestFramework (INFO): Restarted node before snapshot validation completed, reloading...
2025-04-21T18:48:42.337000Z TestFramework (INFO): Ensuring snapshot chain syncs to tip. (399)
2025-04-21T18:48:44.489000Z TestFramework (INFO): Ensuring background validation completes
2025-04-21T18:50:49.023000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
        self.wait_until(lambda: n1.getindexinfo() == completed_idx_state)
'''
2025-04-21T18:50:49.023000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 152, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 142, in _run_test_internal
    self.run_test()
  File "/work/test/functional/feature_assumeutxo.py", line 430, in run_test
    self.wait_until(lambda: n1.getindexinfo() == completed_idx_state)
  File "/work/test/functional/test_framework/test_framework.py", line 890, in wait_until
    return wait_until_helper(
           ^^^^^^^^^^^^^^^^^^
  File "/work/test/functional/test_framework/util.py", line 309, in wait_until_helper
    raise AssertionError(
AssertionError: Predicate ''''
        self.wait_until(lambda: n1.getindexinfo() == completed_idx_state)
''' not true after 120.0 seconds
2025-04-21T18:50:49.075000Z TestFramework (INFO): Stopping nodes
2025-04-21T18:50:49.379000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_🏃_20250421_184717/feature_assumeutxo_24
2025-04-21T18:50:49.379000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_🏃_20250421_184717/feature_assumeutxo_24/test_framework.log
2025-04-21T18:50:49.379000Z TestFramework (ERROR): 
2025-04-21T18:50:49.379000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_🏃_20250421_184717/feature_assumeutxo_24' to consolidate all logs
2025-04-21T18:50:49.379000Z TestFramework (ERROR): 
2025-04-21T18:50:49.379000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2025-04-21T18:50:49.379000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2025-04-21T18:50:49.379000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC functional tests: feature_assumeutxo.py

Mon, Apr 21, 20:09
teamcity added a comment to D17958: wallet: Move restorewallet() logic to the wallet section.
Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.
Mon, Apr 21, 18:54
Fabien updated the test plan for D17958: wallet: Move restorewallet() logic to the wallet section.
Mon, Apr 21, 18:44
Fabien published D17958: wallet: Move restorewallet() logic to the wallet section for review.
Mon, Apr 21, 18:44
Fabien accepted D17952: refactor: remove ::vpwallets and related global variables.
Mon, Apr 21, 18:44
teamcity closed T3785: Build Bitcoin-ABC / Master / Sanitizers / Address Sanitizer (ASAN) is broken. as Resolved.
Mon, Apr 21, 18:36
PiRK updated the diff for D17952: refactor: remove ::vpwallets and related global variables.

rebase on D17960

Mon, Apr 21, 18:36
Fabien added a comment to D17952: refactor: remove ::vpwallets and related global variables.

You can now rebase, the issue should be fixed

Mon, Apr 21, 18:23
Fabien closed D17961: Temporarly ignore the ASAN build failure in wallet_assumeutxo.
Mon, Apr 21, 18:22
Fabien committed rABCdebfff580e29: Temporarly ignore the ASAN build failure in wallet_assumeutxo (authored by Fabien).
Temporarly ignore the ASAN build failure in wallet_assumeutxo
Mon, Apr 21, 18:22
Fabien closed D17960: gui: Unregister wallet notifications before unloading wallets.
Mon, Apr 21, 18:21
Fabien committed rABC28cb76e32139: gui: Unregister wallet notifications before unloading wallets (authored by Fabien).
gui: Unregister wallet notifications before unloading wallets
Mon, Apr 21, 18:21
PiRK accepted D17961: Temporarly ignore the ASAN build failure in wallet_assumeutxo.
Mon, Apr 21, 15:59
PiRK accepted D17960: gui: Unregister wallet notifications before unloading wallets.
Mon, Apr 21, 15:58
teamcity awarded D17961: Temporarly ignore the ASAN build failure in wallet_assumeutxo a Haypence token.
Mon, Apr 21, 15:35
Fabien added a comment to D17961: Temporarly ignore the ASAN build failure in wallet_assumeutxo.

@bot build-asan

Mon, Apr 21, 15:35
Fabien requested review of D17961: Temporarly ignore the ASAN build failure in wallet_assumeutxo.
Mon, Apr 21, 15:35
teamcity updated the summary of D17960: gui: Unregister wallet notifications before unloading wallets.
Mon, Apr 21, 15:27
Fabien requested review of D17960: gui: Unregister wallet notifications before unloading wallets.
Mon, Apr 21, 15:27
abc-bot committed rABC078eeff814d1: [Automated] Update timing.json (authored by abc-bot).
[Automated] Update timing.json
Mon, Apr 21, 14:58
teamcity awarded D17952: refactor: remove ::vpwallets and related global variables a Piece of Eight token.
Mon, Apr 21, 13:02
PiRK added a comment to D17952: refactor: remove ::vpwallets and related global variables.

@bot build-tsan

Mon, Apr 21, 13:02
Fabien closed D17957: wallet: refactor GetNewDestination, use BResult.
Mon, Apr 21, 11:37
Fabien closed D17956: send: refactor CreateTransaction flow to return a BResult<CTransactionRef>.
Mon, Apr 21, 11:37
Next