Page MenuHomePhabricator
Feed All Stories

Today

roqqit updated the diff for D17728: [avalanche] Down-rank rejected contenders.

feedback

Mon, Mar 3, 17:43
teamcity triaged T3764: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Linux 64 is broken. as Unbreak Now! priority.
Mon, Mar 3, 17:43
roqqit closed D17700: [avalanche] Process responses to stake contender polls.
Mon, Mar 3, 17:11
roqqit committed rABCd25b7436bca1: [avalanche] Process responses to stake contender polls (authored by roqqit).
[avalanche] Process responses to stake contender polls
Mon, Mar 3, 17:11
roqqit requested review of D17737: [avalanche] Fix a race in contenders voting test (again).
Mon, Mar 3, 16:57
teamcity closed T3763: Build Bitcoin-ABC / Master / Native tests / Test Native OSX is broken. as Resolved.
Mon, Mar 3, 16:28
PiRK closed D17736: refactor: Reduce number of SanityChecks return values and return util::Result.
Mon, Mar 3, 16:11
PiRK committed rABC4b9853aa63ac: refactor: Reduce number of SanityChecks return values and return util::Result (authored by Ryan Ofsky <ryan@ofsky.org>).
refactor: Reduce number of SanityChecks return values and return util::Result
Mon, Mar 3, 16:11
PiRK closed D17723: [kernel 2c/n] Introduce kernel::Context, encapsulate global init/teardown.
Mon, Mar 3, 16:11
PiRK committed rABC7bc86ab136f9: [kernel 2c/n] Introduce kernel::Context, encapsulate global init/teardown (authored by Carl Dong <contact@carldong.me>).
[kernel 2c/n] Introduce kernel::Context, encapsulate global init/teardown
Mon, Mar 3, 16:11
PiRK closed D17735: build: remove ENABLE_GLICB_COMPAT from builds.
Mon, Mar 3, 16:11
PiRK committed rABCb1e851853035: build: remove ENABLE_GLICB_COMPAT from builds (authored by PiRK).
build: remove ENABLE_GLICB_COMPAT from builds
Mon, Mar 3, 16:11
Fabien accepted D17736: refactor: Reduce number of SanityChecks return values and return util::Result.
Mon, Mar 3, 15:27
Fabien accepted D17735: build: remove ENABLE_GLICB_COMPAT from builds.
Mon, Mar 3, 15:23
teamcity updated the summary of D17736: refactor: Reduce number of SanityChecks return values and return util::Result.
Mon, Mar 3, 14:39
PiRK requested review of D17736: refactor: Reduce number of SanityChecks return values and return util::Result.
Mon, Mar 3, 14:38
Fabien accepted D17723: [kernel 2c/n] Introduce kernel::Context, encapsulate global init/teardown.
Mon, Mar 3, 14:31
PiRK updated the diff for D17723: [kernel 2c/n] Introduce kernel::Context, encapsulate global init/teardown.

depend on D17735 to address one of the review items

Mon, Mar 3, 14:19
teamcity added a comment to D17735: build: remove ENABLE_GLICB_COMPAT from builds.
Mon, Mar 3, 14:17
teamcity awarded D17735: build: remove ENABLE_GLICB_COMPAT from builds a Piece of Eight token.
Mon, Mar 3, 14:08
PiRK published D17735: build: remove ENABLE_GLICB_COMPAT from builds for review.

@bot guix-linux guix-win guix-osx

Mon, Mar 3, 14:08
teamcity awarded D17735: build: remove ENABLE_GLICB_COMPAT from builds a Haypence token.
Mon, Mar 3, 13:46
PiRK added inline comments to D17723: [kernel 2c/n] Introduce kernel::Context, encapsulate global init/teardown.
Mon, Mar 3, 10:44
Fabien accepted D17733: [ecash-lib] Add `compressPk` to `Ecc`.
Mon, Mar 3, 10:20
Fabien added a comment to D17734: [ecash-lib] Add `payment` with `asn1` and `x509`.

Is there any reason for not using an existing off-the-shelf lib for this task ?

Mon, Mar 3, 10:07
Fabien added inline comments to D17733: [ecash-lib] Add `compressPk` to `Ecc`.
Mon, Mar 3, 09:42
Fabien requested changes to D17723: [kernel 2c/n] Introduce kernel::Context, encapsulate global init/teardown.
Mon, Mar 3, 09:29
teamcity triaged T3763: Build Bitcoin-ABC / Master / Native tests / Test Native OSX is broken. as Unbreak Now! priority.
Mon, Mar 3, 09:13
Fabien closed D17717: [avalanche] Also finalize the ancestors of a transaction.
Mon, Mar 3, 08:58
Fabien committed rABC37ee28b3d040: [avalanche] Also finalize the ancestors of a transaction (authored by Fabien).
[avalanche] Also finalize the ancestors of a transaction
Mon, Mar 3, 08:58
Fabien accepted D17700: [avalanche] Process responses to stake contender polls.
Mon, Mar 3, 08:57
Fabien requested changes to D17728: [avalanche] Down-rank rejected contenders.
Mon, Mar 3, 08:50
teamcity added a comment to D17734: [ecash-lib] Add `payment` with `asn1` and `x509`.
Mon, Mar 3, 08:45
tobias_ruck updated the diff for D17734: [ecash-lib] Add `payment` with `asn1` and `x509`.

change readString to return Uint8Array

Mon, Mar 3, 08:38
tobias_ruck updated the diff for D17734: [ecash-lib] Add `payment` with `asn1` and `x509`.

change readCert to parseCert

Mon, Mar 3, 08:29
Fabien updated the diff for D17717: [avalanche] Also finalize the ancestors of a transaction.

Better log message, unleash my full ascii art creativity skills

Mon, Mar 3, 08:23
PiRK closed D17730: tests: use noban_tx_relay in more tests.
Mon, Mar 3, 08:11
PiRK committed rABCc71468342225: tests: use noban_tx_relay in more tests (authored by PiRK).
tests: use noban_tx_relay in more tests
Mon, Mar 3, 08:11
tobias_ruck updated the diff for D17734: [ecash-lib] Add `payment` with `asn1` and `x509`.

rebase

Mon, Mar 3, 08:08
tobias_ruck updated the diff for D17733: [ecash-lib] Add `compressPk` to `Ecc`.

fix types

Mon, Mar 3, 07:39
bytesofman closed D17720: [Cashtab] Show Firma on agora page.
Mon, Mar 3, 00:26
bytesofman committed rABC65d7ab9d4e84: [Cashtab] Show Firma on agora page (authored by bytesofman).
[Cashtab] Show Firma on agora page
Mon, Mar 3, 00:26
johnkuney accepted D17720: [Cashtab] Show Firma on agora page.
Mon, Mar 3, 00:23
bytesofman published D17720: [Cashtab] Show Firma on agora page for review.
Mon, Mar 3, 00:19

Yesterday

teamcity added a comment to D17734: [ecash-lib] Add `payment` with `asn1` and `x509`.
Sun, Mar 2, 22:45
bytesofman accepted D17732: [ecash-lib] Add `ecdsaVerify` and `schnorrVerify` to `Ecc`.
Sun, Mar 2, 22:39
teamcity added a comment to D17734: [ecash-lib] Add `payment` with `asn1` and `x509`.
Sun, Mar 2, 22:37
teamcity added a comment to D17734: [ecash-lib] Add `payment` with `asn1` and `x509`.
Sun, Mar 2, 22:37
teamcity added a comment to D17734: [ecash-lib] Add `payment` with `asn1` and `x509`.
Sun, Mar 2, 22:36
teamcity added a comment to D17734: [ecash-lib] Add `payment` with `asn1` and `x509`.
Sun, Mar 2, 22:36
tobias_ruck updated the summary of D17734: [ecash-lib] Add `payment` with `asn1` and `x509`.
Sun, Mar 2, 22:26
tobias_ruck updated the test plan for D17734: [ecash-lib] Add `payment` with `asn1` and `x509`.
Sun, Mar 2, 22:22
tobias_ruck requested review of D17734: [ecash-lib] Add `payment` with `asn1` and `x509`.
Sun, Mar 2, 22:19
abc-bot committed rABC2ce646a8b5c2: [Automated] Update seeds (authored by abc-bot).
[Automated] Update seeds
Sun, Mar 2, 22:14
abc-bot committed rABC3d01d55fcd4d: [Automated] Update chainparams (authored by abc-bot).
[Automated] Update chainparams
Sun, Mar 2, 22:07
abc-bot committed rABC71453954f334: [Automated] Update timing.json (authored by abc-bot).
[Automated] Update timing.json
Sun, Mar 2, 21:38
teamcity added a comment to D17733: [ecash-lib] Add `compressPk` to `Ecc`.
Sun, Mar 2, 21:24
teamcity added a comment to D17733: [ecash-lib] Add `compressPk` to `Ecc`.
Sun, Mar 2, 21:17
teamcity added a comment to D17733: [ecash-lib] Add `compressPk` to `Ecc`.
Sun, Mar 2, 21:17
teamcity added a comment to D17733: [ecash-lib] Add `compressPk` to `Ecc`.
Sun, Mar 2, 21:16
teamcity added a comment to D17733: [ecash-lib] Add `compressPk` to `Ecc`.
Sun, Mar 2, 21:16
tobias_ruck requested review of D17733: [ecash-lib] Add `compressPk` to `Ecc`.
Sun, Mar 2, 21:14
tobias_ruck requested review of D17732: [ecash-lib] Add `ecdsaVerify` and `schnorrVerify` to `Ecc`.
Sun, Mar 2, 19:56

Sat, Mar 1

bytesofman closed D17726: [Cashtab] Include FIRMA in balance header and fiat balance.
Sat, Mar 1, 13:28
bytesofman committed rABCe73aef19b191: [Cashtab] Include FIRMA in balance header and fiat balance (authored by bytesofman).
[Cashtab] Include FIRMA in balance header and fiat balance
Sat, Mar 1, 13:28
bytesofman closed D17731: [ecash-herald] Show the date of the activity in the msg header.
Sat, Mar 1, 13:20
bytesofman committed rABC8fe9069a9b06: [ecash-herald] Show the date of the activity in the msg header (authored by bytesofman).
[ecash-herald] Show the date of the activity in the msg header
Sat, Mar 1, 13:20
emack accepted D17726: [Cashtab] Include FIRMA in balance header and fiat balance.
Sat, Mar 1, 07:30
emack accepted D17731: [ecash-herald] Show the date of the activity in the msg header.
Sat, Mar 1, 07:17

Fri, Feb 28

abc-bot committed rABC685052f08d31: [Automated] Update electrum checkpoints (authored by abc-bot).
[Automated] Update electrum checkpoints
Fri, Feb 28, 23:09
bytesofman published D17731: [ecash-herald] Show the date of the activity in the msg header for review.
Fri, Feb 28, 22:43
teamcity closed T3762: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Linux AArch64 is broken. as Resolved.
Fri, Feb 28, 22:25
bytesofman closed D17725: [ecash-herald] Send daily summaries to the main chat.
Fri, Feb 28, 22:14
bytesofman committed rABC5dba84431a89: [ecash-herald] Send daily summaries to the main chat (authored by bytesofman).
[ecash-herald] Send daily summaries to the main chat
Fri, Feb 28, 22:14
roqqit closed D17729: [avalanche] Fix a race in contenders voting test.
Fri, Feb 28, 21:45
roqqit committed rABCd029363ecc33: [avalanche] Fix a race in contenders voting test (authored by roqqit).
[avalanche] Fix a race in contenders voting test
Fri, Feb 28, 21:45
bytesofman closed D17724: [ecash-herald] Do not use polling for the telegram bot.
Fri, Feb 28, 21:42
bytesofman committed rABCf718de701eb1: [ecash-herald] Do not use polling for the telegram bot (authored by bytesofman).
[ecash-herald] Do not use polling for the telegram bot
Fri, Feb 28, 21:42
roqqit accepted D17730: tests: use noban_tx_relay in more tests.
Fri, Feb 28, 21:22
PiRK accepted D17729: [avalanche] Fix a race in contenders voting test.
Fri, Feb 28, 21:21
PiRK requested review of D17730: tests: use noban_tx_relay in more tests.
Fri, Feb 28, 21:19
roqqit requested review of D17729: [avalanche] Fix a race in contenders voting test.
Fri, Feb 28, 21:15
teamcity triaged T3762: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Linux AArch64 is broken. as Unbreak Now! priority.
Fri, Feb 28, 20:49
teamcity closed T3761: Build Bitcoin-ABC / Master / Sanitizers / Thread Sanitizer (TSAN) is broken. as Resolved.
Fri, Feb 28, 20:28
PiRK closed D17722: indexes, refactor: Remove CBlockIndex* uses in index Init methods.
Fri, Feb 28, 20:13
PiRK committed rABC3f303c2e897e: indexes, refactor: Remove CBlockIndex* uses in index Init methods (authored by Ryan Ofsky <ryan@ofsky.org>).
indexes, refactor: Remove CBlockIndex* uses in index Init methods
Fri, Feb 28, 20:13
PiRK closed D17721: indexes, refactor: Remove CBlockIndex* uses in coinstatsindex LookUpOne function.
Fri, Feb 28, 20:13
PiRK committed rABCef4a1052f5f0: indexes, refactor: Remove CBlockIndex* uses in coinstatsindex LookUpOne function (authored by Ryan Ofsky <ryan@ofsky.org>).
indexes, refactor: Remove CBlockIndex* uses in coinstatsindex LookUpOne function
Fri, Feb 28, 20:13
PiRK accepted D17725: [ecash-herald] Send daily summaries to the main chat.
Fri, Feb 28, 20:11
PiRK accepted D17724: [ecash-herald] Do not use polling for the telegram bot.
Fri, Feb 28, 20:10
roqqit accepted D17722: indexes, refactor: Remove CBlockIndex* uses in index Init methods.

reviewer note: the call to CustomInit() got added to BaseIndex::Start() in one commit and removed in the other. it makes comparing each to this patch a bit weird.

Fri, Feb 28, 18:47
teamcity triaged T3761: Build Bitcoin-ABC / Master / Sanitizers / Thread Sanitizer (TSAN) is broken. as Unbreak Now! priority.
Fri, Feb 28, 18:44
roqqit accepted D17721: indexes, refactor: Remove CBlockIndex* uses in coinstatsindex LookUpOne function.
Fri, Feb 28, 18:33
roqqit accepted D17717: [avalanche] Also finalize the ancestors of a transaction.

re: the note at the end of the summary: when you write this other diff, be sure to include test coverage that attempt to poll finalized ancestors. there is risk of regression here otherwise.

Fri, Feb 28, 18:29
bytesofman closed D17727: [mock-chronik-client] Major version bump for new chronik-client types.
Fri, Feb 28, 18:29
bytesofman committed rABC15ff3ada9e81: [mock-chronik-client] Major version bump for new chronik-client types (authored by bytesofman).
[mock-chronik-client] Major version bump for new chronik-client types
Fri, Feb 28, 18:29
johnkuney accepted D17727: [mock-chronik-client] Major version bump for new chronik-client types.
Fri, Feb 28, 18:28
roqqit added inline comments to D17700: [avalanche] Process responses to stake contender polls.
Fri, Feb 28, 18:22
roqqit requested review of D17728: [avalanche] Down-rank rejected contenders.
Fri, Feb 28, 18:21
roqqit added inline comments to D17700: [avalanche] Process responses to stake contender polls.
Fri, Feb 28, 18:18