Page MenuHomePhabricator
Feed All Stories

Aug 9 2019

teamcity added a comment to D3833: Merge #11395: Qt: Enable searching by transaction id.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 9 2019, 00:06

Aug 8 2019

nakihito planned changes to D3833: Merge #11395: Qt: Enable searching by transaction id.
Aug 8 2019, 23:57
nakihito created D3833: Merge #11395: Qt: Enable searching by transaction id.
Aug 8 2019, 23:57
nakihito planned changes to D3832: Merge #11015: [Qt] Add delay before filtering transactions.
Aug 8 2019, 23:55
jasonbcox committed rABC2804a49bfc07: Updated manpages for 0.19.12 release (authored by jasonbcox).
Updated manpages for 0.19.12 release
Aug 8 2019, 23:34
jasonbcox closed D3831: Updated manpages for 0.19.12 release.
Aug 8 2019, 23:34
jasonbcox committed rABCf17b81e0786b: Update chainparams (authored by jasonbcox).
Update chainparams
Aug 8 2019, 23:33
jasonbcox closed D3830: Update chainparams.
Aug 8 2019, 23:33
teamcity added a comment to D3832: Merge #11015: [Qt] Add delay before filtering transactions.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 8 2019, 23:31
jasonbcox added a comment to D3830: Update chainparams.

You can always change the minimum chainwork via command line if you want to switch chains.

Aug 8 2019, 23:30
jasonbcox committed rABCd68d2d9e613f: Update seeds (authored by jasonbcox).
Update seeds
Aug 8 2019, 23:27
jasonbcox closed D3829: Update seeds.
Aug 8 2019, 23:27
jasonbcox committed rABC400a92157546: Added some release notes for 0.19.12 release (authored by jasonbcox).
Added some release notes for 0.19.12 release
Aug 8 2019, 23:27
jasonbcox closed D3828: Added some release notes for 0.19.12 release.
Aug 8 2019, 23:26
teamcity added a comment to D3832: Merge #11015: [Qt] Add delay before filtering transactions.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 8 2019, 23:24
nakihito created D3832: Merge #11015: [Qt] Add delay before filtering transactions.
Aug 8 2019, 23:24
Nico Guiton <nico@bitframe.org> committed rABC4afd5d82e98d: Merge #12284: Remove assigned but never used local variables. Enable linter… (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #12284: Remove assigned but never used local variables. Enable linter…
Aug 8 2019, 22:49
Nico Guiton <nico@bitframe.org> closed D3814: Merge #12284: Remove assigned but never used local variables. Enable linter checking for unused local variables..
Aug 8 2019, 22:49
Fabien accepted D3814: Merge #12284: Remove assigned but never used local variables. Enable linter checking for unused local variables..
Aug 8 2019, 20:49
Mengerian accepted D3830: Update chainparams.

The chainwork should be as high as the highest seen PoW and does not need to match the assume valid block. However, it should always be greater than the assume valid block, which is obvious. See D3732

Aug 8 2019, 20:41
teamcity added a comment to D3814: Merge #12284: Remove assigned but never used local variables. Enable linter checking for unused local variables..

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 8 2019, 20:40
nakihito updated the test plan for D3814: Merge #12284: Remove assigned but never used local variables. Enable linter checking for unused local variables..
Aug 8 2019, 20:34
teamcity added a comment to D3814: Merge #12284: Remove assigned but never used local variables. Enable linter checking for unused local variables..

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 8 2019, 20:34
nakihito updated the diff for D3814: Merge #12284: Remove assigned but never used local variables. Enable linter checking for unused local variables..

Removed non-functional lines and no longer need imports.

Aug 8 2019, 20:34
Fabien accepted D3831: Updated manpages for 0.19.12 release.
Aug 8 2019, 20:12
Fabien accepted D3830: Update chainparams.
Aug 8 2019, 20:05
jasonbcox accepted D3805: Merge #12716: Fix typos and cleanup in various files.
Aug 8 2019, 19:44
jasonbcox accepted D3810: Merge #13194: Remove template matching and pseudo opcodes.
Aug 8 2019, 19:40
jasonbcox requested review of D3830: Update chainparams.

The chainwork should be as high as the highest seen PoW and does not need to match the assume valid block. However, it should always be greater than the assume valid block, which is obvious. See D3732

Aug 8 2019, 19:35
jasonbcox accepted D3826: [CMAKE] Avoid duplicating the compiler/linker flags.
Aug 8 2019, 19:34
Mengerian requested changes to D3830: Update chainparams.

Seems strange that chainwork does not correspond to the block hashes used for assumevalid.

Aug 8 2019, 19:31
jasonbcox accepted D3825: [CMAKE] Fix -Wunused-command-line-argument when adding linker flag.
Aug 8 2019, 19:30
jasonbcox accepted D3824: build: avoid getifaddrs when unavailable.
Aug 8 2019, 19:20
teamcity added a comment to D3831: Updated manpages for 0.19.12 release.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 8 2019, 18:52
teamcity added a comment to D3830: Update chainparams.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 8 2019, 18:47
teamcity added a comment to D3831: Updated manpages for 0.19.12 release.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 8 2019, 18:45
teamcity added a comment to D3831: Updated manpages for 0.19.12 release.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 8 2019, 18:44
jasonbcox created D3831: Updated manpages for 0.19.12 release.
Aug 8 2019, 18:44
teamcity added a comment to D3830: Update chainparams.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 8 2019, 18:41
jasonbcox created D3830: Update chainparams.
Aug 8 2019, 18:41
Fabien accepted D3805: Merge #12716: Fix typos and cleanup in various files.
Aug 8 2019, 18:29
Fabien accepted D3828: Added some release notes for 0.19.12 release.
Aug 8 2019, 18:28
Fabien accepted D3829: Update seeds.
Aug 8 2019, 18:27
teamcity added a comment to D3805: Merge #12716: Fix typos and cleanup in various files.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 8 2019, 18:14
teamcity added a comment to D3829: Update seeds.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 8 2019, 18:04
teamcity added a comment to D3805: Merge #12716: Fix typos and cleanup in various files.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 8 2019, 18:01
nakihito updated the diff for D3805: Merge #12716: Fix typos and cleanup in various files.

Fixed formatting and another typo.

Aug 8 2019, 18:00
teamcity added a comment to D3829: Update seeds.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 8 2019, 17:58
jasonbcox created D3829: Update seeds.
Aug 8 2019, 17:58
teamcity added a comment to D3828: Added some release notes for 0.19.12 release.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 8 2019, 17:38
teamcity added a comment to D3828: Added some release notes for 0.19.12 release.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 8 2019, 17:32
jasonbcox created D3828: Added some release notes for 0.19.12 release.
Aug 8 2019, 17:31
jasonbcox committed rABC9d1d31fe6b4d: Merge #12569: net: Increase signal-to-noise ratio in debug.log by adjusting log… (authored by jasonbcox).
Merge #12569: net: Increase signal-to-noise ratio in debug.log by adjusting log…
Aug 8 2019, 17:27
jasonbcox closed D3822: Merge #12569: net: Increase signal-to-noise ratio in debug.log by adjusting log level when logging failed non-manual connect():s.
Aug 8 2019, 17:27
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABC22961ed53191: better error message for mandatory-flag tx rejections (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>).
better error message for mandatory-flag tx rejections
Aug 8 2019, 16:44
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> closed D3811: better error message for mandatory-flag tx rejections.
Aug 8 2019, 16:44
teamcity added a comment to D3822: Merge #12569: net: Increase signal-to-noise ratio in debug.log by adjusting log level when logging failed non-manual connect():s.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 8 2019, 16:21
jasonbcox committed rABC4a608c655010: Merge #12537: [arith_uint256] Make it safe to use "self" in operators (authored by jasonbcox).
Merge #12537: [arith_uint256] Make it safe to use "self" in operators
Aug 8 2019, 16:18
jasonbcox closed D3819: Merge #12537: [arith_uint256] Make it safe to use "self" in operators.
Aug 8 2019, 16:18
teamcity added a comment to D3822: Merge #12569: net: Increase signal-to-noise ratio in debug.log by adjusting log level when logging failed non-manual connect():s.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 8 2019, 16:14
jasonbcox updated the diff for D3822: Merge #12569: net: Increase signal-to-noise ratio in debug.log by adjusting log level when logging failed non-manual connect():s.

fixed nit

Aug 8 2019, 16:13
teamcity added a comment to D3827: [CMAKE] Make secp256k1 build standalone.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 8 2019, 14:56
teamcity added a comment to D3825: [CMAKE] Fix -Wunused-command-line-argument when adding linker flag.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 8 2019, 14:51
teamcity added a comment to D3826: [CMAKE] Avoid duplicating the compiler/linker flags.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 8 2019, 14:50
teamcity added a comment to D3827: [CMAKE] Make secp256k1 build standalone.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 8 2019, 14:50
Fabien created D3827: [CMAKE] Make secp256k1 build standalone.
Aug 8 2019, 14:46
teamcity added a comment to D3826: [CMAKE] Avoid duplicating the compiler/linker flags.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 8 2019, 14:42
Fabien created D3826: [CMAKE] Avoid duplicating the compiler/linker flags.
Aug 8 2019, 14:42
teamcity added a comment to D3825: [CMAKE] Fix -Wunused-command-line-argument when adding linker flag.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 8 2019, 14:39
Fabien created D3825: [CMAKE] Fix -Wunused-command-line-argument when adding linker flag.
Aug 8 2019, 14:39
teamcity added a comment to D3824: build: avoid getifaddrs when unavailable.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 8 2019, 12:02
teamcity added a comment to D3824: build: avoid getifaddrs when unavailable.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 8 2019, 11:51
Fabien created D3824: build: avoid getifaddrs when unavailable.
Aug 8 2019, 11:50
teamcity added a comment to D3823: build: Enable -Wredundant-decls where available.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 8 2019, 10:06
teamcity added a comment to D3823: build: Enable -Wredundant-decls where available.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 8 2019, 09:55
Fabien created D3823: build: Enable -Wredundant-decls where available.
Aug 8 2019, 09:40
Fabien committed rABC4412d8ab7a09: build: add missing leveldb defines (authored by Cory Fields <cory-nospam-@coryfields.com>).
build: add missing leveldb defines
Aug 8 2019, 08:50
Fabien closed D3817: build: add missing leveldb defines.
Aug 8 2019, 08:50
Fabien committed rABC0c4d36b3425d: Fix leveldb compilation for NetBSD (authored by Randolf Richardson <randolf@richardson.tw>).
Fix leveldb compilation for NetBSD
Aug 8 2019, 08:48
Fabien closed D3816: Fix leveldb compilation for NetBSD.
Aug 8 2019, 08:48
Fabien committed rABC4bc8ab85992e: Detect if char equals int8_t (authored by Chun Kuan Lee <ken2812221@gmail.com>).
Detect if char equals int8_t
Aug 8 2019, 08:45
Fabien closed D3815: Detect if char equals int8_t.
Aug 8 2019, 08:44
Fabien committed rABCb44d73a64c20: Enforce clang-format version 7.x (authored by Fabien).
Enforce clang-format version 7.x
Aug 8 2019, 08:42
Fabien closed D3806: Enforce clang-format version 7.x.
Aug 8 2019, 08:42
Fabien requested changes to D3814: Merge #12284: Remove assigned but never used local variables. Enable linter checking for unused local variables..

Some of the tests modified by this diff have their estimated duration > 40s (you can check this from test/functional/timing.json).
Therefore they are not run as part of test_runner.py but are part of the extended tests, requiring the use of test_runner.py --extended to be run.
You need to try it and add it to the test plan once you're sure that the patch did not introduce any regression.

Aug 8 2019, 08:38
Fabien accepted D3822: Merge #12569: net: Increase signal-to-noise ratio in debug.log by adjusting log level when logging failed non-manual connect():s.
Aug 8 2019, 08:33
Fabien accepted D3819: Merge #12537: [arith_uint256] Make it safe to use "self" in operators.
Aug 8 2019, 08:23
Fabien requested changes to D3805: Merge #12716: Fix typos and cleanup in various files.
Aug 8 2019, 07:16
deadalnix accepted D3806: Enforce clang-format version 7.x.
Aug 8 2019, 05:37
teamcity added a comment to D3820: Merge #12918: test: Assert on correct variable.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 8 2019, 00:04
teamcity added a comment to D3732: Added a script to generate chainparams intermediate files.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Aug 8 2019, 00:03

Aug 7 2019

jasonbcox committed rABC4391a2e6d76f: Merge #12925: wallet: Logprint the start of a rescan (authored by jasonbcox).
Merge #12925: wallet: Logprint the start of a rescan
Aug 7 2019, 23:59
jasonbcox closed D3821: Merge #12925: wallet: Logprint the start of a rescan.
Aug 7 2019, 23:59
teamcity added a comment to D3820: Merge #12918: test: Assert on correct variable.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 7 2019, 23:58
jasonbcox committed rABC267c3977cfaf: Merge #12918: test: Assert on correct variable (authored by jasonbcox).
Merge #12918: test: Assert on correct variable
Aug 7 2019, 23:58
jasonbcox closed D3820: Merge #12918: test: Assert on correct variable.
Aug 7 2019, 23:58
teamcity added a comment to D3732: Added a script to generate chainparams intermediate files.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Aug 7 2019, 23:56
jasonbcox updated the diff for D3732: Added a script to generate chainparams intermediate files.
  • Added check-devtools to make/ninja check
  • Ignore linter warning about imports at top of the file
Aug 7 2019, 23:56
nakihito accepted D3820: Merge #12918: test: Assert on correct variable.
Aug 7 2019, 23:35
nakihito accepted D3821: Merge #12925: wallet: Logprint the start of a rescan.
Aug 7 2019, 23:34