Page MenuHomePhabricator
Feed All Stories

Oct 14 2019

nakihito created D4249: Fix --wipeignore and add message indicating if wipe options are set and successful.
Oct 14 2019, 19:20
teamcity added a comment to D4248: Merge #13722: trivial: Replace CPubKey::operator[] with CPubKey::vch where possible.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 14 2019, 19:08
teamcity added a comment to D4248: Merge #13722: trivial: Replace CPubKey::operator[] with CPubKey::vch where possible.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 14 2019, 18:52
nakihito created D4248: Merge #13722: trivial: Replace CPubKey::operator[] with CPubKey::vch where possible.
Oct 14 2019, 18:52
teamcity added a comment to D3689: Merge #11293: Deduplicate CMerkleBlock construction code, add test coverage.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 14 2019, 18:23
teamcity added a comment to D3689: Merge #11293: Deduplicate CMerkleBlock construction code, add test coverage.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 14 2019, 18:08
nakihito planned changes to D3689: Merge #11293: Deduplicate CMerkleBlock construction code, add test coverage.
Oct 14 2019, 18:07
nakihito updated the diff for D3689: Merge #11293: Deduplicate CMerkleBlock construction code, add test coverage.

Restored comment change.

Oct 14 2019, 18:07
nakihito added a comment to D3689: Merge #11293: Deduplicate CMerkleBlock construction code, add test coverage.

Updated summary to reflect changes.

Oct 14 2019, 17:59
nakihito updated the summary of D3689: Merge #11293: Deduplicate CMerkleBlock construction code, add test coverage.
Oct 14 2019, 17:59
deadalnix requested changes to D4223: Update Seeder to use ArgsManager.

This is almost impossible to figure out if this patch missed something or not as it combine logic changes with refactoring.

Oct 14 2019, 17:10
deadalnix requested changes to D4225: Merge #14444: Add compile time checking for cs_main locks which we assert at run time.

Why is that split this way? s there a reason this patch cannot be done by itself as it is in the PR?

Oct 14 2019, 17:02
deadalnix committed rABC4d6e498e3767: Decodehextx scripts sanity check (authored by Andrew Chow <achow101-github@achow101.com>).
Decodehextx scripts sanity check
Oct 14 2019, 16:03
deadalnix closed D4247: Decodehextx scripts sanity check.
Oct 14 2019, 16:02
teamcity added a comment to D4229: [CMAKE] Build bitcoinconsensus library both static and shared.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 14 2019, 15:14
teamcity added a comment to D4229: [CMAKE] Build bitcoinconsensus library both static and shared.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 14 2019, 14:59
Fabien updated the diff for D4229: [CMAKE] Build bitcoinconsensus library both static and shared.

Attempt to make the interface more simple and clear.
The add_library_with_type() function manages adding a library with one type or
more (STATIC, SHARED or both) but let the caller deal with properties.
This makes it easier to apply some property to only the static or shared variant
of a library if both are added.

Oct 14 2019, 14:59
Fabien updated the summary of D4229: [CMAKE] Build bitcoinconsensus library both static and shared.
Oct 14 2019, 14:34
Fabien accepted D4247: Decodehextx scripts sanity check.
Oct 14 2019, 06:18
jasonbcox accepted D4190: Rename master key to seed.
Oct 14 2019, 03:43

Oct 12 2019

Nico Guiton <nico@bitframe.org> committed rABCabb7cfc0104c: Update seeder files to use fprintf() instead of printf() (authored by Nico Guiton <nico@bitframe.org>).
Update seeder files to use fprintf() instead of printf()
Oct 12 2019, 19:50
Nico Guiton <nico@bitframe.org> closed D4222: Update seeder files to use fprintf() instead of printf().
Oct 12 2019, 19:50
Nico Guiton <nico@bitframe.org> committed rABCdb003f8301e2: Merge #9598: Improve readability by removing redundant casts to same type (on… (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #9598: Improve readability by removing redundant casts to same type (on…
Oct 12 2019, 19:46
Nico Guiton <nico@bitframe.org> closed D4230: Merge #9598: Improve readability by removing redundant casts to same type (on all platforms).
Oct 12 2019, 19:46
deadalnix requested changes to D4240: [gitian-build] Remove ambiguous buildsign argument.

Why increased automation would make this parameter obsolete? Why remove it before such automation exists and the parameter actually is obsolete?

Oct 12 2019, 13:15
deadalnix requested changes to D4241: [gitian-build] Rename ambiguous --sign argument.

First, I'm not convinced this is ambiguous. What would you sign in there that makes any sense? Is that worth breaking things? Second, the test plan doesn't cover the feature whatsoever.

Oct 12 2019, 13:13
deadalnix accepted D4222: Update seeder files to use fprintf() instead of printf().
Oct 12 2019, 13:09
deadalnix accepted D4230: Merge #9598: Improve readability by removing redundant casts to same type (on all platforms).
Oct 12 2019, 13:07
deadalnix requested changes to D4234: bench: Benchmark MempoolToJSON.

It looks like you have dependencies to backport first.

Oct 12 2019, 13:04
Nico Guiton <nico@bitframe.org> committed rABC7f1df1c95985: Merge #13275: Qt: use [default wallet] as name for wallet with no name (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #13275: Qt: use [default wallet] as name for wallet with no name
Oct 12 2019, 04:52
Nico Guiton <nico@bitframe.org> closed D4244: Merge #13275: Qt: use [default wallet] as name for wallet with no name.
Oct 12 2019, 04:52
Nico Guiton <nico@bitframe.org> committed rABC962952f31a0a: Merge #13506: Qt: load wallet in UI after possible init aborts (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #13506: Qt: load wallet in UI after possible init aborts
Oct 12 2019, 04:45
Nico Guiton <nico@bitframe.org> closed D4238: Merge #13506: Qt: load wallet in UI after possible init aborts.
Oct 12 2019, 04:45
Nico Guiton <nico@bitframe.org> committed rABC9a4a353f1328: Merge #13564: [wallet] loadwallet shouldn't create new wallets. (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #13564: [wallet] loadwallet shouldn't create new wallets.
Oct 12 2019, 04:41
Nico Guiton <nico@bitframe.org> closed D4239: Merge #13564: [wallet] loadwallet shouldn't create new wallets..
Oct 12 2019, 04:41
teamcity added a comment to D4223: Update Seeder to use ArgsManager.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 12 2019, 04:39
Nico Guiton <nico@bitframe.org> committed rABC482ae43a56df: Merge #13097: ui: Support wallets loaded dynamically (authored by Jonas Schnelli <dev@jonasschnelli.ch>).
Merge #13097: ui: Support wallets loaded dynamically
Oct 12 2019, 04:38
Nico Guiton <nico@bitframe.org> closed D4236: Merge #13097: ui: Support wallets loaded dynamically.
Oct 12 2019, 04:38
nakihito requested review of D4230: Merge #9598: Improve readability by removing redundant casts to same type (on all platforms).
Oct 12 2019, 04:31
teamcity added a comment to D4223: Update Seeder to use ArgsManager.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 12 2019, 04:30
nakihito updated the diff for D4223: Update Seeder to use ArgsManager.

Removed AppInit() and moved functionality to main().

Oct 12 2019, 04:29
deadalnix accepted D4236: Merge #13097: ui: Support wallets loaded dynamically.
Oct 12 2019, 01:33
deadalnix accepted D4238: Merge #13506: Qt: load wallet in UI after possible init aborts.
Oct 12 2019, 01:30
deadalnix accepted D4239: Merge #13564: [wallet] loadwallet shouldn't create new wallets..
Oct 12 2019, 01:29
deadalnix accepted D4244: Merge #13275: Qt: use [default wallet] as name for wallet with no name.
Oct 12 2019, 01:25
teamcity added a comment to D4247: Decodehextx scripts sanity check.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 12 2019, 01:22
teamcity added a comment to D4247: Decodehextx scripts sanity check.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 12 2019, 01:07
deadalnix created D4247: Decodehextx scripts sanity check.
Oct 12 2019, 01:07
teamcity added a comment to D4223: Update Seeder to use ArgsManager.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 12 2019, 00:45
teamcity added a comment to D4230: Merge #9598: Improve readability by removing redundant casts to same type (on all platforms).

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing passed.

Oct 12 2019, 00:42
teamcity added a comment to D4244: Merge #13275: Qt: use [default wallet] as name for wallet with no name.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 12 2019, 00:42
teamcity added a comment to D4230: Merge #9598: Improve readability by removing redundant casts to same type (on all platforms).

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing passed.

Oct 12 2019, 00:40
nakihito planned changes to D4223: Update Seeder to use ArgsManager.
Oct 12 2019, 00:38
teamcity added a comment to D4236: Merge #13097: ui: Support wallets loaded dynamically.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 12 2019, 00:38
teamcity added a comment to D4223: Update Seeder to use ArgsManager.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 12 2019, 00:33
teamcity added a comment to D4244: Merge #13275: Qt: use [default wallet] as name for wallet with no name.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 12 2019, 00:29
teamcity added a comment to D4230: Merge #9598: Improve readability by removing redundant casts to same type (on all platforms).

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing started.

Oct 12 2019, 00:29
teamcity added a comment to D4230: Merge #9598: Improve readability by removing redundant casts to same type (on all platforms).

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing passed.

Oct 12 2019, 00:29
nakihito updated the test plan for D4230: Merge #9598: Improve readability by removing redundant casts to same type (on all platforms).
Oct 12 2019, 00:27
teamcity added a comment to D4236: Merge #13097: ui: Support wallets loaded dynamically.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 12 2019, 00:25
teamcity added a comment to D4230: Merge #9598: Improve readability by removing redundant casts to same type (on all platforms).

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing started.

Oct 12 2019, 00:24
teamcity added a comment to D4230: Merge #9598: Improve readability by removing redundant casts to same type (on all platforms).

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing started.

Oct 12 2019, 00:24
nakihito updated the diff for D4223: Update Seeder to use ArgsManager.

Rebased.

Oct 12 2019, 00:22
nakihito updated the diff for D4244: Merge #13275: Qt: use [default wallet] as name for wallet with no name.

Rebased.

Oct 12 2019, 00:18
nakihito updated the diff for D4236: Merge #13097: ui: Support wallets loaded dynamically.

Rebased.

Oct 12 2019, 00:16
Nico Guiton <nico@bitframe.org> committed rABCce33ec89a97f: Merge #13273: Qt/Bugfix: fix handling default wallet with no name (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #13273: Qt/Bugfix: fix handling default wallet with no name
Oct 12 2019, 00:15
Nico Guiton <nico@bitframe.org> closed D4245: Merge #13273: Qt/Bugfix: fix handling default wallet with no name.
Oct 12 2019, 00:14

Oct 11 2019

Nico Guiton <nico@bitframe.org> committed rABC26f1841307ed: Version Bump to v20.5 (authored by Nico Guiton <nico@bitframe.org>).
Version Bump to v20.5
Oct 11 2019, 23:59
Nico Guiton <nico@bitframe.org> closed D4246: Version Bump to v20.5.
Oct 11 2019, 23:59
teamcity added a comment to D4246: Version Bump to v20.5.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 11 2019, 23:45
nakihito updated the test plan for D4246: Version Bump to v20.5.
Oct 11 2019, 23:40
jasonbcox accepted D4246: Version Bump to v20.5.
Oct 11 2019, 23:38
nakihito updated the test plan for D4246: Version Bump to v20.5.
Oct 11 2019, 23:34
nakihito updated the summary of D4246: Version Bump to v20.5.
Oct 11 2019, 23:33
teamcity added a comment to D4246: Version Bump to v20.5.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 11 2019, 23:33
nakihito created D4246: Version Bump to v20.5.
Oct 11 2019, 23:33
teamcity added a comment to D4244: Merge #13275: Qt: use [default wallet] as name for wallet with no name.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 11 2019, 23:29
jasonbcox accepted D4245: Merge #13273: Qt/Bugfix: fix handling default wallet with no name.
Oct 11 2019, 23:26
nakihito updated the test plan for D4245: Merge #13273: Qt/Bugfix: fix handling default wallet with no name.
Oct 11 2019, 23:26
nakihito requested review of D4239: Merge #13564: [wallet] loadwallet shouldn't create new wallets..
Oct 11 2019, 23:23
teamcity added a comment to D4245: Merge #13273: Qt/Bugfix: fix handling default wallet with no name.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 11 2019, 23:22
teamcity added a comment to D4244: Merge #13275: Qt: use [default wallet] as name for wallet with no name.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 11 2019, 23:20
nakihito updated the diff for D4244: Merge #13275: Qt: use [default wallet] as name for wallet with no name.

Added release notes.

Oct 11 2019, 23:19
nakihito requested review of D4236: Merge #13097: ui: Support wallets loaded dynamically.
Oct 11 2019, 23:17
nakihito requested review of D4238: Merge #13506: Qt: load wallet in UI after possible init aborts.
Oct 11 2019, 23:16
nakihito requested review of D4244: Merge #13275: Qt: use [default wallet] as name for wallet with no name.
Oct 11 2019, 23:16
nakihito updated the summary of D4236: Merge #13097: ui: Support wallets loaded dynamically.
Oct 11 2019, 23:15
nakihito requested review of D4245: Merge #13273: Qt/Bugfix: fix handling default wallet with no name.
Oct 11 2019, 23:15
nakihito updated the test plan for D4245: Merge #13273: Qt/Bugfix: fix handling default wallet with no name.
Oct 11 2019, 23:15
teamcity added a comment to D4245: Merge #13273: Qt/Bugfix: fix handling default wallet with no name.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 11 2019, 23:13
nakihito planned changes to D4245: Merge #13273: Qt/Bugfix: fix handling default wallet with no name.
Oct 11 2019, 23:13
nakihito created D4245: Merge #13273: Qt/Bugfix: fix handling default wallet with no name.
Oct 11 2019, 23:13
teamcity added a comment to D4244: Merge #13275: Qt: use [default wallet] as name for wallet with no name.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 11 2019, 21:32
teamcity added a comment to D4234: bench: Benchmark MempoolToJSON.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 11 2019, 21:28
teamcity added a comment to D4234: bench: Benchmark MempoolToJSON.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 11 2019, 21:26
teamcity added a comment to D4244: Merge #13275: Qt: use [default wallet] as name for wallet with no name.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 11 2019, 21:23
teamcity added a comment to D4243: rpc: Expose g_is_mempool_loaded via getmempoolinfo.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Oct 11 2019, 21:23
nakihito planned changes to D4244: Merge #13275: Qt: use [default wallet] as name for wallet with no name.
Oct 11 2019, 21:22
nakihito created D4244: Merge #13275: Qt: use [default wallet] as name for wallet with no name.
Oct 11 2019, 21:22
teamcity added a comment to D4234: bench: Benchmark MempoolToJSON.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Oct 11 2019, 21:14