Page MenuHomePhabricator
Feed All Stories

Nov 4 2019

nakihito updated the summary of D4368: [wallet] [rpc] Remove duplicate entries in rpcwallet.cpp's CRPCCommand table.
Nov 4 2019, 19:09
teamcity added a comment to D4368: [wallet] [rpc] Remove duplicate entries in rpcwallet.cpp's CRPCCommand table.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 4 2019, 19:08
nakihito created D4368: [wallet] [rpc] Remove duplicate entries in rpcwallet.cpp's CRPCCommand table.
Nov 4 2019, 19:08
nakihito updated the summary of D4361: [tests] Rename rpc_listtransactions.py to wallet_listtransactions.py.
Nov 4 2019, 19:08
jasonbcox requested review of D4367: Added a build config to explicitly run all extended tests.
Nov 4 2019, 18:09
jasonbcox added a comment to D4367: Added a build config to explicitly run all extended tests.

build-extended-tests all green: https://build.bitcoinabc.org/viewLog.html?buildId=21344&buildTypeId=BitcoinABC_BitcoinAbcStaging&tab=buildResultsDiv
Run time is ~35 minutes.

Nov 4 2019, 18:09
jasonbcox accepted D4365: scripted-diff: test: Use py3.5 bytes::hex() method.
Nov 4 2019, 17:47
teamcity added a comment to D4367: Added a build config to explicitly run all extended tests.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 4 2019, 17:45
teamcity added a comment to D4367: Added a build config to explicitly run all extended tests.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 4 2019, 17:18
jasonbcox accepted D4362: Fix various linter issues.
Nov 4 2019, 17:12
teamcity added a comment to D4367: Added a build config to explicitly run all extended tests.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 4 2019, 17:10
teamcity added a comment to D4367: Added a build config to explicitly run all extended tests.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 4 2019, 17:09
jasonbcox planned changes to D4367: Added a build config to explicitly run all extended tests.
Nov 4 2019, 17:09
jasonbcox created D4367: Added a build config to explicitly run all extended tests.
Nov 4 2019, 17:09
jasonbcox accepted D4366: scripted-diff: test: Remove brackets after assert.
Nov 4 2019, 16:49
Fabien committed rABC60b61d490000: [GITIAN] Sort dependencies lexically (authored by Fabien).
[GITIAN] Sort dependencies lexically
Nov 4 2019, 16:06
Fabien closed D4355: [GITIAN] Sort dependencies lexically.
Nov 4 2019, 16:06
Fabien committed rABC62d988958d9b: [GITIAN] Remove symbolic link to asm for 32-bits gitian build (authored by Fabien).
[GITIAN] Remove symbolic link to asm for 32-bits gitian build
Nov 4 2019, 16:05
Fabien closed D4354: [GITIAN] Remove symbolic link to asm for 32-bits gitian build.
Nov 4 2019, 16:05
teamcity added a comment to D4366: scripted-diff: test: Remove brackets after assert.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 4 2019, 16:02
teamcity added a comment to D4366: scripted-diff: test: Remove brackets after assert.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 4 2019, 15:52
Fabien created D4366: scripted-diff: test: Remove brackets after assert.
Nov 4 2019, 15:52
Fabien accepted D4360: Add simple FlatSigningProvider.
Nov 4 2019, 14:06
Fabien added a comment to D4357: Add scantxoutset RPC method.

Also the release notes are missing.

Nov 4 2019, 14:05
Fabien accepted D4359: Add more methods to Span class.
Nov 4 2019, 14:03
Fabien accepted D4358: Fix comment layout in client.h.
Nov 4 2019, 13:58
Fabien requested changes to D4357: Add scantxoutset RPC method.
Nov 4 2019, 13:58
Fabien requested changes to D4353: Tests for PSBT.
Nov 4 2019, 13:33
Fabien requested changes to D4352: Create wallet RPCs for PSBT.

This deserves release notes.

Nov 4 2019, 13:09
Fabien requested changes to D4351: Create utility RPCs for PSBT.

This deserves release notes.

Nov 4 2019, 12:32
teamcity added a comment to D4365: scripted-diff: test: Use py3.5 bytes::hex() method.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 4 2019, 11:37
teamcity added a comment to D4365: scripted-diff: test: Use py3.5 bytes::hex() method.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 4 2019, 11:29
Fabien created D4365: scripted-diff: test: Use py3.5 bytes::hex() method.
Nov 4 2019, 11:29
teamcity added a comment to D4364: Upgrade mac_alias to 2.0.7.

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing passed.

Nov 4 2019, 11:01
teamcity added a comment to D4363: [depends] mac_alias 2.0.6, ds_store 1.1.2.

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing passed.

Nov 4 2019, 11:01
teamcity added a comment to D4364: Upgrade mac_alias to 2.0.7.

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing started.

Nov 4 2019, 10:57
teamcity added a comment to D4363: [depends] mac_alias 2.0.6, ds_store 1.1.2.

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing started.

Nov 4 2019, 10:56
teamcity added a comment to D4364: Upgrade mac_alias to 2.0.7.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 4 2019, 10:19
teamcity added a comment to D4363: [depends] mac_alias 2.0.6, ds_store 1.1.2.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 4 2019, 10:13
teamcity added a comment to D4364: Upgrade mac_alias to 2.0.7.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 4 2019, 10:06
Fabien created D4364: Upgrade mac_alias to 2.0.7.
Nov 4 2019, 10:06
teamcity added a comment to D4363: [depends] mac_alias 2.0.6, ds_store 1.1.2.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 4 2019, 10:05
Fabien created D4363: [depends] mac_alias 2.0.6, ds_store 1.1.2.
Nov 4 2019, 10:05
teamcity added a comment to D4362: Fix various linter issues.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 4 2019, 09:29
teamcity added a comment to D4362: Fix various linter issues.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 4 2019, 09:20
Fabien created D4362: Fix various linter issues.
Nov 4 2019, 09:20
teamcity added a comment to D4350: [CMAKE] Generate the split-debug.sh script.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 4 2019, 09:08
Fabien planned changes to D4340: [CMAKE] Build the OSX DMG image.

Will split for better readability.

Nov 4 2019, 08:59
teamcity added a comment to D4350: [CMAKE] Generate the split-debug.sh script.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 4 2019, 08:58
Fabien updated the diff for D4350: [CMAKE] Generate the split-debug.sh script.

Avoid re-configuring at each call.

Nov 4 2019, 08:58
Fabien added inline comments to D4350: [CMAKE] Generate the split-debug.sh script.
Nov 4 2019, 08:57
teamcity added a comment to D4304: Merge #9662: Add createwallet "disableprivatekeys" option: a sane mode for watchonly-wallets.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 4 2019, 07:50
nakihito abandoned D4223: Update Seeder to use ArgsManager.
Nov 4 2019, 07:44
teamcity added a comment to D4304: Merge #9662: Add createwallet "disableprivatekeys" option: a sane mode for watchonly-wallets.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 4 2019, 07:39
nakihito planned changes to D4304: Merge #9662: Add createwallet "disableprivatekeys" option: a sane mode for watchonly-wallets.
Nov 4 2019, 07:39
nakihito updated the diff for D4304: Merge #9662: Add createwallet "disableprivatekeys" option: a sane mode for watchonly-wallets.

Reverted static_cast to functional cast to prevent issues of code ownership and reformatted a comment.

Nov 4 2019, 07:39
nakihito planned changes to D4304: Merge #9662: Add createwallet "disableprivatekeys" option: a sane mode for watchonly-wallets.
Nov 4 2019, 07:38
teamcity added a comment to D4361: [tests] Rename rpc_listtransactions.py to wallet_listtransactions.py.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 4 2019, 04:58
teamcity added a comment to D4361: [tests] Rename rpc_listtransactions.py to wallet_listtransactions.py.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 4 2019, 04:48
nakihito planned changes to D4361: [tests] Rename rpc_listtransactions.py to wallet_listtransactions.py.
Nov 4 2019, 04:48
nakihito created D4361: [tests] Rename rpc_listtransactions.py to wallet_listtransactions.py.
Nov 4 2019, 04:48

Nov 3 2019

teamcity added a comment to D4360: Add simple FlatSigningProvider.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 3 2019, 23:19
teamcity added a comment to D4360: Add simple FlatSigningProvider.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 3 2019, 23:07
deadalnix created D4360: Add simple FlatSigningProvider.
Nov 3 2019, 23:07
teamcity added a comment to D4359: Add more methods to Span class.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 3 2019, 18:20
teamcity added a comment to D4359: Add more methods to Span class.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 3 2019, 18:05
deadalnix created D4359: Add more methods to Span class.
Nov 3 2019, 18:05
teamcity added a comment to D4357: Add scantxoutset RPC method.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 3 2019, 17:35
teamcity added a comment to D4357: Add scantxoutset RPC method.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 3 2019, 17:26
deadalnix updated the diff for D4357: Add scantxoutset RPC method.

Make the method static

Nov 3 2019, 17:26
teamcity added a comment to D4358: Fix comment layout in client.h.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 3 2019, 15:03
teamcity added a comment to D4357: Add scantxoutset RPC method.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 3 2019, 14:53
teamcity added a comment to D4358: Fix comment layout in client.h.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 3 2019, 14:47
deadalnix created D4358: Fix comment layout in client.h.
Nov 3 2019, 14:47
teamcity added a comment to D4357: Add scantxoutset RPC method.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 3 2019, 14:44
deadalnix created D4357: Add scantxoutset RPC method.
Nov 3 2019, 14:44

Nov 2 2019

Nico Guiton <nico@bitframe.org> committed rABCa451959e86bb: test: Add lint to prevent SIGNAL/SLOT connect style (authored by João Barbosa <joao.paulo.barbosa@gmail.com>).
test: Add lint to prevent SIGNAL/SLOT connect style
Nov 2 2019, 20:16
Nico Guiton <nico@bitframe.org> closed D4306: test: Add lint to prevent SIGNAL/SLOT connect style.
Nov 2 2019, 20:16
deadalnix requested changes to D4304: Merge #9662: Add createwallet "disableprivatekeys" option: a sane mode for watchonly-wallets.
Nov 2 2019, 18:49
deadalnix requested changes to D4340: [CMAKE] Build the OSX DMG image.

This is a very large diff. You may want to split it up in more logical chunks, such as generating the different variation of the png. This would make review easier, and ensure that parts of it that are good do not end up blocked by arts that are not.

Nov 2 2019, 17:29
deadalnix accepted D4355: [GITIAN] Sort dependencies lexically.
Nov 2 2019, 17:03
deadalnix requested changes to D4350: [CMAKE] Generate the split-debug.sh script.
Nov 2 2019, 17:02
deadalnix accepted D4354: [GITIAN] Remove symbolic link to asm for 32-bits gitian build.

I trust this is correct.

Nov 2 2019, 16:59
teamcity added a comment to D4356: [CMAKE] Migrate linux gitian build to cmake and ninja.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 2 2019, 11:43
teamcity added a comment to D4356: [CMAKE] Migrate linux gitian build to cmake and ninja.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 2 2019, 11:34
Fabien created D4356: [CMAKE] Migrate linux gitian build to cmake and ninja.
Nov 2 2019, 11:34
teamcity added a comment to D4355: [GITIAN] Sort dependencies lexically.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 2 2019, 10:08
teamcity added a comment to D4355: [GITIAN] Sort dependencies lexically.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 2 2019, 09:59
Fabien created D4355: [GITIAN] Sort dependencies lexically.
Nov 2 2019, 09:59
Fabien accepted D4306: test: Add lint to prevent SIGNAL/SLOT connect style.
Nov 2 2019, 09:06
teamcity added a comment to D4350: [CMAKE] Generate the split-debug.sh script.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 2 2019, 08:48
Fabien retitled D4354: [GITIAN] Remove symbolic link to asm for 32-bits gitian build from [GITIAN] Remove link symbolic link to asm for 32-bits gitian build to [GITIAN] Remove symbolic link to asm for 32-bits gitian build.
Nov 2 2019, 08:42
teamcity added a comment to D4350: [CMAKE] Generate the split-debug.sh script.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 2 2019, 08:40
Fabien updated the diff for D4350: [CMAKE] Generate the split-debug.sh script.

Fix permissions.

Nov 2 2019, 08:39
teamcity added a comment to D4354: [GITIAN] Remove symbolic link to asm for 32-bits gitian build.

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing passed.

Nov 2 2019, 08:22
teamcity added a comment to D4354: [GITIAN] Remove symbolic link to asm for 32-bits gitian build.

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing started.

Nov 2 2019, 07:55
teamcity added a comment to D4354: [GITIAN] Remove symbolic link to asm for 32-bits gitian build.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 2 2019, 07:47
teamcity added a comment to D4354: [GITIAN] Remove symbolic link to asm for 32-bits gitian build.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 2 2019, 07:39
Fabien created D4354: [GITIAN] Remove symbolic link to asm for 32-bits gitian build.
Nov 2 2019, 07:39
teamcity added a comment to D4353: Tests for PSBT.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 2 2019, 02:00