Page MenuHomePhabricator
Feed All Stories

May 11 2023

PiRK requested review of D13889: [lint] replace autopep8 with black (everything but contrib).
May 11 2023, 08:01
PiRK requested review of D13888: [lint] replace autopep8 with black (test_framework).
May 11 2023, 07:24
PiRK requested review of D13887: [lint] replace autopep8 with black (test/functional/wallet_*).
May 11 2023, 07:22
PiRK requested review of D13886: [lint] replace autopep8 with black (test/functional/rpc_*).
May 11 2023, 07:19
PiRK requested review of D13885: [lint] replace autopep8 with black (test/functional/p2p_*).
May 11 2023, 07:17
PiRK closed D13881: [lint] replace autopep8 with black (test/functional/interface_*).
May 11 2023, 07:15
PiRK closed D13880: [lint] replace autopep8 with black (test/functional/feature_*).
May 11 2023, 07:15
PiRK committed rABCa97f5dd5f3f4: [lint] replace autopep8 with black (test/functional/interface_*) (authored by PiRK).
[lint] replace autopep8 with black (test/functional/interface_*)
May 11 2023, 07:15
PiRK committed rABC585999845447: [lint] replace autopep8 with black (test/functional/feature_*) (authored by PiRK).
[lint] replace autopep8 with black (test/functional/feature_*)
May 11 2023, 07:15
PiRK closed D13879: [lint] replace autopep8 with black (test/functional/[mempool,mining,misc]).
May 11 2023, 07:15
PiRK committed rABCc067daa43245: [lint] replace autopep8 with black (test/functional/[mempool,mining,misc]) (authored by PiRK).
[lint] replace autopep8 with black (test/functional/[mempool,mining,misc])
May 11 2023, 07:15
PiRK closed D13882: [lint] fix deprecation warning printed to stderr by black.
May 11 2023, 07:13
PiRK committed rABC8d208f8edbd8: [lint] fix deprecation warning printed to stderr by black (authored by PiRK).
[lint] fix deprecation warning printed to stderr by black
May 11 2023, 07:13
teamcity closed T3166: Build Bitcoin-ABC / Master / Coverage is broken. as Resolved.
May 11 2023, 05:02
abc-bot committed rABCf2f18b821140: [Automated] Update timing.json (authored by abc-bot).
[Automated] Update timing.json
May 11 2023, 03:36
teamcity triaged T3166: Build Bitcoin-ABC / Master / Coverage is broken. as Unbreak Now! priority.
May 11 2023, 00:29

May 10 2023

teamcity closed T3165: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Linux ARM is broken. as Resolved.
May 10 2023, 23:44
bytesofman closed D13884: [alias-server] replace util with lib.
May 10 2023, 23:06
bytesofman committed rABCe7310e71f64a: [alias-server] replace util with lib (authored by bytesofman).
[alias-server] replace util with lib
May 10 2023, 23:06
teamcity triaged T3165: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Linux ARM is broken. as Unbreak Now! priority.
May 10 2023, 22:59
Fabien accepted D13884: [alias-server] replace util with lib.
May 10 2023, 22:35
johnkuney added inline comments to D13874: [e.cash] Add roadmap section.
May 10 2023, 22:34
johnkuney updated the diff for D13874: [e.cash] Add roadmap section.

gitignor update

May 10 2023, 22:29
Fabien added inline comments to D13874: [e.cash] Add roadmap section.
May 10 2023, 22:29
bytesofman updated the diff for D13884: [alias-server] replace util with lib.

lint

May 10 2023, 22:21
bytesofman requested review of D13884: [alias-server] replace util with lib.
May 10 2023, 22:20
bytesofman added a comment to D13874: [e.cash] Add roadmap section.

also, if you run npm test, a folder coverage/ is created in the repo

May 10 2023, 22:19
johnkuney updated the diff for D13874: [e.cash] Add roadmap section.

add new colors, fix x overflow

May 10 2023, 22:16
Fabien accepted D13881: [lint] replace autopep8 with black (test/functional/interface_*).
May 10 2023, 22:15
Fabien accepted D13880: [lint] replace autopep8 with black (test/functional/feature_*).
May 10 2023, 22:15
bytesofman closed D13883: [ecashaddrjs] Add function to get outputScript from address.
May 10 2023, 22:14
bytesofman committed rABCe5e94dbac37b: [ecashaddrjs] Add function to get outputScript from address (authored by bytesofman).
[ecashaddrjs] Add function to get outputScript from address
May 10 2023, 22:14
Fabien accepted D13882: [lint] fix deprecation warning printed to stderr by black.
May 10 2023, 22:14
Fabien accepted D13879: [lint] replace autopep8 with black (test/functional/[mempool,mining,misc]).
May 10 2023, 22:13
Fabien accepted D13883: [ecashaddrjs] Add function to get outputScript from address.
May 10 2023, 22:12
bytesofman added a comment to D13874: [e.cash] Add roadmap section.

I do think maybe some like neon green and yellow could look cool with all the black and white, so could try that here, but it may also be better to stick with a light use of the established brand colors...

May 10 2023, 22:11
bytesofman added a comment to D13874: [e.cash] Add roadmap section.

Stealth mode should use different colors than nomral for "complete", "underway", and "planning" on the roadmap

Why? Seems like a subjective design choice, and I'm kind of still figuring out what exactly the stealth theme is as we go. So far its been make everything black and white, but this may be boring, so may play with lightly using the blue and pink, or could develop some different colors.

I do think maybe some like neon green and yellow could look cool with all the black and white, so could try that here, but it may also be better to stick with a light use of the established brand colors...

May 10 2023, 22:11
johnkuney added a comment to D13874: [e.cash] Add roadmap section.

Stealth mode should use different colors than nomral for "complete", "underway", and "planning" on the roadmap

May 10 2023, 21:42
bytesofman requested changes to D13874: [e.cash] Add roadmap section.

Stealth mode should use different colors than nomral for "complete", "underway", and "planning" on the roadmap

May 10 2023, 20:15
teamcity added a comment to D13874: [e.cash] Add roadmap section.

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.68.37.192:41686 for the next 60 minutes.

May 10 2023, 20:08
teamcity awarded D13874: [e.cash] Add roadmap section a Piece of Eight token.
May 10 2023, 20:07
bytesofman added a comment to D13874: [e.cash] Add roadmap section.

@bot preview-e.cash

May 10 2023, 20:07
johnkuney updated the diff for D13874: [e.cash] Add roadmap section.

use one description for roadmap method test

May 10 2023, 19:37
bytesofman requested changes to D13874: [e.cash] Add roadmap section.
May 10 2023, 19:14
bytesofman closed D13867: [Cashtab] Support alias registration of user input addresses.
May 10 2023, 19:06
bytesofman committed rABCaff2d5a7752d: [Cashtab] Support alias registration of user input addresses (authored by bytesofman).
[Cashtab] Support alias registration of user input addresses
May 10 2023, 19:06
PiRK updated the summary of D13882: [lint] fix deprecation warning printed to stderr by black.
May 10 2023, 18:35
johnkuney updated the summary of D13874: [e.cash] Add roadmap section.
May 10 2023, 18:23
johnkuney updated the diff for D13874: [e.cash] Add roadmap section.

Move and rename methods and create test/add jest

May 10 2023, 18:22
bytesofman added inline comments to D13874: [e.cash] Add roadmap section.
May 10 2023, 17:21
bytesofman planned changes to D13875: [herald] Upgrade miner parsing.
May 10 2023, 17:17
bytesofman updated the diff for D13883: [ecashaddrjs] Add function to get outputScript from address.

Bump minor version as feature is added in backwards compatible way

May 10 2023, 17:15
bytesofman requested review of D13883: [ecashaddrjs] Add function to get outputScript from address.
May 10 2023, 17:14
PiRK requested review of D13882: [lint] fix deprecation warning printed to stderr by black.
May 10 2023, 16:55
Mengerian closed D13868: [alias spec] Add Usage section.
May 10 2023, 16:00
Mengerian committed rABCa60da1178ba9: [alias spec] Add Usage section (authored by Mengerian).
[alias spec] Add Usage section
May 10 2023, 16:00
Mengerian updated the diff for D13868: [alias spec] Add Usage section.

Pluralize applications

May 10 2023, 16:00
teamcity closed T3163: Build Bitcoin-ABC / Master / Default Extended Tests is broken. as Resolved.
May 10 2023, 15:56
aimal accepted D13868: [alias spec] Add Usage section.
May 10 2023, 15:38
PiRK requested review of D13881: [lint] replace autopep8 with black (test/functional/interface_*).
May 10 2023, 15:35
PiRK updated the summary of D13880: [lint] replace autopep8 with black (test/functional/feature_*).
May 10 2023, 15:30
PiRK requested review of D13880: [lint] replace autopep8 with black (test/functional/feature_*).
May 10 2023, 15:29
PiRK requested review of D13879: [lint] replace autopep8 with black (test/functional/[mempool,mining,misc]).
May 10 2023, 15:23
PiRK closed D13878: [lint] replace autopep8 with black (test/functional/chronik_*).
May 10 2023, 15:10
PiRK committed rABC0996192bf1b3: [lint] replace autopep8 with black (test/functional/chronik_*) (authored by PiRK).
[lint] replace autopep8 with black (test/functional/chronik_*)
May 10 2023, 15:10
PiRK closed D13877: [lint] replace autopep8 with black (test/functional/abc_*).
May 10 2023, 15:10
PiRK committed rABCf43cedb5384c: [lint] replace autopep8 with black (test/functional/abc_*) (authored by PiRK).
[lint] replace autopep8 with black (test/functional/abc_*)
May 10 2023, 15:10
teamcity triaged T3163: Build Bitcoin-ABC / Master / Default Extended Tests is broken. as Unbreak Now! priority.
May 10 2023, 14:24
Fabien accepted D13878: [lint] replace autopep8 with black (test/functional/chronik_*).
May 10 2023, 14:18
Fabien accepted D13877: [lint] replace autopep8 with black (test/functional/abc_*).
May 10 2023, 14:17
bytesofman requested changes to D13874: [e.cash] Add roadmap section.

How do y'all do unit tests?

May 10 2023, 14:16
Fabien requested changes to D13874: [e.cash] Add roadmap section.
May 10 2023, 14:15
Fabien accepted D13867: [Cashtab] Support alias registration of user input addresses.
May 10 2023, 14:13
Fabien requested changes to D13875: [herald] Upgrade miner parsing.
May 10 2023, 14:06
Fabien added inline comments to D13875: [herald] Upgrade miner parsing.
May 10 2023, 14:06
Fabien added inline comments to D13875: [herald] Upgrade miner parsing.
May 10 2023, 13:54
bytesofman requested review of D13875: [herald] Upgrade miner parsing.
May 10 2023, 13:49
Fabien requested changes to D13875: [herald] Upgrade miner parsing.
May 10 2023, 13:32
PiRK closed D13876: [lint] replace autopep8 with black (test/functional/abc-*).
May 10 2023, 13:31
PiRK committed rABC87ab57fe9f4c: [lint] replace autopep8 with black (test/functional/abc-*) (authored by PiRK).
[lint] replace autopep8 with black (test/functional/abc-*)
May 10 2023, 13:31
PiRK requested review of D13878: [lint] replace autopep8 with black (test/functional/chronik_*).
May 10 2023, 13:00
teamcity awarded D13871: build: Makes rcc output always deterministic a Piece of Eight token.
May 10 2023, 12:33
PiRK accepted D13875: [herald] Upgrade miner parsing.
May 10 2023, 12:11
Fabien accepted D13876: [lint] replace autopep8 with black (test/functional/abc-*).
May 10 2023, 11:43
PiRK updated the diff for D13876: [lint] replace autopep8 with black (test/functional/abc-*).

add black to contributing.md and install-dependencies-bullseye.sh, fix comment in linter

May 10 2023, 11:09
Fabien requested changes to D13876: [lint] replace autopep8 with black (test/functional/abc-*).

You need to add black to:

  • The CI install script
  • The CONTRIBUTING document
May 10 2023, 09:33
PiRK requested review of D13877: [lint] replace autopep8 with black (test/functional/abc_*).
May 10 2023, 09:00
PiRK updated the diff for D13876: [lint] replace autopep8 with black (test/functional/abc-*).

use triple quotes for docstring as per PEP257

May 10 2023, 08:54
PiRK updated the summary of D13876: [lint] replace autopep8 with black (test/functional/abc-*).
May 10 2023, 08:48
PiRK updated the summary of D13876: [lint] replace autopep8 with black (test/functional/abc-*).
May 10 2023, 08:46
PiRK requested review of D13876: [lint] replace autopep8 with black (test/functional/abc-*).
May 10 2023, 08:46
Fabien closed D13869: Remove Makefile.
May 10 2023, 07:38
Fabien committed rABC9231451954b8: Remove Makefile (authored by Fabien).
Remove Makefile
May 10 2023, 07:38
johnkuney added a comment to D13874: [e.cash] Add roadmap section.

How do y'all do unit tests?

May 10 2023, 07:28
johnkuney updated the diff for D13874: [e.cash] Add roadmap section.

create helpers.js for status logic

May 10 2023, 07:27
bytesofman requested changes to D13874: [e.cash] Add roadmap section.
  • Move existing helper function to new file containing helper functions
  • Add helper functions for in-line comments
  • Add unit tests
May 10 2023, 04:01
johnkuney updated the diff for D13874: [e.cash] Add roadmap section.

make theme specific roadmap colors, move icon logic to function

May 10 2023, 02:56
johnkuney added a comment to D13874: [e.cash] Add roadmap section.

The x-overflow thats causing this is from the H2 image being to wide, so can adjust that in another diff I guess, take the new overflow rule off here and make a task to make position sticky work later

May 10 2023, 02:52
johnkuney added a comment to D13874: [e.cash] Add roadmap section.

Also, doesn't need to be fixed here, but the "eCash" in the top left of the nav bar looks shitty when it is over content, as in the above screenshot. Maybe show just the hex e logo without the text after the user starts scrolling? Would apply to desktop as well. Need a task.

May 10 2023, 02:02
johnkuney added a comment to D13874: [e.cash] Add roadmap section.

image.png (643×431 px, 192 KB)

width-chopping issue is back at 320px width

Also, doesn't need to be fixed here, but the "eCash" in the top left of the nav bar looks shitty when it is over content, as in the above screenshot. Maybe show just the hex e logo without the text after the user starts scrolling? Would apply to desktop as well. Need a task.

May 10 2023, 01:58