Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.19.73:41295 for the next 60 minutes.

@bot preview-e.cash

Transaction.from_io now requires a list of TxInputs rather than a list of coin dictionnaries.

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.178.130.230:41393 for the next 60 minutes.

@bot preview-e.cash

nothing is changing here so hard to say what is actually being done. will see impact in diff that implements this component. worthwhile to have a general announcement component and a special countdown component in the codebase, as both are expected to be used at regular intervals.

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.178.130.230:41456 for the next 60 minutes.

@bot preview-e.cash

better comments

Checked Mainnet upgrade block hash, looks good.

@bot build-ibd

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.19.73:41980 for the next 60 minutes.

@bot preview-e.cash

@bot preview-e.cash

better test_function name

add a wait_until helper and add comments to clarify why the block height is 0

The main reason for this test, besides demonstrating that we currently do the right thing, is to give us some more confidence that we are not breaking things when optimizing performance critical codepaths (D14703)

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.19.73:41148 for the next 60 minutes.

@bot preview-e.cash

changing polling interval to 10

add comment for supress hydrationprop

remove unneeded condition

so is this a case of expected behavior just happening to be how electrum is currently working? Seems kinda fortunate.

No infinite loop, add test to confirm expected error