Add P2PKH requirement
Fix typo

In D14808#332663, @PiRK wrote:

I'm still thinking about the best strategy to enable mypy on that codebase. It would be great to have it, it could save us from obvious bugs such as D14795. On the other hand, there is a very long way to go until all existing errors and warnings are fixed. So either we activate it file by file, the same way as I managed to activate flake8 back in the days (see for instance https://github.com/Bitcoin-ABC/ElectrumABC/pull/161/commits/d512bd4ef2d41e2ab807cddc21feab18f1f120cb), or we make a clever script that makes a list of existing errors and tests if no new error is introduced. But that could prove very noisy whenever some dependency changes a typehint in a function we are calling.

I'm still thinking about the best strategy to enable mypy on that codebase. It would be great to have it, it could save us from obvious bugs such as D14795. On the other hand, there is a very long way to go until all existing errors and warnings are fixed. So either we activate it file by file, the same way as I managed to activate flake8 back in the days (see for instance https://github.com/Bitcoin-ABC/ElectrumABC/pull/161/commits/d512bd4ef2d41e2ab807cddc21feab18f1f120cb), or we make a clever script that makes a list of existing errors and tests if no new error is introduced. But that could prove very noisy whenever some dependency changes a typehint in a function we are calling.

rebase after touching adjacent code in D14803

remove some branching in the code by unconditionally initializing the keys for index 0 before setting the index

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.19.73:41967 for the next 60 minutes.

@bot preview-e.cash

remove unused Dict

rebase

rebase

adjust the relevant unit test

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.178.130.230:41899 for the next 60 minutes.

@bot preview-e.cash

Update summary

Need to self review, look at file names and organization, add failover proxy ws tests for in-node chronik

Rebase on working ws

remove unnecessary synchronization code. This was needed in an old version of the code when the index could be set via some API.

back to your queue

remove special case for handling hangover from while loop, define ws before adding it to wsEndpoint, add error handling to ws tests

Don't special case a loop iteration

remove while loop

remove unused var

In D14795#332389, @bytesofman wrote:

Transaction.from_io now requires a list of TxInputs rather than a list of coin dictionnaries.

Is this the only remaining instance of the legacy form being used? Should update test plan to confirm this