Query: All Stories

	Include stories about projects I am a member of.

Updated for pricing array length 0 check, diff summary and test plan.

[electrum] push release notification for 5.2.10

[chronik-client] Generate proto file for in-node chronik

Note to myself: wait for the website to be deployed before landing (~10 minutes)

[e.cash] Add FAQ to staking page

[electrum] bump version to 5.2.10 and add release notes

[electrum] fix signature updating in fusion code

[avalanche] Don't log all the avahello we send

Please update your summary and test plan to match the last diff revision

[electrum] replace all len(tx.inputs()) with len(tx.txinputs())

[Automated] Update seeds

Tweak wording based on review comments

[Automated] Update chainparams

[Automated] Update timing.json

Updated array length checks, error message and price element index.

[ecash-herald] Add amount for staking rewards

[Cashtab] Do not try to parse outputscript of coinbase txs

Minor wording/simplification suggestions

In D14818#332833, @bytesofman wrote:

the problem is that the function does too many things. You should split it into logical pieces so you can bail early for coinbase txs without adding another nesting level that makes the code harder to follow.

similar to the tx functions, there is a lot of technical debt in parseChronikTx and it should be rewritten separately from this patch (which is needed to fix a critical issue for wallets with staking rewards).

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.19.73:41821 for the next 60 minutes.

Capitalize words in heading

the problem is that the function does too many things. You should split it into logical pieces so you can bail early for coinbase txs without adding another nesting level that makes the code harder to follow.

add test for parsing coinbase tx

There is no test for the change.

If you have a coinbase tx, dont iterate through inputs at all

this fixes the bug but is not the right implementation

remove debug logging

Per tg chat, disabling alias registration if the pricing array from API has more than one entry. I've kept the Alias component itself still accessible as the user should still be able to check their purchased aliases, which is separate from pricing matters.

will print xec amount if price is unavailable, e.g.

In D14758#332754, @Fabien wrote:

Rename NNG types that will conflict with ChronikClientNode (even though these types are in separate files, bc they are used by ChronikClient and ChronikClientNode, and both objects are exported, ts will not allow them to have the same name)

Is there no kind of namespace ? Or maybe make it a member of the ChronikClient

name the generated file specific to in-node chronik

Rename NNG types that will conflict with ChronikClientNode (even though these types are in separate files, bc they are used by ChronikClient and ChronikClientNode, and both objects are exported, ts will not allow them to have the same name)

In D14758#332748, @Fabien wrote:

This could be split into several diffs, for example file/var renames could be their own diffs. Same for the @generated mark on the proto ts file. This makes it easier to spot the where the changes are.

This could be split into several diffs, for example file/var renames could be their own diffs. Same for the @generated mark on the proto ts file. This makes it easier to spot the where the changes are.

[e.cash] Fix typo on staking page

update: draft up for review.

sharing failoverProxy, support ws iterations for in-node

[chronik] Test: make sure the tx reached the mempool before asserting on the ws…

@bot build-linux-arm build-linux-aarch64

All Stories
Use Results
Edit Query
Hide Query

Nov 21 2023

Nov 20 2023

Nov 19 2023

Nov 18 2023

Nov 17 2023