Page MenuHomePhabricator
Feed All Stories

Nov 22 2023

PiRK committed rABC68088fe66a6c: [electrum] extract get_fulcrum_stat from poll_for_answer (authored by PiRK).
[electrum] extract get_fulcrum_stat from poll_for_answer
Nov 22 2023, 19:02
PiRK closed D14838: [electrum] extract get_fulcrum_stat from poll_for_answer.
Nov 22 2023, 19:02
PiRK accepted D14836: [avalanche] Add coverage for the avapeers dump file deserialization error behavior.
Nov 22 2023, 18:57
PiRK accepted D14837: [avalanche] Fix a couple issue from D14833.
Nov 22 2023, 18:55
PiRK added inline comments to D14839: [electrum] regtest: refactor poll_for_answer.
Nov 22 2023, 16:39
Fabien requested changes to D14839: [electrum] regtest: refactor poll_for_answer.
Nov 22 2023, 16:33
Fabien accepted D14838: [electrum] extract get_fulcrum_stat from poll_for_answer.
Nov 22 2023, 16:30
Fabien retitled D14837: [avalanche] Fix a couple issue from D14833 from [avalanche] Fix a couple issue from D14833 The log from D14833 fails on some platforms due to path to string conversion, and the chronik test fails due to the persistent avapeers messing with the quorum. to [avalanche] Fix a couple issue from D14833.
Nov 22 2023, 16:25
PiRK added inline comments to D14839: [electrum] regtest: refactor poll_for_answer.
Nov 22 2023, 16:18
PiRK updated the summary of D14838: [electrum] extract get_fulcrum_stat from poll_for_answer.
Nov 22 2023, 16:14
PiRK requested review of D14839: [electrum] regtest: refactor poll_for_answer.
Nov 22 2023, 16:13
PiRK added a comment to D14838: [electrum] extract get_fulcrum_stat from poll_for_answer.

Note that the regtests are currently flaky (failing about 20% of the time) . I'm still investigating this issue, and this simplification should make my debugging easier.

Nov 22 2023, 16:11
PiRK requested review of D14838: [electrum] extract get_fulcrum_stat from poll_for_answer.
Nov 22 2023, 16:08
teamcity awarded D14837: [avalanche] Fix a couple issue from D14833 a Haypence token.
Nov 22 2023, 15:33
Fabien added a comment to D14837: [avalanche] Fix a couple issue from D14833.

@bot build-win64 build-linux64

Nov 22 2023, 15:33
Fabien requested review of D14837: [avalanche] Fix a couple issue from D14833.
Nov 22 2023, 15:33
teamcity triaged T3350: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Linux 64 is broken. as Unbreak Now! priority.
Nov 22 2023, 14:59
teamcity triaged T3349: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Windows 64-bit is broken. as Unbreak Now! priority.
Nov 22 2023, 14:51
Fabien requested review of D14836: [avalanche] Add coverage for the avapeers dump file deserialization error behavior.
Nov 22 2023, 14:35
Fabien closed D14833: [avalanche] Actually dump/load the peers list upon shutdown/startup.
Nov 22 2023, 14:20
Fabien committed rABC39cd9dafffc6: [avalanche] Actually dump/load the peers list upon shutdown/startup (authored by Fabien).
[avalanche] Actually dump/load the peers list upon shutdown/startup
Nov 22 2023, 14:20
PiRK closed D14829: Use std::chrono for the time to rotate destination of addr messages + tests.
Nov 22 2023, 11:50
PiRK committed rABC2db7298bc3cd: Use std::chrono for the time to rotate destination of addr messages + tests (authored by Gleb Naumenko <naumenko.gs@gmail.com>).
Use std::chrono for the time to rotate destination of addr messages + tests
Nov 22 2023, 11:50
PiRK closed D14828: refactor: make GetRand a template, remove GetRandInt.
Nov 22 2023, 11:50
PiRK committed rABCe041fc0369a2: refactor: make GetRand a template, remove GetRandInt (authored by pasta <pasta@dashboost.org>).
refactor: make GetRand a template, remove GetRandInt
Nov 22 2023, 11:50
PiRK accepted D14833: [avalanche] Actually dump/load the peers list upon shutdown/startup.
Nov 22 2023, 09:08
Fabien updated the diff for D14833: [avalanche] Actually dump/load the peers list upon shutdown/startup.

Update the circular dependency, update the files.md doc, remove the debugging log and fix the copyright year.

Nov 22 2023, 09:01
Fabien requested changes to D14835: [herald] Simplify price api to add specific urls to mocks.
Nov 22 2023, 08:55
Fabien accepted D14831: [chronik-client] Implement keepAlive to preserve longlived connections.

I don't think we can expect the avg chronik-client user to know what the interval value should be. Once we have to validate for "must be at least 20 seconds" ... might as well just fix it at a value that is working well empirically.

Nov 22 2023, 08:52
Fabien closed D14834: Bump version to 0.28.4.
Nov 22 2023, 08:48
Fabien committed rABC1281b06a1eee: Bump version to 0.28.4 (authored by Fabien).
Bump version to 0.28.4
Nov 22 2023, 08:48
PiRK added inline comments to D14833: [avalanche] Actually dump/load the peers list upon shutdown/startup.
Nov 22 2023, 07:32
Fabien added a comment to D14833: [avalanche] Actually dump/load the peers list upon shutdown/startup.

Also, we could mention the new file in files.md

Good point

Nov 22 2023, 07:23
PiRK added inline comments to D14833: [avalanche] Actually dump/load the peers list upon shutdown/startup.
Nov 22 2023, 07:16
PiRK requested changes to D14833: [avalanche] Actually dump/load the peers list upon shutdown/startup.

There is a linter issue.
Also, we could mention the new file in files.md

Nov 22 2023, 07:13
PiRK accepted D14834: Bump version to 0.28.4.
Nov 22 2023, 06:56
bytesofman requested review of D14835: [herald] Simplify price api to add specific urls to mocks.
Nov 22 2023, 02:29

Nov 21 2023

emack closed D14728: [Cashtab][Alias] Sync pricing on new blocks.
Nov 21 2023, 22:13
emack committed rABCcfa2e804dff0: [Cashtab][Alias] Sync pricing on new blocks (authored by emack).
[Cashtab][Alias] Sync pricing on new blocks
Nov 21 2023, 22:13
bytesofman added inline comments to D14831: [chronik-client] Implement keepAlive to preserve longlived connections.
Nov 21 2023, 21:52
teamcity added a comment to D14833: [avalanche] Actually dump/load the peers list upon shutdown/startup.
Nov 21 2023, 21:50
bytesofman abandoned D14832: [Cashtab] Modify unknown msg warning.

What is the problem with the actual warning ? It feels more secure to me.

Nov 21 2023, 21:46
Fabien updated the summary of D14833: [avalanche] Actually dump/load the peers list upon shutdown/startup.
Nov 21 2023, 21:45
Fabien updated the diff for D14833: [avalanche] Actually dump/load the peers list upon shutdown/startup.

Add a release note

Nov 21 2023, 21:45
Fabien requested review of D14834: Bump version to 0.28.4.
Nov 21 2023, 21:42
Fabien added a comment to D14832: [Cashtab] Modify unknown msg warning.

What is the problem with the actual warning ? It feels more secure to me.

Nov 21 2023, 21:38
Fabien added inline comments to D14831: [chronik-client] Implement keepAlive to preserve longlived connections.
Nov 21 2023, 21:38
Fabien accepted D14728: [Cashtab][Alias] Sync pricing on new blocks.
Nov 21 2023, 21:33
Fabien added a comment to D14828: refactor: make GetRand a template, remove GetRandInt.

I restarted the builds

Nov 21 2023, 21:32
Fabien accepted D14828: refactor: make GetRand a template, remove GetRandInt.
Nov 21 2023, 21:32
teamcity added a comment to D14833: [avalanche] Actually dump/load the peers list upon shutdown/startup.
Nov 21 2023, 21:18
Fabien added a comment to D14833: [avalanche] Actually dump/load the peers list upon shutdown/startup.

This needs a release note, will rebase

Nov 21 2023, 21:17
Fabien requested review of D14833: [avalanche] Actually dump/load the peers list upon shutdown/startup.
Nov 21 2023, 21:16
emack requested review of D14728: [Cashtab][Alias] Sync pricing on new blocks.

wait for a new block to be found and observe the "New block found, refreshing alias prices" message in console

I think this message has been removed ?

Nov 21 2023, 20:24
bytesofman requested review of D14832: [Cashtab] Modify unknown msg warning.
Nov 21 2023, 20:07
teamcity closed T3345: Build Bitcoin-ABC / Master / Sanitizers / Thread Sanitizer (TSAN) is broken. as Resolved.
Nov 21 2023, 19:49
bytesofman updated the summary of D14831: [chronik-client] Implement keepAlive to preserve longlived connections.
Nov 21 2023, 19:46
bytesofman requested review of D14831: [chronik-client] Implement keepAlive to preserve longlived connections.
Nov 21 2023, 19:45
teamcity closed T3346: Build Bitcoin-ABC / Master / Sanitizers / Address Sanitizer (ASAN) is broken. as Resolved.
Nov 21 2023, 19:37
Fabien closed D14830: [avalanche] Fix a use after free bug in the peer manager unit tests.
Nov 21 2023, 19:19
Fabien committed rABC6a9d2e9baa02: [avalanche] Fix a use after free bug in the peer manager unit tests (authored by Fabien).
[avalanche] Fix a use after free bug in the peer manager unit tests
Nov 21 2023, 19:19
PiRK requested review of D14828: refactor: make GetRand a template, remove GetRandInt.

The failure seems unrelated. That test attempts to cause a race in wallet loading, so it would make sense that it can sometimes fail, but it should be really really unlikely.

Nov 21 2023, 16:59
PiRK planned changes to D14828: refactor: make GetRand a template, remove GetRandInt.

investigating the build failure

Nov 21 2023, 16:39
Fabien accepted D14829: Use std::chrono for the time to rotate destination of addr messages + tests.
Nov 21 2023, 16:24
PiRK closed D14827: refactor: use Span in random.*.
Nov 21 2023, 16:22
PiRK committed rABC2cdd79b987c7: refactor: use Span in random.* (authored by pasta <pasta@dashboost.org>).
refactor: use Span in random.*
Nov 21 2023, 16:22
PiRK closed D14826: refactor: Replace &foo[0] with foo.data().
Nov 21 2023, 16:22
PiRK committed rABC30bff8486a50: refactor: Replace &foo[0] with foo.data() (authored by Guido Vranken <guidovranken@gmail.com>).
refactor: Replace &foo[0] with foo.data()
Nov 21 2023, 16:22
PiRK accepted D14830: [avalanche] Fix a use after free bug in the peer manager unit tests.
Nov 21 2023, 16:17
teamcity added a comment to D14828: refactor: make GetRand a template, remove GetRandInt.
Nov 21 2023, 15:48
teamcity awarded D14830: [avalanche] Fix a use after free bug in the peer manager unit tests a Haypence token.
Nov 21 2023, 15:34
Fabien added a comment to D14830: [avalanche] Fix a use after free bug in the peer manager unit tests.

@bot build-asan

Nov 21 2023, 15:34
Fabien requested review of D14830: [avalanche] Fix a use after free bug in the peer manager unit tests.
Nov 21 2023, 15:34
teamcity updated the summary of D14829: Use std::chrono for the time to rotate destination of addr messages + tests.
Nov 21 2023, 15:27
PiRK requested review of D14829: Use std::chrono for the time to rotate destination of addr messages + tests.
Nov 21 2023, 15:27
bytesofman closed D14824: [Cashtab] app.js format improvements.
Nov 21 2023, 15:25
bytesofman committed rABC8270010d754c: [Cashtab] app.js format improvements (authored by bytesofman).
[Cashtab] app.js format improvements
Nov 21 2023, 15:24
PiRK updated the diff for D14828: refactor: make GetRand a template, remove GetRandInt.

use uint32_t for random IP

Nov 21 2023, 15:24
bytesofman closed D14823: [chronik-client] Organize code to prepare for additional in-node class.
Nov 21 2023, 15:24
bytesofman committed rABCbfd65df0138a: [chronik-client] Organize code to prepare for additional in-node class (authored by bytesofman).
[chronik-client] Organize code to prepare for additional in-node class
Nov 21 2023, 15:24
teamcity triaged T3346: Build Bitcoin-ABC / Master / Sanitizers / Address Sanitizer (ASAN) is broken. as Unbreak Now! priority.
Nov 21 2023, 15:23
teamcity triaged T3345: Build Bitcoin-ABC / Master / Sanitizers / Thread Sanitizer (TSAN) is broken. as Unbreak Now! priority.
Nov 21 2023, 15:22
Fabien closed D14825: [avalanche] Add dump and load functions to save/load the avalanche peers to/from a file.
Nov 21 2023, 15:03
Fabien committed rABC2cfc190651da: [avalanche] Add dump and load functions to save/load the avalanche peers… (authored by Fabien).
[avalanche] Add dump and load functions to save/load the avalanche peers…
Nov 21 2023, 15:03
Fabien requested changes to D14828: refactor: make GetRand a template, remove GetRandInt.
Nov 21 2023, 15:03
Fabien accepted D14827: refactor: use Span in random.*.
Nov 21 2023, 14:58
Fabien accepted D14826: refactor: Replace &foo[0] with foo.data().
Nov 21 2023, 14:56
PiRK accepted D14825: [avalanche] Add dump and load functions to save/load the avalanche peers to/from a file.
Nov 21 2023, 14:53
Fabien updated the diff for D14825: [avalanche] Add dump and load functions to save/load the avalanche peers to/from a file.

Remove the unused peerid from the file

Nov 21 2023, 14:42
Fabien planned changes to D14825: [avalanche] Add dump and load functions to save/load the avalanche peers to/from a file.
Nov 21 2023, 14:40
PiRK added inline comments to D14825: [avalanche] Add dump and load functions to save/load the avalanche peers to/from a file.
Nov 21 2023, 14:17
PiRK added a comment to D14826: refactor: Replace &foo[0] with foo.data().

additional rationale: this is a dependency of a dependency of another PR touching code that is moved around and touched by other more important backports (in net_processing.cpp)

Nov 21 2023, 13:58
teamcity updated the summary of D14828: refactor: make GetRand a template, remove GetRandInt.
Nov 21 2023, 13:56
PiRK requested review of D14828: refactor: make GetRand a template, remove GetRandInt.
Nov 21 2023, 13:56
teamcity updated the summary of D14827: refactor: use Span in random.*.
Nov 21 2023, 13:55
PiRK requested review of D14827: refactor: use Span in random.*.
Nov 21 2023, 13:55
teamcity updated the summary of D14826: refactor: Replace &foo[0] with foo.data().
Nov 21 2023, 13:53
PiRK requested review of D14826: refactor: Replace &foo[0] with foo.data().
Nov 21 2023, 13:53
Fabien requested changes to D14728: [Cashtab][Alias] Sync pricing on new blocks.

wait for a new block to be found and observe the "New block found, refreshing alias prices" message in console

I think this message has been removed ?

Nov 21 2023, 13:49
Fabien requested review of D14825: [avalanche] Add dump and load functions to save/load the avalanche peers to/from a file.
Nov 21 2023, 13:42