- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Aug 22 2024
minor fixes/cleanup, rebase on D16674
use a verb in the function name, as per suggestion
remove unrelated chronik-db change
rebase, update using a dataclass, add sats calculation as requested
fix comments
Aug 21 2024
so when I saved it did all that formatting...removed it though and just saved without autoformat on...
update js file hash
remove format change
update hash for js files
use named arg per feedback
rebase
I missed one
review items
We figured out my issue for running the explorer, I wasn't running cargo run in the right folder.
The result looks good, each UTXO shows the correct token now.
The code looks good as far as I can tell, but I'm having trouble running the test plan to check the result.
with a nit in the test
Aug 20 2024
fix missing =
OK. It requires python >= 3.8, which is fine. I added a suggestion about an alternative way to pass the input data to stdin, your pick.
fix lint length
use djlint to lint explorer templates
I tried adding a .prettierignore file to web/explorer with a explorer-server/templates line, but it does not seem to have any effect, prettier still messes up the html files in this directory. So not sure how to what I suggested.
I agree that it looks a lot more readable like this, and everything looks good to me. I'm just wondering whether applying markdown formatting to html files makes sense in the first place. Does it add anything useful vs just disabling prettier altogether for this project?
Aug 19 2024
rebase on latest master
use Sha256d instead of [u8; 32] everywhere and use integer arithmetic in branch_length
Looks good.
As discussed above, there is some ambiguity about TX_AVALANCHE_RECONSIDERABLE currently only being used for non-finalized conflicting txs (tx added to the TxConflicting pool). The pool will need to be renamed if/when we start adding other type of transactions to it, but that can be done if/when needed.
Aug 18 2024
Aug 17 2024
@bot ecash-herald-tests
Minor nit