Page MenuHomePhabricator
Feed All Stories

Oct 26 2024

Fabien closed D17012: ArgsManager: return path by value from GetBlocksDirPath().
Oct 26 2024, 18:20
Fabien committed rABC3ab65b20c797: ArgsManager: return path by value from GetBlocksDirPath() (authored by Vasil Dimov <vd@FreeBSD.org>).
ArgsManager: return path by value from GetBlocksDirPath()
Oct 26 2024, 18:20
PiRK accepted D17013: wallet: avoid returning a reference to vMasterKey after releasing the mutex that guards it.
Oct 26 2024, 18:11
PiRK accepted D17012: ArgsManager: return path by value from GetBlocksDirPath().
Oct 26 2024, 18:07
PiRK updated the summary of D17012: ArgsManager: return path by value from GetBlocksDirPath().
Oct 26 2024, 18:06
bytesofman closed D17010: [Cashtab] Patch misnamed mock.
Oct 26 2024, 17:52
bytesofman committed rABC2a0a45a36489: [Cashtab] Patch misnamed mock (authored by bytesofman).
[Cashtab] Patch misnamed mock
Oct 26 2024, 17:52
teamcity updated the summary of D17013: wallet: avoid returning a reference to vMasterKey after releasing the mutex that guards it.
Oct 26 2024, 12:30
Fabien requested review of D17013: wallet: avoid returning a reference to vMasterKey after releasing the mutex that guards it.
Oct 26 2024, 12:30
Fabien requested review of D17012: ArgsManager: return path by value from GetBlocksDirPath().
Oct 26 2024, 12:09
tobias_ruck requested changes to D16937: [chronik] add scripthash option to the various script endpoints.
Oct 26 2024, 11:59
Fabien accepted D17009: [CONTRIBUTING.md] Update webdev versions.
Oct 26 2024, 11:01
Fabien closed D17006: Bump our clang toolchain to version 16.
Oct 26 2024, 10:05
Fabien committed rABCe50d1ee720e0: Bump our clang toolchain to version 16 (authored by Fabien).
Bump our clang toolchain to version 16
Oct 26 2024, 10:05
Fabien closed D17004: [CI] Properly pass the cflags in the secp256k1 c++ test.
Oct 26 2024, 10:05
Fabien committed rABC019781ae84f5: [CI] Properly pass the cflags in the secp256k1 c++ test (authored by Fabien).
[CI] Properly pass the cflags in the secp256k1 c++ test
Oct 26 2024, 10:05
PiRK accepted D17010: [Cashtab] Patch misnamed mock.
Oct 26 2024, 07:46
PiRK accepted D17004: [CI] Properly pass the cflags in the secp256k1 c++ test.
Oct 26 2024, 07:44
PiRK accepted D17006: Bump our clang toolchain to version 16.
Oct 26 2024, 07:44

Oct 25 2024

bytesofman closed D17011: [Cashtab] Add corporate scams to agora blacklist.
Oct 25 2024, 23:56
bytesofman committed rABC900f7db03692: [Cashtab] Add corporate scams to agora blacklist (authored by bytesofman).
[Cashtab] Add corporate scams to agora blacklist
Oct 25 2024, 23:56
bytesofman closed D17008: [Cashtab] Prevent token qty errors on listings for large quantities.
Oct 25 2024, 23:51
bytesofman committed rABC6f6a0a328c31: [Cashtab] Prevent token qty errors on listings for large quantities (authored by bytesofman).
[Cashtab] Prevent token qty errors on listings for large quantities
Oct 25 2024, 23:51
Kronkmeister accepted D17011: [Cashtab] Add corporate scams to agora blacklist.
Oct 25 2024, 23:51
Kronkmeister accepted D17008: [Cashtab] Prevent token qty errors on listings for large quantities.
Oct 25 2024, 23:49
bytesofman published D17010: [Cashtab] Patch misnamed mock for review.
Oct 25 2024, 23:36
bytesofman published D17011: [Cashtab] Add corporate scams to agora blacklist for review.
Oct 25 2024, 23:35
bytesofman published D17009: [CONTRIBUTING.md] Update webdev versions for review.
Oct 25 2024, 23:19
bytesofman published D17008: [Cashtab] Prevent token qty errors on listings for large quantities for review.
Oct 25 2024, 23:17
bytesofman closed D17007: [Cashtab] Expand blacklist.
Oct 25 2024, 21:36
bytesofman committed rABC24fa92b7826a: [Cashtab] Expand blacklist (authored by bytesofman).
[Cashtab] Expand blacklist
Oct 25 2024, 21:36
Kronkmeister accepted D17007: [Cashtab] Expand blacklist.
Oct 25 2024, 21:34
bytesofman published D17007: [Cashtab] Expand blacklist for review.
Oct 25 2024, 21:34
Fabien published D17006: Bump our clang toolchain to version 16 for review.
Oct 25 2024, 21:21
teamcity awarded D17006: Bump our clang toolchain to version 16 a Haypence token.
Oct 25 2024, 20:46
Fabien requested review of D17004: [CI] Properly pass the cflags in the secp256k1 c++ test.
Oct 25 2024, 19:23
PiRK abandoned D16301: [electrum] refactor ecc.py.

done (split in multiple diffs)

Oct 25 2024, 19:20
bytesofman closed D17003: [Cashtab] Attempt to patch whitescreen failures related to OrderBook.js and hex.
Oct 25 2024, 17:59
bytesofman committed rABC7f3bbc26f49c: [Cashtab] Attempt to patch whitescreen failures related to OrderBook.js and hex (authored by bytesofman).
[Cashtab] Attempt to patch whitescreen failures related to OrderBook.js and hex
Oct 25 2024, 17:59
johnkuney accepted D17003: [Cashtab] Attempt to patch whitescreen failures related to OrderBook.js and hex.
Oct 25 2024, 17:58
bytesofman published D17003: [Cashtab] Attempt to patch whitescreen failures related to OrderBook.js and hex for review.
Oct 25 2024, 17:43
Fabien requested changes to D16992: [avalanche] Start populating the staking contender cache.

This can be split into several parts:

  • Automate the stake contenders promotion via updatedBlockTip()
  • Add the manual winners to the cache
  • Vote on manual winners
Oct 25 2024, 13:02
teamcity awarded D16992: [avalanche] Start populating the staking contender cache a Haypence token.
Oct 25 2024, 13:01
Fabien added a comment to D16992: [avalanche] Start populating the staking contender cache.

@bot build-tsan

Oct 25 2024, 13:01
bytesofman closed D16998: [Cashtab] Patch cancel vs buy distinction in agora partials.
Oct 25 2024, 12:42
bytesofman committed rABCd20281f7a04d: [Cashtab] Patch cancel vs buy distinction in agora partials (authored by bytesofman).
[Cashtab] Patch cancel vs buy distinction in agora partials
Oct 25 2024, 12:42
Fabien requested changes to D17000: [64-bit ints] Move `{Add,Sub}Int63Overflow(Emulated)` impl to cpp file.
Oct 25 2024, 12:37
Fabien requested changes to D16996: [64-bit ints] Change `CScriptNum::getint` to return `int64_t`.

I still don't get what you're doing with the test. Look at the scriptnum10 purpose: it's an older implementation and is here to check the new implementation behaves the same.
Your change is breaking that expectation, deliberately. To check if this introduces a problem:

  • You need to make sure opcodes are well covered by existing tests, including edge cases. I suggest you add these tests if they don't already exist in another diff to prove this one introduces no change in behavior.
  • Just remove that legacy compliant test, which is no longer relevant exactly because of that change.
Oct 25 2024, 12:21
PiRK closed D16827: [chronik] store a scripthash -> script index.
Oct 25 2024, 08:59
PiRK committed rABC8cabfa5c8575: [chronik] store a scripthash -> script index (authored by PiRK).
[chronik] store a scripthash -> script index
Oct 25 2024, 08:59
PiRK updated the diff for D16827: [chronik] store a scripthash -> script index.

comment nit

Oct 25 2024, 08:58
tobias_ruck published D17000: [64-bit ints] Move `{Add,Sub}Int63Overflow(Emulated)` impl to cpp file for review.
Oct 25 2024, 08:55
tobias_ruck updated the summary of D16996: [64-bit ints] Change `CScriptNum::getint` to return `int64_t`.
Oct 25 2024, 08:45
tobias_ruck updated the diff for D16996: [64-bit ints] Change `CScriptNum::getint` to return `int64_t`.

remove getint32, change ScriptNum10::getint instead to support int64_t

Oct 25 2024, 08:42
emack accepted D16998: [Cashtab] Patch cancel vs buy distinction in agora partials.
Oct 25 2024, 08:31
PiRK updated the diff for D16937: [chronik] add scripthash option to the various script endpoints.

fix a warning

Oct 25 2024, 08:16
tobias_ruck accepted D16827: [chronik] store a scripthash -> script index.

One comment nit

Oct 25 2024, 08:16
Fabien requested changes to D16996: [64-bit ints] Change `CScriptNum::getint` to return `int64_t`.
Oct 25 2024, 08:15
PiRK added inline comments to D16827: [chronik] store a scripthash -> script index.
Oct 25 2024, 07:45
PiRK updated the diff for D16827: [chronik] store a scripthash -> script index.

improve behavior when cancelling a reindexing: remove alarming log, wipe the index and don't set the metadata flag to true when shutdown is requested during the process

Oct 25 2024, 07:40
PiRK planned changes to D16937: [chronik] add scripthash option to the various script endpoints.
Oct 25 2024, 06:56
bytesofman closed D16999: [Cashtab] Add a blacklist to remove scams from agora.
Oct 25 2024, 05:01
bytesofman committed rABCf0bb80a474c9: [Cashtab] Add a blacklist to remove scams from agora (authored by bytesofman).
[Cashtab] Add a blacklist to remove scams from agora
Oct 25 2024, 05:01
Kronkmeister accepted D16999: [Cashtab] Add a blacklist to remove scams from agora.
Oct 25 2024, 05:00
bytesofman published D16999: [Cashtab] Add a blacklist to remove scams from agora for review.
Oct 25 2024, 04:59
bytesofman published D16998: [Cashtab] Patch cancel vs buy distinction in agora partials for review.
Oct 25 2024, 03:56
bytesofman closed D16994: [Cashtab] Patch tx parsing for agora buy/sell/cancel.
Oct 25 2024, 02:43
bytesofman committed rABC37407f3b82e1: [Cashtab] Patch tx parsing for agora buy/sell/cancel (authored by bytesofman).
[Cashtab] Patch tx parsing for agora buy/sell/cancel
Oct 25 2024, 02:43
emack accepted D16994: [Cashtab] Patch tx parsing for agora buy/sell/cancel.
Oct 25 2024, 00:18

Oct 24 2024

tobias_ruck requested review of D16996: [64-bit ints] Change `CScriptNum::getint` to return `int64_t`.
Oct 24 2024, 23:57
bytesofman closed D16990: [ecash-herald] Parse token actions in daily summary msgs.
Oct 24 2024, 23:53
bytesofman committed rABCfc9ca739ba1c: [ecash-herald] Parse token actions in daily summary msgs (authored by bytesofman).
[ecash-herald] Parse token actions in daily summary msgs
Oct 24 2024, 23:53
tobias_ruck accepted D16990: [ecash-herald] Parse token actions in daily summary msgs.
Oct 24 2024, 23:52
bytesofman closed D16991: [Cashtab] Patch displayed spot prices for agora offers.
Oct 24 2024, 23:45
bytesofman committed rABC84b79729fc97: [Cashtab] Patch displayed spot prices for agora offers (authored by bytesofman).
[Cashtab] Patch displayed spot prices for agora offers
Oct 24 2024, 23:45
tobias_ruck accepted D16991: [Cashtab] Patch displayed spot prices for agora offers.
Oct 24 2024, 23:40
bytesofman closed D16995: [ecash-agora] Improve approximation for USD-esque tokens.
Oct 24 2024, 23:33
bytesofman committed rABCf9a22eecb934: [ecash-agora] Improve approximation for USD-esque tokens (authored by bytesofman).
[ecash-agora] Improve approximation for USD-esque tokens
Oct 24 2024, 23:33
bytesofman updated the summary of D16995: [ecash-agora] Improve approximation for USD-esque tokens.
Oct 24 2024, 23:22
tobias_ruck accepted D16995: [ecash-agora] Improve approximation for USD-esque tokens.

Note: you can remove the note or un-bold it and move it to the bottom

Oct 24 2024, 23:21
bytesofman published D16995: [ecash-agora] Improve approximation for USD-esque tokens for review.
Oct 24 2024, 23:19
bytesofman published D16994: [Cashtab] Patch tx parsing for agora buy/sell/cancel for review.
Oct 24 2024, 22:52
teamcity awarded D16966: [Chronik] Build Bitcoin Core with Chronik attached a Like token.
Oct 24 2024, 22:16
roqqit updated the diff for D16992: [avalanche] Start populating the staking contender cache.

Fix chainstate dependency

Oct 24 2024, 20:54
bytesofman published D16990: [ecash-herald] Parse token actions in daily summary msgs for review.
Oct 24 2024, 20:34
bytesofman published D16991: [Cashtab] Patch displayed spot prices for agora offers for review.
Oct 24 2024, 20:32
teamcity added a comment to D16992: [avalanche] Start populating the staking contender cache.
Oct 24 2024, 20:31
roqqit requested review of D16992: [avalanche] Start populating the staking contender cache.
Oct 24 2024, 20:28
tobias_ruck requested changes to D16827: [chronik] store a scripthash -> script index.
Oct 24 2024, 19:27
teamcity added a comment to D16989: [explorer] Show the correct unit in the faucet.

Build Bitcoin ABC Diffs / Diff Testing (preview-explorer) passed.
Preview is available at http://51.89.41.69:41257 for the next 60 minutes.

Oct 24 2024, 19:03
Fabien closed D16989: [explorer] Show the correct unit in the faucet.
Oct 24 2024, 18:57
Fabien committed rABCa355cc677892: [explorer] Show the correct unit in the faucet (authored by Fabien).
[explorer] Show the correct unit in the faucet
Oct 24 2024, 18:56
bytesofman closed D16846: [Cashtab] Support agora partial listings, cancels, and buys.
Oct 24 2024, 18:47
bytesofman committed rABC07388568e236: [Cashtab] Support agora partial listings, cancels, and buys (authored by bytesofman).
[Cashtab] Support agora partial listings, cancels, and buys
Oct 24 2024, 18:47
Kronkmeister closed D16988: [e.cash] Change "Stack" to Stack Wallet and add "Desktop".
Oct 24 2024, 18:46
Kronkmeister committed rABC57f6b86fc493: [e.cash] Change "Stack" to Stack Wallet and add "Desktop" (authored by Kronkmeister).
[e.cash] Change "Stack" to Stack Wallet and add "Desktop"
Oct 24 2024, 18:46
bytesofman accepted D16989: [explorer] Show the correct unit in the faucet.
Oct 24 2024, 18:45
teamcity awarded D16989: [explorer] Show the correct unit in the faucet a Haypence token.
Oct 24 2024, 18:43
Fabien added a comment to D16989: [explorer] Show the correct unit in the faucet.

@bot preview-explorer

Oct 24 2024, 18:43
Fabien requested review of D16989: [explorer] Show the correct unit in the faucet.
Oct 24 2024, 18:42