rebase to restart CI. I can't figure out why rpc_psbt.py failed, but it is clearly unrelated (nodes[2] never received an inv for the transaction)

investigating build failure

pull out cashaddr logic from ecash-lib, remove dependencies from ecashaddrjs, major version bump for ecashaddrjs, implement ecashaddrjs 2.0.0 in all monorepo libraries, modify toLegacyAddress so it is a no-op if called with legacy addr

I updated the diff a bit too fast, so some of these recent errors are from previous versions of the diff.

improve for loop as per clippy's advice

remove unneeded rehash and wrong comment

In D17269#394989, @Fabien wrote:

What is the benefit vs a no-op ? Imagine I'm a mining pool and I want to convert all my miner addresses to legacy (real world use case) even if they are using BCH or XEC addresses. I would like to just use to_legacy() and not have to first check it's not legacy format already

In D17269#394758, @bytesofman wrote:

change toLegacyAddress behavior to throw if called with legacy address

• just use getStakeContenderStatus instead of a new accessor
• hasstakecontender -> getstakecontendervote per feedback
• pass in prevblockhash and proofid instead of stakecontenderid

feedback

In D17366#394875, @PiRK wrote:

In D17366#394869, @teamcity wrote:

Build Bitcoin ABC Diffs / Diff Testing (ecash-lib-integration-tests) failed.

Unrelated. Looks like a permission error when creating a directory

20:03:09     File "/work/abc-ci-builds/ecash-lib-integration-tests/test/functional/test_runner.py", line 1094, in <module>
20:03:09       main()
20:03:09     File "/work/abc-ci-builds/ecash-lib-integration-tests/test/functional/test_runner.py", line 361, in main
20:03:09       os.makedirs(tmpdir)
20:03:09     File "<frozen os>", line 225, in makedirs
20:03:09     FileExistsError: [Errno 17] File exists: '/work/abc-ci-builds/ecash-lib-integration-tests/test/tmp/test_runner_₿₵_🏃_20241217_200307'

Just bump the value because predicting it is proving to be difficult and time consuming

In D17366#394869, @teamcity wrote:

Build Bitcoin ABC Diffs / Diff Testing (ecash-lib-integration-tests) failed.

Unrelated. Looks like a permission error when creating a directory

custom error code and test for wrong type for boolean arg

i missed one

feedback

TIL chage

Note that I also tried a form for the macro that check both min and max check_number_of_params!(params, 1, 2); but then I ran into a compiler warning when I added check_number_of_params!(params, 0, 0); in the server.ping handler

line length nit

address clippy's complaint

feedback

@bot build-bitcoinsuite-chronik-client

so it looks like we don't need to use serde_json::Value; in the module that implement try_from(value: &'_ serde_json::Value), but we still need to have the crate as a depencency (Cargo.[toml/lock])

change toLegacyAddress behavior to throw if called with legacy address, move legacy functions to legacyaddr.ts, define toLegacyAddress in address.ts, organize and update tests accordingly

Not sure why the build claims serde_json:: Value is unused in txid.rs, will investigate