Page MenuHomePhabricator
Feed All Stories

Dec 16 2024

roqqit updated the diff for D17345: [avalanche] Make sure each proof is added to contender cache before mining the next block in contender voting test.

Use a debug RPC. Waiting for getavalanchepeerinfo is not sufficient here because its possible for this value to be updated before the contender is added to the cache.

Dec 16 2024, 17:49
teamcity added a comment to D17356: [chronik] add electrum method blockchain.transaction.get_height.
Dec 16 2024, 16:30
teamcity added a comment to D17356: [chronik] add electrum method blockchain.transaction.get_height.
Dec 16 2024, 16:24
teamcity added a comment to D17356: [chronik] add electrum method blockchain.transaction.get_height.
Dec 16 2024, 16:23
teamcity added a comment to D17356: [chronik] add electrum method blockchain.transaction.get_height.
Dec 16 2024, 16:17
teamcity added a comment to D17356: [chronik] add electrum method blockchain.transaction.get_height.
Dec 16 2024, 16:15
PiRK updated the diff for D17356: [chronik] add electrum method blockchain.transaction.get_height.

use is_none() isntead of match

Dec 16 2024, 16:12
PiRK updated the diff for D17356: [chronik] add electrum method blockchain.transaction.get_height.

take a reference for TryFrom, use it also in transaction_get (minor behavior change in the error message, because now we have one less line that can raise a variant on the same error message)

Dec 16 2024, 16:07
teamcity closed T3705: Build Bitcoin-ABC / Master / Sanitizers / Thread Sanitizer (TSAN) is broken. as Resolved.
Dec 16 2024, 15:50
PiRK closed D17347: [chronik] add macros to extract params from a JSONRPC request.
Dec 16 2024, 15:33
PiRK committed rABC719ef6251e2e: [chronik] add macros to extract params from a JSONRPC request (authored by PiRK).
[chronik] add macros to extract params from a JSONRPC request
Dec 16 2024, 15:33
PiRK closed D17323: [chronik] add electrum method blockchain.transaction.get.
Dec 16 2024, 15:32
PiRK closed D17314: [chronik] add a test for the new JSON RPC interface.
Dec 16 2024, 15:32
PiRK committed rABC5ccdd58eaef1: [chronik] add electrum method blockchain.transaction.get (authored by PiRK).
[chronik] add electrum method blockchain.transaction.get
Dec 16 2024, 15:32
PiRK committed rABCcedd98bd44e8: [chronik] add a test for the new JSON RPC interface (authored by PiRK).
[chronik] add a test for the new JSON RPC interface
Dec 16 2024, 15:32
PiRK accepted D17363: Bump version to 0.30.7.
Dec 16 2024, 15:32
teamcity triaged T3705: Build Bitcoin-ABC / Master / Sanitizers / Thread Sanitizer (TSAN) is broken. as Unbreak Now! priority.
Dec 16 2024, 15:30
hazzarust updated the test plan for D17335: [Modules] Added `bitcoinsuite-chronik-client` to monorepo.
Dec 16 2024, 15:20
Fabien requested review of D17363: Bump version to 0.30.7.
Dec 16 2024, 15:09
teamcity added a comment to D17356: [chronik] add electrum method blockchain.transaction.get_height.
Dec 16 2024, 15:00
teamcity added a comment to D17323: [chronik] add electrum method blockchain.transaction.get.
Dec 16 2024, 14:51
bytesofman closed D17362: [ecash-herald] Make sure to build mock-chronik-client.
Dec 16 2024, 14:44
bytesofman committed rABCfd2a3acba2d3: [ecash-herald] Make sure to build mock-chronik-client (authored by bytesofman).
[ecash-herald] Make sure to build mock-chronik-client
Dec 16 2024, 14:44
Fabien accepted D17362: [ecash-herald] Make sure to build mock-chronik-client.
Dec 16 2024, 14:44
bytesofman published D17362: [ecash-herald] Make sure to build mock-chronik-client for review.
Dec 16 2024, 14:44
hazzarust updated the diff for D17335: [Modules] Added `bitcoinsuite-chronik-client` to monorepo.

Added CI integration (build-configurations.yml), added copyright licenses, changed server and reduced Tokio syntax.

Dec 16 2024, 14:42
bytesofman abandoned D17361: [ecash-herald] Dockerfile update.

not the issue

Dec 16 2024, 14:38
bytesofman published D17361: [ecash-herald] Dockerfile update for review.
Dec 16 2024, 14:24
tobias_ruck requested changes to D17269: [ecash-lib] Improve address handling of ecash dev libraries.
Dec 16 2024, 14:22
PiRK updated the diff for D17356: [chronik] add electrum method blockchain.transaction.get_height.

rebase after reducing the port range in D17314

Dec 16 2024, 14:06
PiRK updated the diff for D17347: [chronik] add macros to extract params from a JSONRPC request.

rebase after reducing the port range in D17314

Dec 16 2024, 14:05
PiRK updated the diff for D17323: [chronik] add electrum method blockchain.transaction.get.

rebase after reducing the port range in D17314

Dec 16 2024, 14:05
teamcity awarded D17314: [chronik] add a test for the new JSON RPC interface a Haypence token.
Dec 16 2024, 14:04
PiRK added a comment to D17314: [chronik] add a test for the new JSON RPC interface.

@bot build-linux64 build-linux-aarch64 build-chronik build-chronik-plugins

Dec 16 2024, 14:04
PiRK updated the diff for D17314: [chronik] add a test for the new JSON RPC interface.

reduce port range to 3000 to keep the same effective range of ports

Dec 16 2024, 14:03
Fabien accepted D17347: [chronik] add macros to extract params from a JSONRPC request.
Dec 16 2024, 13:54
PiRK closed D17354: [electrum] use blockchain.transaction.get_height method.
Dec 16 2024, 13:53
PiRK committed rABC26ca7aa70c44: [electrum] use blockchain.transaction.get_height method (authored by PiRK).
[electrum] use blockchain.transaction.get_height method
Dec 16 2024, 13:53
Fabien closed D17360: [chronik-docs] Fix download links.
Dec 16 2024, 13:51
Fabien committed rABC951384487677: [chronik-docs] Fix download links (authored by Fabien).
[chronik-docs] Fix download links
Dec 16 2024, 13:50
Fabien closed D17359: [chronik-docs] Update the latest client version.
Dec 16 2024, 13:50
Fabien committed rABCacf701c2ff16: [chronik-docs] Update the latest client version (authored by Fabien).
[chronik-docs] Update the latest client version
Dec 16 2024, 13:50
PiRK planned changes to D17356: [chronik] add electrum method blockchain.transaction.get_height.

Collision on port 33380, Lets try to reduce the port range first to not conflict with docker ports (see D16048)

Dec 16 2024, 13:47
bytesofman updated the diff for D17269: [ecash-lib] Improve address handling of ecash dev libraries.

adding docs, style clean-ups, remove default type as it is not used anymore, remove unnecessary code duplication

Dec 16 2024, 13:45
teamcity added a comment to D17356: [chronik] add electrum method blockchain.transaction.get_height.
Dec 16 2024, 13:38
PiRK updated the test plan for D17354: [electrum] use blockchain.transaction.get_height method.
Dec 16 2024, 13:38
tobias_ruck accepted D17347: [chronik] add macros to extract params from a JSONRPC request.

very cool!

Dec 16 2024, 13:38
PiRK updated the summary of D17356: [chronik] add electrum method blockchain.transaction.get_height.
Dec 16 2024, 13:37
PiRK updated the diff for D17356: [chronik] add electrum method blockchain.transaction.get_height.

do this without the macro from D17355 (need to study macros more to make it work), fix clippy::needless-question-mark

Dec 16 2024, 13:28
bytesofman closed D17358: [ecash-herald] patch docker.
Dec 16 2024, 13:26
bytesofman committed rABC9c49d22f48d3: [ecash-herald] patch docker (authored by bytesofman).
[ecash-herald] patch docker
Dec 16 2024, 13:26
teamcity added a comment to D17323: [chronik] add electrum method blockchain.transaction.get.
Dec 16 2024, 13:07
teamcity added a comment to D17347: [chronik] add macros to extract params from a JSONRPC request.
Dec 16 2024, 12:56
PiRK updated the diff for D17347: [chronik] add macros to extract params from a JSONRPC request.

rebase

Dec 16 2024, 12:50
PiRK updated the diff for D17323: [chronik] add electrum method blockchain.transaction.get.

use consistent error message "Unknown transaction id"

Dec 16 2024, 12:49
PiRK planned changes to D17347: [chronik] add macros to extract params from a JSONRPC request.
Dec 16 2024, 12:47
PiRK updated the diff for D17347: [chronik] add macros to extract params from a JSONRPC request.

test all errors responses

Dec 16 2024, 12:42
tobias_ruck requested changes to D17269: [ecash-lib] Improve address handling of ecash dev libraries.
Dec 16 2024, 12:27
PiRK accepted D17359: [chronik-docs] Update the latest client version.
Dec 16 2024, 11:25
PiRK accepted D17360: [chronik-docs] Fix download links.
Dec 16 2024, 11:25
Fabien accepted D17354: [electrum] use blockchain.transaction.get_height method.

now it works even if electrum is not synced to the tip btw

Dec 16 2024, 11:10
Fabien requested changes to D17347: [chronik] add macros to extract params from a JSONRPC request.

I would love to see a test for these error cases, since blockchain.transaction.get has both a mandatory and an optional arg it fits perfectly

Dec 16 2024, 11:06
Fabien accepted D17323: [chronik] add electrum method blockchain.transaction.get.
Dec 16 2024, 11:01
Fabien requested review of D17360: [chronik-docs] Fix download links.
Dec 16 2024, 10:50
Fabien requested review of D17359: [chronik-docs] Update the latest client version.
Dec 16 2024, 10:36
tobias_ruck requested changes to D17335: [Modules] Added `bitcoinsuite-chronik-client` to monorepo.
Dec 16 2024, 10:11
tobias_ruck accepted D17314: [chronik] add a test for the new JSON RPC interface.
Dec 16 2024, 10:03
Fabien requested changes to D17335: [Modules] Added `bitcoinsuite-chronik-client` to monorepo.
Dec 16 2024, 09:52
Fabien requested changes to D17349: [seeder] Bump thread stacksize.
Dec 16 2024, 09:15
PiRK accepted D17358: [ecash-herald] patch docker.
Dec 16 2024, 06:09
bytesofman added a comment to D17340: [Cashtab] Parse tx history async to resolve UI lock issue on homescreen.

This may be subjective but I'm not seeing a drastic improvement after updating to latest and hard refreshing twice. In some instances prod loaded the home screen and agora pages quicker than the test site, though that could also be the hosting infra playing a part. Tests were done with wallets having agora txs in tx history

Dec 16 2024, 05:06
bytesofman updated the diff for D17340: [Cashtab] Parse tx history async to resolve UI lock issue on homescreen.

=== p2pkh instead of !== p2sh

Dec 16 2024, 05:05
bytesofman published D17358: [ecash-herald] patch docker for review.
Dec 16 2024, 04:53
emack requested changes to D17340: [Cashtab] Parse tx history async to resolve UI lock issue on homescreen.

confirm there that load times are significantly improved for wallets with Agora txs

Dec 16 2024, 04:51
bytesofman updated the diff for D17340: [Cashtab] Parse tx history async to resolve UI lock issue on homescreen.

rebase

Dec 16 2024, 00:49
bytesofman updated the test plan for D17340: [Cashtab] Parse tx history async to resolve UI lock issue on homescreen.
Dec 16 2024, 00:47
bytesofman closed D17353: [Cashtab] Convert Home screen to typescript.
Dec 16 2024, 00:40
bytesofman committed rABC9b4c6905cbae: [Cashtab] Convert Home screen to typescript (authored by bytesofman).
[Cashtab] Convert Home screen to typescript
Dec 16 2024, 00:40
bytesofman added inline comments to D17269: [ecash-lib] Improve address handling of ecash dev libraries.
Dec 16 2024, 00:39
bytesofman updated the diff for D17269: [ecash-lib] Improve address handling of ecash dev libraries.

implementing feedback (add parse method, clean up existing methods, doc, remove unused interfaces and imports now that stuff is cleaned up)

Dec 16 2024, 00:38
emack accepted D17353: [Cashtab] Convert Home screen to typescript.
Dec 16 2024, 00:27

Dec 15 2024

tobias_ruck requested changes to D17269: [ecash-lib] Improve address handling of ecash dev libraries.
Dec 15 2024, 23:38
teamcity added a comment to D17269: [ecash-lib] Improve address handling of ecash dev libraries.
Dec 15 2024, 22:47
teamcity added a comment to D17269: [ecash-lib] Improve address handling of ecash dev libraries.
Dec 15 2024, 22:43
teamcity added a comment to D17269: [ecash-lib] Improve address handling of ecash dev libraries.
Dec 15 2024, 22:41
bytesofman updated the diff for D17269: [ecash-lib] Improve address handling of ecash dev libraries.

ts build lint

Dec 15 2024, 22:41
teamcity added a comment to D17269: [ecash-lib] Improve address handling of ecash dev libraries.
Dec 15 2024, 22:40
bytesofman updated the diff for D17269: [ecash-lib] Improve address handling of ecash dev libraries.

simplify constructor, pure functions for legacy() and cash(), better error handling for withPrefix

Dec 15 2024, 22:36
bytesofman added inline comments to D17269: [ecash-lib] Improve address handling of ecash dev libraries.
Dec 15 2024, 22:35
abc-bot committed rABC5782e63f3348: [Automated] Update seeds (authored by abc-bot).
[Automated] Update seeds
Dec 15 2024, 22:11
abc-bot committed rABCeaa7b1f28c26: [Automated] Update chainparams (authored by abc-bot).
[Automated] Update chainparams
Dec 15 2024, 22:04
bytesofman updated the diff for D17353: [Cashtab] Convert Home screen to typescript.

Use '===' and not '=='

Dec 15 2024, 21:55
bytesofman added inline comments to D17353: [Cashtab] Convert Home screen to typescript.
Dec 15 2024, 21:55
bytesofman closed D17351: [ecash-herald] Correct upgraded mock chronik client in script.
Dec 15 2024, 21:51
bytesofman committed rABC83bf5311bb43: [ecash-herald] Correct upgraded mock chronik client in script (authored by bytesofman).
[ecash-herald] Correct upgraded mock chronik client in script
Dec 15 2024, 21:51
abc-bot committed rABCe2fe260bbaa1: [Automated] Update timing.json (authored by abc-bot).
[Automated] Update timing.json
Dec 15 2024, 21:37
emack requested changes to D17353: [Cashtab] Convert Home screen to typescript.
Dec 15 2024, 21:07
emack accepted D17351: [ecash-herald] Correct upgraded mock chronik client in script.
Dec 15 2024, 20:42
bytesofman published D17340: [Cashtab] Parse tx history async to resolve UI lock issue on homescreen for review.
Dec 15 2024, 18:20

Dec 14 2024

teamcity added a comment to D17356: [chronik] add electrum method blockchain.transaction.get_height.
Dec 14 2024, 21:52