- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Oct 13 2025
The dependency should be in the diff summary not in a review comment. I added it for you.
We usually do self-contained diffs, and this is introducing an icon that is currently unused.
I will green it for this time because it doesn't introduce any issue per se and I know you're adding the parsing that will use it, but please be careful to not add dead code next times.
Depends on D18757
Squash commits and clean up the diff for clarity
we can't force the config to be a singleton, as RPC commands each use their own config to communicate their command line params to the daemon.
This can be fixed in the future by splitting command line args and persistent config committed to disk into separate objects. For now let's not change anything, except no more global config.
Looks good but you need to rebase on D18757 so it doesn't reference an non existent spec.
To do so rebase you branch over the other one, submit diff and add "Depends on D18757" in the diff summary so Phabricator knows there is a dependency between these diffs and prevent landing them out of order.
You need to squash your changes before you update the diff so it includes all the changes and shows as a new file, which it is in the context of this diff
Oct 12 2025
Updating D18757: [Cashtab] About NFToa Protocol ID
Rebase issue fix
there seems to be a rebase issue here bc docs/standards/nftoa.md does not yet exist in the monorepo, but this diff shows changes to it. The diff needs to be based on a single commit, which must be based off the latest master.
modified functions should have tests covering the new case, i.e.
Oct 10 2025
Updating D18757: About NFToa Protocol ID
refine regular message example
Looks like there is an extra SimpleConfig object instantiated in daemon mode, whenever a RPC command is queried. Need to investigate and reproduce outside of the functional test framework
rebase
Oct 9 2025
Oct 8 2025
- Updating D18656: Claim NFToa Protocol ID