Various nits
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Sep 20 2020
Sep 20 2020
[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.
Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.
[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.
Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.
[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.
[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.
Sep 19 2020
Sep 19 2020
PiRK committed rABC5bc64bce59f3: update outdated links related to UAHF and use explicit MarkDown syntax (authored by PiRK).
update outdated links related to UAHF and use explicit MarkDown syntax
jasonbcox committed rABC9acea42cd09f: [land-bot] Fix git HEAD after checking revision (authored by jasonbcox).
[land-bot] Fix git HEAD after checking revision
jasonbcox requested review of D7489: [buildbot] Strip out commonly used separators when detecting backports in diff summaries.
I don't think you read the summary. All of these variants are re-written to appear as the first variant, ensuring that these are both greppable and linked.
jasonbcox updated the summary of D7490: Decouple AUR patch recipe from the rest of the automated commits pipeline.
Sep 18 2020
Sep 18 2020
jasonbcox retitled D5808: [land-bot] Bail early if there's nothing to land from [land-patch] Bail early if there's nothing to land to [land-bot] Bail early if there's nothing to land.
Rebase
At least for the field size thing.
This doesn't really answer the question.
deadalnix requested changes to D7489: [buildbot] Strip out commonly used separators when detecting backports in diff summaries.
No. This makes history ungreppable.
deadalnix added inline comments to D7481: Add a check for unstaged changes when generating automated commits.
jasonbcox committed rABCd7bea469527a: Use heredoc for outputting help text in automated commit scripts (authored by jasonbcox).
Use heredoc for outputting help text in automated commit scripts
jasonbcox requested review of D7481: Add a check for unstaged changes when generating automated commits.
teamcity triaged T1054: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Linux ARM is broken. as Unbreak Now! priority.
PiRK added a comment to D7486: update outdated links related to UAHF and use explicit MarkDown syntax.
In D7486#177985, @jasonbcox wrote:I noticed your test plan is rather complex and duplicates a lot of the logic in scripts/fetch_documentation.sh in the website repo. Consider improving it so it can take a local target instead of always pulling from the internet.
fix MarkDown links and code formatting
PiRK updated the diff for D7486: update outdated links related to UAHF and use explicit MarkDown syntax.
Put links directly in the text and remove References section
PiRK added a comment to D7486: update outdated links related to UAHF and use explicit MarkDown syntax.
So far I have not been able to find another way of adding internal references to arbitrary places in a markdown file without using <a name="..."></a>. For instance the reference defined on line 199 is linked-to on line 9 with BIP143[[1]](#bip143)
remove leading $ for commands
PiRK committed rABC614ff9a886ec: [Backport] Fix Markdown formatting issues in init.md (authored by Carl Dong <accounts@carldong.me>).
[Backport] Fix Markdown formatting issues in init.md
jasonbcox requested changes to D7486: update outdated links related to UAHF and use explicit MarkDown syntax.
I noticed your test plan is rather complex and duplicates a lot of the logic in scripts/fetch_documentation.sh in the website repo. Consider improving it so it can take a local target instead of always pulling from the internet. This should come in a separate diff of course.
Fabien committed rABC88ac041b3196: [LINTER] Accept hard line breaks in markdown files (authored by Fabien).
[LINTER] Accept hard line breaks in markdown files
jasonbcox updated the diff for D7489: [buildbot] Strip out commonly used separators when detecting backports in diff summaries.
Match more cases
teamcity added a comment to D7489: [buildbot] Strip out commonly used separators when detecting backports in diff summaries.
[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.
Don't exclude all markdown, but adds an exception to the linter for the hard break special case
Fabien retitled D7484: [LINTER] Accept hard line breaks in markdown files from [LINTER] Exclude markdown files from the trailing whitespaces linter to [LINTER] Accept hard line breaks in markdown files.
jasonbcox requested review of D7488: [buildbot] Explicitly set the build agent pool for TSAN builds.
Add explicit check that HEAD has no changes from master
Build Bitcoin ABC Diffs / Diff Testing (build-tsan) failed.
@bot build-tsan
I don't think this makes sense. Even if markdown supports trailing whitespace as a line break, it doesn't mean it's a good idea. Consider:
- Not linting this will now allow accidental trailing whitespaces.
- Trailing whitespace does not render well in all IDEs/editors.
- Intentional line breaks should be obvious, which trailing whitespace are not.
majcosta updated the diff for D7440: [backport#14193][test] Add test to check mempool consistency in case of reorgs.
rebase
switch lock order on mempool_tests pointed by tsan
@bot build-tsan
PiRK requested review of D7486: update outdated links related to UAHF and use explicit MarkDown syntax.
use backslash as line breaks, to avoid lint issues with trailing whitespaces
squash another commit from the same PR (fix lines breaks)
Fix bad rebase
Rebase on top of D7473.
Fix rebase issue
Rebase on top of D7473
Rebase, depends on D7473