Page MenuHomePhabricator
Feed All Stories

Apr 8 2021

Fabien retitled D9377: [SECP256K1] sage: Add script for generating scalar_split_lambda constants from sage: Add script for generating scalar_split_lambda constants to [SECP256K1] sage: Add script for generating scalar_split_lambda constants.
Apr 8 2021, 09:06
teamcity updated the summary of D9377: [SECP256K1] sage: Add script for generating scalar_split_lambda constants.
Apr 8 2021, 09:05
Fabien requested review of D9377: [SECP256K1] sage: Add script for generating scalar_split_lambda constants.
Apr 8 2021, 09:05
Fabien closed D9374: [SECP256K1] Convert Sage code to Python 3 (as used by Sage >= 9).
Apr 8 2021, 08:53
Fabien committed rABCfc71d001248f: [SECP256K1] Convert Sage code to Python 3 (as used by Sage >= 9) (authored by Frdric Chapoton <fchapoton2@gmail.com>).
[SECP256K1] Convert Sage code to Python 3 (as used by Sage >= 9)
Apr 8 2021, 08:53
Fabien updated the test plan for D9374: [SECP256K1] Convert Sage code to Python 3 (as used by Sage >= 9).
Apr 8 2021, 08:52
teamcity updated the summary of D9376: [SECP256K1] Rename msg32 to msghash32 in ecdsa_sign/verify and add explanation.
Apr 8 2021, 08:49
Fabien requested review of D9376: [SECP256K1] Rename msg32 to msghash32 in ecdsa_sign/verify and add explanation.
Apr 8 2021, 08:49
teamcity closed T1598: Build Bitcoin-ABC / Master / Make Generator is broken. as Resolved.
Apr 8 2021, 08:42
PiRK closed D9110: build: warn on potentially uninitialized reads.
Apr 8 2021, 08:29
PiRK committed rABC9c7bed4ea4b8: build: warn on potentially uninitialized reads (authored by Vasil Dimov <vd@FreeBSD.org>).
build: warn on potentially uninitialized reads
Apr 8 2021, 08:29
PiRK closed D9372: [secp256k1] initialize variable in tests.
Apr 8 2021, 08:29
PiRK committed rABCb0d8c607a6ca: [secp256k1] initialize variable in tests (authored by PiRK).
[secp256k1] initialize variable in tests
Apr 8 2021, 08:29
PiRK accepted D9374: [SECP256K1] Convert Sage code to Python 3 (as used by Sage >= 9).
Apr 8 2021, 08:26
PiRK accepted D9375: [SECP256K1] make test count iteration configurable by environment variable.
Apr 8 2021, 08:22
teamcity updated the summary of D9375: [SECP256K1] make test count iteration configurable by environment variable.
Apr 8 2021, 08:03
Fabien requested review of D9375: [SECP256K1] make test count iteration configurable by environment variable.
Apr 8 2021, 08:03
teamcity updated the summary of D9374: [SECP256K1] Convert Sage code to Python 3 (as used by Sage >= 9).
Apr 8 2021, 07:50
Fabien requested review of D9374: [SECP256K1] Convert Sage code to Python 3 (as used by Sage >= 9).
Apr 8 2021, 07:50
teamcity updated the summary of D9373: [SECP256K1] Don't use reserved identifiers memczero and benchmark_verify_t.
Apr 8 2021, 07:36
Fabien requested review of D9373: [SECP256K1] Don't use reserved identifiers memczero and benchmark_verify_t.
Apr 8 2021, 07:36
Fabien accepted D9110: build: warn on potentially uninitialized reads.
Apr 8 2021, 06:58
Fabien accepted D9372: [secp256k1] initialize variable in tests.
Apr 8 2021, 06:55
Fabien updated the summary of D9372: [secp256k1] initialize variable in tests.
Apr 8 2021, 06:55
PiRK updated the diff for D9110: build: warn on potentially uninitialized reads.

rebase onto D9372

Apr 8 2021, 06:52
PiRK retitled D9372: [secp256k1] initialize variable in tests from initialize variable in tests to [secp256k1] initialize variable in tests.
Apr 8 2021, 06:44
teamcity updated the summary of D9372: [secp256k1] initialize variable in tests.
Apr 8 2021, 06:44
PiRK requested review of D9372: [secp256k1] initialize variable in tests.
Apr 8 2021, 06:44
teamcity triaged T1598: Build Bitcoin-ABC / Master / Make Generator is broken. as Unbreak Now! priority.
Apr 8 2021, 03:36
abc-bot committed rABCda7fa24db627: [Automated] Update timing.json (authored by abc-bot).
[Automated] Update timing.json
Apr 8 2021, 03:19
teamcity closed T1595: Build Bitcoin-ABC / Master / Default Extended Tests is broken. as Resolved.
Apr 8 2021, 02:31
teamcity closed T1597: Build Bitcoin-ABC / Master / Native tests / Test Native OSX is broken. as Resolved.
Apr 8 2021, 02:30
teamcity triaged T1597: Build Bitcoin-ABC / Master / Native tests / Test Native OSX is broken. as Unbreak Now! priority.
Apr 8 2021, 02:19
abc-bot committed rABCbeca947d5775: [Automated] Update seeds (authored by abc-bot).
[Automated] Update seeds
Apr 8 2021, 02:16
abc-bot committed rABCdf8354e07083: [Automated] Update chainparams (authored by abc-bot).
[Automated] Update chainparams
Apr 8 2021, 02:07

Apr 7 2021

PiRK updated the diff for D9345: [avalanche] set a minimum amount for a proof.

SCORE_DUST_THRESHOLD -> LOWEST_VALID_SCORE

Apr 7 2021, 19:35
PiRK added a comment to D9368: [avalanche] move proof verification code to processor.cpp.

I noticed that I removed a block scope that used to contain only the Proof deserialization. I'm not sure why it was there. Should I restore it?

Apr 7 2021, 17:46
PiRK updated the diff for D9368: [avalanche] move proof verification code to processor.cpp.

revert unrelated style changes in the test, use ternary operator in hasLocalProof instead of control flow

Apr 7 2021, 17:42
PiRK planned changes to D9370: [avalanche] orphan pool for proofs, make AlreadyHave support proofs.

Not ready yet

Apr 7 2021, 17:20
PiRK updated the diff for D9370: [avalanche] orphan pool for proofs, make AlreadyHave support proofs.

fix index by proofid for PeerSet and ProofPool: we cannot use the same struct

Apr 7 2021, 17:20
deadalnix requested changes to D9368: [avalanche] move proof verification code to processor.cpp.
Apr 7 2021, 17:04
deadalnix requested changes to D9345: [avalanche] set a minimum amount for a proof.
Apr 7 2021, 15:40
majcosta updated the diff for D9371: [avalanche] delay executing avalanche event loop until IBD is done.

went with simpler

Apr 7 2021, 15:35
PiRK updated the diff for D9368: [avalanche] move proof verification code to processor.cpp.

remove unecessary import and else clause (the if ends with a throw)

Apr 7 2021, 14:56
PiRK updated the diff for D9368: [avalanche] move proof verification code to processor.cpp.

address review

Apr 7 2021, 12:00
sellmyhousecashbaltimore updated sellmyhousecashbaltimore.
Apr 7 2021, 00:33

Apr 6 2021

deadalnix added inline comments to D9371: [avalanche] delay executing avalanche event loop until IBD is done.
Apr 6 2021, 23:31
deadalnix requested changes to D9371: [avalanche] delay executing avalanche event loop until IBD is done.

Why not just check for IBD status in runEventLoop ? What benefit does all this complication achieves?

Apr 6 2021, 23:30
majcosta requested review of D9371: [avalanche] delay executing avalanche event loop until IBD is done.
Apr 6 2021, 18:49
teamcity added a comment to D9370: [avalanche] orphan pool for proofs, make AlreadyHave support proofs.
Apr 6 2021, 16:39
teamcity added a comment to D9370: [avalanche] orphan pool for proofs, make AlreadyHave support proofs.
Apr 6 2021, 16:38
teamcity added a comment to D9370: [avalanche] orphan pool for proofs, make AlreadyHave support proofs.
Apr 6 2021, 16:36
teamcity added a comment to D9370: [avalanche] orphan pool for proofs, make AlreadyHave support proofs.
Apr 6 2021, 16:35
teamcity added a comment to D9370: [avalanche] orphan pool for proofs, make AlreadyHave support proofs.
Apr 6 2021, 16:34
PiRK planned changes to D9370: [avalanche] orphan pool for proofs, make AlreadyHave support proofs.
Apr 6 2021, 16:30
PiRK requested review of D9370: [avalanche] orphan pool for proofs, make AlreadyHave support proofs.
Apr 6 2021, 16:30
PiRK planned changes to D9369: [avalanche] implement a proof relay struct.
Apr 6 2021, 16:29
PiRK requested review of D9369: [avalanche] implement a proof relay struct.
Apr 6 2021, 16:29
deadalnix requested changes to D9368: [avalanche] move proof verification code to processor.cpp.

Some open question, but this is better.

Apr 6 2021, 15:26
SamuelSmith updated SamuelSmith.
Apr 6 2021, 06:22
hammad added a comment to rABCWEB7ad44b03b62d: [WEBSITE] Fetch the documentation content from the abc repo.
Apr 6 2021, 06:08

Apr 5 2021

PiRK updated the diff for D9345: [avalanche] set a minimum amount for a proof.

refactor conditional check of ProofValidationResult as suggested in the review

Apr 5 2021, 13:07
PiRK added inline comments to D9345: [avalanche] set a minimum amount for a proof.
Apr 5 2021, 10:23
PiRK requested review of D9368: [avalanche] move proof verification code to processor.cpp.
Apr 5 2021, 09:07

Apr 4 2021

teamcity closed T1596: Build Bitcoin-ABC / Nightly Builds / Initial Block Download Tests / Initial Block Download w/o Checkpoints is broken. as Resolved.
Apr 4 2021, 09:59

Apr 3 2021

deadalnix accepted D8673: Add -overridednsseed for testing DNS seed behavior.
Apr 3 2021, 20:39
deadalnix requested changes to D9345: [avalanche] set a minimum amount for a proof.
Apr 3 2021, 20:37
deadalnix requested changes to D9365: [avalanche] Add an option to import a delegation.

What problem removing the distinction between master key and session key solves? It seems to me like it's making security of the whole thing worse for no good reason.

Apr 3 2021, 19:57
teamcity triaged T1596: Build Bitcoin-ABC / Nightly Builds / Initial Block Download Tests / Initial Block Download w/o Checkpoints is broken. as Unbreak Now! priority.
Apr 3 2021, 14:24

Apr 2 2021

teamcity triaged T1595: Build Bitcoin-ABC / Master / Default Extended Tests is broken. as Unbreak Now! priority.
Apr 2 2021, 18:23
Fabien closed D9366: Add some release notes for 0.23.1.
Apr 2 2021, 17:49
Fabien committed rABCf357eadea1f6: Add some release notes for 0.23.1 (authored by Fabien).
Add some release notes for 0.23.1
Apr 2 2021, 17:49
Fabien closed D9367: Add a checkpoint at block height 680140.
Apr 2 2021, 17:48
Fabien committed rABCa2ff22b3e4f7: Add a checkpoint at block height 680140 (authored by Fabien).
Add a checkpoint at block height 680140
Apr 2 2021, 17:48
Mengerian accepted D9367: Add a checkpoint at block height 680140.

Checked hash, looks good.

Apr 2 2021, 17:28
Mengerian accepted D9366: Add some release notes for 0.23.1.
Apr 2 2021, 17:21
majcosta accepted D9366: Add some release notes for 0.23.1.
Apr 2 2021, 13:58
majcosta accepted D9367: Add a checkpoint at block height 680140.

double checked hash, ok

Apr 2 2021, 13:58
teamcity awarded D9367: Add a checkpoint at block height 680140 a Haypence token.
Apr 2 2021, 13:56
Fabien added a comment to D9367: Add a checkpoint at block height 680140.

@bot build-ibd

Apr 2 2021, 13:56
Fabien requested review of D9367: Add a checkpoint at block height 680140.
Apr 2 2021, 13:30
Fabien requested review of D9366: Add some release notes for 0.23.1.
Apr 2 2021, 13:13
Fabien requested review of D9365: [avalanche] Add an option to import a delegation.
Apr 2 2021, 08:45
PiRK closed D9363: [avalanche tests] implement AvalancheProof serialization.
Apr 2 2021, 07:50
PiRK committed rABCb4c1f0e896e1: [avalanche tests] implement AvalancheProof serialization (authored by PiRK).
[avalanche tests] implement AvalancheProof serialization
Apr 2 2021, 07:50
PiRK closed D9360: [avalanche] add an inventory type and a message for proofs.
Apr 2 2021, 07:49
PiRK committed rABCe062e1c3b6b8: [avalanche] add an inventory type and a message for proofs (authored by PiRK).
[avalanche] add an inventory type and a message for proofs
Apr 2 2021, 07:49
Fabien abandoned D9361: [avalanche] Build a stripped delegation to remove unnecessary levels.
Apr 2 2021, 06:39

Apr 1 2021

PiRK updated the diff for D9345: [avalanche] set a minimum amount for a proof.

mmove constexprs into the avalanche namespace
rename MIN_SCORE_DUST -> SCORE_DUST_THRESHOLD

Apr 1 2021, 14:06
deadalnix requested changes to D9361: [avalanche] Build a stripped delegation to remove unnecessary levels.

The use case does not make sense. You don't want to have a long delegation chain for all the node one after the other anyways, you want to have a master key and delegate to each node. There is no point delegating to begin with if the master also have all the private key to which it is delegating. If you want to do that, you might as well distribute the master key instead of devising a complicated scheme that isn't any more secure.

Apr 1 2021, 12:28
deadalnix requested changes to D9345: [avalanche] set a minimum amount for a proof.
Apr 1 2021, 12:25
deadalnix accepted D9360: [avalanche] add an inventory type and a message for proofs.
Apr 1 2021, 12:23
deadalnix requested changes to D9364: [avalanche] start implementing reception of avaproof.

You want to fix the proof size handling before moving on there, or you'll just multiply the point where this needs fixing.

Apr 1 2021, 12:23
sheeraz added a comment to rABCWEB7ad44b03b62d: [WEBSITE] Fetch the documentation content from the abc repo.
Apr 1 2021, 09:57
sheeraz added a comment to rABCWEB7ad44b03b62d: [WEBSITE] Fetch the documentation content from the abc repo.
Apr 1 2021, 09:53
abc-bot committed rABC57fd63bce089: [Automated] Update timing.json (authored by abc-bot).
[Automated] Update timing.json
Apr 1 2021, 03:19
abc-bot committed rABCc2a9e91a1dcd: [Automated] Update seeds (authored by abc-bot).
[Automated] Update seeds
Apr 1 2021, 02:17
abc-bot committed rABC061f36186492: [Automated] Update chainparams (authored by abc-bot).
[Automated] Update chainparams
Apr 1 2021, 02:07

Mar 31 2021

Patrick updated Patrick.
Mar 31 2021, 22:50
PiRK abandoned D9327: [avalanche] implement an avalanche handshake.
Mar 31 2021, 16:37