Page MenuHomePhabricator
Feed All Stories

Jun 13 2023

teamcity triaged T3190: Build Bitcoin-ABC / Nightly Builds / Initial Block Download Tests / Initial Block Download w/o Checkpoints is broken. as Unbreak Now! priority.
Jun 13 2023, 14:07
teamcity closed T3189: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Linux ARM is broken. as Resolved.
Jun 13 2023, 13:42
bytesofman closed D13994: [alias] spec overview before alias-server implementation.
Jun 13 2023, 12:51
bytesofman committed rABCb0b8f54d94f6: [alias] spec overview before alias-server implementation (authored by bytesofman).
[alias] spec overview before alias-server implementation
Jun 13 2023, 12:51
teamcity triaged T3189: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Linux ARM is broken. as Unbreak Now! priority.
Jun 13 2023, 10:16
PiRK closed D14040: [depends] Use more recent config.guess and config.sub in various packages.
Jun 13 2023, 09:05
PiRK closed D14041: build: copy config.{guess,sub} post autogen in zmq package.
Jun 13 2023, 09:05
PiRK committed rABCd05f24bf6b92: [depends] Use more recent config.guess and config.sub in various packages (authored by Chun Kuan Lee <ken2812221@gmail.com>).
[depends] Use more recent config.guess and config.sub in various packages
Jun 13 2023, 09:05
PiRK committed rABCde6ef355dc40: build: copy config.{guess,sub} post autogen in zmq package (authored by PiRK).
build: copy config.{guess,sub} post autogen in zmq package
Jun 13 2023, 09:05
PiRK closed D14038: depends: bump openssl to 1.1.1t.
Jun 13 2023, 09:05
PiRK committed rABC5730e791e5d3: depends: bump openssl to 1.1.1t (authored by tobtoht <tob@featherwallet.org>).
depends: bump openssl to 1.1.1t
Jun 13 2023, 09:05
teamcity awarded D14042: [depends] bump jemalloc to 5.3.0 a Piece of Eight token.
Jun 13 2023, 08:45
PiRK added a comment to D14042: [depends] bump jemalloc to 5.3.0.

@bot build-linux64 build-linux-arm build-linux-aarch64 build-osx build-win64

Jun 13 2023, 08:45
PiRK updated the diff for D14042: [depends] bump jemalloc to 5.3.0.

rebase and update dependency

Jun 13 2023, 08:45
PiRK updated the diff for D14040: [depends] Use more recent config.guess and config.sub in various packages.

rebase and update dependency (commits reordered so I can land the accepted ones without waiting for D14039)

Jun 13 2023, 08:44
PiRK updated the diff for D14041: build: copy config.{guess,sub} post autogen in zmq package.

rebase and fix dependency

Jun 13 2023, 08:42
PiRK updated the diff for D14038: depends: bump openssl to 1.1.1t.

rebase

Jun 13 2023, 08:40
abc-bot committed rABCa470d26f75f0: [Automated] Update timing.json (authored by abc-bot).
[Automated] Update timing.json
Jun 13 2023, 07:19
PiRK closed D14044: depends: couple of fixes.
Jun 13 2023, 07:03
PiRK committed rABC00d5310804d9: depends: couple of fixes (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).
depends: couple of fixes
Jun 13 2023, 07:03
Fabien added inline comments to D14035: [e.cash] Add tile section to homepage.
Jun 13 2023, 06:59
abc-bot committed rABC5f5b003a038a: [Automated] Update chainparams (authored by abc-bot).
[Automated] Update chainparams
Jun 13 2023, 06:38
abc-bot committed rABCf2c448d7e8c4: [Automated] Update seeds (authored by abc-bot).
[Automated] Update seeds
Jun 13 2023, 06:31
Fabien accepted D14045: [alias-server] Run npm audit fix to update dependencies.
Jun 13 2023, 06:28
Fabien closed D14043: [chronik] Install the protobuf file.
Jun 13 2023, 06:27
Fabien committed rABC4c6ab5673da8: [chronik] Install the protobuf file (authored by Fabien).
[chronik] Install the protobuf file
Jun 13 2023, 06:27
Fabien accepted D13994: [alias] spec overview before alias-server implementation.
Jun 13 2023, 06:27
Fabien accepted D14044: depends: couple of fixes.
Jun 13 2023, 06:20
PiRK accepted D14043: [chronik] Install the protobuf file.
Jun 13 2023, 06:19
Fabien closed D14048: Workaround jemalloc printing warnings to stderr with qemu.
Jun 13 2023, 06:18
Fabien committed rABC2be90cee610a: Workaround jemalloc printing warnings to stderr with qemu (authored by Fabien).
Workaround jemalloc printing warnings to stderr with qemu
Jun 13 2023, 06:18
emack requested changes to D14046: [alias-server] Move aliasConstants out of config and into constants dir.

Even after npm i, I'm getting this when running npm test

image.png (310×868 px, 62 KB)

Should this be in package.json?

Jun 13 2023, 00:15

Jun 12 2023

bytesofman closed D14034: [ecash-herald] Parse cash fusion txs.
Jun 12 2023, 22:33
bytesofman committed rABCa5b1e17c9593: [ecash-herald] Parse cash fusion txs (authored by bytesofman).
[ecash-herald] Parse cash fusion txs
Jun 12 2023, 22:33
bytesofman closed D14036: [ecash-herald] Add new script to support testing, sendMsgByBlock.
Jun 12 2023, 22:31
bytesofman committed rABCd7eb09e76314: [ecash-herald] Add new script to support testing, sendMsgByBlock (authored by bytesofman).
[ecash-herald] Add new script to support testing, sendMsgByBlock
Jun 12 2023, 22:31
emack accepted D14047: [alias-server] Remove reserved aliases from aliasConstants.
Jun 12 2023, 22:30
emack accepted D14034: [ecash-herald] Parse cash fusion txs.
Jun 12 2023, 22:28
emack accepted D14036: [ecash-herald] Add new script to support testing, sendMsgByBlock.
Jun 12 2023, 22:25
bytesofman added inline comments to D14025: [e.cash] Fetch exchanges and services and render on get ecash page.
Jun 12 2023, 22:15
johnkuney added inline comments to D14025: [e.cash] Fetch exchanges and services and render on get ecash page.
Jun 12 2023, 21:56
PiRK accepted D14048: Workaround jemalloc printing warnings to stderr with qemu.
Jun 12 2023, 20:28
Fabien requested review of D14048: Workaround jemalloc printing warnings to stderr with qemu.
Jun 12 2023, 20:23
johnkuney updated the diff for D14035: [e.cash] Add tile section to homepage.

remove image imports, css uppercase

Jun 12 2023, 20:16
bytesofman requested changes to D14025: [e.cash] Fetch exchanges and services and render on get ecash page.
Jun 12 2023, 20:01
johnkuney added a comment to D14035: [e.cash] Add tile section to homepage.

What do you think about mirroring the placement of the "Lean more" tile ? The site is in english, reading from left to right and it would make sense imo to have the tile on the left, and the techno tiles on the right.
This should be done in another diff though.

Jun 12 2023, 19:48
johnkuney added a comment to D14035: [e.cash] Add tile section to homepage.

links load with title under nav bar, would be nice if they loaded with the title just below nav bar. Maybe further down or something like "centered in screen" , so that the animation is not cut off

what we have now:

image.png (403×1 px, 121 KB)

would be nice:

image.png (840×1 px, 236 KB)

Jun 12 2023, 19:46
johnkuney added a comment to D14025: [e.cash] Fetch exchanges and services and render on get ecash page.

Good suggestions in general, added.

Jun 12 2023, 19:32
johnkuney updated the diff for D14025: [e.cash] Fetch exchanges and services and render on get ecash page.

improve testing and comments, rename and move utils function

Jun 12 2023, 19:25
bytesofman requested review of D14036: [ecash-herald] Add new script to support testing, sendMsgByBlock.

Both default genesis block and user specified block words fine, just need to test the failed price API scenario on sendBlockSummary

Jun 12 2023, 17:55
bytesofman updated the diff for D14034: [ecash-herald] Parse cash fusion txs.

Support legacy fusion prefix

Jun 12 2023, 17:37
bytesofman closed D14033: [ecash-herald] Remove deprecated function.
Jun 12 2023, 17:26
bytesofman committed rABC3a5b26642dca: [ecash-herald] Remove deprecated function (authored by bytesofman).
[ecash-herald] Remove deprecated function
Jun 12 2023, 17:26
bytesofman requested review of D14047: [alias-server] Remove reserved aliases from aliasConstants.
Jun 12 2023, 17:24
bytesofman updated the diff for D14046: [alias-server] Move aliasConstants out of config and into constants dir.

lint

Jun 12 2023, 17:23
bytesofman requested review of D14046: [alias-server] Move aliasConstants out of config and into constants dir.
Jun 12 2023, 17:22
bytesofman updated the diff for D13994: [alias] spec overview before alias-server implementation.

Update spec for txs with multiple OP_RETURN outputs

Jun 12 2023, 17:10
bytesofman requested review of D14045: [alias-server] Run npm audit fix to update dependencies.
Jun 12 2023, 16:49
bytesofman requested review of D13994: [alias] spec overview before alias-server implementation.

Actually if we want to do minimum pushes, better to support eMPP spec https://github.com/Bitcoin-ABC/bitcoin-abc/blob/master/chronik/bitcoinsuite-slp/src/empp/mod.rs

In this way:

  • We can lose the "04" for protocol identifier push
  • We can lose the "15" for address type + hash push
  • We can lose the 0x01-0x15 for alias length push (by putting the alias at the end, we just say "the rest of this push is the alias"

We need to add OP_RESERVED but still save a couple bytes. And of course, would also enable other app pushes in the same tx.

That said, we should prob support both (legacy with min push and empp)

Jun 12 2023, 16:46
teamcity awarded D14044: depends: couple of fixes a Haypence token.
Jun 12 2023, 16:02
Fabien added a comment to D14044: depends: couple of fixes.

@bot build-win64

Jun 12 2023, 16:01
teamcity updated the summary of D14044: depends: couple of fixes.
Jun 12 2023, 15:49
PiRK requested review of D14044: depends: couple of fixes.
Jun 12 2023, 15:49
Fabien requested changes to D14042: [depends] bump jemalloc to 5.3.0.

This needs some fixes to work around the jemalloc messages to stderr when running under qemu

Jun 12 2023, 14:56
Fabien accepted D14038: depends: bump openssl to 1.1.1t.
Jun 12 2023, 14:21
teamcity added a comment to D14042: [depends] bump jemalloc to 5.3.0.
Jun 12 2023, 13:08
PiRK closed D14037: Fix parallel make of OpenSSL.
Jun 12 2023, 12:57
PiRK committed rABC9bb733558906: Fix parallel make of OpenSSL (authored by Howard Chu <hyc@symas.com>).
Fix parallel make of OpenSSL
Jun 12 2023, 12:57
teamcity added a comment to D14042: [depends] bump jemalloc to 5.3.0.
Jun 12 2023, 12:57
teamcity awarded D14042: [depends] bump jemalloc to 5.3.0 a Haypence token.
Jun 12 2023, 12:35
Fabien added a comment to D14042: [depends] bump jemalloc to 5.3.0.

@bot build-linux64 build-linux-arm build-linux-aarch64 build-osx build-win64

Jun 12 2023, 12:35
Fabien accepted D14041: build: copy config.{guess,sub} post autogen in zmq package.
Jun 12 2023, 12:34
Fabien accepted D14040: [depends] Use more recent config.guess and config.sub in various packages.
Jun 12 2023, 12:27
Fabien requested changes to D14039: Fix arm64 darwin package def for OpenSSl.

The test plan doesn't really help to know if this is enough. You should run:

cd depends
HOSTS="arm64-apple-darwin" make openssl

And check the libs are built for the correct target

Jun 12 2023, 12:22
teamcity awarded D14038: depends: bump openssl to 1.1.1t a Haypence token.
Jun 12 2023, 12:17
Fabien added a comment to D14038: depends: bump openssl to 1.1.1t.

@bot build-linux64 build-osx build-win64

Jun 12 2023, 12:17
Fabien accepted D14037: Fix parallel make of OpenSSL.

nice!

Jun 12 2023, 12:15
Fabien requested review of D14043: [chronik] Install the protobuf file.
Jun 12 2023, 12:13
Fabien closed D14032: Remove the miner fund consensus code.
Jun 12 2023, 12:03
Fabien committed rABC43c402d947d7: Remove the miner fund consensus code (authored by Fabien).
Remove the miner fund consensus code
Jun 12 2023, 12:03
Fabien closed D14029: Remove tx MIN_STANDARD_VERSION and MAX_STANDARD_VERSION.
Jun 12 2023, 12:03
Fabien committed rABCe614433d1ab3: Remove tx MIN_STANDARD_VERSION and MAX_STANDARD_VERSION (authored by Fabien).
Remove tx MIN_STANDARD_VERSION and MAX_STANDARD_VERSION
Jun 12 2023, 12:03
teamcity awarded D14016: gitian: support arm64 darwin a Doubloon token.
Jun 12 2023, 11:49
PiRK updated the test plan for D14042: [depends] bump jemalloc to 5.3.0.
Jun 12 2023, 11:38
PiRK requested review of D14042: [depends] bump jemalloc to 5.3.0.
Jun 12 2023, 11:35
PiRK requested review of D14041: build: copy config.{guess,sub} post autogen in zmq package.
Jun 12 2023, 11:25
teamcity awarded D14040: [depends] Use more recent config.guess and config.sub in various packages a Haypence token.
Jun 12 2023, 09:50
PiRK added a comment to D14040: [depends] Use more recent config.guess and config.sub in various packages.

@bot gitian-osx gitian-linux gitian-win

Jun 12 2023, 09:50
PiRK updated the diff for D14040: [depends] Use more recent config.guess and config.sub in various packages.

Just drop the change to protobuf.mk, it is not needed with our recent protobuf version

Jun 12 2023, 09:29
PiRK updated the diff for D14040: [depends] Use more recent config.guess and config.sub in various packages.

fix protobuf. Apparently the version we build does not have gtest/build-aux

Jun 12 2023, 09:25
PiRK planned changes to D14040: [depends] Use more recent config.guess and config.sub in various packages.

The protobuf failure might be related to this change, actually.

Preprocessing protobuf...
cp: target 'gtest/build-aux' is not a directory
make: *** [funcs.mk:277: /bitcoin/depends/work/build/arm64-apple-darwin/protobuf/21.12-b4be8389631/.stamp_preprocessed] Error 1
make: Leaving directory '/bitcoin/depends'
Jun 12 2023, 09:10
PiRK requested review of D14040: [depends] Use more recent config.guess and config.sub in various packages.
Jun 12 2023, 09:09
teamcity awarded D14016: gitian: support arm64 darwin a Piece of Eight token.
Jun 12 2023, 08:39
PiRK requested review of D14039: Fix arm64 darwin package def for OpenSSl.
Jun 12 2023, 08:36
PiRK requested review of D14038: depends: bump openssl to 1.1.1t.
Jun 12 2023, 08:33
teamcity awarded D14037: Fix parallel make of OpenSSL a Haypence token.
Jun 12 2023, 08:05
PiRK added a comment to D14037: Fix parallel make of OpenSSL.

@bot gitian-osx gitian-linux gitian-win

Jun 12 2023, 08:05
PiRK requested review of D14037: Fix parallel make of OpenSSL.
Jun 12 2023, 08:03
PiRK accepted D14029: Remove tx MIN_STANDARD_VERSION and MAX_STANDARD_VERSION.
Jun 12 2023, 07:32
PiRK accepted D14032: Remove the miner fund consensus code.
Jun 12 2023, 07:28