Remove stupid timeout

Remove debug statements

remove unused include

remove unnecessary forward declaration

some suggestions trying to tighten up the copy, go with whatever you think is best. I don't think anyone reads something longer than a full sentence on the internet anymore. But we really only need a handful of people who "get it" to see this stuff, so I don't think we need to worry about general consumption too much here.

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.68.37.192:41502 for the next 60 minutes.

@bot preview-e.cash

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.68.37.192:41146 for the next 60 minutes.

@bot preview-e.cash

update proto script, patch lingering "value:" keys in READMEs, downstream impacts of proto script update (other bigints, type handling)

Since the button will only work based on the external api, it's better to not show the button if the api is unavailable for some reason.
I suggest you do this:

1. Attempt to retrieve the price from that endpoint
2. If not successful, don't show the button. Otherwise show the button with the actual price, like "Redeem FIRMA for 1234 XEC"
3. Not sure if it's worth refreshing periodically (in the even the price changes quickly)

I'll keep looking what's wrong with feature_assumevalid, but it is not related to this diff.

use the constant in strings

i think will just forget about this for now. we have good demand for the 42-xec reward and no one has complained about it being insufficient.

patch implementation of reduce in cashtab transactions (do not mix bigint and number)

rebase, bigint in reduce, bigint math for token rewards in herald, camelCase patches in ecash-agora, var name patches in cashtab constants, hex instead of decimal for hex-defined constants

make max length a constexpr

chech the donation address length

@bot build-tsan

bump -avastalevotethreshold a bit because some rounds get voted while finalizing the first block

add test cases for all invalidated and all stalled contenders

fixing locking issues

Early feedback indicates some stuff is missing:

1. Comment on the outcomes of a stale vote.
2. Test case if all contenders are rejected.
3. Test case if all contenders are stalled.