Page MenuHomePhabricator

bytesofman (Joey)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Nov 5 2020, 18:28 (220 w, 6 d)
Roles
Administrator

Recent Activity

Today

bytesofman closed D17608: [Cashtab] Support buying agora offers above spot, within reason.
Thu, Jan 30, 05:57
bytesofman committed rABC76ae72c209be: [Cashtab] Support buying agora offers above spot, within reason (authored by bytesofman).
[Cashtab] Support buying agora offers above spot, within reason
Thu, Jan 30, 05:57
bytesofman accepted D17609: [ecash-lib] Add SHA512 support, hashers and `Hmac`.

not necessarily related to the diff -- why is it better to keep all of these hash functions in webassembly? afaik we are the only cryptocurrency doing this.

Thu, Jan 30, 04:06
bytesofman published D17608: [Cashtab] Support buying agora offers above spot, within reason for review.
Thu, Jan 30, 00:34
bytesofman accepted D17606: [e.cash] Replace Pay2Stay logo.

is a higher resolution image available? it does look a little grainier than the last one, but not bad.

Thu, Jan 30, 00:31
bytesofman added a comment to D17606: [e.cash] Replace Pay2Stay logo.

@bot preview-e.cash

Thu, Jan 30, 00:24

Tue, Jan 28

bytesofman accepted D17603: Bump version to 0.30.10.
Tue, Jan 28, 12:38

Mon, Jan 27

bytesofman closed D16610: [explorer] Render cashaddr for all inputs and outputs on transaction page.
Mon, Jan 27, 12:35
bytesofman committed rABC93c43bbd7852: [explorer] Render cashaddr for all inputs and outputs on transaction page (authored by bytesofman).
[explorer] Render cashaddr for all inputs and outputs on transaction page
Mon, Jan 27, 12:35
bytesofman closed D17594: [Cashtab] Deprecate the auto-open camera on send feature.
Mon, Jan 27, 12:32
bytesofman committed rABC16a652e341b7: [Cashtab] Deprecate the auto-open camera on send feature (authored by bytesofman).
[Cashtab] Deprecate the auto-open camera on send feature
Mon, Jan 27, 12:32

Sun, Jan 26

bytesofman published D17594: [Cashtab] Deprecate the auto-open camera on send feature for review.
Sun, Jan 26, 18:31
bytesofman closed D17593: [Cashtab] Change default setting for camera auto-open.
Sun, Jan 26, 15:26
bytesofman committed rABC52a98f0e8ff5: [Cashtab] Change default setting for camera auto-open (authored by bytesofman).
[Cashtab] Change default setting for camera auto-open
Sun, Jan 26, 15:26
bytesofman published D17593: [Cashtab] Change default setting for camera auto-open for review.
Sun, Jan 26, 08:48

Sat, Jan 25

bytesofman updated the diff for D16610: [explorer] Render cashaddr for all inputs and outputs on transaction page.

rebase

Sat, Jan 25, 22:16
bytesofman updated the summary of D16610: [explorer] Render cashaddr for all inputs and outputs on transaction page.
Sat, Jan 25, 15:27
bytesofman updated the diff for D16610: [explorer] Render cashaddr for all inputs and outputs on transaction page.

update logic lost in rebase

Sat, Jan 25, 15:26
bytesofman updated the diff for D16610: [explorer] Render cashaddr for all inputs and outputs on transaction page.

rebase

Sat, Jan 25, 15:21
bytesofman closed D17592: [Cashtab] Make listing amounts more readable in agora listing notifications.
Sat, Jan 25, 15:19
bytesofman committed rABC81de6074a0f9: [Cashtab] Make listing amounts more readable in agora listing notifications (authored by bytesofman).
[Cashtab] Make listing amounts more readable in agora listing notifications
Sat, Jan 25, 15:19
bytesofman published D17592: [Cashtab] Make listing amounts more readable in agora listing notifications for review.
Sat, Jan 25, 14:26
bytesofman closed D17591: [Cashtab] Reduce tx autoclose time from 5s to 2s.
Sat, Jan 25, 11:08
bytesofman committed rABCe1f8ecba93fe: [Cashtab] Reduce tx autoclose time from 5s to 2s (authored by bytesofman).
[Cashtab] Reduce tx autoclose time from 5s to 2s
Sat, Jan 25, 11:08
bytesofman published D17591: [Cashtab] Reduce tx autoclose time from 5s to 2s for review.
Sat, Jan 25, 05:59

Fri, Jan 24

bytesofman accepted D17588: [cashtab] Token view UI updates.
Fri, Jan 24, 23:26
bytesofman requested changes to D17588: [cashtab] Token view UI updates.

nice looks much better.

Fri, Jan 24, 22:38

Thu, Jan 23

bytesofman closed D17575: [Cashtab] No double notifications for SLP partial lists.
Thu, Jan 23, 08:32
bytesofman committed rABC63dc3deda632: [Cashtab] No double notifications for SLP partial lists (authored by bytesofman).
[Cashtab] No double notifications for SLP partial lists
Thu, Jan 23, 08:32

Wed, Jan 22

bytesofman published D17575: [Cashtab] No double notifications for SLP partial lists for review.
Wed, Jan 22, 23:29
bytesofman added a comment to D17464: [ecash-lib] attach ecc and hashes to globalThis.

Some alt options on this diff

Wed, Jan 22, 23:28

Tue, Jan 21

bytesofman closed D17571: [Cashtab] Make sure selectedOffer cannot be undefined after a ws update.
Tue, Jan 21, 21:03
bytesofman committed rABCf840614d26c6: [Cashtab] Make sure selectedOffer cannot be undefined after a ws update (authored by bytesofman).
[Cashtab] Make sure selectedOffer cannot be undefined after a ws update
Tue, Jan 21, 21:03
bytesofman published D17571: [Cashtab] Make sure selectedOffer cannot be undefined after a ws update for review.
Tue, Jan 21, 11:42

Mon, Jan 20

bytesofman accepted D17566: [e.cash] Remove eCashPoker.

greening this as I don't want to block it when I go to bed, but the package-lock.json changes should be backed out before landing

Mon, Jan 20, 10:58
bytesofman accepted D17562: [explorer] Fix sorting txs by age/date.
Mon, Jan 20, 08:48
bytesofman requested changes to D17566: [e.cash] Remove eCashPoker.
Mon, Jan 20, 08:08

Sat, Jan 18

bytesofman added a comment to D17562: [explorer] Fix sorting txs by age/date.

mb this issue is just from me running it locally?

Sat, Jan 18, 21:28
bytesofman closed D17560: [Cashtab] Disable claim button while we wait for server response.
Sat, Jan 18, 21:09
bytesofman committed rABC2020461465ff: [Cashtab] Disable claim button while we wait for server response (authored by bytesofman).
[Cashtab] Disable claim button while we wait for server response
Sat, Jan 18, 21:09
bytesofman closed D17559: [Cashtab] Rewards screen to typescript.
Sat, Jan 18, 21:08
bytesofman committed rABC3da5fb76c470: [Cashtab] Rewards screen to typescript (authored by bytesofman).
[Cashtab] Rewards screen to typescript
Sat, Jan 18, 21:08
bytesofman published D17560: [Cashtab] Disable claim button while we wait for server response for review.
Sat, Jan 18, 09:11
bytesofman closed D17558: [Cashtab] Improve wallet select behavior on wallets screen.
Sat, Jan 18, 09:08
bytesofman committed rABC665e42e93702: [Cashtab] Improve wallet select behavior on wallets screen (authored by bytesofman).
[Cashtab] Improve wallet select behavior on wallets screen
Sat, Jan 18, 09:08
bytesofman closed D17557: [Cashtab] Convert wallet management screen to typescript.
Sat, Jan 18, 09:07
bytesofman committed rABC2615794e3596: [Cashtab] Convert wallet management screen to typescript (authored by bytesofman).
[Cashtab] Convert wallet management screen to typescript
Sat, Jan 18, 09:07
bytesofman published D17559: [Cashtab] Rewards screen to typescript for review.
Sat, Jan 18, 01:30
bytesofman updated the test plan for D17558: [Cashtab] Improve wallet select behavior on wallets screen.
Sat, Jan 18, 00:44
bytesofman published D17558: [Cashtab] Improve wallet select behavior on wallets screen for review.
Sat, Jan 18, 00:41
bytesofman published D17557: [Cashtab] Convert wallet management screen to typescript for review.
Sat, Jan 18, 00:36

Fri, Jan 17

bytesofman closed D17552: [Cashtab] Lock UI and disable keyboard input while user switches wallets.
Fri, Jan 17, 21:38
bytesofman committed rABCed585d0ace20: [Cashtab] Lock UI and disable keyboard input while user switches wallets (authored by bytesofman).
[Cashtab] Lock UI and disable keyboard input while user switches wallets
Fri, Jan 17, 21:38
bytesofman closed D17551: [Cashtab] Do not double call updateCashtabState on wallet change.
Fri, Jan 17, 21:38
bytesofman committed rABC70d070d2a9c4: [Cashtab] Do not double call updateCashtabState on wallet change (authored by bytesofman).
[Cashtab] Do not double call updateCashtabState on wallet change
Fri, Jan 17, 21:38
bytesofman closed D17549: [Cashtab] Patch render logic for spinner.
Fri, Jan 17, 21:32
bytesofman committed rABC03869debbc95: [Cashtab] Patch render logic for spinner (authored by bytesofman).
[Cashtab] Patch render logic for spinner
Fri, Jan 17, 21:32
bytesofman updated the summary of D17549: [Cashtab] Patch render logic for spinner.
Fri, Jan 17, 20:42
bytesofman closed D17550: [Cashtab] Convert WalletLabel to ts.
Fri, Jan 17, 08:56
bytesofman committed rABCf424953ba614: [Cashtab] Convert WalletLabel to ts (authored by bytesofman).
[Cashtab] Convert WalletLabel to ts
Fri, Jan 17, 08:56
bytesofman updated the test plan for D17549: [Cashtab] Patch render logic for spinner.
Fri, Jan 17, 08:42
bytesofman added a comment to D17549: [Cashtab] Patch render logic for spinner.

I assume the flakiness of the test you're referring to is when the int test is waiting for the spinner to disappear but it doesn't, and the await waitFor() call just hangs there holding up the entire test suite?

// Wait for Cashtab wallet info to load
await waitFor(() =>
    expect(screen.queryByTitle('Loading...')).not.toBeInTheDocument(),
);
Fri, Jan 17, 08:41
bytesofman requested review of D17549: [Cashtab] Patch render logic for spinner.

So before this patch it's broken and after this patch it's not, great.
May I ask how it's broken and how it's fixed ? Because I can't spot the change in behavior.

Fri, Jan 17, 08:37
bytesofman published D17549: [Cashtab] Patch render logic for spinner for review.
Fri, Jan 17, 03:26
bytesofman updated the test plan for D17552: [Cashtab] Lock UI and disable keyboard input while user switches wallets.
Fri, Jan 17, 03:24
bytesofman published D17552: [Cashtab] Lock UI and disable keyboard input while user switches wallets for review.
Fri, Jan 17, 03:23
bytesofman published D17551: [Cashtab] Do not double call updateCashtabState on wallet change for review.
Fri, Jan 17, 03:23
bytesofman published D17550: [Cashtab] Convert WalletLabel to ts for review.
Fri, Jan 17, 02:54
bytesofman accepted D17547: [electrum] Bugfix: close the "Check your trezor" popup after entering a passphrase.
Fri, Jan 17, 02:39

Thu, Jan 16

bytesofman closed D17544: [Cashtab] Prevent double notifications on send xec txs while preserving testing of component tx building.
Thu, Jan 16, 20:20
bytesofman committed rABC779edc7f5c42: [Cashtab] Prevent double notifications on send xec txs while preserving testing… (authored by bytesofman).
[Cashtab] Prevent double notifications on send xec txs while preserving testing…
Thu, Jan 16, 20:20
bytesofman published D17544: [Cashtab] Prevent double notifications on send xec txs while preserving testing of component tx building for review.
Thu, Jan 16, 15:06
bytesofman closed D17545: [Cashtab] Patch bug in building token change outputs.
Thu, Jan 16, 14:27
bytesofman committed rABC467afd4d59d5: [Cashtab] Patch bug in building token change outputs (authored by bytesofman).
[Cashtab] Patch bug in building token change outputs
Thu, Jan 16, 14:27
bytesofman published D17545: [Cashtab] Patch bug in building token change outputs for review.
Thu, Jan 16, 14:21
bytesofman closed D17542: [mock-chronik-client] Improve path defs for typescript build.
Thu, Jan 16, 13:23
bytesofman committed rABC0ac291483c70: [mock-chronik-client] Improve path defs for typescript build (authored by bytesofman).
[mock-chronik-client] Improve path defs for typescript build
Thu, Jan 16, 13:23
bytesofman closed D17543: [mock-chronik-client] Clean up test mocks file.
Thu, Jan 16, 13:22
bytesofman committed rABC36524d889f0e: [mock-chronik-client] Clean up test mocks file (authored by bytesofman).
[mock-chronik-client] Clean up test mocks file
Thu, Jan 16, 13:22
bytesofman closed D17540: [Cashtab] Show token qty and cumulative qty in any given agora offer in a tooltip.
Thu, Jan 16, 05:55
bytesofman committed rABCbb9172b62a96: [Cashtab] Show token qty and cumulative qty in any given agora offer in a… (authored by bytesofman).
[Cashtab] Show token qty and cumulative qty in any given agora offer in a…
Thu, Jan 16, 05:55
bytesofman added a comment to D17540: [Cashtab] Show token qty and cumulative qty in any given agora offer in a tooltip.

image.png (172×542 px, 17 KB)

Actually, I did an actual check on the bundle size, one meg over 227 megs is negligible in the grand scheme of things. Non-issue unless the whole bundle is getting to a point where it may start to affect performance?

Thu, Jan 16, 05:51
bytesofman published D17543: [mock-chronik-client] Clean up test mocks file for review.
Thu, Jan 16, 05:27
bytesofman published D17542: [mock-chronik-client] Improve path defs for typescript build for review.
Thu, Jan 16, 04:42

Wed, Jan 15

bytesofman updated the test plan for D17540: [Cashtab] Show token qty and cumulative qty in any given agora offer in a tooltip.
Wed, Jan 15, 22:57
bytesofman updated the test plan for D17540: [Cashtab] Show token qty and cumulative qty in any given agora offer in a tooltip.
Wed, Jan 15, 22:57
bytesofman updated the test plan for D17540: [Cashtab] Show token qty and cumulative qty in any given agora offer in a tooltip.
Wed, Jan 15, 22:55
bytesofman retitled D17540: [Cashtab] Show token qty and cumulative qty in any given agora offer in a tooltip from [Cashtab] Show token qty in any given agora offer in a tooltip to [Cashtab] Show token qty and cumulative qty in any given agora offer in a tooltip.
Wed, Jan 15, 22:54
bytesofman updated the diff for D17540: [Cashtab] Show token qty and cumulative qty in any given agora offer in a tooltip.

add cumulative, make sure tooltips are always on top

Wed, Jan 15, 22:53
bytesofman closed D17527: [ecash-lib] Add toHex method to Script class.
Wed, Jan 15, 21:29
bytesofman committed rABCe348c74a4fdd: [ecash-lib] Add toHex method to Script class (authored by bytesofman).
[ecash-lib] Add toHex method to Script class
Wed, Jan 15, 21:29
bytesofman published D17540: [Cashtab] Show token qty and cumulative qty in any given agora offer in a tooltip for review.
Wed, Jan 15, 19:31
bytesofman retitled D17527: [ecash-lib] Add toHex method to Script class from [ecash-lib] Add toScriptHex method to Script class to [ecash-lib] Add toHex method to Script class.
Wed, Jan 15, 13:38
bytesofman updated the diff for D17527: [ecash-lib] Add toHex method to Script class.

toHex it is

Wed, Jan 15, 13:37
bytesofman updated the diff for D17527: [ecash-lib] Add toHex method to Script class.

update test name

Wed, Jan 15, 00:41
bytesofman retitled D17527: [ecash-lib] Add toHex method to Script class from [ecash-lib] Add toString method to Script class to [ecash-lib] Add toScriptHex method to Script class.
Wed, Jan 15, 00:40
bytesofman updated the diff for D17527: [ecash-lib] Add toHex method to Script class.

toString becomes toScriptHex

Wed, Jan 15, 00:39
bytesofman added inline comments to D17527: [ecash-lib] Add toHex method to Script class.
Wed, Jan 15, 00:39

Tue, Jan 14

bytesofman published D17527: [ecash-lib] Add toHex method to Script class for review.
Tue, Jan 14, 20:12

Mon, Jan 13

bytesofman closed D17517: [ecash-agora] Do not allow creation of unacceptable agora partials.
Mon, Jan 13, 22:50