[wallet] [test] Add listwallets RPC, include wallet name in `getwalletinfo` and add multiwallet test.
ClosedPublic
Actions

Authored by deadalnix on Jan 25 2018, 17:47.

Details

Reviewers

jasonbcox
matiu

Group Reviewers

Restricted Project

Maniphest Tasks

T172: Backport core PR10604: Add listwallets RPC, include wallet name in `getwalletinfo` and add multiwallet test

Commits

rSTAGING4cc6a9dda9fb: [wallet] [test] Add listwallets RPC, include wallet name in `getwalletinfo` and…
rABC4cc6a9dda9fb: [wallet] [test] Add listwallets RPC, include wallet name in `getwalletinfo` and…

Summary

This backports core's PR10604 and fixes T172.

Test Plan

make check
./test/functional/test_runner.py multiwallet

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Jan 25 2018, 17:47

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 25 2018, 17:47

deadalnix retitled this revision from [wallet] [test] Add listwallets RPX, include wallet name in `getwalletinfo` and add multiwallet test. to [wallet] [test] Add listwallets RPC, include wallet name in `getwalletinfo` and add multiwallet test..Jan 25 2018, 17:47

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

I think this is already done at https://reviews.bitcoinabc.org/D1033 :(

jasonbcox accepted this revision.Jan 25 2018, 17:54

jasonbcox added a subscriber: jasonbcox.

jasonbcox added inline comments.

src/wallet/wallet.h
1045–1047 ↗	(On Diff #2737)	This looks strange. Are the last 3 comment lines supposed to have //! like the first 2 lines? Alternatively, this could be changed to the /.../ format used elsewhere in this file.