Page MenuHomePhabricator

[wallet] [test] Add listwallets RPC, include wallet name in `getwalletinfo` and add multiwallet test.
ClosedPublic

Authored by deadalnix on Jan 25 2018, 17:47.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
listwallet
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 1758
Build 1758: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jan 25 2018, 17:47
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 25 2018, 17:47
deadalnix retitled this revision from [wallet] [test] Add listwallets RPX, include wallet name in `getwalletinfo` and add multiwallet test. to [wallet] [test] Add listwallets RPC, include wallet name in `getwalletinfo` and add multiwallet test..Jan 25 2018, 17:47
matiu resigned from this revision.Jan 25 2018, 17:54
matiu added a subscriber: matiu.

I think this is already done at https://reviews.bitcoinabc.org/D1033 :(

jasonbcox accepted this revision.Jan 25 2018, 17:54
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/wallet/wallet.h
1045–1047

This looks strange. Are the last 3 comment lines supposed to have //! like the first 2 lines? Alternatively, this could be changed to the /*...*/ format used elsewhere in this file.

This revision is now accepted and ready to land.Jan 25 2018, 17:54
This revision was automatically updated to reflect the committed changes.