Make functions in validation.cpp static and pass chainparams
ClosedPublic
Actions

Authored by deadalnix on Jan 27 2018, 00:21.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING90e8343a5081: Make functions in validation.cpp static and pass chainparams
rABC90e8343a5081: Make functions in validation.cpp static and pass chainparams

Summary

Fix bugs as per PR comment

Change bool static to static bool

Backport core's PR10201

Test Plan

make check
./test/functional/test_runner.py --extended

Diff Detail

Repository

rABC Bitcoin ABC

Branch

params

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1765
Build 1765: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jan 27 2018, 00:21

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 27 2018, 00:21

Harbormaster completed remote builds in B1765: Diff 2748.Jan 27 2018, 00:21

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

I see some parts of PR10201 were already done on D348, D689

https://github.com/bitcoin/bitcoin/pull/10201/files#diff-349fbb003d5ae550a2e8fa658e475880L356
(making CheckInputs static) seems to be omitted here, is that on purpose?

I see it is not static on current Core's master;
https://github.com/bitcoin/bitcoin/blob/master/src/validation.cpp#L1356

jasonbcox added a subscriber: jasonbcox.Jan 29 2018, 18:54

jasonbcox added inline comments.

src/validation.cpp
2954	params -> chainParams
4535	params is a vague name that could have future naming conflicts. Should be something like chainParams

jasonbcox requested changes to this revision.Jan 29 2018, 18:54

This revision now requires changes to proceed.Jan 29 2018, 18:54

deadalnix requested review of this revision.Jan 30 2018, 13:13

deadalnix added inline comments.

src/validation.cpp
2954	dito
4535	It's called params everywhere.

deadalnix added a child revision: D1043: Track keypool entries as internal vs external in memory.Jan 30 2018, 15:51

jasonbcox accepted this revision.Jan 30 2018, 17:04

This revision is now accepted and ready to land.Jan 30 2018, 17:04

Closed by commit rABC90e8343a5081: Make functions in validation.cpp static and pass chainparams (authored by Mario Dian <mariodian@gmail.com>, committed by deadalnix). · Explain WhyJan 30 2018, 20:04

This revision was automatically updated to reflect the committed changes.

jasonbcox mentioned this in D2723: Merge #11028: Avoid masking of difficulty adjustment errors by checkpoints.Mar 21 2019, 21:27

markblundeberg mentioned this in D3093: Remove AcceptToMemoryPoolWithTime default args.May 22 2019, 21:11

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> mentioned this in rABC1e0b4b7e66a8: Remove AcceptToMemoryPoolWithTime default args.May 23 2019, 14:14

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> mentioned this in rSTAGING1e0b4b7e66a8: Remove AcceptToMemoryPoolWithTime default args.Sep 18 2019, 23:41

Revision Contents
Changeset List

Path

Size

src/

validation.h

47 lines

validation.cpp

167 lines

Diff 2748

View Options

src/validation.h