Page MenuHomePhabricator

Make sure compact blocks work when there are more than 65536 transactions in a block
ClosedPublic

Authored by deadalnix on Mar 2 2018, 09:18.

Details

Summary

As per title. The compact block code rely heavily on the use of 16 bits integers, which made it unsuitable for the propagation of block containing a large number of transactions.

Depends on D1144

Test Plan

abc-p2p-compactblocks was updated to ensure that blocks with a very large number of transactions are passed back and forth.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
biggercompactblocks
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1961
Build 2071: Bitcoin ABC Buildbot (legacy)
Build 2070: arc lint + arc unit

Event Timeline

Herald added a reviewer: Restricted Project. · View Herald Transcript
dagurval added a subscriber: dagurval.

LGTM. The equivalent in XT is in PR https://github.com/bitcoinxt/bitcoinxt/pull/344.

Are there any other clients than XT and ABC that support compact blocks on BCH? If so, I still think this deserves a version number bump. This is backward compatible for us, but not forward compatible for them.

This revision is now accepted and ready to land.Mar 2 2018, 11:00
deadalnix retitled this revision from make sure coppact blocks work when there are more than 65536 transactions in a block to Make sure compact blocks work when there are more than 65536 transactions in a block.
This revision was automatically updated to reflect the committed changes.
schancel added a task: Restricted Maniphest Task.Mar 15 2018, 14:52