Details

Reviewers

Group Reviewers

Restricted Project

Maniphest Tasks

Commits

rSTAGING3ea13c39e5c8: Make sure compact blocks work when there are more than 65536 transactions in a…
rABC3ea13c39e5c8: Make sure compact blocks work when there are more than 65536 transactions in a…

Summary

As per title. The compact block code rely heavily on the use of 16 bits integers, which made it unsuitable for the propagation of block containing a large number of transactions.

Depends on D1144

Test Plan

abc-p2p-compactblocks was updated to ensure that blocks with a very large number of transactions are passed back and forth.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

biggercompactblocks

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1961
Build 2071: Bitcoin ABC Buildbot (legacy)
Build 2070: arc lint + arc unit

Event Timeline

deadalnix created this revision.Mar 2 2018, 09:18

Harbormaster completed remote builds in B1961: Diff 3021.Mar 2 2018, 09:18

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 2 2018, 09:18

Herald added a reviewer: Restricted Project. · View Herald Transcript

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Harbormaster completed remote builds in B1961: Diff 3021.Mar 2 2018, 09:44

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

LGTM. The equivalent in XT is in PR https://github.com/bitcoinxt/bitcoinxt/pull/344.

Are there any other clients than XT and ABC that support compact blocks on BCH? If so, I still think this deserves a version number bump. This is backward compatible for us, but not forward compatible for them.

This revision is now accepted and ready to land.Mar 2 2018, 11:00

deadalnix added a child revision: D1149: Activate 32MB blocks after May 15, 2018.Mar 2 2018, 16:16

deadalnix retitled this revision from make sure coppact blocks work when there are more than 65536 transactions in a block to Make sure compact blocks work when there are more than 65536 transactions in a block.

Closed by commit rABC3ea13c39e5c8: Make sure compact blocks work when there are more than 65536 transactions in a… (authored by deadalnix). · Explain WhyMar 4 2018, 23:13

This revision was automatically updated to reflect the committed changes.

schancel added a task: T297: Allow for 32 Megabyte blocks.Mar 15 2018, 14:52

Fabien mentioned this in D5049: fix a deserialization overflow edge case.Jan 23 2020, 10:54

Fabien mentioned this in rABCec5df583ca34: fix a deserialization overflow edge case.Feb 3 2020, 16:21

Fabien mentioned this in rSTAGINGec5df583ca34: fix a deserialization overflow edge case.Apr 7 2020, 22:46

PiRK mentioned this in D8790: Convert blockencodings.h to new serialization framework.Jan 5 2021, 13:24

PiRK mentioned this in rABC7b24ab196413: Convert blockencodings.h to new serialization framework.Jan 6 2021, 09:07