Add a function MinimalizeBigEndianArray to trim a byte array
of leading zeros, while maintaining any MSB for negation. This
will get used in BIN2NUM in a later patch.
Co-authored-by: Shammah Chancellor <shammah.chancellor@gmail.com>
Details
Details
- Reviewers
shadders movrcx schancel deadalnix - Group Reviewers
Restricted Project - Commits
- rSTAGINGa635b73ad81d: Add function to trim leading array zeros maintaining MSB.
rABCa635b73ad81d: Add function to trim leading array zeros maintaining MSB.
make check
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- MinimalizeBigEndianArray
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 2163 Build 2470: Bitcoin ABC Buildbot (legacy) Build 2469: arc lint + arc unit
Event Timeline
| src/test/script_tests.cpp | ||
|---|---|---|
| 431 | Some additional tests to ensure behavior is an inverse match for IsMinimalArray (apologies for redeclaring all the variables each time, not sure of correct C++ syntax) //case: 0x00 00 80 -> 0x 00 80
//case: 0x80 00 80 -> 0x80 80
std::vector<uint8_t> input({{0x00, 0x00, 0x80}});
std::vector<uint8_t> negInput({{0x80, 0x00, 0x80}});
std::vector<uint8_t> check({0x00, 0x80});
std::vector<uint8_t> negCheck({0x80, 0x80});
std::vector<uint8_t> out = MinimalizeBigEndianArray(input);
std::vector<uint8_t> negOut = MinimalizeBigEndianArray(negInput);
BOOST_CHECK(out == check);
BOOST_CHECK(negOut == negCheck);
//case: 0x00 80 -> 0x00 80
//case: 0x80 80 -> 0x80 80
std::vector<uint8_t> input({{0x00, 0x80}});
std::vector<uint8_t> negInput({{0x80, 0x80}});
std::vector<uint8_t> check({0x00, 0x80});
std::vector<uint8_t> negCheck({0x80, 0x80});
std::vector<uint8_t> out = MinimalizeBigEndianArray(input);
std::vector<uint8_t> negOut = MinimalizeBigEndianArray(negInput);
BOOST_CHECK(out == check);
BOOST_CHECK(negOut == negCheck);
//case: 0x00 00 0f -> 0x0f
//case: 0x80 00 0f -> 0x8f
std::vector<uint8_t> input({{0x00, 0x00, 0x0f}});
std::vector<uint8_t> negInput({{0x80, 0x00, 0x0f}});
std::vector<uint8_t> check({0x0f});
std::vector<uint8_t> negCheck({0x8f});
std::vector<uint8_t> out = MinimalizeBigEndianArray(input);
std::vector<uint8_t> negOut = MinimalizeBigEndianArray(negInput);
BOOST_CHECK(out == check);
BOOST_CHECK(negOut == negCheck);
//case: 0x00 0f -> 0x0f
//case: 0x80 0f -> 0x8f
std::vector<uint8_t> input({{0x00, 0x0f}});
std::vector<uint8_t> negInput({{0x80, 0x0f}});
std::vector<uint8_t> check({0x0f});
std::vector<uint8_t> negCheck({0x8f});
std::vector<uint8_t> out = MinimalizeBigEndianArray(input);
std::vector<uint8_t> negOut = MinimalizeBigEndianArray(negInput);
BOOST_CHECK(out == check);
BOOST_CHECK(negOut == negCheck); | |
| src/test/script_tests.cpp | ||
|---|---|---|
| 431 | One more: //case: 0x00 00 8f 00 00 01 -> 0x 00 8f 00 00 01 | |
| src/script/script.cpp | ||
|---|---|---|
| 277 | msb -> neg since this is no longer the msb | |
| 278 | This can be interpreted as "isStart" in which case init as false is confusing. Please rename to something like pushedRes or hasPushedResult. | |
| src/test/script_tests.cpp | ||
| 431 | Need to check these cases: | |
| src/test/script_tests.cpp | ||
|---|---|---|
| 431 | Scratch the last case. Should be 0x7f 0xff 0xff 0xff -> 0x7f 0xff 0xff 0xff | |
| src/script/script.cpp | ||
|---|---|---|
| 284 | Found a bug while writing tests: This line skips all instances of {0x00 ... 0x00} and returns empty list. | |
| src/script/script.cpp | ||
|---|---|---|
| 310 ↗ | (On Diff #3298) | for (uint8_t x : data) {
// ...
} |
| src/test/script_tests.cpp | ||
| 456 ↗ | (On Diff #3298) | A few test case made of a test input + expected result is necessary. They ensure that you did not have the same bug in the test and the implementation - which you both did, so that's actually very likely. They also constitute reusable material from someone wanting to build a compatible system. |